[ 1508778 ] Fix for wxOwnerDrawnComboBox list selection rendering.

[wxWidgets.git] / src / gtk / radiobox.cpp

diff --git a/src/gtk/radiobox.cpp b/src/gtk/radiobox.cpp
index 9d5d6773956daaea550fc0c011453ba3e1e52fc4..f38936d468c46fdfb1bdc33f689f46bf577a709b 100644 (file)
--- a/src/gtk/radiobox.cpp
+++ b/src/gtk/radiobox.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        radiobox.cpp
+// Name:        src/gtk/radiobox.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$


@@ -7,53 +7,66 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "radiobox.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
+#if wxUSE_RADIOBOX

 
 #include "wx/radiobox.h"
 
 
 #include "wx/radiobox.h"
 

-#if wxUSE_RADIOBOX
+#ifndef WX_PRECOMP
+    #include "wx/log.h"
+    #include "wx/frame.h"
+    #include "wx/dialog.h"
+#endif
+
+#if wxUSE_TOOLTIPS
+    #include "wx/tooltip.h"
+#endif

 
 

-#include "wx/dialog.h"
-#include "wx/frame.h"
+#include "wx/gtk/private.h"
+#include <gdk/gdkkeysyms.h>

 
 

-#include "gdk/gdk.h"
-#include "gtk/gtk.h"
-#include "gdk/gdkkeysyms.h"

 #include "wx/gtk/win_gtk.h"
 
 //-----------------------------------------------------------------------------
 #include "wx/gtk/win_gtk.h"
 
 //-----------------------------------------------------------------------------

-// idle system
+// wxGTKRadioButtonInfo

 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

+// structure internally used by wxRadioBox to store its child buttons

 
 

-extern void wxapp_install_idle_handler();
-extern bool g_isIdle;
+class wxGTKRadioButtonInfo : public wxObject
+{
+public:
+    wxGTKRadioButtonInfo( GtkRadioButton * abutton, const wxRect & arect )
+    : button( abutton ), rect( arect ) {}
+
+    GtkRadioButton * button;
+    wxRect           rect;
+};

 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 

-extern bool   g_blockEventsOnDrag;
+#include "wx/listimpl.cpp"
+WX_DEFINE_LIST( wxRadioBoxButtonsInfoList );
+
+extern bool          g_blockEventsOnDrag;
+extern wxWindowGTK  *g_delayedFocus;

 
 //-----------------------------------------------------------------------------
 // "clicked"
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 // "clicked"
 //-----------------------------------------------------------------------------
 

-static void gtk_radiobutton_clicked_callback( GtkWidget *WXUNUSED(widget), wxRadioBox *rb )
+extern "C" {
+static void gtk_radiobutton_clicked_callback( GtkToggleButton *button, wxRadioBox *rb )

 {
     if (g_isIdle) wxapp_install_idle_handler();
 
     if (!rb->m_hasVMT) return;
     if (g_blockEventsOnDrag) return;
 
 {
     if (g_isIdle) wxapp_install_idle_handler();
 
     if (!rb->m_hasVMT) return;
     if (g_blockEventsOnDrag) return;
 

-    if (rb->m_alreadySent)
-    {
-        rb->m_alreadySent = FALSE;
-        return;
-    }
-
-    rb->m_alreadySent = TRUE;
+    if (!button->active) return;

 
     wxCommandEvent event( wxEVT_COMMAND_RADIOBOX_SELECTED, rb->GetId() );
     event.SetInt( rb->GetSelection() );
 
     wxCommandEvent event( wxEVT_COMMAND_RADIOBOX_SELECTED, rb->GetId() );
     event.SetInt( rb->GetSelection() );


@@ -61,525 +74,638 @@ static void gtk_radiobutton_clicked_callback( GtkWidget *WXUNUSED(widget), wxRad
     event.SetEventObject( rb );
     rb->GetEventHandler()->ProcessEvent(event);
 }
     event.SetEventObject( rb );
     rb->GetEventHandler()->ProcessEvent(event);
 }

+}

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-// wxRadioBox
+// "key_press_event"

 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxRadioBox,wxControl)
-
-wxRadioBox::wxRadioBox()
+extern "C" {
+static gint gtk_radiobox_keypress_callback( GtkWidget *widget, GdkEventKey *gdk_event, wxRadioBox *rb )

 {
 {

-}
+    if (g_isIdle)
+        wxapp_install_idle_handler();

 
 

-bool wxRadioBox::Create( wxWindow *parent, wxWindowID id, const wxString& title,
-                         const wxPoint &pos, const wxSize &size,
-                         int n, const wxString choices[], int majorDim,
-                         long style, const wxValidator& validator,
-                         const wxString &name )
-{
-    m_alreadySent = FALSE;
-    m_needParent = TRUE;
-    m_acceptsFocus = TRUE;
+    if (!rb->m_hasVMT) return FALSE;
+    if (g_blockEventsOnDrag) return FALSE;

 
 

-    if (!PreCreation( parent, pos, size ) ||
-        !CreateBase( parent, id, pos, size, style, validator, name ))
+    if ( ((gdk_event->keyval == GDK_Tab) ||
+          (gdk_event->keyval == GDK_ISO_Left_Tab)) &&
+         rb->GetParent() && (rb->GetParent()->HasFlag( wxTAB_TRAVERSAL)) )

     {
     {

-        wxFAIL_MSG( wxT("wxRadioBox creation failed") );
-       return FALSE;
+        wxNavigationKeyEvent new_event;
+        new_event.SetEventObject( rb->GetParent() );
+        // GDK reports GDK_ISO_Left_Tab for SHIFT-TAB
+        new_event.SetDirection( (gdk_event->keyval == GDK_Tab) );
+        // CTRL-TAB changes the (parent) window, i.e. switch notebook page
+        new_event.SetWindowChange( (gdk_event->state & GDK_CONTROL_MASK) );
+        new_event.SetCurrentFocus( rb );
+        return rb->GetParent()->GetEventHandler()->ProcessEvent( new_event );

     }
 
     }
 

-    m_widget = gtk_frame_new( title.mbc_str() );
-
-    m_majorDim = majorDim;
-
-    GtkRadioButton *m_radio = (GtkRadioButton*) NULL;
-
-    wxString label;
-    GSList *radio_button_group = (GSList *) NULL;
-    for (int i = 0; i < n; i++)
+    if ((gdk_event->keyval != GDK_Up) &&
+        (gdk_event->keyval != GDK_Down) &&
+        (gdk_event->keyval != GDK_Left) &&
+        (gdk_event->keyval != GDK_Right))

     {
     {

-        if ( i != 0 )
-            radio_button_group = gtk_radio_button_group( GTK_RADIO_BUTTON(m_radio) );
+        return FALSE;
+    }

 
 

-        label.Empty();
-        for ( const wxChar *pc = choices[i]; *pc; pc++ )
-        {
-            if ( *pc != wxT('&') )
-                label += *pc;
-        }
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = rb->m_buttonsInfo.GetFirst();
+    while( node && GTK_WIDGET( node->GetData()->button ) != widget )
+    {
+        node = node->GetNext();
+    }
+    if (!node)
+    {
+        return FALSE;
+    }

 
 

-        m_radio = GTK_RADIO_BUTTON( gtk_radio_button_new_with_label( radio_button_group, label.mbc_str() ) );
+    g_signal_stop_emission_by_name (widget, "key_press_event");

 
 

-        m_boxes.Append( (wxObject*) m_radio );
+    if ((gdk_event->keyval == GDK_Up) ||
+        (gdk_event->keyval == GDK_Left))
+    {
+        if (node == rb->m_buttonsInfo.GetFirst())
+            node = rb->m_buttonsInfo.GetLast();
+        else
+            node = node->GetPrevious();
+    }
+    else
+    {
+        if (node == rb->m_buttonsInfo.GetLast())
+            node = rb->m_buttonsInfo.GetFirst();
+        else
+            node = node->GetNext();
+    }

 
 

-        ConnectWidget( GTK_WIDGET(m_radio) );
+    GtkWidget *button = (GtkWidget*) node->GetData()->button;

 
 

-        if (!i) gtk_toggle_button_set_state( GTK_TOGGLE_BUTTON(m_radio), TRUE );
+    gtk_widget_grab_focus( button );

 
 

-        gtk_signal_connect( GTK_OBJECT(m_radio), "clicked",
-            GTK_SIGNAL_FUNC(gtk_radiobutton_clicked_callback), (gpointer*)this );
+    return TRUE;
+}
+}

 
 

-        gtk_pizza_put( GTK_PIZZA(m_parent->m_wxwindow),
-                         GTK_WIDGET(m_radio),
-                         m_x+10, m_y+10+(i*24), 10, 10 );
+extern "C" {
+static gint gtk_radiobutton_focus_in( GtkWidget *widget,
+                                      GdkEvent *WXUNUSED(event),
+                                      wxRadioBox *win )
+{
+    if ( win->m_lostFocus )
+    {
+        // no, we didn't really lose it
+        win->m_lostFocus = FALSE;

     }
     }

+    else if ( !win->m_hasFocus )
+    {
+        win->m_hasFocus = true;

 
 

-    wxSize ls = LayoutItems();
-
-    wxSize newSize = size;
-    if (newSize.x == -1) newSize.x = ls.x;
-    if (newSize.y == -1) newSize.y = ls.y;
-    SetSize( newSize.x, newSize.y );
-
-    m_parent->DoAddChild( this );
+        wxFocusEvent event( wxEVT_SET_FOCUS, win->GetId() );
+        event.SetEventObject( win );

 
 

-    PostCreation();
+        // never stop the signal emission, it seems to break the kbd handling
+        // inside the radiobox
+        (void)win->GetEventHandler()->ProcessEvent( event );
+    }

 
 

-    SetLabel( title );
+    return FALSE;
+}
+}

 
 

-    SetBackgroundColour( parent->GetBackgroundColour() );
-    SetForegroundColour( parent->GetForegroundColour() );
-    SetFont( parent->GetFont() );
+extern "C" {
+static gint gtk_radiobutton_focus_out( GtkWidget *widget,
+                                       GdkEvent *WXUNUSED(event),
+                                       wxRadioBox *win )
+{
+  //    wxASSERT_MSG( win->m_hasFocus, _T("got focus out without any focus in?") );
+  // Replace with a warning, else we dump core a lot!
+  //  if (!win->m_hasFocus)
+  //      wxLogWarning(_T("Radiobox got focus out without any focus in.") );

 
 

-    Show( TRUE );
+    // we might have lost the focus, but may be not - it may have just gone to
+    // another button in the same radiobox, so we'll check for it in the next
+    // idle iteration (leave m_hasFocus == true for now)
+    win->m_lostFocus = true;

 
 

-    return TRUE;
+    return FALSE;
+}

 }
 
 }
 

-wxRadioBox::~wxRadioBox()
+extern "C" {
+static void gtk_radiobutton_size_allocate( GtkWidget *widget,
+                                           GtkAllocation * alloc,
+                                           wxRadioBox *win )

 {
 {

-    wxNode *node = m_boxes.First();
-    while (node)
+    unsigned int n = 0;
+    for ( wxRadioBoxButtonsInfoList::compatibility_iterator node = win->m_buttonsInfo.GetFirst();
+          node;
+          node = node->GetNext(), n++ )

     {
     {

-        GtkWidget *button = GTK_WIDGET( node->Data() );
-        gtk_widget_destroy( button );
-        node = node->Next();
+        if( widget == GTK_WIDGET(node->GetData()->button) )
+        {
+            const wxPoint origin = win->GetPosition();
+            wxRect rect = wxRect( alloc->x - origin.x, alloc->y - origin.y,
+                                  alloc->width, alloc->height );
+            node->GetData()->rect = rect;
+            break;
+        }

     }
 }
     }
 }

+}
+
+
+//-----------------------------------------------------------------------------
+// wxRadioBox
+//-----------------------------------------------------------------------------
+
+IMPLEMENT_DYNAMIC_CLASS(wxRadioBox,wxControl)

 
 

-void wxRadioBox::DoSetSize( int x, int y, int width, int height, int sizeFlags )
+void wxRadioBox::Init()

 {
 {

-    wxWindow::DoSetSize( x, y, width, height, sizeFlags );
-    
-    LayoutItems();
+    m_needParent = true;
+    m_acceptsFocus = true;
+
+    m_hasFocus =
+    m_lostFocus = false;

 }
 
 }
 

-wxSize wxRadioBox::LayoutItems()
+bool wxRadioBox::Create( wxWindow *parent, wxWindowID id,
+                         const wxString& title,
+                         const wxPoint &pos, const wxSize &size,
+                         const wxArrayString& choices, int majorDim,
+                         long style, const wxValidator& validator,
+                         const wxString &name )

 {
 {

-    int x = 7;
-    int y = 15;
+    wxCArrayString chs(choices);

 
 

-    if ( m_majorDim == 0 )
-    {
-        // avoid dividing by 0 below
-        wxFAIL_MSG( wxT("dimension of radiobox should not be 0!") );
+    return Create( parent, id, title, pos, size, chs.GetCount(),
+                   chs.GetStrings(), majorDim, style, validator, name );
+}

 
 

-        m_majorDim = 1;
+bool wxRadioBox::Create( wxWindow *parent, wxWindowID id, const wxString& title,
+                         const wxPoint &pos, const wxSize &size,
+                         int n, const wxString choices[], int majorDim,
+                         long style, const wxValidator& validator,
+                         const wxString &name )
+{
+    if (!PreCreation( parent, pos, size ) ||
+        !CreateBase( parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG( wxT("wxRadioBox creation failed") );
+        return false;

     }
 
     }
 

-    int num_per_major = (m_boxes.GetCount() - 1) / m_majorDim +1;
+    m_widget = GTKCreateFrame(title);
+    wxControl::SetLabel(title);

 
 

-    wxSize res( 0, 0 );
+    // majorDim may be 0 if all trailing parameters were omitted, so don't
+    // assert here but just use the correct value for it
+    SetMajorDim(majorDim == 0 ? n : majorDim, style);

 
 

-    int num_of_cols = 0;
-    int num_of_rows = 0;
-    if (HasFlag(wxRA_SPECIFY_COLS))
-    {
-        num_of_cols = m_majorDim;
-        num_of_rows = num_per_major;
-    }
-    else
-    {
-        num_of_cols = num_per_major;
-        num_of_rows = m_majorDim;
-    }
-       
-    if ( HasFlag(wxRA_SPECIFY_COLS) ||
-         (HasFlag(wxRA_SPECIFY_ROWS) && (num_of_cols > 1)) )
-    {
-        for (int j = 0; j < num_of_cols; j++)
-        {
-            y = 15;

 
 

-            int max_len = 0;
-            wxNode *node = m_boxes.Nth( j*num_of_rows );
-            for (int i1 = 0; i1< num_of_rows; i1++)
-            {
-                GtkWidget *button = GTK_WIDGET( node->Data() );
-                GtkLabel *label = GTK_LABEL( GTK_BUTTON(button)->child );
-                GdkFont *font = m_widget->style->font;
-                int len = 22+gdk_string_measure( font, label->label );
-                if (len > max_len) max_len = len;
+    unsigned int num_of_cols = GetColumnCount();
+    unsigned int num_of_rows = GetRowCount();

 
 

-                gtk_pizza_move( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y );
-                y += 22;
+    GtkRadioButton *rbtn = (GtkRadioButton*) NULL;

 
 

-                node = node->Next();
-                if (!node) break;
-            }
+    GtkWidget *table = gtk_table_new( num_of_rows, num_of_cols, FALSE );
+    gtk_table_set_col_spacings( GTK_TABLE(table), 1 );
+    gtk_table_set_row_spacings( GTK_TABLE(table), 1 );
+    gtk_widget_show( table );
+    gtk_container_add( GTK_CONTAINER(m_widget), table );

 
 

-            // we don't know the max_len before
+    wxString label;
+    GSList *radio_button_group = (GSList *) NULL;
+    for (unsigned int i = 0; i < (unsigned int)n; i++)
+    {
+        if ( i != 0 )
+            radio_button_group = gtk_radio_button_get_group( GTK_RADIO_BUTTON(rbtn) );

 
 

-            node = m_boxes.Nth( j*num_of_rows );
-            for (int i2 = 0; i2< num_of_rows; i2++)
-            {
-                GtkWidget *button = GTK_WIDGET( node->Data() );
+        label.Empty();
+        for ( const wxChar *pc = choices[i]; *pc; pc++ )
+        {
+            if ( *pc != wxT('&') )
+                label += *pc;
+        }

 
 

-                gtk_pizza_resize( GTK_PIZZA(m_parent->m_wxwindow), button, max_len, 20 );
+        rbtn = GTK_RADIO_BUTTON( gtk_radio_button_new_with_label( radio_button_group, wxGTK_CONV( label ) ) );
+        gtk_widget_show( GTK_WIDGET(rbtn) );

 
 

-                node = node->Next();
-                if (!node) break;
-            }
+        g_signal_connect (rbtn, "key_press_event",
+                          G_CALLBACK (gtk_radiobox_keypress_callback), this);

 
 

-            if (y > res.y) res.y = y;
+        m_buttonsInfo.Append( new wxGTKRadioButtonInfo( rbtn, wxRect() ) );

 
 

-            x += max_len + 2;
+        if (HasFlag(wxRA_SPECIFY_COLS))
+        {
+            int left = i%num_of_cols;
+            int right = (i%num_of_cols) + 1;
+            int top = i/num_of_cols;
+            int bottom = (i/num_of_cols)+1;
+            gtk_table_attach( GTK_TABLE(table), GTK_WIDGET(rbtn), left, right, top, bottom,
+                  GTK_FILL, GTK_FILL, 1, 1 );
+        }
+        else
+        {
+            int left = i/num_of_rows;
+            int right = (i/num_of_rows) + 1;
+            int top = i%num_of_rows;
+            int bottom = (i%num_of_rows)+1;
+            gtk_table_attach( GTK_TABLE(table), GTK_WIDGET(rbtn), left, right, top, bottom,
+                  GTK_FILL, GTK_FILL, 1, 1 );

         }
 
         }
 

-        res.x = x+4;
-        res.y += 9;
-    }
-    else
-    {
-        int max = 0;
+        ConnectWidget( GTK_WIDGET(rbtn) );

 
 

-        wxNode *node = m_boxes.First();
-        while (node)
-        {
-            GtkButton *button = GTK_BUTTON( node->Data() );
-            GtkLabel *label = GTK_LABEL( button->child );
+        if (!i)
+            gtk_toggle_button_set_active( GTK_TOGGLE_BUTTON(rbtn), TRUE );

 
 

-            GdkFont *font = m_widget->style->font;
-            int len = 22+gdk_string_measure( font, label->label );
-            if (len > max) max = len;
+        g_signal_connect (rbtn, "clicked",
+                          G_CALLBACK (gtk_radiobutton_clicked_callback), this);
+        g_signal_connect (rbtn, "focus_in_event",
+                          G_CALLBACK (gtk_radiobutton_focus_in), this);
+        g_signal_connect (rbtn, "focus_out_event",
+                          G_CALLBACK (gtk_radiobutton_focus_out), this);
+        g_signal_connect (rbtn, "size_allocate",
+                          G_CALLBACK (gtk_radiobutton_size_allocate), this);
+    }

 
 

-            node = node->Next();
-        }
+    m_parent->DoAddChild( this );

 
 

-        node = m_boxes.First();
-        while (node)
-        {
-            GtkWidget *button = GTK_WIDGET( node->Data() );
+    PostCreation(size);

 
 

-            gtk_pizza_set_size( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y, max, 20 );
-            x += max;
+    return true;
+}

 
 

-            node = node->Next();
-        }
-        res.x = x+4;
-        res.y = 40;
+wxRadioBox::~wxRadioBox()
+{
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();
+    while (node)
+    {
+        GtkWidget *button = GTK_WIDGET( node->GetData()->button );
+        gtk_widget_destroy( button );
+        node = node->GetNext();

     }
     }

-
-    return res;
+    WX_CLEAR_LIST( wxRadioBoxButtonsInfoList, m_buttonsInfo );

 }
 
 bool wxRadioBox::Show( bool show )
 {
 }
 
 bool wxRadioBox::Show( bool show )
 {

-    wxCHECK_MSG( m_widget != NULL, FALSE, wxT("invalid radiobox") );
+    wxCHECK_MSG( m_widget != NULL, false, wxT("invalid radiobox") );

 
     if (!wxControl::Show(show))
     {
         // nothing to do
 
     if (!wxControl::Show(show))
     {
         // nothing to do

-        return FALSE;
+        return false;

     }
 
     }
 

-    if ((m_windowStyle & wxNO_BORDER) != 0)
+    if ( HasFlag(wxNO_BORDER) )

         gtk_widget_hide( m_widget );
 
         gtk_widget_hide( m_widget );
 

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        GtkWidget *button = GTK_WIDGET( node->Data() );
+        GtkWidget *button = GTK_WIDGET( node->GetData()->button );

 
 

-        if (show) gtk_widget_show( button ); else gtk_widget_hide( button );
+        if (show)
+            gtk_widget_show( button );
+        else
+            gtk_widget_hide( button );

 
 

-        node = node->Next();
+        node = node->GetNext();

     }
 
     }
 

-    return TRUE;
-}
-
-int wxRadioBox::FindString( const wxString &s ) const
-{
-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid radiobox") );
-
-    int count = 0;
-
-    wxNode *node = m_boxes.First();
-    while (node)
-    {
-        GtkButton *button = GTK_BUTTON( node->Data() );
-
-        GtkLabel *label = GTK_LABEL( button->child );
-        if (s == label->label) return count;
-        count++;
-
-        node = node->Next();
-    }
-
-    return -1;
+    return true;

 }
 
 void wxRadioBox::SetFocus()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 
 }
 
 void wxRadioBox::SetFocus()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 

-    if (m_boxes.GetCount() == 0) return;
+    if (m_buttonsInfo.GetCount() == 0) return;

 
 

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->Data() );
+        GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->GetData()->button );

         if (button->active)
         {
             gtk_widget_grab_focus( GTK_WIDGET(button) );
         if (button->active)
         {
             gtk_widget_grab_focus( GTK_WIDGET(button) );

-

             return;
         }
             return;
         }

-        node = node->Next();
+        node = node->GetNext();

     }
     }

-

 }
 
 void wxRadioBox::SetSelection( int n )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 
 }
 
 void wxRadioBox::SetSelection( int n )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 

-    wxNode *node = m_boxes.Nth( n );
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( n );

 
     wxCHECK_RET( node, wxT("radiobox wrong index") );
 
 
     wxCHECK_RET( node, wxT("radiobox wrong index") );
 

-    GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->Data() );
+    GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->GetData()->button );
+
+    GtkDisableEvents();

 
 

-    DisableEvents();
-    
-    gtk_toggle_button_set_state( button, 1 );
-    
-    EnableEvents();
+    gtk_toggle_button_set_active( button, 1 );
+
+    GtkEnableEvents();

 }
 
 int wxRadioBox::GetSelection(void) const
 {
 }
 
 int wxRadioBox::GetSelection(void) const
 {

-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid radiobox") );
+    wxCHECK_MSG( m_widget != NULL, wxNOT_FOUND, wxT("invalid radiobox") );

 
     int count = 0;
 
 
     int count = 0;
 

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->Data() );
+        GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->GetData()->button );

         if (button->active) return count;
         count++;
         if (button->active) return count;
         count++;

-        node = node->Next();
+        node = node->GetNext();

     }
 
     wxFAIL_MSG( wxT("wxRadioBox none selected") );
 
     }
 
     wxFAIL_MSG( wxT("wxRadioBox none selected") );
 

-    return -1;
+    return wxNOT_FOUND;

 }
 
 }
 

-wxString wxRadioBox::GetString( int n ) const
+wxString wxRadioBox::GetString(unsigned int n) const

 {
 {

-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid radiobox") );
-
-    wxNode *node = m_boxes.Nth( n );
+    wxCHECK_MSG( m_widget != NULL, wxEmptyString, wxT("invalid radiobox") );

 
 

-    wxCHECK_MSG( node, wxT(""), wxT("radiobox wrong index") );
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( n );

 
 

-    GtkButton *button = GTK_BUTTON( node->Data() );
-    GtkLabel *label = GTK_LABEL( button->child );
+    wxCHECK_MSG( node, wxEmptyString, wxT("radiobox wrong index") );

 
 

-    return wxString( label->label );
-}
+    GtkLabel *label = GTK_LABEL(GTK_BIN(node->GetData()->button)->child);

 
 

-wxString wxRadioBox::GetLabel( int item ) const
-{
-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid radiobox") );
+    wxString str( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );

 
 

-    return GetString( item );
+    return str;

 }
 
 void wxRadioBox::SetLabel( const wxString& label )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 
 }
 
 void wxRadioBox::SetLabel( const wxString& label )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 

-    wxControl::SetLabel( label );
-
-    gtk_frame_set_label( GTK_FRAME(m_widget), wxControl::GetLabel().mbc_str() );
+    GTKSetLabelForFrame(GTK_FRAME(m_widget), label);

 }
 
 }
 

-void wxRadioBox::SetLabel( int item, const wxString& label )
+void wxRadioBox::SetString(unsigned int item, const wxString& label)

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
 

-    wxNode *node = m_boxes.Nth( item );
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( item );

 
     wxCHECK_RET( node, wxT("radiobox wrong index") );
 
 
     wxCHECK_RET( node, wxT("radiobox wrong index") );
 

-    GtkButton *button = GTK_BUTTON( node->Data() );
-    GtkLabel *g_label = GTK_LABEL( button->child );
-
-    gtk_label_set( g_label, label.mbc_str() );
-}
+    GtkLabel *g_label = GTK_LABEL(GTK_BIN(node->GetData()->button)->child);

 
 

-void wxRadioBox::SetLabel( int WXUNUSED(item), wxBitmap *WXUNUSED(bitmap) )
-{
-    wxFAIL_MSG(wxT("wxRadioBox::SetLabel not implemented."));
+    gtk_label_set_text( g_label, wxGTK_CONV( label ) );

 }
 
 bool wxRadioBox::Enable( bool enable )
 {
     if ( !wxControl::Enable( enable ) )
 }
 
 bool wxRadioBox::Enable( bool enable )
 {
     if ( !wxControl::Enable( enable ) )

-        return FALSE;
+        return false;

 
 

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        GtkButton *button = GTK_BUTTON( node->Data() );
-        GtkWidget *label = button->child;
+        GtkButton *button = GTK_BUTTON( node->GetData()->button );
+        GtkLabel *label = GTK_LABEL(GTK_BIN(button)->child);
+

         gtk_widget_set_sensitive( GTK_WIDGET(button), enable );
         gtk_widget_set_sensitive( GTK_WIDGET(button), enable );

-        gtk_widget_set_sensitive( label, enable );
-        node = node->Next();
+        gtk_widget_set_sensitive( GTK_WIDGET(label), enable );
+        node = node->GetNext();

     }
 
     }
 

-    return TRUE;
+    return true;

 }
 
 }
 

-void wxRadioBox::Enable( int item, bool enable )
+bool wxRadioBox::Enable(unsigned int item, bool enable)

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
+    wxCHECK_MSG( m_widget != NULL, false, wxT("invalid radiobox") );

 
 

-    wxNode *node = m_boxes.Nth( item );
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( item );

 
 

-    wxCHECK_RET( node, wxT("radiobox wrong index") );
+    wxCHECK_MSG( node, false, wxT("radiobox wrong index") );
+
+    GtkButton *button = GTK_BUTTON( node->GetData()->button );
+    GtkLabel *label = GTK_LABEL(GTK_BIN(button)->child);

 
 

-    GtkButton *button = GTK_BUTTON( node->Data() );
-    GtkWidget *label = button->child;

     gtk_widget_set_sensitive( GTK_WIDGET(button), enable );
     gtk_widget_set_sensitive( GTK_WIDGET(button), enable );

-    gtk_widget_set_sensitive( label, enable );
+    gtk_widget_set_sensitive( GTK_WIDGET(label), enable );
+
+    return true;

 }
 
 }
 

-void wxRadioBox::Show( int item, bool show )
+bool wxRadioBox::IsItemEnabled(unsigned int item) const

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid radiobox") );
+    wxCHECK_MSG( m_widget != NULL, false, wxT("invalid radiobox") );

 
 

-    wxNode *node = m_boxes.Nth( item );
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( item );

 
 

-    wxCHECK_RET( node, wxT("radiobox wrong index") );
+    wxCHECK_MSG( node, false, wxT("radiobox wrong index") );
+
+    GtkButton *button = GTK_BUTTON( node->GetData()->button );
+
+    // don't use GTK_WIDGET_IS_SENSITIVE() here, we want to return true even if
+    // the parent radiobox is disabled
+    return GTK_WIDGET_SENSITIVE(GTK_WIDGET(button));
+}
+
+bool wxRadioBox::Show(unsigned int item, bool show)
+{
+    wxCHECK_MSG( m_widget != NULL, false, wxT("invalid radiobox") );
+
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( item );

 
 

-    GtkWidget *button = GTK_WIDGET( node->Data() );
+    wxCHECK_MSG( node, false, wxT("radiobox wrong index") );
+
+    GtkWidget *button = GTK_WIDGET( node->GetData()->button );

 
     if (show)
         gtk_widget_show( button );
     else
         gtk_widget_hide( button );
 
     if (show)
         gtk_widget_show( button );
     else
         gtk_widget_hide( button );

+
+    return true;

 }
 
 }
 

-wxString wxRadioBox::GetStringSelection() const
+bool wxRadioBox::IsItemShown(unsigned int item) const

 {
 {

-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid radiobox") );
+    wxCHECK_MSG( m_widget != NULL, false, wxT("invalid radiobox") );

 
 

-    wxNode *node = m_boxes.First();
-    while (node)
-    {
-        GtkToggleButton *button = GTK_TOGGLE_BUTTON( node->Data() );
-        if (button->active)
-        {
-            GtkLabel *label = GTK_LABEL( GTK_BUTTON(button)->child );
-            return label->label;
-        }
-        node = node->Next();
-    }
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.Item( item );

 
 

-    wxFAIL_MSG( wxT("wxRadioBox none selected") );
-    return wxT("");
-}
+    wxCHECK_MSG( node, false, wxT("radiobox wrong index") );

 
 

-bool wxRadioBox::SetStringSelection( const wxString &s )
-{
-    wxCHECK_MSG( m_widget != NULL, FALSE, wxT("invalid radiobox") );
-
-    int res = FindString( s );
-    if (res == -1) return FALSE;
-    SetSelection( res );
+    GtkButton *button = GTK_BUTTON( node->GetData()->button );

 
 

-    return TRUE;
+    return GTK_WIDGET_VISIBLE(GTK_WIDGET(button));

 }
 
 }
 

-int wxRadioBox::Number() const
+unsigned int wxRadioBox::GetCount() const

 {
 {

-    return m_boxes.Number();
+    return m_buttonsInfo.GetCount();

 }
 
 }
 

-int wxRadioBox::GetNumberOfRowsOrCols() const
+void wxRadioBox::GtkDisableEvents()

 {
 {

-    return 1;
-}
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();
+    while (node)
+    {
+        g_signal_handlers_disconnect_by_func (node->GetData()->button,
+                                              (gpointer) gtk_radiobutton_clicked_callback,
+                                              this);

 
 

-void wxRadioBox::SetNumberOfRowsOrCols( int WXUNUSED(n) )
-{
-    wxFAIL_MSG(wxT("wxRadioBox::SetNumberOfRowsOrCols not implemented."));
+        node = node->GetNext();
+    }

 }
 
 }
 

-void wxRadioBox::DisableEvents()
+void wxRadioBox::GtkEnableEvents()

 {
 {

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        gtk_signal_disconnect_by_func( GTK_OBJECT(node->Data()),
-           GTK_SIGNAL_FUNC(gtk_radiobutton_clicked_callback), (gpointer*)this );
+        g_signal_connect (node->GetData()->button, "clicked",
+                          G_CALLBACK (gtk_radiobutton_clicked_callback), this);

 
 

-       node = node->Next();
+        node = node->GetNext();

     }
 }
 
     }
 }
 

-void wxRadioBox::EnableEvents()
+void wxRadioBox::DoApplyWidgetStyle(GtkRcStyle *style)

 {
 {

-    wxNode *node = m_boxes.First();
+    GTKFrameApplyWidgetStyle(GTK_FRAME(m_widget), style);
+
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        gtk_signal_connect( GTK_OBJECT(node->Data()), "clicked",
-           GTK_SIGNAL_FUNC(gtk_radiobutton_clicked_callback), (gpointer*)this );
+        GtkWidget *widget = GTK_WIDGET( node->GetData()->button );
+
+        gtk_widget_modify_style( widget, style );
+        gtk_widget_modify_style(GTK_BIN(widget)->child, style);

 
 

-       node = node->Next();
+        node = node->GetNext();

     }
 }
 
     }
 }
 

-void wxRadioBox::ApplyWidgetStyle()
+bool wxRadioBox::GTKWidgetNeedsMnemonic() const

 {
 {

-    SetWidgetStyle();
+    return true;
+}

 
 

-    gtk_widget_set_style( m_widget, m_widgetStyle );
+void wxRadioBox::GTKWidgetDoSetMnemonic(GtkWidget* w)
+{
+    GTKFrameSetMnemonicWidget(GTK_FRAME(m_widget), w);
+}

 
 

-    wxNode *node = m_boxes.First();
-    while (node)
+#if wxUSE_TOOLTIPS
+void wxRadioBox::ApplyToolTip(GtkTooltips * WXUNUSED(tips), const wxChar *tip)
+{
+    // set this tooltip for all radiobuttons which don't have their own tips
+    unsigned n = 0;
+    for ( wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();
+          node;
+          node = node->GetNext(), n++ )

     {
     {

-        GtkWidget *widget = GTK_WIDGET( node->Data() );
-        gtk_widget_set_style( widget, m_widgetStyle );
+        if ( !GetItemToolTip(n) )
+        {
+            wxToolTip::Apply(GTK_WIDGET(node->GetData()->button),
+                             wxConvCurrent->cWX2MB(tip));
+        }
+    }
+}

 
 

-        GtkButton *button = GTK_BUTTON( node->Data() );
-        gtk_widget_set_style( button->child, m_widgetStyle );
+void wxRadioBox::DoSetItemToolTip(unsigned int n, wxToolTip *tooltip)
+{
+    wxCharBuffer buf;
+    if ( !tooltip )
+        tooltip = GetToolTip();
+    if ( tooltip )
+        buf = wxGTK_CONV(tooltip->GetTip());

 
 

-        node = node->Next();
-    }
+    wxToolTip::Apply(GTK_WIDGET(m_buttonsInfo[n]->button), buf);

 }
 
 }
 

+#endif // wxUSE_TOOLTIPS
+

 bool wxRadioBox::IsOwnGtkWindow( GdkWindow *window )
 {
 bool wxRadioBox::IsOwnGtkWindow( GdkWindow *window )
 {

-    if (window == m_widget->window) return TRUE;
+    if (window == m_widget->window)
+        return true;

 
 

-    wxNode *node = m_boxes.First();
+    wxRadioBoxButtonsInfoList::compatibility_iterator node = m_buttonsInfo.GetFirst();

     while (node)
     {
     while (node)
     {

-        GtkWidget *button = GTK_WIDGET( node->Data() );
+        GtkWidget *button = GTK_WIDGET( node->GetData()->button );

 
 

-        if (window == button->window) return TRUE;
+        if (window == button->window)
+            return true;

 
 

-        node = node->Next();
+        node = node->GetNext();

     }
 
     }
 

-    return FALSE;
+    return false;

 }
 
 }
 

-#endif
+void wxRadioBox::OnInternalIdle()
+{
+    if ( m_lostFocus )
+    {
+        m_hasFocus = false;
+        m_lostFocus = false;
+
+        wxFocusEvent event( wxEVT_KILL_FOCUS, GetId() );
+        event.SetEventObject( this );
+
+        (void)GetEventHandler()->ProcessEvent( event );
+    }
+
+    if (g_delayedFocus == this)
+    {
+        if (GTK_WIDGET_REALIZED(m_widget))
+        {
+            g_delayedFocus = NULL;
+            SetFocus();
+        }
+    }
+}
+
+// static
+wxVisualAttributes
+wxRadioBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+    wxVisualAttributes attr;
+    // NB: we need toplevel window so that GTK+ can find the right style
+    GtkWidget *wnd = gtk_window_new(GTK_WINDOW_TOPLEVEL);
+    GtkWidget* widget = gtk_radio_button_new_with_label(NULL, "");
+    gtk_container_add(GTK_CONTAINER(wnd), widget);
+    attr = GetDefaultAttributesFromGTKWidget(widget);
+    gtk_widget_destroy(wnd);
+    return attr;
+}
+
+int wxRadioBox::GetItemFromPoint(const wxPoint& point) const
+{
+    const wxPoint pt = ScreenToClient(point);
+    unsigned n = 0;
+    for ( wxRadioBoxButtonsInfoList::compatibility_iterator
+            node = m_buttonsInfo.GetFirst(); node; node = node->GetNext(), n++ )
+    {
+        if ( m_buttonsInfo[n]->rect.Inside(pt) )
+            return n;
+    }
+
+    return wxNOT_FOUND;
+}
+
+#endif // wxUSE_RADIOBOX