Fix recreating of wxBitmapComboBox using untyped client data.

[wxWidgets.git] / src / motif / bmpbuttn.cpp

diff --git a/src/motif/bmpbuttn.cpp b/src/motif/bmpbuttn.cpp
index 9f8f221f7bdd0c09bc40eb68c1534317cbe56fc4..d4403a2e169d36eeb27f9f6322e78bee72d75748 100644 (file)
--- a/src/motif/bmpbuttn.cpp
+++ b/src/motif/bmpbuttn.cpp
@@ -1,109 +1,97 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        bmpbuttn.cpp
+// Name:        src/motif/bmpbuttn.cpp

 // Purpose:     wxBitmapButton
 // Author:      Julian Smart
 // Modified by:
 // Created:     17/09/98
 // Purpose:     wxBitmapButton
 // Author:      Julian Smart
 // Modified by:
 // Created:     17/09/98

-// RCS-ID:      $Id$

 // Copyright:   (c) Julian Smart
 // Copyright:   (c) Julian Smart

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "bmpbuttn.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 #include "wx/bmpbuttn.h"
 
 
 #include "wx/bmpbuttn.h"
 

+#ifdef __VMS__
+#pragma message disable nosimpint
+#endif

 #include <Xm/PushBG.h>
 #include <Xm/PushB.h>
 #include <Xm/PushBG.h>
 #include <Xm/PushB.h>

+#ifdef __VMS__
+#pragma message enable nosimpint
+#endif

 
 #include "wx/motif/private.h"
 
 // Implemented in button.cpp
 void wxButtonCallback (Widget w, XtPointer clientData, XtPointer ptr);
 
 
 #include "wx/motif/private.h"
 
 // Implemented in button.cpp
 void wxButtonCallback (Widget w, XtPointer clientData, XtPointer ptr);
 

-Pixmap XCreateInsensitivePixmap( Display *display, Pixmap pixmap );
-
-#if !USE_SHARED_LIBRARY
-IMPLEMENT_DYNAMIC_CLASS(wxBitmapButton, wxButton)
-#endif
+// Pixmap XCreateInsensitivePixmap( Display *display, Pixmap pixmap );

 
 wxBitmapButton::wxBitmapButton()
 {
 
 wxBitmapButton::wxBitmapButton()
 {

-    m_marginX = wxDEFAULT_BUTTON_MARGIN; m_marginY = wxDEFAULT_BUTTON_MARGIN;
+    m_marginX = m_marginY = wxDEFAULT_BUTTON_MARGIN;

     m_insensPixmap = (WXPixmap) 0;
 }
 
     m_insensPixmap = (WXPixmap) 0;
 }
 

-bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id, const wxBitmap& bitmap,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id,
+                            const wxBitmap& bitmap,
+                            const wxPoint& pos,
+                            const wxSize& size, long style,
+                            const wxValidator& validator,
+                            const wxString& name)

 {
 {

-    m_buttonBitmap = bitmap;
-    m_buttonBitmapOriginal = bitmap;
-    m_buttonBitmapSelected = bitmap;
-    m_buttonBitmapSelectedOriginal = bitmap;
-
-    SetName(name);
-    SetValidator(validator);
-    parent->AddChild(this);
-
-    m_backgroundColour = parent->GetBackgroundColour() ;
-    m_foregroundColour = parent->GetForegroundColour() ;
-    m_windowStyle = style;
-    m_marginX = 0;
-    m_marginY = 0;
-
-    int x = pos.x;
-    int y = pos.y;
-    int width = size.x;
-    int height = size.y;
-
-    if (id == -1)
-        m_windowId = NewControlId();
-    else
-        m_windowId = id;
+    if( !CreateControl( parent, id, pos, size, style, validator, name ) )
+        return false;
+    PreCreation();
+
+    m_bitmaps[State_Normal] =
+    m_bitmapsOriginal[State_Normal] = bitmap;
+    m_bitmaps[State_Pressed] =
+    m_bitmapsOriginal[State_Pressed] = bitmap;

 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 
 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 

-  /*
-   * Patch Note (important)
-   * There is no major reason to put a defaultButtonThickness here.
-   * Not requesting it give the ability to put wxButton with a spacing
-   * as small as requested. However, if some button become a DefaultButton,
-   * other buttons are no more aligned -- This is why we set
-   * defaultButtonThickness of ALL buttons belonging to the same wxPanel,
-   * in the ::SetDefaultButton method.
-   */
+    /*
+    * Patch Note (important)
+    * There is no major reason to put a defaultButtonThickness here.
+    * Not requesting it give the ability to put wxButton with a spacing
+    * as small as requested. However, if some button become a DefaultButton,
+    * other buttons are no more aligned -- This is why we set
+    * defaultButtonThickness of ALL buttons belonging to the same wxPanel,
+    * in the ::SetDefaultButton method.
+    */

     Widget buttonWidget = XtVaCreateManagedWidget ("button",
 
     Widget buttonWidget = XtVaCreateManagedWidget ("button",
 

-    // Gadget causes problems for default button operation.
+        // Gadget causes problems for default button operation.

 #if wxUSE_GADGETS
 #if wxUSE_GADGETS

-                           xmPushButtonGadgetClass, parentWidget,
+        xmPushButtonGadgetClass, parentWidget,

 #else
 #else

-                xmPushButtonWidgetClass, parentWidget,
+        xmPushButtonWidgetClass, parentWidget,

 #endif
 #endif

-//                  XmNdefaultButtonShadowThickness, 1, // See comment for wxButton::SetDefault
-                                                NULL);
+        // See comment for wxButton::SetDefault
+        // XmNdefaultButtonShadowThickness, 1,
+        XmNrecomputeSize, False,
+        NULL);

 
     m_mainWidget = (WXWidget) buttonWidget;
 
 
     m_mainWidget = (WXWidget) buttonWidget;
 

-    ChangeBackgroundColour ();
-
-    DoSetBitmap();
+    XtAddCallback (buttonWidget,
+                   XmNactivateCallback, (XtCallbackProc) wxButtonCallback,
+                   (XtPointer) this);

 
 

-    XtAddCallback (buttonWidget, XmNactivateCallback, (XtCallbackProc) wxButtonCallback,
-            (XtPointer) this);
+    wxSize best = GetBitmapLabel().IsOk() ? GetBestSize() : wxSize(30, 30);
+    if( size.x != -1 ) best.x = size.x;
+    if( size.y != -1 ) best.y = size.y;

 
 

-    SetCanAddEventHandler(TRUE);
-    AttachWidget (parent, m_mainWidget, (WXWidget) NULL, pos.x, pos.y, size.x, size.y);
+    PostCreation();
+    OnSetBitmap();

 
 

-    SetFont(* parent->GetFont());
+    AttachWidget (parent, m_mainWidget, (WXWidget) NULL,
+                  pos.x, pos.y, best.x, best.y);

 
 

-
-    return TRUE;
+    return true;

 }
 
 wxBitmapButton::~wxBitmapButton()
 }
 
 wxBitmapButton::~wxBitmapButton()


@@ -111,42 +99,22 @@ wxBitmapButton::~wxBitmapButton()
     SetBitmapLabel(wxNullBitmap);
 
     if (m_insensPixmap)
     SetBitmapLabel(wxNullBitmap);
 
     if (m_insensPixmap)

-        XmDestroyPixmap (DefaultScreenOfDisplay ((Display*) GetXDisplay()), (Pixmap) m_insensPixmap);
+        XmDestroyPixmap (DefaultScreenOfDisplay ((Display*) GetXDisplay()),
+                         (Pixmap) m_insensPixmap);

 }
 
 }
 

-void wxBitmapButton::SetBitmapLabel(const wxBitmap& bitmap)
+void wxBitmapButton::DoSetBitmap(const wxBitmap& bitmap, State which)

 {
 {

-    m_buttonBitmapOriginal = bitmap;
-    m_buttonBitmap = bitmap;
+    m_bitmapsOriginal[which] = bitmap;

 
 

-    DoSetBitmap();
+    wxBitmapButtonBase::DoSetBitmap(bitmap, which);

 }
 
 }
 

-void wxBitmapButton::SetBitmapSelected(const wxBitmap& sel)
-{
-    m_buttonBitmapSelected = sel;
-    m_buttonBitmapSelectedOriginal = sel;
-
-    DoSetBitmap();
-};
-
-void wxBitmapButton::SetBitmapFocus(const wxBitmap& focus)
+void wxBitmapButton::OnSetBitmap()

 {
 {

-    m_buttonBitmapFocus = focus;
-    // Not used in Motif
-};
+    wxBitmapButtonBase::OnSetBitmap();

 
 

-void wxBitmapButton::SetBitmapDisabled(const wxBitmap& disabled)
-{
-    m_buttonBitmapDisabled = disabled;
-    m_buttonBitmapDisabledOriginal = disabled;
-
-    DoSetBitmap();
-};
-
-void wxBitmapButton::DoSetBitmap()
-{
-    if (m_buttonBitmapOriginal.Ok())
+    if ( m_bitmapsOriginal[State_Normal].IsOk() )

     {
         Pixmap pixmap = 0;
         Pixmap insensPixmap = 0;
     {
         Pixmap pixmap = 0;
         Pixmap insensPixmap = 0;


@@ -154,74 +122,77 @@ void wxBitmapButton::DoSetBitmap()
 
         // Must re-make the bitmap to have its transparent areas drawn
         // in the current widget background colour.
 
         // Must re-make the bitmap to have its transparent areas drawn
         // in the current widget background colour.

-        if (m_buttonBitmapOriginal.GetMask())
+        if ( m_bitmapsOriginal[State_Normal].GetMask() )

         {
         {

-            int backgroundPixel;
-            XtVaGetValues((Widget) m_mainWidget, XmNbackground, &backgroundPixel,
-                   NULL);
+            WXPixel backgroundPixel;
+            XtVaGetValues((Widget) m_mainWidget,
+                          XmNbackground, &backgroundPixel,
+                          NULL);

 
             wxColour col;
             col.SetPixel(backgroundPixel);
 
             wxColour col;
             col.SetPixel(backgroundPixel);

-                
-            wxBitmap newBitmap = wxCreateMaskedBitmap(m_buttonBitmapOriginal, col);
-            m_buttonBitmap = newBitmap;

 
 

-            pixmap = (Pixmap) m_buttonBitmap.GetPixmap();
+            wxBitmap newBitmap =
+                wxCreateMaskedBitmap(m_bitmapsOriginal[State_Normal], col);
+            m_bitmaps[State_Normal] = newBitmap;
+            m_bitmapCache.SetBitmap( m_bitmaps[State_Normal] );
+
+            pixmap = (Pixmap) m_bitmaps[State_Normal].GetDrawable();

         }
         else
         }
         else

-            pixmap = (Pixmap) m_buttonBitmap.GetLabelPixmap(m_mainWidget);
+        {
+            m_bitmapCache.SetBitmap( m_bitmaps[State_Normal] );
+            pixmap = (Pixmap) m_bitmapCache.GetLabelPixmap(m_mainWidget);
+        }

 
 

-        if (m_buttonBitmapDisabledOriginal.Ok())
+        if (m_bitmapsOriginal[State_Disabled].IsOk())

         {
         {

-            if (m_buttonBitmapDisabledOriginal.GetMask())
+            if (m_bitmapsOriginal[State_Disabled].GetMask())

             {
             {

-                int backgroundPixel;
-                XtVaGetValues((Widget) m_mainWidget, XmNbackground, &backgroundPixel,
-                   NULL);
+                WXPixel backgroundPixel;
+                XtVaGetValues((Widget) m_mainWidget,
+                              XmNbackground, &backgroundPixel,
+                              NULL);

 
                 wxColour col;
                 col.SetPixel(backgroundPixel);
 
                 wxColour col;
                 col.SetPixel(backgroundPixel);

-                
-                wxBitmap newBitmap = wxCreateMaskedBitmap(m_buttonBitmapDisabledOriginal, col);
-                m_buttonBitmapDisabled = newBitmap;

 
 

-                insensPixmap = (Pixmap) m_buttonBitmapDisabled.GetPixmap();
+                wxBitmap newBitmap =
+                    wxCreateMaskedBitmap(m_bitmapsOriginal[State_Disabled], col);
+                m_bitmaps[State_Disabled] = newBitmap;
+
+                insensPixmap = (Pixmap) m_bitmaps[State_Disabled].GetDrawable();

             }
             else
             }
             else

-                insensPixmap = (Pixmap) m_buttonBitmap.GetInsensPixmap(m_mainWidget);
+                insensPixmap = (Pixmap) m_bitmapCache.GetInsensPixmap(m_mainWidget);

         }
         else
         }
         else

-            insensPixmap = (Pixmap) m_buttonBitmap.GetInsensPixmap(m_mainWidget);
+            insensPixmap = (Pixmap) m_bitmapCache.GetInsensPixmap(m_mainWidget);

 
         // Now make the bitmap representing the armed state
 
         // Now make the bitmap representing the armed state

-        if (m_buttonBitmapSelectedOriginal.Ok())
+        if (m_bitmapsOriginal[State_Pressed].IsOk())

         {
         {

-            if (m_buttonBitmapSelectedOriginal.GetMask())
+            if (m_bitmapsOriginal[State_Pressed].GetMask())

             {
             {

-                int backgroundPixel;
-                XtVaGetValues((Widget) m_mainWidget, XmNarmColor, &backgroundPixel,
-                   NULL);
+                WXPixel backgroundPixel;
+                XtVaGetValues((Widget) m_mainWidget,
+                              XmNarmColor, &backgroundPixel,
+                              NULL);

 
                 wxColour col;
                 col.SetPixel(backgroundPixel);
 
                 wxColour col;
                 col.SetPixel(backgroundPixel);

-                
-                wxBitmap newBitmap = wxCreateMaskedBitmap(m_buttonBitmapSelectedOriginal, col);
-                m_buttonBitmapSelected = newBitmap;

 
 

-                armPixmap = (Pixmap) m_buttonBitmapSelected.GetPixmap();
+                wxBitmap newBitmap =
+                    wxCreateMaskedBitmap(m_bitmapsOriginal[State_Pressed], col);
+                m_bitmaps[State_Pressed] = newBitmap;
+
+                armPixmap = (Pixmap) m_bitmaps[State_Pressed].GetDrawable();

             }
             else
             }
             else

-              armPixmap = (Pixmap) m_buttonBitmap.GetArmPixmap(m_mainWidget);
+                armPixmap = (Pixmap) m_bitmapCache.GetArmPixmap(m_mainWidget);

         }
         else
         }
         else

-          armPixmap = (Pixmap) m_buttonBitmap.GetArmPixmap(m_mainWidget);
-
-        if (insensPixmap == pixmap) // <- the Get...Pixmap()-functions return the same pixmap!
-        {
-            insensPixmap =
-                XCreateInsensitivePixmap(DisplayOfScreen(XtScreen((Widget) m_mainWidget)), pixmap);
-            m_insensPixmap = (WXPixmap) insensPixmap;
-        }
+            armPixmap = (Pixmap) m_bitmapCache.GetArmPixmap(m_mainWidget);

 
         XtVaSetValues ((Widget) m_mainWidget,
             XmNlabelPixmap, pixmap,
 
         XtVaSetValues ((Widget) m_mainWidget,
             XmNlabelPixmap, pixmap,


@@ -237,7 +208,7 @@ void wxBitmapButton::DoSetBitmap()
         XtVaSetValues ((Widget) m_mainWidget,
             XmNlabelType, XmSTRING,
             XmNlabelPixmap, XmUNSPECIFIED_PIXMAP,
         XtVaSetValues ((Widget) m_mainWidget,
             XmNlabelType, XmSTRING,
             XmNlabelPixmap, XmUNSPECIFIED_PIXMAP,

-           XmNlabelInsensitivePixmap, XmUNSPECIFIED_PIXMAP,
+            XmNlabelInsensitivePixmap, XmUNSPECIFIED_PIXMAP,

             XmNarmPixmap, XmUNSPECIFIED_PIXMAP,
             NULL);
     }
             XmNarmPixmap, XmUNSPECIFIED_PIXMAP,
             NULL);
     }


@@ -245,8 +216,24 @@ void wxBitmapButton::DoSetBitmap()
 
 void wxBitmapButton::ChangeBackgroundColour()
 {
 
 void wxBitmapButton::ChangeBackgroundColour()
 {

-    DoChangeBackgroundColour(m_mainWidget, m_backgroundColour, TRUE);
+    wxDoChangeBackgroundColour(m_mainWidget, m_backgroundColour, true);

 
     // Must reset the bitmaps since the colours have changed.
 
     // Must reset the bitmaps since the colours have changed.

-    DoSetBitmap();
+    OnSetBitmap();
+}
+
+wxSize wxBitmapButton::DoGetBestSize() const
+{
+    wxSize ret( 30,30 );
+
+    if (GetBitmapLabel().IsOk())
+    {
+        int border = HasFlag(wxNO_BORDER) ? 4 : 10;
+        ret.x += border;
+        ret.y += border;
+
+        ret += GetBitmapLabel().GetSize();
+    }
+
+    return ret;

 }
 }