static wxString GetTypeName(wxCmdLineParamType type);
+static wxString GetOptionName(const wxChar *p, const wxChar *allowedChars);
+
+static wxString GetShortOptionName(const wxChar *p);
+
+static wxString GetLongOptionName(const wxChar *p);
+
// ----------------------------------------------------------------------------
-// private classes
+// private structs
// ----------------------------------------------------------------------------
// an internal representation of an option
wxASSERT_MSG( !shrt.empty() || !lng.empty(),
_T("option should have at least one name") );
+ wxASSERT_MSG
+ (
+ GetShortOptionName(shrt).Len() == shrt.Len(),
+ wxT("Short option contains invalid characters")
+ );
+
+ wxASSERT_MSG
+ (
+ GetLongOptionName(lng).Len() == lng.Len(),
+ wxT("Long option contains invalid characters")
+ );
+
kind = k;
shortName = shrt;
public:
wxCmdLineEntryType kind;
- wxString shortName, longName, description;
+ wxString shortName,
+ longName,
+ description;
wxCmdLineParamType type;
int flags;
m_data->m_enableLongOptions = enable;
}
+bool wxCmdLineParser::AreLongOptionsEnabled()
+{
+ return m_data->m_enableLongOptions;
+}
+
void wxCmdLineParser::SetLogo(const wxString& logo)
{
m_data->m_logo = logo;
wxString wxCmdLineParser::GetParam(size_t n) const
{
+ wxCHECK_MSG( n < GetParamCount(), wxEmptyString, _T("invalid param index") );
+
return m_data->m_parameters[n];
}
// the real work is done here
// ----------------------------------------------------------------------------
-int wxCmdLineParser::Parse()
+int wxCmdLineParser::Parse(bool showUsage)
{
bool maybeOption = TRUE; // can the following arg be an option?
bool ok = TRUE; // TRUE until an error is detected
int optInd = wxNOT_FOUND; // init to suppress warnings
// an option or a switch: find whether it's a long or a short one
- if ( m_data->m_enableLongOptions &&
- arg[0u] == _T('-') && arg[1u] == _T('-') )
+ if ( arg[0u] == _T('-') && arg[1u] == _T('-') )
{
// a long one
isLong = TRUE;
+ // Skip leading "--"
const wxChar *p = arg.c_str() + 2;
- while ( wxIsalnum(*p) || (*p == _T('_')) || (*p == _T('-')) )
+
+ bool longOptionsEnabled = AreLongOptionsEnabled();
+
+ name = GetLongOptionName(p);
+
+ if (longOptionsEnabled)
{
- name += *p++;
+ optInd = m_data->FindOptionByLongName(name);
+ if ( optInd == wxNOT_FOUND )
+ {
+ wxLogError(_("Unknown long option '%s'"), name.c_str());
+ }
}
-
- optInd = m_data->FindOptionByLongName(name);
- if ( optInd == wxNOT_FOUND )
+ else
{
- wxLogError(_("Unknown long option '%s'"), name.c_str());
+ optInd = wxNOT_FOUND; // Sanity check
+
+ // Print the argument including leading "--"
+ name.Prepend( wxT("--") );
+ wxLogError(_("Unknown option '%s'"), name.c_str());
}
+
}
else
{
// a short one: as they can be cumulated, we try to find the
// longest substring which is a valid option
const wxChar *p = arg.c_str() + 1;
- while ( wxIsalnum(*p) || (*p == _T('_')) )
- {
- name += *p++;
- }
+
+ name = GetShortOptionName(p);
size_t len = name.length();
do
}
}
- if ( !ok )
+ if ( !ok && showUsage )
{
Usage();
}
wxChar chSwitch = !m_data->m_switchChars ? _T('-')
: m_data->m_switchChars[0u];
+ bool areLongOptionsEnabled = AreLongOptionsEnabled();
size_t n, count = m_data->m_options.GetCount();
for ( n = 0; n < count; n++ )
{
brief << _T('[');
}
- brief << chSwitch << opt.shortName;
+ if ( !opt.shortName.empty() )
+ {
+ brief << chSwitch << opt.shortName;
+ }
+ else if ( areLongOptionsEnabled && !opt.longName.empty() )
+ {
+ brief << _T("--") << opt.longName;
+ }
+ else
+ {
+ if (!opt.longName.empty())
+ {
+ wxFAIL_MSG( wxT("option with only a long name while long ")
+ wxT("options are disabled") );
+ }
+ else
+ {
+ wxFAIL_MSG( _T("option without neither short nor long name") );
+ }
+ }
wxString option;
- option << _T(" ") << chSwitch << opt.shortName;
- if ( !!opt.longName )
+
+ if ( !opt.shortName.empty() )
+ {
+ option << _T(" ") << chSwitch << opt.shortName;
+ }
+
+ if ( areLongOptionsEnabled && !opt.longName.empty() )
{
- option << _T(" --") << opt.longName;
+ option << (option.empty() ? _T(" ") : _T(", "))
+ << _T("--") << opt.longName;
}
if ( opt.kind != wxCMD_LINE_SWITCH )
wxLogMessage(m_data->m_logo);
}
+ // in console mode we want to show the brief usage message first, then the
+ // detailed one but in GUI build we give the details first and then the
+ // summary - like this, the brief message appears in the wxLogGui dialog,
+ // as expected
+#if !wxUSE_GUI
wxLogMessage(brief);
+#endif // !wxUSE_GUI
// now construct the detailed help message
size_t len, lenMax = 0;
}
wxLogMessage(detailed);
+
+ // do it now if not done above
+#if wxUSE_GUI
+ wxLogMessage(brief);
+#endif // wxUSE_GUI
}
// ----------------------------------------------------------------------------
return s;
}
+/*
+Returns a string which is equal to the string pointed to by p, but up to the
+point where p contains an character that's not allowed.
+Allowable characters are letters and numbers, and characters pointed to by
+the parameter allowedChars.
+
+For example, if p points to "abcde-@-_", and allowedChars is "-_",
+this function returns "abcde-".
+*/
+static wxString GetOptionName(const wxChar *p,
+ const wxChar *allowedChars)
+{
+ wxString argName;
+
+ while ( *p && (wxIsalnum(*p) || wxStrchr(allowedChars, *p)) )
+ {
+ argName += *p++;
+ }
+
+ return argName;
+}
+
+// Besides alphanumeric characters, short and long options can
+// have other characters.
+
+// A short option additionally can have these
+#define wxCMD_LINE_CHARS_ALLOWED_BY_SHORT_OPTION wxT("_?")
+
+// A long option can have the same characters as a short option and a '-'.
+#define wxCMD_LINE_CHARS_ALLOWED_BY_LONG_OPTION \
+ wxCMD_LINE_CHARS_ALLOWED_BY_SHORT_OPTION wxT("-")
+
+static wxString GetShortOptionName(const wxChar *p)
+{
+ return GetOptionName(p, wxCMD_LINE_CHARS_ALLOWED_BY_SHORT_OPTION);
+}
+
+static wxString GetLongOptionName(const wxChar *p)
+{
+ return GetOptionName(p, wxCMD_LINE_CHARS_ALLOWED_BY_LONG_OPTION);
+}
+
#endif // wxUSE_CMDLINE_PARSER
// ----------------------------------------------------------------------------
// global functions
// ----------------------------------------------------------------------------
+/*
+ This function is mainly used under Windows (as under Unix we always get the
+ command line arguments as argc/argv anyhow) and so it tries to handle the
+ Windows path names (separated by backslashes) correctly. For this it only
+ considers that a backslash may be used to escape another backslash (but
+ normally this is _not_ needed) or a quote but nothing else.
+
+ In particular, to pass a single argument containing a space to the program
+ it should be quoted:
+
+ myprog.exe foo bar -> argc = 3, argv[1] = "foo", argv[2] = "bar"
+ myprog.exe "foo bar" -> argc = 2, argv[1] = "foo bar"
+
+ To pass an argument containing spaces and quotes, the latter should be
+ escaped with a backslash:
+
+ myprog.exe "foo \"bar\"" -> argc = 2, argv[1] = "foo "bar""
+
+ This hopefully matches the conventions used by Explorer/command line
+ interpreter under Windows. If not, this function should be fixed.
+ */
+
/* static */
wxArrayString wxCmdLineParser::ConvertStringToArgs(const wxChar *p)
{
p++;
// if we have 2 backslashes in a row, output one
- if ( isQuotedByBS )
+ // unless it looks like a UNC path \\machine\dir\file.ext
+ if ( isQuotedByBS || arg.Len() == 0 )
{
arg += _T('\\');
isQuotedByBS = FALSE;
case _T(' '):
case _T('\t'):
+ // we intentionally don't check for preceding backslash
+ // here as if we allowed it to be used to escape spaces the
+ // cmd line of the form "foo.exe a:\ c:\bar" wouldn't be
+ // parsed correctly
if ( isInsideQuotes )
{
// preserve it, skip endParam below
case _T('\0'):
endParam = TRUE;
break;
+
+ default:
+ if ( isQuotedByBS )
+ {
+ // ignore backslash before an ordinary character - this
+ // is needed to properly handle the file names under
+ // Windows appearing in the command line
+ arg += _T('\\');
+ }
}
// end of argument?
projects / wxWidgets.git / blobdiff