always define our HKPD/CC/DD constants, without using WINVER which is irrelevant...

[wxWidgets.git] / include / wx / msw / combobox.h

diff --git a/include/wx/msw/combobox.h b/include/wx/msw/combobox.h
index 0ef87a536a301f63d15a2151195690f1a2375f09..a99ec2fee80f9192b6faecd12c61c52f6c7826f3 100644 (file)
--- a/include/wx/msw/combobox.h
+++ b/include/wx/msw/combobox.h
@@ -23,7 +23,7 @@
 class WXDLLEXPORT wxComboBox: public wxChoice
 {
 public:
 class WXDLLEXPORT wxComboBox: public wxChoice
 {
 public:

-    wxComboBox() { Init(); }
+    wxComboBox() { }

 
     wxComboBox(wxWindow *parent, wxWindowID id,
             const wxString& value = wxEmptyString,
 
     wxComboBox(wxWindow *parent, wxWindowID id,
             const wxString& value = wxEmptyString,


@@ -34,8 +34,6 @@ public:
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxComboBoxNameStr)
     {
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxComboBoxNameStr)
     {

-        Init();
-

         Create(parent, id, value, pos, size, n, choices, style, validator, name);
     }
     wxComboBox(wxWindow *parent, wxWindowID id,
         Create(parent, id, value, pos, size, n, choices, style, validator, name);
     }
     wxComboBox(wxWindow *parent, wxWindowID id,


@@ -47,8 +45,6 @@ public:
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxComboBoxNameStr)
     {
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxComboBoxNameStr)
     {

-        Init();
-

         Create(parent, id, value, pos, size, choices, style, validator, name);
     }
 
         Create(parent, id, value, pos, size, choices, style, validator, name);
     }
 


@@ -75,7 +71,7 @@ public:
     // List functions: see wxChoice
 
     // Text field functions
     // List functions: see wxChoice
 
     // Text field functions

-    wxString GetValue() const { return m_value; }
+    virtual wxString GetValue() const;

     virtual void SetValue(const wxString& value);
 
     // Clipboard operations
     virtual void SetValue(const wxString& value);
 
     // Clipboard operations


@@ -91,19 +87,18 @@ public:
     virtual wxTextPos GetLastPosition() const;
     virtual void Replace(long from, long to, const wxString& value);
     virtual void Remove(long from, long to);
     virtual wxTextPos GetLastPosition() const;
     virtual void Replace(long from, long to, const wxString& value);
     virtual void Remove(long from, long to);

-    virtual void SetSelection(int n);
+    virtual void SetSelection(int n) { wxChoice::SetSelection(n); }

     virtual void SetSelection(long from, long to);
     virtual void SetSelection(long from, long to);

-    virtual int GetSelection() const;
+    virtual int GetSelection() const { return wxChoice::GetSelection(); }

     virtual void GetSelection(long* from, long* to) const;
     virtual void SetEditable(bool editable);
     virtual void GetSelection(long* from, long* to) const;
     virtual void SetEditable(bool editable);

-    virtual void Clear();

 
 

-    virtual void Undo() ;
-    virtual void Redo() ;
+    virtual void Undo();
+    virtual void Redo();

     virtual bool CanUndo() const;
     virtual bool CanRedo() const;
     virtual void SelectAll();
     virtual bool CanUndo() const;
     virtual bool CanRedo() const;
     virtual void SelectAll();

-    virtual bool IsEditable() const ;
+    virtual bool IsEditable() const;

     virtual bool HasSelection() const;
 
     // implementation only from now on
     virtual bool HasSelection() const;
 
     // implementation only from now on


@@ -130,19 +125,8 @@ public:
     void OnUpdateDelete(wxUpdateUIEvent& event);
     void OnUpdateSelectAll(wxUpdateUIEvent& event);
 
     void OnUpdateDelete(wxUpdateUIEvent& event);
     void OnUpdateSelectAll(wxUpdateUIEvent& event);
 

-protected:

     virtual WXDWORD MSWGetStyle(long style, WXDWORD *exstyle) const;
 
     virtual WXDWORD MSWGetStyle(long style, WXDWORD *exstyle) const;
 

-    // common part of all ctors
-    void Init() { m_selectionOld = -1; }
-
-
-    // the previous selection (see MSWCommand() to see why it is needed)
-    int m_selectionOld;
-
-    // the current selection (also see MSWCommand())
-    wxString m_value;
-

 private:
     DECLARE_DYNAMIC_CLASS_NO_COPY(wxComboBox)
     DECLARE_EVENT_TABLE()
 private:
     DECLARE_DYNAMIC_CLASS_NO_COPY(wxComboBox)
     DECLARE_EVENT_TABLE()