avoid causing idle event from GetValue(), fixes #11013

[wxWidgets.git] / src / gtk / combobox.cpp

diff --git a/src/gtk/combobox.cpp b/src/gtk/combobox.cpp
index 13d19d958b4b3ff85b4ee2296a081d92529cb76d..e5a8a75d6d01fad8b3fe80043040dd63caf0cd27 100644 (file)
--- a/src/gtk/combobox.cpp
+++ b/src/gtk/combobox.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        combobox.cpp
+// Name:        src/gtk/combobox.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$


@@ -7,842 +7,336 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "combobox.h"
-#endif
-
-#include "wx/combobox.h"
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 #if wxUSE_COMBOBOX
 
 
 #if wxUSE_COMBOBOX
 

-#include "wx/settings.h"
-#include "wx/intl.h"
+#include "wx/combobox.h"

 
 

-#include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/settings.h"
+    #include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
+    #include "wx/arrstr.h"
+#endif

 
 #include "wx/gtk/private.h"
 
 
 #include "wx/gtk/private.h"
 

-//-----------------------------------------------------------------------------
-// idle system
-//-----------------------------------------------------------------------------
-
-extern void wxapp_install_idle_handler();
-extern bool g_isIdle;
-
-//-----------------------------------------------------------------------------
-// data
-//-----------------------------------------------------------------------------
-
-extern bool   g_blockEventsOnDrag;
-
-//-----------------------------------------------------------------------------
-// "select-child" - click/cursor get select-child, changed, select-child
-//-----------------------------------------------------------------------------
+// ----------------------------------------------------------------------------
+// GTK callbacks
+// ----------------------------------------------------------------------------

 
 

+extern "C" {

 static void
 static void

-gtk_combo_select_child_callback( GtkList *WXUNUSED(list), GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+gtkcombobox_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )

 {
 {

-    if (g_isIdle) wxapp_install_idle_handler();
-

     if (!combo->m_hasVMT) return;
 
     if (!combo->m_hasVMT) return;
 

-    if (g_blockEventsOnDrag) return;
-
-    int curSelection = combo->GetSelection();
-
-    if (combo->m_prevSelection != curSelection)
-    {
-        GtkWidget *list = GTK_COMBO(combo->m_widget)->list;
-        gtk_list_unselect_item( GTK_LIST(list), combo->m_prevSelection );
-    }
-    combo->m_prevSelection = curSelection;
-
-    wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
-    event.SetInt( curSelection );
-    event.SetString( combo->GetStringSelection() );
+    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+    event.SetString( combo->GetValue() );

     event.SetEventObject( combo );
     event.SetEventObject( combo );

-
-    combo->GetEventHandler()->ProcessEvent( event );
+    combo->HandleWindowEvent( event );

 }
 
 }
 

-//-----------------------------------------------------------------------------
-//  "changed" - typing and list item matches get changed, select-child
-//              if it doesn't match an item then just get a single changed
-//-----------------------------------------------------------------------------
-

 static void
 static void

-gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+gtkcombobox_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )

 {
 {

-    if (g_isIdle) wxapp_install_idle_handler();
-
-    if (!combo->m_hasVMT) return;
-
-    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
-    event.SetString( combo->GetValue() );
-    event.SetEventObject( combo );
-    combo->GetEventHandler()->ProcessEvent( event );
+    combo->SendSelectionChangedEvent(wxEVT_COMMAND_COMBOBOX_SELECTED);

 }
 
 static void
 }
 
 static void

-gtk_dummy_callback(GtkEntry *WXUNUSED(entry), GtkCombo *WXUNUSED(combo))
-{
+gtkcombobox_popupshown_callback(GObject *WXUNUSED(gobject),
+                                GParamSpec *WXUNUSED(param_spec),
+                                wxComboBox *combo)
+{
+    gboolean isShown;
+    g_object_get( combo->m_widget, "popup-shown", &isShown, NULL );
+    wxCommandEvent event( isShown ? wxEVT_COMMAND_COMBOBOX_DROPDOWN
+                                  : wxEVT_COMMAND_COMBOBOX_CLOSEUP,
+                          combo->GetId() );
+    event.SetEventObject( combo );
+    combo->HandleWindowEvent( event );
+}

 }
 
 //-----------------------------------------------------------------------------
 // wxComboBox
 //-----------------------------------------------------------------------------
 
 }
 
 //-----------------------------------------------------------------------------
 // wxComboBox
 //-----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxComboBox,wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxComboBox, wxChoice)

 
 

-BEGIN_EVENT_TABLE(wxComboBox, wxControl)
-    EVT_SIZE(wxComboBox::OnSize)
+BEGIN_EVENT_TABLE(wxComboBox, wxChoice)

     EVT_CHAR(wxComboBox::OnChar)
     EVT_CHAR(wxComboBox::OnChar)

+
+    EVT_MENU(wxID_CUT, wxComboBox::OnCut)
+    EVT_MENU(wxID_COPY, wxComboBox::OnCopy)
+    EVT_MENU(wxID_PASTE, wxComboBox::OnPaste)
+    EVT_MENU(wxID_UNDO, wxComboBox::OnUndo)
+    EVT_MENU(wxID_REDO, wxComboBox::OnRedo)
+    EVT_MENU(wxID_CLEAR, wxComboBox::OnDelete)
+    EVT_MENU(wxID_SELECTALL, wxComboBox::OnSelectAll)
+
+    EVT_UPDATE_UI(wxID_CUT, wxComboBox::OnUpdateCut)
+    EVT_UPDATE_UI(wxID_COPY, wxComboBox::OnUpdateCopy)
+    EVT_UPDATE_UI(wxID_PASTE, wxComboBox::OnUpdatePaste)
+    EVT_UPDATE_UI(wxID_UNDO, wxComboBox::OnUpdateUndo)
+    EVT_UPDATE_UI(wxID_REDO, wxComboBox::OnUpdateRedo)
+    EVT_UPDATE_UI(wxID_CLEAR, wxComboBox::OnUpdateDelete)
+    EVT_UPDATE_UI(wxID_SELECTALL, wxComboBox::OnUpdateSelectAll)

 END_EVENT_TABLE()
 
 END_EVENT_TABLE()
 

+void wxComboBox::Init()
+{
+    m_entry = NULL;
+}
+
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id,
+                         const wxString& value,
+                         const wxPoint& pos, const wxSize& size,
+                         const wxArrayString& choices,
+                         long style, const wxValidator& validator,
+                         const wxString& name )
+{
+    wxCArrayString chs(choices);
+
+    return Create( parent, id, value, pos, size, chs.GetCount(),
+                   chs.GetStrings(), style, validator, name );
+}
+

 bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
                          const wxPoint& pos, const wxSize& size,
                          int n, const wxString choices[],
                          long style, const wxValidator& validator,
                          const wxString& name )
 {
 bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
                          const wxPoint& pos, const wxSize& size,
                          int n, const wxString choices[],
                          long style, const wxValidator& validator,
                          const wxString& name )
 {

-    m_alreadySent = FALSE;
-    m_needParent = TRUE;
-    m_acceptsFocus = TRUE;
-    m_prevSelection = 0;
-

     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {
         wxFAIL_MSG( wxT("wxComboBox creation failed") );
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {
         wxFAIL_MSG( wxT("wxComboBox creation failed") );

-        return FALSE;
+        return false;

     }
 
     }
 

-    m_widget = gtk_combo_new();
-    GtkCombo *combo = GTK_COMBO(m_widget);
-
-    // Disable GTK's broken events ...
-    gtk_signal_disconnect( GTK_OBJECT(combo->entry), combo->entry_change_id );
-    // ... and add surogate handler.
-    combo->entry_change_id = gtk_signal_connect (GTK_OBJECT (combo->entry), "changed",
-                             (GtkSignalFunc) gtk_dummy_callback, combo);
-
-    // make it more useable
-    gtk_combo_set_use_arrows_always( GTK_COMBO(m_widget), TRUE );
+    if (HasFlag(wxCB_SORT))
+        m_strings = new wxSortedArrayString();

 
 

-    // and case-sensitive
-    gtk_combo_set_case_sensitive( GTK_COMBO(m_widget), TRUE );
+    GTKCreateComboBoxWidget();

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-#ifndef __WXGTK20__
-    // gtk_list_set_selection_mode( GTK_LIST(list), GTK_SELECTION_MULTIPLE );
-#endif
-
-    for (int i = 0; i < n; i++)
+    if (HasFlag(wxBORDER_NONE))

     {
     {

-        GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( choices[i] ) );
-
-        m_clientDataList.Append( (wxObject*)NULL );
-        m_clientObjectList.Append( (wxObject*)NULL );
-
-        gtk_container_add( GTK_CONTAINER(list), list_item );
-
-        gtk_widget_show( list_item );
+        // Doesn't seem to work
+        // g_object_set (m_widget, "has-frame", FALSE, NULL);

     }
 
     }
 

-    m_parent->DoAddChild( this );
-
-    m_focusWidget = combo->entry;
-
-    PostCreation();
-
-    ConnectWidget( combo->button );
-
-    // MSW's combo box shows the value and the selection is -1
-    gtk_entry_set_text( GTK_ENTRY(combo->entry), wxGTK_CONV(value) );
-    gtk_list_unselect_all( GTK_LIST(combo->list) );
-
-    if (style & wxCB_READONLY)
-        gtk_entry_set_editable( GTK_ENTRY( combo->entry ), FALSE );
-
-    gtk_signal_connect( GTK_OBJECT(combo->entry), "changed",
-      GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
+    GtkEntry * const entry = GetEntry();

 
 

-    gtk_signal_connect( GTK_OBJECT(combo->list), "select-child",
-      GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
-
-    wxSize size_best( DoGetBestSize() );
-    wxSize new_size( size );
-    if (new_size.x == -1)
-        new_size.x = size_best.x;
-    if (new_size.y == -1)
-        new_size.y = size_best.y;
-    if (new_size.y > size_best.y)
-        new_size.y = size_best.y;
-    if ((new_size.x != size.x) || (new_size.y != size.y))
+    if ( entry )

     {
     {

-        SetSize( new_size.x, new_size.y );
+        // Set it up to trigger default item on enter key press
+        gtk_entry_set_activates_default( entry,
+                                         !HasFlag(wxTE_PROCESS_ENTER) );

 
 

-        // This is required for tool bar support
-        gtk_widget_set_usize( m_widget, new_size.x, new_size.y );
+        gtk_entry_set_editable( entry, TRUE );

     }
 
     }
 

-    SetBackgroundColour( wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOW ) );
-    SetForegroundColour( parent->GetForegroundColour() );
-
-    Show( TRUE );
-
-    return TRUE;
-}
-
-wxComboBox::~wxComboBox()
-{
-    wxNode *node = m_clientObjectList.GetFirst();
-    while (node)
-    {
-        wxClientData *cd = (wxClientData*)node->GetData();
-        if (cd) delete cd;
-        node = node->GetNext();
-    }
-    m_clientObjectList.Clear();
-
-    m_clientDataList.Clear();
-}
-
-void wxComboBox::SetFocus()
-{
-    if ( m_hasFocus )
-    {
-        // don't do anything if we already have focus
-        return;
-    }
-
-    gtk_widget_grab_focus( m_focusWidget );
-}
-
-void wxComboBox::AppendCommon( const wxString &item )
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    DisableEvents();
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );
-
-    gtk_container_add( GTK_CONTAINER(list), list_item );
-
-    if (GTK_WIDGET_REALIZED(m_widget))
-    {
-        gtk_widget_realize( list_item );
-        gtk_widget_realize( GTK_BIN(list_item)->child );
-
-        if (m_widgetStyle) ApplyWidgetStyle();
-    }
-
-    gtk_widget_show( list_item );
-
-    EnableEvents();
-}
-
-void wxComboBox::Append( const wxString &item )
-{
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) NULL );
-
-    AppendCommon( item );
-}
-
-void wxComboBox::Append( const wxString &item, void *clientData )
-{
-    m_clientDataList.Append( (wxObject*) clientData );
-    m_clientObjectList.Append( (wxObject*)NULL );
-
-    AppendCommon( item );
-}
-
-void wxComboBox::Append( const wxString &item, wxClientData *clientData )
-{
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) clientData );
-
-    AppendCommon( item );
-}
-
-void wxComboBox::InsertCommon( const wxString &item, int pos )
-{
-    wxCHECK_RET(!(GetWindowStyle() & wxCB_SORT), wxT("can't insert into sorted list"));
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    int count = GetCount();
-    wxCHECK_RET((pos>=0) && (pos<=count), wxT("invalid index"));
-    if (pos == count)
-    {
-        AppendCommon(item);
-        return;
-    }
-
-    DisableEvents();
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );
-
-    GList *gitem_list = g_list_alloc ();
-    gitem_list->data = list_item;
-    gtk_list_insert_items( GTK_LIST (list), gitem_list, pos );
-
-    if (GTK_WIDGET_REALIZED(m_widget))
-    {
-        gtk_widget_realize( list_item );
-        gtk_widget_realize( GTK_BIN(list_item)->child );
-
-        if (m_widgetStyle) ApplyWidgetStyle();
-    }
-
-    gtk_widget_show( list_item );
-
-    EnableEvents();
-}
-
-void wxComboBox::Insert( const wxString &item, int pos )
-{
-    wxCHECK_RET(!(GetWindowStyle() & wxCB_SORT), wxT("can't insert into sorted list"));
-    int count = GetCount();
-    wxCHECK_RET((pos>=0) && (pos<=count), wxT("invalid index"));
-    if (pos == count)
-    {
-        Append(item);
-        return;
-    }
-
-    m_clientDataList.Insert( pos, (wxObject*) NULL );
-    m_clientObjectList.Insert( pos, (wxObject*) NULL );
-
-    InsertCommon( item, pos );
-}
-
-void wxComboBox::Insert( const wxString &item, int pos, void *clientData )
-{
-    wxCHECK_RET(!(GetWindowStyle() & wxCB_SORT), wxT("can't insert into sorted list"));
-    int count = GetCount();
-    wxCHECK_RET((pos>=0) && (pos<=count), wxT("invalid index"));
-    if (pos == count)
-    {
-        Append(item, clientData);
-        return;
-    }
-
-    m_clientDataList.Insert( pos, (wxObject*) clientData );
-    m_clientObjectList.Insert( pos, (wxObject*)NULL );
-
-    InsertCommon( item, pos );
-}
-
-void wxComboBox::Insert( const wxString &item, int pos, wxClientData *clientData )
-{
-    wxCHECK_RET(!(GetWindowStyle() & wxCB_SORT), wxT("can't insert into sorted list"));
-    int count = GetCount();
-    wxCHECK_RET((pos>=0) && (pos<=count), wxT("invalid index"));
-    if (pos == count)
-    {
-        Append(item, clientData);
-        return;
-    }
-
-    m_clientDataList.Insert( pos, (wxObject*) NULL );
-    m_clientObjectList.Insert( pos, (wxObject*) clientData );
-
-    InsertCommon( item, pos );
-}
+    Append(n, choices);

 
 

-void wxComboBox::SetClientData( int n, void* clientData )
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    wxNode *node = m_clientDataList.Item( n );
-    if (!node) return;
-
-    node->SetData( (wxObject*) clientData );
-}
-
-void* wxComboBox::GetClientData( int n ) const
-{
-    wxCHECK_MSG( m_widget != NULL, NULL, wxT("invalid combobox") );
-
-    wxNode *node = m_clientDataList.Item( n );
-
-    return node ? node->GetData() : NULL;
-}
-
-void wxComboBox::SetClientObject( int n, wxClientData* clientData )
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    wxNode *node = m_clientObjectList.Item( n );
-    if (!node) return;
-
-    wxClientData *cd = (wxClientData*) node->GetData();
-    if (cd) delete cd;
-
-    node->SetData( (wxObject*) clientData );
-}
-
-wxClientData* wxComboBox::GetClientObject( int n ) const
-{
-    wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, wxT("invalid combobox") );
-
-    wxNode *node = m_clientObjectList.Item( n );
-
-    return node ? (wxClientData*) node->GetData() : NULL;
-}
-
-void wxComboBox::Clear()
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    DisableEvents();
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_clear_items( GTK_LIST(list), 0, Number() );
-
-    wxNode *node = m_clientObjectList.GetFirst();
-    while (node)
-    {
-        wxClientData *cd = (wxClientData*)node->GetData();
-        if (cd) delete cd;
-        node = node->GetNext();
-    }
-    m_clientObjectList.Clear();
-
-    m_clientDataList.Clear();
-
-    EnableEvents();
-}
-
-void wxComboBox::Delete( int n )
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
-
-    GList *child = g_list_nth( listbox->children, n );
-
-    if (!child)
-    {
-        wxFAIL_MSG(wxT("wrong index"));
-        return;
-    }
-
-    DisableEvents();
-
-    GList *list = g_list_append( (GList*) NULL, child->data );
-    gtk_list_remove_items( listbox, list );
-    g_list_free( list );
-
-    wxNode *node = m_clientObjectList.Item( n );
-    if (node)
-    {
-        wxClientData *cd = (wxClientData*)node->GetData();
-        if (cd) delete cd;
-        m_clientObjectList.DeleteNode( node );
-    }
-
-    node = m_clientDataList.Item( n );
-    if (node)
-        m_clientDataList.DeleteNode( node );
-
-    EnableEvents();
-}
-
-void wxComboBox::SetString(int n, const wxString &text)
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GList *child = g_list_nth( GTK_LIST(list)->children, n );
-    if (child)
-    {
-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-        gtk_label_set_text(label, wxGTK_CONV(text));
-    }
-    else
-    {
-        wxFAIL_MSG( wxT("wxComboBox: wrong index") );
-    }
-}
-
-int wxComboBox::FindString( const wxString &item )
-{
-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child)
-    {
-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-#ifdef __WXGTK20__
-        wxString str( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
-#else
-        wxString str( label->label );
-#endif
-        if (item == str)
-            return count;
-
-        count++;
-        child = child->next;
-    }
-
-    return wxNOT_FOUND;
-}
+    m_parent->DoAddChild( this );

 
 

-int wxComboBox::GetSelection() const
-{
-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+    if ( entry )
+        m_focusWidget = GTK_WIDGET( entry );

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    PostCreation(size);

 
 

-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
+    if ( entry )

     {
     {

-        GList *child = GTK_LIST(list)->children;
-        int count = 0;
-        while (child)
+        if (style & wxCB_READONLY)

         {
         {

-            if (child->data == selection->data) return count;
-            count++;
-            child = child->next;
+            // this will assert and do nothing if the value is not in our list
+            // of strings which is the desired behaviour (for consistency with
+            // wxMSW and also because it doesn't make sense to have a string
+            // which is not a possible choice in a read-only combobox)
+            SetStringSelection(value);
+            gtk_entry_set_editable( entry, FALSE );
+        }
+        else // editable combobox
+        {
+            // any value is accepted, even if it's not in our list
+            gtk_entry_set_text( entry, wxGTK_CONV(value) );

         }
         }

-    }
-
-    return -1;
-}
-
-wxString wxComboBox::GetString( int n ) const
-{
-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;

 
 

-    wxString str;
-    GList *child = g_list_nth( GTK_LIST(list)->children, n );
-    if (child)
-    {
-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-#ifdef __WXGTK20__
-        str = wxGTK_CONV_BACK( gtk_label_get_text(label) );
-#else
-        str = wxString( label->label );
-#endif
-    }
-    else
-    {
-        wxFAIL_MSG( wxT("wxComboBox: wrong index") );
+        g_signal_connect_after (entry, "changed",
+                                G_CALLBACK (gtkcombobox_text_changed_callback), this);

     }
 
     }
 

-    return str;
-}
-
-wxString wxComboBox::GetStringSelection() const
-{
-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    g_signal_connect_after (m_widget, "changed",
+                        G_CALLBACK (gtkcombobox_changed_callback), this);

 
 

-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
+    if ( !gtk_check_version(2,10,0) )

     {
     {

-        GtkBin *bin = GTK_BIN( selection->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-#ifdef __WXGTK20__
-        wxString tmp( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
-#else
-        wxString tmp( label->label );
-#endif
-        return tmp;
+        g_signal_connect (m_widget, "notify::popup-shown",
+                          G_CALLBACK (gtkcombobox_popupshown_callback), this);

     }
 
     }
 

-    wxFAIL_MSG( wxT("wxComboBox: no selection") );
+    SetInitialSize(size); // need this too because this is a wxControlWithItems

 
 

-    return wxT("");
+    return true;

 }
 
 }
 

-int wxComboBox::Number() const
+void wxComboBox::GTKCreateComboBoxWidget()

 {
 {

-    wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    m_widget = gtk_combo_box_entry_new_text();
+    g_object_ref(m_widget);

 
 

-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child) { count++; child = child->next; }
-    return count;
+    m_entry = GTK_ENTRY(GTK_BIN(m_widget)->child);

 }
 
 }
 

-void wxComboBox::SetSelection( int n )
+GtkEditable *wxComboBox::GetEditable() const

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    DisableEvents();
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_unselect_item( GTK_LIST(list), m_prevSelection );
-    gtk_list_select_item( GTK_LIST(list), n );
-    m_prevSelection = n;
-
-    EnableEvents();
+    return GTK_EDITABLE( GTK_BIN(m_widget)->child );

 }
 
 }
 

-void wxComboBox::SetStringSelection( const wxString &string )
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    int res = FindString( string );
-    if (res == -1) return;
-    SetSelection( res );
-}
-
-wxString wxComboBox::GetValue() const
+void wxComboBox::OnChar( wxKeyEvent &event )

 {
 {

-    GtkEntry *entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
-    wxString tmp( wxGTK_CONV_BACK( gtk_entry_get_text( entry ) ) );
-
-#if 0
-    for (int i = 0; i < wxStrlen(tmp.c_str()) +1; i++)
+    switch ( event.GetKeyCode() )

     {
     {

-        wxChar c = tmp[i];
-        printf( "%d ", (int) (c) );
+        case WXK_RETURN:
+            if ( HasFlag(wxTE_PROCESS_ENTER) && GetEntry() )
+            {
+                // GTK automatically selects an item if its in the list
+                wxCommandEvent eventEnter(wxEVT_COMMAND_TEXT_ENTER, GetId());
+                eventEnter.SetString( GetValue() );
+                eventEnter.SetInt( GetSelection() );
+                eventEnter.SetEventObject( this );
+
+                if ( HandleWindowEvent(eventEnter) )
+                {
+                    // Catch GTK event so that GTK doesn't open the drop
+                    // down list upon RETURN.
+                    return;
+                }
+            }
+            break;

     }
     }

-    printf( "\n" );
-#endif

 
 

-    return tmp;
+    event.Skip();

 }
 
 }
 

-void wxComboBox::SetValue( const wxString& value )
+void wxComboBox::DisableEvents()

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    if ( GetEntry() )
+        g_signal_handlers_block_by_func(GTK_BIN(m_widget)->child,
+            (gpointer)gtkcombobox_text_changed_callback, this);

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    wxString tmp = wxT("");
-    if (!value.IsNull()) tmp = value;
-    gtk_entry_set_text( GTK_ENTRY(entry), wxGTK_CONV( tmp ) );
+    g_signal_handlers_block_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);
+    g_signal_handlers_block_by_func(m_widget,
+        (gpointer)gtkcombobox_popupshown_callback, this);

 }
 
 }
 

-void wxComboBox::Copy()
+void wxComboBox::EnableEvents()

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    if ( GetEntry() )
+        g_signal_handlers_unblock_by_func(GTK_BIN(m_widget)->child,
+            (gpointer)gtkcombobox_text_changed_callback, this);

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_copy_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG );
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtkcombobox_popupshown_callback, this);

 }
 
 }
 

-void wxComboBox::Cut()
+GtkWidget* wxComboBox::GetConnectWidget()

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_cut_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG );
+    return GTK_WIDGET( GetEntry() );

 }
 
 }
 

-void wxComboBox::Paste()
+GdkWindow *wxComboBox::GTKGetWindow(wxArrayGdkWindows& windows) const

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    wxUnusedVar(windows);

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_paste_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG);
+    return GetEntry()->text_area;

 }
 
 }
 

-void wxComboBox::SetInsertionPoint( long pos )
+// static
+wxVisualAttributes
+wxComboBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_entry_set_position( GTK_ENTRY(entry), (int)pos );
+    return GetDefaultAttributesFromGTKWidget(gtk_combo_box_entry_new, true);

 }
 
 }
 

-void wxComboBox::SetInsertionPointEnd()
-{
-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    SetInsertionPoint( -1 );
-}
+// ----------------------------------------------------------------------------
+// standard event handling
+// ----------------------------------------------------------------------------

 
 

-long wxComboBox::GetInsertionPoint() const
+void wxComboBox::OnCut(wxCommandEvent& WXUNUSED(event))

 {
 {

-    return (long) GET_EDITABLE_POS( GTK_COMBO(m_widget)->entry );
+    Cut();

 }
 
 }
 

-long wxComboBox::GetLastPosition() const
+void wxComboBox::OnCopy(wxCommandEvent& WXUNUSED(event))

 {
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    int pos = GTK_ENTRY(entry)->text_length;
-    return (long) pos-1;
+    Copy();

 }
 
 }
 

-void wxComboBox::Replace( long from, long to, const wxString& value )
+void wxComboBox::OnPaste(wxCommandEvent& WXUNUSED(event))

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
-    if (value.IsNull()) return;
-    gint pos = (gint)to;
-
-#if wxUSE_UNICODE
-    wxCharBuffer buffer = wxConvUTF8.cWX2MB( value );
-    gtk_editable_insert_text( GTK_EDITABLE(entry), (const char*) buffer, strlen( (const char*) buffer ), &pos );
-#else
-    gtk_editable_insert_text( GTK_EDITABLE(entry), value.c_str(), value.Length(), &pos );
-#endif
+    Paste();

 }
 
 }
 

-void wxComboBox::Remove(long from, long to)
+void wxComboBox::OnUndo(wxCommandEvent& WXUNUSED(event))

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    Undo();

 }
 
 }
 

-void wxComboBox::SetSelection( long from, long to )
+void wxComboBox::OnRedo(wxCommandEvent& WXUNUSED(event))

 {
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_select_region( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    Redo();

 }
 
 }
 

-void wxComboBox::SetEditable( bool editable )
+void wxComboBox::OnDelete(wxCommandEvent& WXUNUSED(event))

 {
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_entry_set_editable( GTK_ENTRY(entry), editable );
+    RemoveSelection();

 }
 
 }
 

-void wxComboBox::OnChar( wxKeyEvent &event )
+void wxComboBox::OnSelectAll(wxCommandEvent& WXUNUSED(event))

 {
 {

-    if ( event.GetKeyCode() == WXK_RETURN )
-    {
-        // GTK automatically selects an item if its in the list
-        wxCommandEvent event(wxEVT_COMMAND_TEXT_ENTER, GetId());
-        event.SetString( GetValue() );
-        event.SetInt( GetSelection() );
-        event.SetEventObject( this );
-
-        if (!GetEventHandler()->ProcessEvent( event ))
-        {
-            // This will invoke the dialog default action, such
-            // as the clicking the default button.
-
-            wxWindow *top_frame = m_parent;
-            while (top_frame->GetParent() && !(top_frame->IsTopLevel()))
-                top_frame = top_frame->GetParent();
-
-            if (top_frame && GTK_IS_WINDOW(top_frame->m_widget))
-            {
-                GtkWindow *window = GTK_WINDOW(top_frame->m_widget);
-
-                if (window->default_widget)
-                    gtk_widget_activate (window->default_widget);
-            }
-        }
-
-        // Catch GTK event so that GTK doesn't open the drop
-        // down list upon RETURN.
-        return;
-    }
-
-    event.Skip();
+    SelectAll();

 }
 
 }
 

-void wxComboBox::DisableEvents()
+void wxComboBox::OnUpdateCut(wxUpdateUIEvent& event)

 {
 {

-    gtk_signal_disconnect_by_func( GTK_OBJECT(GTK_COMBO(m_widget)->list),
-      GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
-    gtk_signal_disconnect_by_func( GTK_OBJECT(GTK_COMBO(m_widget)->entry),
-      GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
+    event.Enable( CanCut() );

 }
 
 }
 

-void wxComboBox::EnableEvents()
+void wxComboBox::OnUpdateCopy(wxUpdateUIEvent& event)

 {
 {

-    gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->list), "select-child",
-      GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
-    gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->entry), "changed",
-      GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
+    event.Enable( CanCopy() );

 }
 
 }
 

-void wxComboBox::OnSize( wxSizeEvent &event )
+void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)

 {
 {

-    event.Skip();
-
-#if 0
-    int w = 21;
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->entry, m_width-w-1, m_height );
-
-    gtk_widget_set_uposition( GTK_COMBO(m_widget)->button, m_x+m_width-w, m_y );
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->button, w, m_height );
-#endif // 0
+    event.Enable( CanPaste() );

 }
 
 }
 

-void wxComboBox::ApplyWidgetStyle()
+void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)

 {
 {

-    SetWidgetStyle();
-
-//    gtk_widget_set_style( GTK_COMBO(m_widget)->button, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->entry, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->list, m_widgetStyle );
-
-    GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
-    GList *child = list->children;
-    while (child)
-    {
-        gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle );
-
-        GtkBin *bin = GTK_BIN(child->data);
-        gtk_widget_set_style( bin->child, m_widgetStyle );
-
-        child = child->next;
-    }
+    event.Enable( CanUndo() );

 }
 
 }
 

-GtkWidget* wxComboBox::GetConnectWidget()
+void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)

 {
 {

-    return GTK_COMBO(m_widget)->entry;
+    event.Enable( CanRedo() );

 }
 
 }
 

-bool wxComboBox::IsOwnGtkWindow( GdkWindow *window )
+void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)

 {
 {

-    return ( (window == GTK_ENTRY( GTK_COMBO(m_widget)->entry )->text_area) ||
-             (window == GTK_COMBO(m_widget)->button->window ) );
+    event.Enable(HasSelection() && IsEditable()) ;

 }
 
 }
 

-wxSize wxComboBox::DoGetBestSize() const
+void wxComboBox::OnUpdateSelectAll(wxUpdateUIEvent& event)

 {
 {

-    wxSize ret( wxControl::DoGetBestSize() );
-
-    // we know better our horizontal extent: it depends on the longest string
-    // in the combobox
-    ret.x = 0;
-    if ( m_widget )
-    {
-        int width;
-        size_t count = GetCount();
-        for ( size_t n = 0; n < count; n++ )
-        {
-            GetTextExtent( GetString(n), &width, NULL, NULL, NULL, &m_font );
-            if ( width > ret.x )
-                ret.x = width;
-        }
-    }
-
-    // empty combobox should have some reasonable default size too
-    if ( ret.x < 100 )
-        ret.x = 100;
-    return ret;
+    event.Enable(!wxTextEntry::IsEmpty());

 }
 
 }
 

-#endif
+#endif // wxUSE_COMBOBOX