fixed memory leak in wxXmlResource introduced when fixing wxVector<> usage (patch...

[wxWidgets.git] / include / wx / buffer.h

diff --git a/include/wx/buffer.h b/include/wx/buffer.h
index bfaba4e58d3679383cd3888b0fb15cb64dc347bb..d06fbf6fc15b57a76d726521cd9f4295621bd111 100644 (file)
--- a/include/wx/buffer.h
+++ b/include/wx/buffer.h
@@ -105,9 +105,12 @@ public:
 
     wxCharTypeBuffer& operator=(const wxCharTypeBuffer& src)
     {
-        if ( m_owned )
-            free(m_str);
-        CopyFrom(src);
+        if (&src != this)
+        {
+            if ( m_owned )
+                free(m_str);
+            CopyFrom(src);
+        }
         return *this;
     }
 
@@ -228,9 +231,9 @@ typedef wxWritableCharTypeBuffer<wchar_t> wxWritableWCharBuffer;
 
 // type of the value returned by wxString::utf8_str()
 #if wxUSE_UNICODE_UTF8
-    #define wxUTF8Buf wxCharBuffer
-#else
     #define wxUTF8Buf char *
+#else
+    #define wxUTF8Buf wxCharBuffer
 #endif
 
 // ----------------------------------------------------------------------------
@@ -317,9 +320,12 @@ public:
 
     wxMemoryBuffer& operator=(const wxMemoryBuffer& src)
     {
-        m_bufdata->DecRef();
-        m_bufdata = src.m_bufdata;
-        m_bufdata->IncRef();
+        if (&src != this)
+        {
+            m_bufdata->DecRef();
+            m_bufdata = src.m_bufdata;
+            m_bufdata->IncRef();
+        }
         return *this;
     }