switched to new XPM code in wxMSW

[wxWidgets.git] / src / msw / radiobox.cpp

diff --git a/src/msw/radiobox.cpp b/src/msw/radiobox.cpp
index fee27add5987da9a3414da5c289a81d15d8180c6..ca437cd5d90f2e67baa4a87f8fad982c0ed59f28 100644 (file)
--- a/src/msw/radiobox.cpp
+++ b/src/msw/radiobox.cpp
@@ -1,6 +1,6 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        radiobox.cpp
-// Purpose:     wxRadioBox
+// Name:        msw/radiobox.cpp
+// Purpose:     wxRadioBox implementation

 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98


@@ -9,734 +9,1069 @@
 // Licence:     wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 

+// ===========================================================================
+// declarations
+// ===========================================================================
+
+// ---------------------------------------------------------------------------
+// headers
+// ---------------------------------------------------------------------------
+

 #ifdef __GNUG__
 #ifdef __GNUG__

-#pragma implementation "radiobox.h"
+    #pragma implementation "radiobox.h"

 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__

-#pragma hdrstop
+    #pragma hdrstop

 #endif
 
 #ifndef WX_PRECOMP
 #endif
 
 #ifndef WX_PRECOMP

-#include <stdio.h>
-#include "wx/setup.h"
-#include "wx/radiobox.h"
+    #include "wx/bitmap.h"
+    #include "wx/brush.h"
+    #include "wx/radiobox.h"
+    #include "wx/settings.h"
+    #include "wx/log.h"

 #endif
 
 #include "wx/msw/private.h"
 
 #endif
 
 #include "wx/msw/private.h"
 

-#if !USE_SHARED_LIBRARY
+#if wxUSE_TOOLTIPS
+    #ifndef __GNUWIN32_OLD__
+        #include <commctrl.h>
+    #endif
+    #include "wx/tooltip.h"
+#endif // wxUSE_TOOLTIPS
+

 IMPLEMENT_DYNAMIC_CLASS(wxRadioBox, wxControl)
 IMPLEMENT_DYNAMIC_CLASS(wxRadioBox, wxControl)

-#endif

 
 

-bool wxRadioBox::MSWCommand(WXUINT param, WXWORD id)
-{
-  if (param == BN_CLICKED)
-  {
+// there are two possible ways to create the radio buttons: either as children
+// of the radiobox or as siblings of it - allow playing with both variants for
+// now, eventually we will choose the best one for our purposes
+//
+// two main problems are the keyboard navigation inside the radiobox (arrows
+// should switch between buttons, not pass focus to the next control) and the
+// tooltips - a tooltip is associated with the radiobox itself, not the
+// children...
+//
+// the problems with setting this to 1:
+// a) Alt-<mnemonic of radiobox> isn't handled properly by IsDialogMessage()
+//    because it sets focus to the next control accepting it which is not a
+//    radio button but a radiobox sibling in this case - the only solution to
+//    this would be to handle Alt-<mnemonic> ourselves
+// b) the problems with setting radiobox colours under Win98/2K were reported
+//    but I couldn't reproduce it so I have no idea about what causes it
+//
+// the problems with setting this to 0:
+// a) the tooltips are not shown for the radiobox - possible solution: make
+//    TTM_WINDOWFROMPOS handling code in msw/tooltip.cpp work (easier said than
+//    done because I don't know why it doesn't work)
+#define RADIOBTN_PARENT_IS_RADIOBOX 0
+
+// ---------------------------------------------------------------------------
+// private functions
+// ---------------------------------------------------------------------------
+
+// wnd proc for radio buttons

 #ifdef __WIN32__
 #ifdef __WIN32__

-    int i;
-    for (i = 0; i < m_noItems; i++)
-      if (id == GetWindowLong((HWND) m_radioButtons[i], GWL_ID))
-        m_selectedButton = i;
-#else
-    int i;
-    for (i = 0; i < m_noItems; i++)
-      if (id == GetWindowWord((HWND) m_radioButtons[i], GWW_ID))
-        m_selectedButton = i;
-#endif
+LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hWnd,
+                                           UINT message,
+                                           WPARAM wParam,
+                                           LPARAM lParam);

 
 

-    wxCommandEvent event(wxEVT_COMMAND_RADIOBOX_SELECTED, m_windowId);
-    event.SetInt( m_selectedButton );
-    event.SetEventObject( this );
-    ProcessCommand(event);
-    return TRUE;
-  }
-  else return FALSE;
+// ---------------------------------------------------------------------------
+// global vars
+// ---------------------------------------------------------------------------
+
+// the pointer to standard radio button wnd proc
+static WXFARPROC s_wndprocRadioBtn = (WXFARPROC)NULL;
+
+#endif // __WIN32__
+
+// ===========================================================================
+// implementation
+// ===========================================================================
+
+// ---------------------------------------------------------------------------
+// wxRadioBox
+// ---------------------------------------------------------------------------
+
+// returns the number of rows
+int wxRadioBox::GetNumVer() const
+{
+    if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+    {
+        return m_majorDim;
+    }
+    else
+    {
+        return (m_noItems + m_majorDim - 1)/m_majorDim;
+    }
+}
+
+// returns the number of columns
+int wxRadioBox::GetNumHor() const
+{
+    if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+    {
+        return (m_noItems + m_majorDim - 1)/m_majorDim;
+    }
+    else
+    {
+        return m_majorDim;
+    }
+}
+
+bool wxRadioBox::MSWCommand(WXUINT cmd, WXWORD id)
+{
+    if ( cmd == BN_CLICKED )
+    {
+        if (id == GetId())
+            return TRUE;
+
+        int selectedButton = -1;
+
+        for ( int i = 0; i < m_noItems; i++ )
+        {
+            if ( id == wxGetWindowId(m_radioButtons[i]) )
+            {
+                selectedButton = i;
+
+                break;
+            }
+        }
+
+        if ( selectedButton == -1 )
+        {
+            // just ignore it - due to a hack with WM_NCHITTEST handling in our
+            // wnd proc, we can receive dummy click messages when we click near
+            // the radiobox edge (this is ugly but Julian wouldn't let me get
+            // rid of this...)
+            return FALSE;
+        }
+
+        if ( selectedButton != m_selectedButton )
+        {
+            m_selectedButton = selectedButton;
+
+            SendNotificationEvent();
+        }
+        //else: don't generate events when the selection doesn't change
+
+        return TRUE;
+    }
+    else
+        return FALSE;

 }
 
 #if WXWIN_COMPATIBILITY
 wxRadioBox::wxRadioBox(wxWindow *parent, wxFunction func, const char *title,
 }
 
 #if WXWIN_COMPATIBILITY
 wxRadioBox::wxRadioBox(wxWindow *parent, wxFunction func, const char *title,

-             int x, int y, int width, int height,
-             int n, char **choices,
-             int majorDim, long style, const char *name)
+        int x, int y, int width, int height,
+        int n, char **choices,
+        int majorDim, long style, const char *name)

 {
     wxString *choices2 = new wxString[n];
     for ( int i = 0; i < n; i ++) choices2[i] = choices[i];
     Create(parent, -1, title, wxPoint(x, y), wxSize(width, height), n, choices2, majorDim, style,
 {
     wxString *choices2 = new wxString[n];
     for ( int i = 0; i < n; i ++) choices2[i] = choices[i];
     Create(parent, -1, title, wxPoint(x, y), wxSize(width, height), n, choices2, majorDim, style,

-        wxDefaultValidator, name);
+            wxDefaultValidator, name);

     Callback(func);
     delete choices2;
 }
 
     Callback(func);
     delete choices2;
 }
 

-#endif
+#endif // WXWIN_COMPATIBILITY

 
 // Radio box item
 
 // Radio box item

-wxRadioBox::wxRadioBox(void)
-{
-  m_selectedButton = -1;
-  m_noItems = 0;
-  m_noRowsOrCols = 0;
-  m_radioButtons = NULL;
-  m_majorDim = 0 ;
-  m_radioWidth = NULL ;
-  m_radioHeight = NULL ;
-}
-
-bool wxRadioBox::Create(wxWindow *parent, wxWindowID id, const wxString& title,
-             const wxPoint& pos, const wxSize& size,
-             int n, const wxString choices[],
-             int majorDim, long style,
-             const wxValidator& val, const wxString& name)
-{
-  m_selectedButton = -1;
-  m_noItems = n;
-
-  SetName(name);
-  SetValidator(val);
-
-  parent->AddChild(this);
-  m_backgroundColour = parent->GetBackgroundColour() ;
-  m_foregroundColour = parent->GetForegroundColour() ;
-
-  m_windowStyle = (long&)style;
-
-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
-
-  if (id == -1)
-    m_windowId = NewControlId();
-  else
-    m_windowId = id;
-
-  m_noRowsOrCols = majorDim;
-  if (majorDim==0)
-    m_majorDim = n ;
-  else // Seemed to make sense to put this 'else' here...  (RD)
-    m_majorDim = majorDim ;
-
-  long msStyle = GROUP_FLAGS;
-
-  bool want3D;
-  WXDWORD exStyle = Determine3DEffects(0, &want3D) ;
-  // Even with extended styles, need to combine with WS_BORDER
-  // for them to look right.
-/*
-  if ( want3D || wxStyleHasBorder(m_windowStyle) )
-    msStyle |= WS_BORDER;
-*/
-
-
-  HWND the_handle = (HWND) parent->GetHWND() ;
-
-  m_hWnd = (WXHWND)::CreateWindowEx
-                     (
-                      (DWORD)exStyle,
-                      GROUP_CLASS,
-                      title,
-                      msStyle,
-                      0, 0, 0, 0,
-                      the_handle,
-                      (HMENU)m_windowId,
-                      wxGetInstance(),
-                      NULL
-                     );
-
-#if CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl((HWND)m_hWnd);
-    m_useCtl3D = TRUE;
-  }
-#endif
-
-  SetFont(* parent->GetFont());
-
-  SubclassWin((WXHWND)m_hWnd);
-
-  // Some radio boxes test consecutive id.
-  (void)NewControlId() ;
-  m_radioButtons = new WXHWND[n];
-  m_radioWidth = new int[n] ;
-  m_radioHeight = new int[n] ;
-  int i;
-  for (i = 0; i < n; i++)
-  {
-    m_radioWidth[i] = m_radioHeight[i] = -1 ;
-    long groupStyle = 0;
-    if (i == 0 && style==0)
-      groupStyle = WS_GROUP;
-    long newId = NewControlId();
-    long msStyle = groupStyle | RADIO_FLAGS;
-
-    m_radioButtons[i] = (WXHWND) CreateWindowEx(exStyle, RADIO_CLASS, choices[i],
-                          msStyle,0,0,0,0,
-                          the_handle, (HMENU)newId, wxGetInstance(), NULL);
-#if CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl((HWND) m_hWnd);
-   m_useCtl3D = TRUE;
-  }
-#endif
-    if (GetFont())
-    {
-       SendMessage((HWND)m_radioButtons[i],WM_SETFONT,
-                    (WPARAM)GetFont()->GetResourceHandle(),0L);
-    }
-    m_subControls.Append((wxObject *)newId);
-  }
-
-  // Create a dummy radio control to end the group.
-  (void)CreateWindowEx(0, RADIO_CLASS, "", WS_GROUP|RADIO_FLAGS, 0,0,0,0, the_handle, (HMENU)NewControlId(), wxGetInstance(), NULL);
-
-  SetSelection(0);
-
-  SetSize(x, y, width, height);
-
-  return TRUE;
+wxRadioBox::wxRadioBox()
+{
+    m_selectedButton = -1;
+    m_noItems = 0;
+    m_noRowsOrCols = 0;
+    m_radioButtons = NULL;
+    m_majorDim = 0;
+    m_radioWidth = NULL;
+    m_radioHeight = NULL;

 }
 
 }
 

-#if 0
-bool wxRadioBox::Create(wxWindow *parent, wxWindowID id, const wxString& title,
-             const wxPoint& pos, const wxSize& size,
-             int n, const wxBitmap *choices[],
-             int majorDim, long style,
-             const wxValidator& val, const wxString& name)
+bool wxRadioBox::Create(wxWindow *parent,
+                        wxWindowID id,
+                        const wxString& title,
+                        const wxPoint& pos,
+                        const wxSize& size,
+                        int n,
+                        const wxString choices[],
+                        int majorDim,
+                        long style,
+                        const wxValidator& val,
+                        const wxString& name)

 {
 {

-  m_selectedButton = -1;
-  m_noRowsOrCols = 0;
-  m_noItems = n;
-
-  SetName(name);
-  SetValidator(val);
+    // initialize members
+    m_selectedButton = -1;
+    m_noItems = 0;
+
+    m_majorDim = majorDim == 0 ? n : majorDim;
+    m_noRowsOrCols = majorDim;
+
+    // common initialization
+    if ( !CreateControl(parent, id, pos, size, style, val, name) )
+        return FALSE;
+
+    // create the static box
+    if ( !MSWCreateControl(wxT("BUTTON"), BS_GROUPBOX | WS_GROUP,
+                           pos, size, title, 0) )
+        return FALSE;
+
+    // and now create the buttons
+    m_noItems = n;
+#if RADIOBTN_PARENT_IS_RADIOBOX
+    HWND hwndParent = GetHwnd();
+#else
+    HWND hwndParent = GetHwndOf(parent);
+#endif

 
 

-  parent->AddChild(this);
-  m_backgroundColour = parent->GetBackgroundColour() ;
-  m_foregroundColour = parent->GetForegroundColour() ;
+    // Some radio boxes test consecutive id.
+    (void)NewControlId();
+    m_radioButtons = new WXHWND[n];
+    m_radioWidth = new int[n];
+    m_radioHeight = new int[n];

 
 

-  m_windowStyle = (long&)style;
+    WXHFONT hfont = 0;
+    wxFont& font = GetFont();
+    if ( font.Ok() )
+    {
+        hfont = font.GetResourceHandle();
+    }

 
 

-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
+    for ( int i = 0; i < n; i++ )
+    {
+        m_radioWidth[i] =
+        m_radioHeight[i] = -1;
+        long styleBtn = BS_AUTORADIOBUTTON | WS_TABSTOP | WS_CHILD | WS_VISIBLE;
+        if ( i == 0 && style == 0 )
+            styleBtn |= WS_GROUP;

 
 

-  if (id == -1)
-    m_windowId = NewControlId();
-  else
-    m_windowId = id;
+        long newId = NewControlId();

 
 

+        HWND hwndBtn = ::CreateWindow(_T("BUTTON"),
+                                      choices[i],
+                                      styleBtn,
+                                      0, 0, 0, 0,   // will be set in SetSize()
+                                      hwndParent,
+                                      (HMENU)newId,
+                                      wxGetInstance(),
+                                      NULL);

 
 

-  m_noRowsOrCols = majorDim;
-  if (majorDim==0)
-    m_majorDim = n ;
-  m_majorDim = majorDim ;
-  HWND the_handle ;
+        if ( !hwndBtn )
+        {
+            wxLogLastError(wxT("CreateWindow(radio btn)"));

 
 

-  long msStyle = GROUP_FLAGS;
+            return FALSE;
+        }

 
 

-  bool want3D;
-  WXDWORD exStyle = Determine3DEffects(0, &want3D) ;
-  // Even with extended styles, need to combine with WS_BORDER
-  // for them to look right.
-  if ( want3D || wxStyleHasBorder(m_windowStyle) )
-    msStyle |= WS_BORDER;
+        m_radioButtons[i] = (WXHWND)hwndBtn;

 
 

-  m_hWnd = (WXHWND) CreateWindowEx((DWORD) exStyle, GROUP_CLASS, (title == "" ? NULL : (const char *)title),
-                           msStyle,
-                           0,0,0,0,
-                           (HWND) parent->GetHWND(), (HMENU) m_windowId, wxGetInstance(), NULL) ;
+        SubclassRadioButton((WXHWND)hwndBtn);

 
 

-  the_handle = (HWND) parent->GetHWND();
+        if ( hfont )
+        {
+            ::SendMessage(hwndBtn, WM_SETFONT, (WPARAM)hfont, 0L);
+        }

 
 

-#if CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl((HWND) m_hWnd);
-   m_useCtl3D = TRUE;
-  }
-#endif
+        m_subControls.Add(newId);
+    }

 
 

-  SetFont(* parent->GetFont());
-
-  // Subclass again for purposes of dialog editing mode
-  SubclassWin((WXHWND)m_hWnd);
-
-  (void)NewControlId() ;
-  m_radioButtons = new WXHWND[n];
-  m_radioWidth = new int[n] ;
-  m_radioHeight = new int[n] ;
-
-  int i;
-  for (i = 0; i < n; i++)
-  {
-    long groupStyle = 0;
-    if (i == 0 && style==0)
-      groupStyle = WS_GROUP;
-    long newId = NewControlId();
-    m_radioWidth[i]  = ((wxBitmap *)choices[i])->GetWidth();
-    m_radioHeight[i] = ((wxBitmap *)choices[i])->GetHeight();
-    char tmp[32] ;
-    sprintf(tmp,"Toggle%d",i) ;
-    long msStyle = groupStyle | RADIO_FLAGS;
-    m_radioButtons[i] = (WXHWND) CreateWindowEx(exStyle, RADIO_CLASS, tmp,
-                          msStyle,0,0,0,0,
-                          the_handle, (HMENU)newId, wxhInstance, NULL);
-#if CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl((HWND) m_hWnd);
-   m_useCtl3D = TRUE;
-  }
-#endif
-    m_subControls.Append((wxObject *)newId);
-  }
-  // Create a dummy radio control to end the group.
-  (void)CreateWindowEx(0, RADIO_CLASS, "", WS_GROUP|RADIO_FLAGS, 0,0,0,0, the_handle, (HMENU)NewControlId(), wxGetInstance(), NULL);
+    // Create a dummy radio control to end the group.
+    (void)::CreateWindow(_T("BUTTON"),
+                         _T(""),
+                         WS_GROUP | BS_AUTORADIOBUTTON | WS_CHILD,
+                         0, 0, 0, 0, hwndParent,
+                         (HMENU)NewControlId(), wxGetInstance(), NULL);

 
 

-  SetSelection(0);
+    SetSelection(0);

 
 

-  SetSize(x, y, width, height);
+    SetSize(pos.x, pos.y, size.x, size.y);

 
 

-  return TRUE;
+    return TRUE;

 }
 }

-#endif

 
 

-wxRadioBox::~wxRadioBox(void)
+wxRadioBox::~wxRadioBox()

 {
 {

-  m_isBeingDeleted = TRUE;
+    m_isBeingDeleted = TRUE;

 
 

-  if (m_radioButtons)
-  {
-    int i;
-    for (i = 0; i < m_noItems; i++)
-      DestroyWindow((HWND) m_radioButtons[i]);
-    delete[] m_radioButtons;
-  }
-  if (m_radioWidth)
-    delete[] m_radioWidth ;
-  if (m_radioHeight)
-    delete[] m_radioHeight ;
-  if (m_hWnd)
-    ::DestroyWindow((HWND) m_hWnd) ;
-  m_hWnd = 0 ;
+    if (m_radioButtons)
+    {
+        int i;
+        for (i = 0; i < m_noItems; i++)
+            ::DestroyWindow((HWND)m_radioButtons[i]);
+        delete[] m_radioButtons;
+    }
+
+    if (m_radioWidth)
+        delete[] m_radioWidth;
+    if (m_radioHeight)
+        delete[] m_radioHeight;

 
 }
 
 wxString wxRadioBox::GetLabel(int item) const
 {
 
 }
 
 wxString wxRadioBox::GetLabel(int item) const
 {

-  GetWindowText((HWND)m_radioButtons[item], wxBuffer, 300);
-  return wxString(wxBuffer);
+    wxCHECK_MSG( item >= 0 && item < m_noItems, wxT(""), wxT("invalid radiobox index") );
+
+    return wxGetWindowText(m_radioButtons[item]);

 }
 
 void wxRadioBox::SetLabel(int item, const wxString& label)
 {
 }
 
 void wxRadioBox::SetLabel(int item, const wxString& label)
 {

-  m_radioWidth[item] = m_radioHeight[item] = -1 ;
-  SetWindowText((HWND)m_radioButtons[item], (const char *)label);
+    wxCHECK_RET( item >= 0 && item < m_noItems, wxT("invalid radiobox index") );
+
+    m_radioWidth[item] = m_radioHeight[item] = -1;
+    SetWindowText((HWND)m_radioButtons[item], label.c_str());

 }
 
 }
 

-void wxRadioBox::SetLabel(int item, wxBitmap *bitmap)
+void wxRadioBox::SetLabel(int WXUNUSED(item), wxBitmap *WXUNUSED(bitmap))

 {
 {

-/*
-    m_radioWidth[item] = bitmap->GetWidth() + FB_MARGIN ;
-    m_radioHeight[item] = bitmap->GetHeight() + FB_MARGIN ;
-*/
+    /*
+       m_radioWidth[item] = bitmap->GetWidth() + FB_MARGIN;
+       m_radioHeight[item] = bitmap->GetHeight() + FB_MARGIN;
+     */
+    wxFAIL_MSG(wxT("not implemented"));

 }
 
 int wxRadioBox::FindString(const wxString& s) const
 {
 }
 
 int wxRadioBox::FindString(const wxString& s) const
 {

- int i;
- for (i = 0; i < m_noItems; i++)
- {
-  GetWindowText((HWND) m_radioButtons[i], wxBuffer, 1000);
-  if (s == wxBuffer)
-    return i;
- }
- return -1;
+    for (int i = 0; i < m_noItems; i++)
+    {
+        if ( s == wxGetWindowText(m_radioButtons[i]) )
+            return i;
+    }
+
+    return wxNOT_FOUND;

 }
 
 void wxRadioBox::SetSelection(int N)
 {
 }
 
 void wxRadioBox::SetSelection(int N)
 {

-  if ((N < 0) || (N >= m_noItems))
-    return;
+    wxCHECK_RET( (N >= 0) && (N < m_noItems), wxT("invalid radiobox index") );
+
+    // Following necessary for Win32s, because Win32s translate BM_SETCHECK
+    if (m_selectedButton >= 0 && m_selectedButton < m_noItems)
+        ::SendMessage((HWND) m_radioButtons[m_selectedButton], BM_SETCHECK, 0, 0L);

 
 

-// Following necessary for Win32s, because Win32s translate BM_SETCHECK
-  if (m_selectedButton >= 0 && m_selectedButton < m_noItems)
-    SendMessage((HWND) m_radioButtons[m_selectedButton], BM_SETCHECK, 0, 0L);
+    ::SendMessage((HWND)m_radioButtons[N], BM_SETCHECK, 1, 0L);
+    ::SetFocus((HWND)m_radioButtons[N]);

 
 

-  SendMessage((HWND) m_radioButtons[N], BM_SETCHECK, 1, 0L);
-  m_selectedButton = N;
+    m_selectedButton = N;

 }
 
 // Get single selection, for single choice list items
 }
 
 // Get single selection, for single choice list items

-int wxRadioBox::GetSelection(void) const
+int wxRadioBox::GetSelection() const

 {
 {

-  return m_selectedButton;
+    return m_selectedButton;

 }
 
 // Find string for position
 wxString wxRadioBox::GetString(int N) const
 {
 }
 
 // Find string for position
 wxString wxRadioBox::GetString(int N) const
 {

-  GetWindowText((HWND) m_radioButtons[N], wxBuffer, 1000);
-  return wxString(wxBuffer);
+    return wxGetWindowText(m_radioButtons[N]);

 }
 
 }
 

-void wxRadioBox::SetSize(int x, int y, int width, int height, int sizeFlags)
+// ----------------------------------------------------------------------------
+// size calculations
+// ----------------------------------------------------------------------------
+
+wxSize wxRadioBox::GetMaxButtonSize() const

 {
 {

-  int currentX, currentY;
-  GetPosition(&currentX, &currentY);
-  int xx = x;
-  int yy = y;
+    // calculate the max button size
+    int widthMax = 0,
+        heightMax = 0;
+    for ( int i = 0 ; i < m_noItems; i++ )
+    {
+        int width, height;
+        if ( m_radioWidth[i] < 0 )
+        {
+            GetTextExtent(wxGetWindowText(m_radioButtons[i]), &width, &height);
+
+            // adjust the size to take into account the radio box itself
+            // FIXME this is totally bogus!
+            width += RADIO_SIZE;
+            height *= 3;
+            height /= 2;
+        }
+        else
+        {
+            width = m_radioWidth[i];
+            height = m_radioHeight[i];
+        }
+
+        if ( widthMax < width )
+            widthMax = width;
+        if ( heightMax < height )
+            heightMax = height;
+    }
+
+    return wxSize(widthMax, heightMax);
+}

 
 

-  if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    xx = currentX;
-  if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    yy = currentY;
+wxSize wxRadioBox::GetTotalButtonSize(const wxSize& sizeBtn) const
+{
+    // the radiobox should be big enough for its buttons
+    int cx1, cy1;
+    wxGetCharSize(m_hWnd, &cx1, &cy1, &GetFont());

 
 

-  AdjustForParentClientOrigin(xx, yy, sizeFlags);
+    int extraHeight = cy1;

 
 

-  char buf[400];
+#if defined(CTL3D) && !CTL3D
+    // Requires a bigger group box in plain Windows
+    extraHeight *= 3;
+    extraHeight /= 2;
+#endif

 
 

-  int y_offset = yy;
-  int x_offset = xx;
-  int current_width, cyf;
+    int height = GetNumVer() * sizeBtn.y + cy1/2 + extraHeight;
+    int width  = GetNumHor() * (sizeBtn.x + cx1) + cx1;

 
 

-  int cx1,cy1 ;
-  wxGetCharSize(m_hWnd, &cx1, &cy1, GetFont());
-  // Attempt to have a look coherent with other platforms:
-  // We compute the biggest toggle dim, then we align all
-  // items according this value.
-  int maxWidth =  -1;
-  int maxHeight = -1 ;
+    // and also wide enough for its label
+    int widthLabel;
+    GetTextExtent(GetTitle(), &widthLabel, NULL);
+    widthLabel += RADIO_SIZE; // FIXME this is bogus too
+    if ( widthLabel > width )
+        width = widthLabel;

 
 

-  int i;
-  for (i = 0 ; i < m_noItems; i++)
-  {
-    int eachWidth;
-    int eachHeight ;
-    if (m_radioWidth[i]<0)
-    {
-      // It's a labelled toggle
-      GetWindowText((HWND) m_radioButtons[i], buf, 300);
-      GetTextExtent(buf, &current_width, &cyf,NULL,NULL, GetFont());
-      eachWidth = (int)(current_width + RADIO_SIZE);
-      eachHeight = (int)((3*cyf)/2);
-    }
-    else
-    {
-      eachWidth = m_radioWidth[i] ;
-      eachHeight = m_radioHeight[i] ;
-    }
-    if (maxWidth<eachWidth) maxWidth = eachWidth ;
-    if (maxHeight<eachHeight) maxHeight = eachHeight ;
-  }
+    return wxSize(width, height);
+}
+
+wxSize wxRadioBox::DoGetBestSize() const
+{
+    return GetTotalButtonSize(GetMaxButtonSize());
+}
+
+// Restored old code.
+void wxRadioBox::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+{
+    int currentX, currentY;
+    GetPosition(&currentX, &currentY);
+    int widthOld, heightOld;
+    GetSize(&widthOld, &heightOld);
+
+    int xx = x;
+    int yy = y;
+
+    if (x == -1 && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
+        xx = currentX;
+    if (y == -1 && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
+        yy = currentY;
+
+#if RADIOBTN_PARENT_IS_RADIOBOX
+    int y_offset = 0;
+    int x_offset = 0;
+#else
+    int y_offset = yy;
+    int x_offset = xx;
+#endif
+
+    int cx1, cy1;
+    wxGetCharSize(m_hWnd, &cx1, &cy1, & GetFont());

 
 

-  if (m_hWnd)
-  {
-    int totWidth ;
-    int totHeight;
+    // Attempt to have a look coherent with other platforms: We compute the
+    // biggest toggle dim, then we align all items according this value.
+    wxSize maxSize = GetMaxButtonSize();
+    int maxWidth = maxSize.x,
+        maxHeight = maxSize.y;

 
 

-    int nbHor,nbVer;
+    wxSize totSize = GetTotalButtonSize(maxSize);
+    int totWidth = totSize.x,
+        totHeight = totSize.y;

 
 

-    if (m_windowStyle & wxRA_VERTICAL)
+    // only change our width/height if asked for
+    if ( width == -1 )

     {
     {

-      nbVer = m_majorDim ;
-      nbHor = (m_noItems+m_majorDim-1)/m_majorDim ;
+        if ( sizeFlags & wxSIZE_AUTO_WIDTH )
+            width = totWidth;
+        else
+            width = widthOld;

     }
     }

-    else
+
+    if ( height == -1 )

     {
     {

-      nbHor = m_majorDim ;
-      nbVer = (m_noItems+m_majorDim-1)/m_majorDim ;
+        if ( sizeFlags & wxSIZE_AUTO_HEIGHT )
+            height = totHeight;
+        else
+            height = heightOld;

     }
 
     }
 

-    // this formula works, but I don't know why.
-    // Please, be sure what you do if you modify it!!
-    if (m_radioWidth[0]<0)
-      totHeight = (nbVer * maxHeight) + cy1/2 ;
-    else
-      totHeight = nbVer * (maxHeight+cy1/2) ;
-    totWidth  = nbHor * (maxWidth+cx1) ;
+    ::MoveWindow(GetHwnd(), xx, yy, width, height, TRUE);
+
+    // Now position all the buttons: the current button will be put at
+    // wxPoint(x_offset, y_offset) and the new row/column will start at
+    // startX/startY. The size of all buttons will be the same wxSize(maxWidth,
+    // maxHeight) except for the buttons in the last column which should extend
+    // to the right border of radiobox and thus can be wider than this.
+
+    // Also, remember that wxRA_SPECIFY_COLS means that we arrange buttons in
+    // left to right order and m_majorDim is the number of columns while
+    // wxRA_SPECIFY_ROWS means that the buttons are arranged top to bottom and
+    // m_majorDim is the number of rows.

 
 

-#if (!CTL3D)
-    // Requires a bigger group box in plain Windows
-    MoveWindow((HWND) m_hWnd,x_offset,y_offset,totWidth+cx1,totHeight+(3*cy1)/2,TRUE) ;
-#else
-    MoveWindow((HWND) m_hWnd,x_offset,y_offset,totWidth+cx1,totHeight+cy1,TRUE) ;
-#endif

     x_offset += cx1;
     y_offset += cy1;
     x_offset += cx1;
     y_offset += cy1;

-  }

 
 

-#if (!CTL3D)
-  y_offset += (int)(cy1/2); // Fudge factor since buttons overlapped label
-                            // JACS 2/12/93. CTL3D draws group label quite high.
+#if defined(CTL3D) && (!CTL3D)
+    y_offset += (int)(cy1/2); // Fudge factor since buttons overlapped label
+    // JACS 2/12/93. CTL3D draws group label quite high.

 #endif
 #endif

-  int startX = x_offset ;
-  int startY = y_offset ;

 
 

-  for ( i = 0 ; i < m_noItems; i++)
-  {
-    // Bidimensional radio adjustment
-    if (i&&((i%m_majorDim)==0)) // Why is this omitted for i = 0?
-    {
-      if (m_windowStyle & wxRA_VERTICAL)
-      {
-        y_offset = startY;
-        x_offset += maxWidth + cx1 ;
-      }
-      else
-      {
-        x_offset = startX ;
-        y_offset += maxHeight ;
-        if (m_radioWidth[0]>0)
-          y_offset += cy1/2 ;
-      }
-    }
-    int eachWidth ;
-    int eachHeight ;
-    if (m_radioWidth[i]<0)
-    {
-      // It's a labeled item
-      GetWindowText((HWND) m_radioButtons[i], buf, 300);
-      GetTextExtent(buf, &current_width, &cyf,NULL,NULL,GetFont());
-
-      // How do we find out radio button bitmap size!!
-      // By adjusting them carefully, manually :-)
-      eachWidth = (int)(current_width + RADIO_SIZE);
-      eachHeight = (int)((3*cyf)/2);
-    }
-    else
-    {
-      eachWidth = m_radioWidth[i] ;
-      eachHeight = m_radioHeight[i] ;
-    }
+    int startX = x_offset;
+    int startY = y_offset;

 
 

-    MoveWindow((HWND) m_radioButtons[i],x_offset,y_offset,eachWidth,eachHeight,TRUE);
-    if (m_windowStyle & wxRA_VERTICAL)
+    for ( int i = 0; i < m_noItems; i++ )

     {
     {

-      y_offset += maxHeight;
-      if (m_radioWidth[0]>0)
-        y_offset += cy1/2 ;
+        // the last button in the row may be wider than the other ones as the
+        // radiobox may be wider than the sum of the button widths (as it
+        // happens, for example, when the radiobox label is very long)
+        bool isLastInTheRow;
+        if ( m_windowStyle & wxRA_SPECIFY_COLS )
+        {
+            // item is the last in its row if it is a multiple of the number of
+            // columns or if it is just the last item
+            int n = i + 1;
+            isLastInTheRow = ((n % m_majorDim) == 0) || (n == m_noItems);
+        }
+        else // wxRA_SPECIFY_ROWS
+        {
+            // item is the last in the row if it is in the last columns
+            isLastInTheRow = i >= (m_noItems/m_majorDim)*m_majorDim;
+        }
+
+        // is this the start of new row/column?
+        if ( i && (i % m_majorDim == 0) )
+        {
+            if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+            {
+                // start of new column
+                y_offset = startY;
+                x_offset += maxWidth + cx1;
+            }
+            else // start of new row
+            {
+                x_offset = startX;
+                y_offset += maxHeight;
+                if (m_radioWidth[0]>0)
+                    y_offset += cy1/2;
+            }
+        }
+
+        int widthBtn;
+        if ( isLastInTheRow )
+        {
+            // make the button go to the end of radio box
+            widthBtn = startX + width - x_offset - 2*cx1;
+            if ( widthBtn < maxWidth )
+                widthBtn = maxWidth;
+        }
+        else
+        {
+            // normal button, always of the same size
+            widthBtn = maxWidth;
+        }
+
+        // VZ: make all buttons of the same, maximal size - like this they
+        //     cover the radiobox entirely and the radiobox tooltips are always
+        //     shown (otherwise they are not when the mouse pointer is in the
+        //     radiobox part not belonging to any radiobutton)
+        ::MoveWindow((HWND)m_radioButtons[i],
+                     x_offset, y_offset, widthBtn, maxHeight,
+                     TRUE);
+
+        // where do we put the next button?
+        if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+        {
+            // below this one
+            y_offset += maxHeight;
+            if (m_radioWidth[0]>0)
+                y_offset += cy1/2;
+        }
+        else
+        {
+            // to the right of this one
+            x_offset += widthBtn + cx1;
+        }

     }
     }

-    else
-      x_offset += maxWidth + cx1;
-  }

 }
 
 void wxRadioBox::GetSize(int *width, int *height) const
 {
 }
 
 void wxRadioBox::GetSize(int *width, int *height) const
 {

-  RECT rect;
-  rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
+    RECT rect;
+    rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;

 
 

-  if (m_hWnd)
-    wxFindMaxSize(m_hWnd, &rect);
+    if (m_hWnd)
+        wxFindMaxSize(m_hWnd, &rect);

 
 

-  int i;
-  for (i = 0; i < m_noItems; i++)
-    wxFindMaxSize(m_radioButtons[i], &rect);
+    int i;
+    for (i = 0; i < m_noItems; i++)
+        wxFindMaxSize(m_radioButtons[i], &rect);

 
 

-  *width = rect.right - rect.left;
-  *height = rect.bottom - rect.top;
+    *width = rect.right - rect.left;
+    *height = rect.bottom - rect.top;

 }
 
 void wxRadioBox::GetPosition(int *x, int *y) const
 {
 }
 
 void wxRadioBox::GetPosition(int *x, int *y) const
 {

-  wxWindow *parent = GetParent();
-  RECT rect;
-  rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
-
-  int i;
-  for (i = 0; i < m_noItems; i++)
-    wxFindMaxSize(m_radioButtons[i], &rect);
+    wxWindow *parent = GetParent();
+    RECT rect = { -1, -1, -1, -1 };

 
 

-  if (m_hWnd)
-    wxFindMaxSize(m_hWnd, &rect);
+    int i;
+    for (i = 0; i < m_noItems; i++)
+        wxFindMaxSize(m_radioButtons[i], &rect);

 
 

-  // Since we now have the absolute screen coords,
-  // if there's a parent we must subtract its top left corner
-  POINT point;
-  point.x = rect.left;
-  point.y = rect.top;
-  if (parent)
-  {
-    ::ScreenToClient((HWND) parent->GetHWND(), &point);
-  }
-  // We may be faking the client origin.
-  // So a window that's really at (0, 30) may appear
-  // (to wxWin apps) to be at (0, 0).
-  if (GetParent())
-  {
-    wxPoint pt(GetParent()->GetClientAreaOrigin());
-    point.x -= pt.x;
-    point.y -= pt.y;
-  }
+    if (m_hWnd)
+        wxFindMaxSize(m_hWnd, &rect);

 
 

-  *x = point.x;
-  *y = point.y;
-}
+    // Since we now have the absolute screen coords, if there's a parent we
+    // must subtract its top left corner
+    POINT point;
+    point.x = rect.left;
+    point.y = rect.top;
+    if (parent)
+    {
+        ::ScreenToClient((HWND) parent->GetHWND(), &point);
+    }

 
 

-wxString wxRadioBox::GetLabel(void) const
-{
-  if (m_hWnd)
-  {
-    GetWindowText((HWND) m_hWnd, wxBuffer, 300);
-    return wxString(wxBuffer);
-  }
-  else return wxString("");
-}
+    // We may be faking the client origin. So a window that's really at (0, 30)
+    // may appear (to wxWin apps) to be at (0, 0).
+    if (GetParent())
+    {
+        wxPoint pt(GetParent()->GetClientAreaOrigin());
+        point.x -= pt.x;
+        point.y -= pt.y;
+    }

 
 

-void wxRadioBox::SetLabel(const wxString& label)
-{
-  if (m_hWnd && label)
-    SetWindowText((HWND) m_hWnd, label);
+    *x = point.x;
+    *y = point.y;

 }
 
 }
 

-void wxRadioBox::SetFocus(void)
+void wxRadioBox::SetFocus()

 {
 {

-  if (m_noItems > 0)
-  {
-    if (m_selectedButton == -1)
-      ::SetFocus((HWND) m_radioButtons[0]);
-    else
-      ::SetFocus((HWND) m_radioButtons[m_selectedButton]);
-  }
+    if (m_noItems > 0)
+    {
+        if (m_selectedButton == -1)
+            ::SetFocus((HWND) m_radioButtons[0]);
+        else
+            ::SetFocus((HWND) m_radioButtons[m_selectedButton]);
+    }

 
 }
 
 bool wxRadioBox::Show(bool show)
 {
 
 }
 
 bool wxRadioBox::Show(bool show)
 {

-  int cshow;
-  if (show)
-    cshow = SW_SHOW;
-  else
-    cshow = SW_HIDE;
-  if (m_hWnd)
-    ShowWindow((HWND) m_hWnd, cshow);
-  int i;
-  for (i = 0; i < m_noItems; i++)
-    ShowWindow((HWND) m_radioButtons[i], cshow);
-  return TRUE;
+    if ( !wxControl::Show(show) )
+        return FALSE;
+
+    int nCmdShow = show ? SW_SHOW : SW_HIDE;
+    for ( int i = 0; i < m_noItems; i++ )
+    {
+        ::ShowWindow((HWND)m_radioButtons[i], nCmdShow);
+    }
+
+    return TRUE;

 }
 
 // Enable a specific button
 void wxRadioBox::Enable(int item, bool enable)
 {
 }
 
 // Enable a specific button
 void wxRadioBox::Enable(int item, bool enable)
 {

-  if (item<0)
-    wxWindow::Enable(enable) ;
-  else if (item < m_noItems)
+    wxCHECK_RET( item >= 0 && item < m_noItems,
+                 wxT("invalid item in wxRadioBox::Enable()") );
+

     ::EnableWindow((HWND) m_radioButtons[item], enable);
 }
 
 // Enable all controls
     ::EnableWindow((HWND) m_radioButtons[item], enable);
 }
 
 // Enable all controls

-void wxRadioBox::Enable(bool enable)
+bool wxRadioBox::Enable(bool enable)

 {
 {

-  wxControl::Enable(enable);
+    if ( !wxControl::Enable(enable) )
+        return FALSE;

 
 

-  int i;
-  for (i = 0; i < m_noItems; i++)
-    ::EnableWindow((HWND) m_radioButtons[i], enable);
+    for (int i = 0; i < m_noItems; i++)
+        ::EnableWindow((HWND) m_radioButtons[i], enable);
+
+    return TRUE;

 }
 
 // Show a specific button
 void wxRadioBox::Show(int item, bool show)
 {
 }
 
 // Show a specific button
 void wxRadioBox::Show(int item, bool show)
 {

-  if (item<0)
-    wxRadioBox::Show(show) ;
-  else if (item < m_noItems)
-  {
-    int cshow;
-    if (show)
-      cshow = SW_SHOW;
+    wxCHECK_RET( item >= 0 && item < m_noItems,
+                 wxT("invalid item in wxRadioBox::Show()") );
+
+    ::ShowWindow((HWND)m_radioButtons[item], show ? SW_SHOW : SW_HIDE);
+}
+
+// For single selection items only
+wxString wxRadioBox::GetStringSelection() const
+{
+    wxString result;
+    int sel = GetSelection();
+    if (sel > -1)
+        result = GetString(sel);
+
+    return result;
+}
+
+bool wxRadioBox::SetStringSelection(const wxString& s)
+{
+    int sel = FindString (s);
+    if (sel > -1)
+    {
+        SetSelection (sel);
+        return TRUE;
+    }

     else
     else

-      cshow = SW_HIDE;
-    ShowWindow((HWND) m_radioButtons[item], cshow);
-  }
+        return FALSE;

 }
 
 }
 

-WXHBRUSH wxRadioBox::OnCtlColor(WXHDC pDC, WXHWND pWnd, WXUINT nCtlColor,
-      WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
+bool wxRadioBox::ContainsHWND(WXHWND hWnd) const

 {
 {

-#if CTL3D
-  if ( m_useCtl3D )
-  {
-    HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);
-    return (WXHBRUSH) hbrush;
-  }
-#endif
+    int i;
+    for (i = 0; i < Number(); i++)
+    {
+        if (GetRadioButtons()[i] == hWnd)
+            return TRUE;
+    }

 
 

-  if (GetParent()->GetTransparentBackground())
-    SetBkMode((HDC) pDC, TRANSPARENT);
-  else
-    SetBkMode((HDC) pDC, OPAQUE);
+    return FALSE;
+}

 
 

-  ::SetBkColor((HDC) pDC, RGB(GetBackgroundColour().Red(), GetBackgroundColour().Green(), GetBackgroundColour().Blue()));
-  ::SetTextColor((HDC) pDC, RGB(GetForegroundColour().Red(), GetForegroundColour().Green(), GetForegroundColour().Blue()));
+void wxRadioBox::Command(wxCommandEvent & event)
+{
+    SetSelection (event.m_commandInt);
+    ProcessCommand (event);
+}
+
+// NB: if this code is changed, wxGetWindowForHWND() which relies on having the
+//     radiobox pointer in GWL_USERDATA for radio buttons must be updated too!
+void wxRadioBox::SubclassRadioButton(WXHWND hWndBtn)
+{
+    // No GWL_USERDATA in Win16, so omit this subclassing.
+#ifdef __WIN32__
+    HWND hwndBtn = (HWND)hWndBtn;

 
 

-  wxBrush *backgroundBrush = wxTheBrushList->FindOrCreateBrush(GetBackgroundColour(), wxSOLID);
+    if ( !s_wndprocRadioBtn )
+        s_wndprocRadioBtn = (WXFARPROC)::GetWindowLong(hwndBtn, GWL_WNDPROC);

 
 

-  // Note that this will be cleaned up in wxApp::OnIdle, if backgroundBrush
-  // has a zero usage count.
-//  backgroundBrush->RealizeResource();
-  return (WXHBRUSH) backgroundBrush->GetResourceHandle();
+    ::SetWindowLong(hwndBtn, GWL_WNDPROC, (long)wxRadioBtnWndProc);
+    ::SetWindowLong(hwndBtn, GWL_USERDATA, (long)this);
+#endif // __WIN32__

 }
 
 }
 

-// For single selection items only
-wxString wxRadioBox::GetStringSelection (void) const
+void wxRadioBox::SendNotificationEvent()

 {
 {

-  int sel = GetSelection ();
-  if (sel > -1)
-    return this->GetString (sel);
-  else
-    return wxString("");
+    wxCommandEvent event(wxEVT_COMMAND_RADIOBOX_SELECTED, m_windowId);
+    event.SetInt( m_selectedButton );
+    event.SetString( GetString(m_selectedButton) );
+    event.SetEventObject( this );
+    ProcessCommand(event);

 }
 
 }
 

-bool wxRadioBox::SetStringSelection (const wxString& s)
+bool wxRadioBox::SetFont(const wxFont& font)

 {
 {

-  int sel = FindString (s);
-  if (sel > -1)
+    if ( !wxControl::SetFont(font) )

     {
     {

-      SetSelection (sel);
-      return TRUE;
+        // nothing to do
+        return FALSE;

     }
     }

-  else
-    return FALSE;
+
+    // also set the font of our radio buttons
+    WXHFONT hfont = wxFont(font).GetResourceHandle();
+    for ( int n = 0; n < m_noItems; n++ )
+    {
+        HWND hwndBtn = (HWND)m_radioButtons[n];
+        ::SendMessage(hwndBtn, WM_SETFONT, (WPARAM)hfont, 0L);
+
+        // otherwise the buttons are not redrawn correctly
+        ::InvalidateRect(hwndBtn, NULL, FALSE /* don't erase bg */);
+    }
+
+    return TRUE;

 }
 
 }
 

-bool wxRadioBox::ContainsHWND(WXHWND hWnd) const
+// ----------------------------------------------------------------------------
+// our window proc
+// ----------------------------------------------------------------------------
+
+long wxRadioBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)

 {
 {

-  int i;
-    for (i = 0; i < Number(); i++)
-       if (GetRadioButtons()[i] == hWnd)
-          return TRUE;
-  return FALSE;
+    switch ( nMsg )
+    {
+#ifdef __WIN32__
+        case WM_CTLCOLORSTATIC:
+            // set the colour of the radio buttons to be the same as ours
+            {
+                HDC hdc = (HDC)wParam;
+
+                const wxColour& colBack = GetBackgroundColour();
+                ::SetBkColor(hdc, wxColourToRGB(colBack));
+                ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
+
+                wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBack, wxSOLID);
+
+                return (WXHBRUSH)brush->GetResourceHandle();
+            }
+#endif // Win32
+
+        // This is required for the radiobox to be sensitive to mouse input,
+        // e.g. for Dialog Editor.
+        case WM_NCHITTEST:
+            {
+                int xPos = LOWORD(lParam);  // horizontal position of cursor
+                int yPos = HIWORD(lParam);  // vertical position of cursor
+
+                ScreenToClient(&xPos, &yPos);
+
+                // Make sure you can drag by the top of the groupbox, but let
+                // other (enclosed) controls get mouse events also
+                if (yPos < 10)
+                    return (long)HTCLIENT;
+            }
+            break;
+    }
+
+    return wxControl::MSWWindowProc(nMsg, wParam, lParam);

 }
 
 }
 

-void wxRadioBox::Command (wxCommandEvent & event)
+WXHBRUSH wxRadioBox::OnCtlColor(WXHDC pDC, WXHWND WXUNUSED(pWnd), WXUINT WXUNUSED(nCtlColor),
+                               WXUINT WXUNUSED(message),
+                               WXWPARAM WXUNUSED(wParam),
+                               WXLPARAM WXUNUSED(lParam))

 {
 {

-  SetSelection (event.m_commandInt);
-  ProcessCommand (event);
+#if wxUSE_CTL3D
+    if ( m_useCtl3D )
+    {
+        HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);
+        return (WXHBRUSH) hbrush;
+    }
+#endif // wxUSE_CTL3D
+
+    HDC hdc = (HDC)pDC;
+    if (GetParent()->GetTransparentBackground())
+        SetBkMode(hdc, TRANSPARENT);
+    else
+        SetBkMode(hdc, OPAQUE);
+
+    wxColour colBack = GetBackgroundColour();
+
+    if (!IsEnabled())
+        colBack = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+
+    ::SetBkColor(hdc, wxColourToRGB(colBack));
+    ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
+
+    wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBack, wxSOLID);
+
+    return (WXHBRUSH)brush->GetResourceHandle();

 }
 
 }
 

-long wxRadioBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
+
+// ---------------------------------------------------------------------------
+// window proc for radio buttons
+// ---------------------------------------------------------------------------
+
+#ifdef __WIN32__
+
+LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hwnd,
+                                           UINT message,
+                                           WPARAM wParam,
+                                           LPARAM lParam)

 {
 {

-  if (nMsg == WM_NCHITTEST)
+    switch ( message )

     {
     {

-        int xPos = LOWORD(lParam);  // horizontal position of cursor
-        int yPos = HIWORD(lParam);  // vertical position of cursor
-
-        ScreenToClient(&xPos, &yPos);
+        case WM_GETDLGCODE:
+            // we must tell IsDialogMessage()/our kbd processing code that we
+            // want to process arrows ourselves because neither of them is
+            // smart enough to handle arrows properly for us
+            {
+                long lDlgCode = ::CallWindowProc(CASTWNDPROC s_wndprocRadioBtn, hwnd,
+                                                 message, wParam, lParam);
+
+                return lDlgCode | DLGC_WANTARROWS;
+            }
+
+#if wxUSE_TOOLTIPS
+        case WM_NOTIFY:
+            {
+                NMHDR* hdr = (NMHDR *)lParam;
+                if ( (int)hdr->code == TTN_NEEDTEXT )
+                {
+                    wxRadioBox *radiobox = (wxRadioBox *)
+                        ::GetWindowLong(hwnd, GWL_USERDATA);
+
+                    wxCHECK_MSG( radiobox, 0,
+                                 wxT("radio button without radio box?") );
+
+                    wxToolTip *tooltip = radiobox->GetToolTip();
+                    if ( tooltip )
+                    {
+                        TOOLTIPTEXT *ttt = (TOOLTIPTEXT *)lParam;
+                        ttt->lpszText = (wxChar *)tooltip->GetTip().c_str();
+                    }
+
+                    // processed
+                    return 0;
+                }
+            }
+            break;
+#endif // wxUSE_TOOLTIPS
+
+        case WM_KEYDOWN:
+            {
+                wxRadioBox *radiobox = (wxRadioBox *)
+                    ::GetWindowLong(hwnd, GWL_USERDATA);
+
+                wxCHECK_MSG( radiobox, 0, wxT("radio button without radio box?") );
+
+                bool processed = TRUE;
+
+                bool horz = (radiobox->GetWindowStyle() & wxRA_SPECIFY_COLS) != 0;
+                int num = radiobox->Number(),
+                    rows = radiobox->GetNumVer(),
+                    cols = radiobox->GetNumHor();
+
+                int selOld = radiobox->GetSelection();
+                int selNew = selOld;
+
+                // wrapping will be handled below for the cases when we
+                // add/substract more than 1 but here otherwise as it's simpler
+                switch ( wParam )
+                {
+                    case VK_UP:
+                        if ( horz )
+                            selNew -= cols;
+                        else
+                        {
+                            if ( selNew )
+                                selNew--;
+                            else
+                                selNew = num - 1;
+                        }
+                        break;
+
+                    case VK_LEFT:
+                        if ( horz )
+                        {
+                            if ( selNew )
+                                selNew--;
+                            else
+                                selNew = num - 1;
+                        }
+                        else
+                            selNew -= rows;
+                        break;
+
+                    case VK_DOWN:
+                        if ( horz )
+                            selNew += cols;
+                        else
+                        {
+                            if ( ++selNew == num )
+                                selNew = 0;
+                        }
+                        break;
+
+                    case VK_RIGHT:
+                        if ( horz )
+                        {
+                            if ( ++selNew == num )
+                                selNew = 0;
+                        }
+                        else
+                            selNew += rows;
+                        break;
+
+                    default:
+                        processed = FALSE;
+                }
+
+                if ( processed )
+                {
+                    // ensure that selNew is in range [0..num)
+                    if ( selNew >= num )
+                    {
+                        selNew -= num;
+
+                        int dim = horz ? cols : rows;
+                        selNew += dim - 1;
+                        selNew %= dim;
+                    }
+                    else if ( selNew < 0 )
+                    {
+                        selNew += num;
+
+                        int dim = horz ? cols : rows;
+                        if ( selNew % dim == 0 )
+                        {
+                            selNew -= dim - 1;
+                        }
+                        else
+                        {
+                            selNew++;
+                        }
+                    }
+
+                    if ( selNew != selOld )
+                    {
+                        radiobox->SetSelection(selNew);
+
+                        // emulate the button click
+                        radiobox->SendNotificationEvent();
+
+                        return 0;
+                    }
+                }
+            }
+            break;

 
 

-        // Make sure you can drag by the top of the groupbox, but let
-        // other (enclosed) controls get mouse events also
-        if (yPos < 10)
-            return (long)HTCLIENT;
+#ifdef __WIN32__
+        case WM_HELP:
+        {
+            wxRadioBox *radiobox = (wxRadioBox *)
+                    ::GetWindowLong(hwnd, GWL_USERDATA);
+
+            wxCHECK_MSG( radiobox, 0, wxT("radio button without radio box?") );
+
+            bool processed = TRUE;
+
+            HELPINFO* info = (HELPINFO*) lParam;
+            // Don't yet process menu help events, just windows
+            if (info->iContextType == HELPINFO_WINDOW)
+            {
+                wxWindow* subjectOfHelp = radiobox;
+                bool eventProcessed = FALSE;
+                while (subjectOfHelp && !eventProcessed)
+                {
+                    wxHelpEvent helpEvent(wxEVT_HELP, subjectOfHelp->GetId(), wxPoint(info->MousePos.x, info->MousePos.y) ) ; // info->iCtrlId);
+                    helpEvent.SetEventObject(radiobox);
+                    eventProcessed = radiobox->GetEventHandler()->ProcessEvent(helpEvent);
+
+                    // Go up the window hierarchy until the event is handled (or not)
+                    subjectOfHelp = subjectOfHelp->GetParent();
+                }
+                processed = eventProcessed;
+            }
+            else if (info->iContextType == HELPINFO_MENUITEM)
+            {
+                wxHelpEvent helpEvent(wxEVT_HELP, info->iCtrlId) ;
+                helpEvent.SetEventObject(radiobox);
+                processed = radiobox->GetEventHandler()->ProcessEvent(helpEvent);
+            }
+            else processed = FALSE;
+
+            if (processed)
+                return 0;
+
+            break;
+        }
+#endif

     }
 
     }
 

-  return wxControl::MSWWindowProc(nMsg, wParam, lParam);
+    return ::CallWindowProc(CASTWNDPROC s_wndprocRadioBtn, hwnd, message, wParam, lParam);

 }
 
 }
 

+#endif // __WIN32__
+