applied SF patch #846738 mousewheel support

[wxWidgets.git] / src / unix / gsocket.c

diff --git a/src/unix/gsocket.c b/src/unix/gsocket.c
index ad900ef994781271043ef34ed054cfbed82580c6..36a2ca622fbb5220b9df7dc3edf8852e7e137867 100644 (file)
--- a/src/unix/gsocket.c
+++ b/src/unix/gsocket.c
@@ -1,107 +1,183 @@
 /* -------------------------------------------------------------------------
  * Project: GSocket (Generic Socket) for WX
  * Name:    gsocket.c
 /* -------------------------------------------------------------------------
  * Project: GSocket (Generic Socket) for WX
  * Name:    gsocket.c

+ * Authors: Guilhem Lavaux,
+ *          Guillermo Rodriguez Garcia <guille@iies.es> (maintainer)

  * Purpose: GSocket main Unix file
  * Purpose: GSocket main Unix file

+ * Licence: The wxWindows licence

  * CVSID:   $Id$
  * -------------------------------------------------------------------------
  */
 
  * CVSID:   $Id$
  * -------------------------------------------------------------------------
  */
 

+/*
+ * PLEASE don't put C++ comments here - this is a C source file.
+ */
+
+#ifndef __GSOCKET_STANDALONE__

 #include "wx/setup.h"
 #include "wx/setup.h"

+#endif

 
 

-#if wxUSE_SOCKETS
+#if wxUSE_SOCKETS || defined(__GSOCKET_STANDALONE__)

 
 #include <assert.h>
 
 #include <assert.h>

-#include <sys/ioctl.h>

 #include <sys/types.h>
 #include <sys/types.h>

-#ifdef vms
+#include <netdb.h>
+#include <sys/ioctl.h>
+
+#ifdef __VMS__

 #include <socket.h>
 #include <socket.h>

+struct sockaddr_un
+{
+    u_char  sun_len;        /* sockaddr len including null */
+    u_char  sun_family;     /* AF_UNIX */
+    char    sun_path[108];  /* path name (gag) */
+};

 #else
 #include <sys/socket.h>
 #else
 #include <sys/socket.h>

-#endif

 #include <sys/un.h>
 #include <sys/un.h>

+#endif
+

 #include <sys/time.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <sys/time.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>

-#include <netdb.h>

 #include <errno.h>
 #include <errno.h>

-

 #include <string.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stddef.h>
 #include <ctype.h>
 #include <string.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stddef.h>
 #include <ctype.h>

-

 #ifdef sun
 #ifdef sun

-#    include <sys/filio.h>
+#  include <sys/filio.h>

 #endif
 #endif

-

 #ifdef sgi
 #ifdef sgi

-#    include <bstring.h>
+#  include <bstring.h>

 #endif
 #endif

-

 #include <signal.h>
 
 #include <signal.h>
 

-#include "wx/gsocket.h"
-#include "wx/unix/gsockunx.h"
-

 #ifndef SOCKLEN_T
 
 #ifndef SOCKLEN_T
 

-#ifdef __GLIBC__
-#      if __GLIBC__ == 2
-#         define SOCKLEN_T socklen_t
-#      endif
+#ifdef VMS
+#  define SOCKLEN_T unsigned int

 #else
 #else

-#      define SOCKLEN_T int
+#  ifdef __GLIBC__
+#    if __GLIBC__ == 2
+#      define SOCKLEN_T socklen_t
+#    endif
+#  else
+#    define SOCKLEN_T int
+#  endif
+#endif
+
+#endif /* SOCKLEN_T */
+
+/*
+ * MSW defines this, Unices don't.
+ */
+#ifndef INVALID_SOCKET
+#define INVALID_SOCKET -1
+#endif
+
+/* UnixWare reportedly needs this for FIONBIO definition */
+#ifdef __UNIXWARE__
+#include <sys/filio.h>

 #endif
 
 #endif
 

+/*
+ * INADDR_BROADCAST is identical to INADDR_NONE which is not defined
+ * on all systems. INADDR_BROADCAST should be fine to indicate an error.
+ */
+#ifndef INADDR_NONE
+#define INADDR_NONE INADDR_BROADCAST

 #endif
 
 #endif
 

-#define MASK_SIGNAL() \
-{ \
-  void (*old_handler)(int); \
-\
+#define MASK_SIGNAL()                       \
+{                                           \
+  void (*old_handler)(int);                 \
+                                            \

   old_handler = signal(SIGPIPE, SIG_IGN);
 
   old_handler = signal(SIGPIPE, SIG_IGN);
 

-#define UNMASK_SIGNAL() \
-  signal(SIGPIPE, old_handler); \
+#define UNMASK_SIGNAL()                     \
+  signal(SIGPIPE, old_handler);             \

 }
 
 }
 

-#define ENABLE_TIMEOUT(socket) \
-{ \
-  struct itimerval old_ival, new_ival; \
-  void (*old_timer_sig)(int); \
-\
-  old_timer_sig = signal(SIGALRM, SIG_DFL); \
-  siginterrupt(SIGALRM, 1); \
-  new_ival.it_value.tv_sec = socket->m_timeout / 1000; \
-  new_ival.it_value.tv_usec = (socket->m_timeout % 1000) * 1000; \
-  new_ival.it_interval.tv_sec = 0; \
-  new_ival.it_interval.tv_usec = 0; \
-  setitimer(ITIMER_REAL, &new_ival, &old_ival);
-
-#define DISABLE_TIMEOUT(socket) \
-  signal(SIGALRM, old_timer_sig); \
-  siginterrupt(SIGALRM, 0); \
-  setitimer(ITIMER_REAL, &old_ival, NULL); \
-}
+
+#ifndef __GSOCKET_STANDALONE__
+#  include "wx/unix/gsockunx.h"
+#  include "wx/gsocket.h"
+#else
+#  include "gsockunx.h"
+#  include "gsocket.h"
+#endif /* __GSOCKET_STANDALONE__ */
+
+/* debugging helpers */
+#ifdef __GSOCKET_DEBUG__
+#  define GSocket_Debug(args) printf args
+#else
+#  define GSocket_Debug(args)
+#endif /* __GSOCKET_DEBUG__ */
+
+/* Table of GUI-related functions. We must call them indirectly because
+ * of wxBase and GUI separation: */
+
+static struct GSocketGUIFunctionsTable *gs_gui_functions;
+
+#define USE_GUI() (gs_gui_functions != NULL)
+
+/* Define macros to simplify indirection: */
+#define _GSocket_GUI_Init() \
+    if (gs_gui_functions) gs_gui_functions->GUI_Init()
+#define _GSocket_GUI_Cleanup() \
+    if (gs_gui_functions) gs_gui_functions->GUI_Cleanup()
+#define _GSocket_GUI_Init_Socket(socket) \
+    (gs_gui_functions ? gs_gui_functions->GUI_Init_Socket(socket) : 1)
+#define _GSocket_GUI_Destroy_Socket(socket) \
+    if (gs_gui_functions) gs_gui_functions->GUI_Destroy_Socket(socket)
+#define _GSocket_Enable_Events(socket) \
+    if (gs_gui_functions) gs_gui_functions->Enable_Events(socket)
+#define _GSocket_Disable_Events(socket) \
+    if (gs_gui_functions) gs_gui_functions->Disable_Events(socket)
+#define _GSocket_Install_Callback(socket, event) \
+    if (gs_gui_functions) gs_gui_functions->Install_Callback(socket, event)
+#define _GSocket_Uninstall_Callback(socket, event) \
+    if (gs_gui_functions) gs_gui_functions->Uninstall_Callback(socket, event)
+
+static struct GSocketBaseFunctionsTable gs_base_functions =
+{
+    _GSocket_Detected_Read,
+    _GSocket_Detected_Write
+};

 
 /* Global initialisers */
 
 
 /* Global initialisers */
 

-bool GSocket_Init()
+void GSocket_SetGUIFunctions(struct GSocketGUIFunctionsTable *guifunc)
+{
+  gs_gui_functions = guifunc;
+}
+         
+int GSocket_Init(void)

 {
 {

-  return TRUE;
+  if (gs_gui_functions)
+  {
+      if ( !gs_gui_functions->GUI_Init() )
+        return 0;
+  }
+  return 1;

 }
 
 }
 

-void GSocket_Cleanup()
+void GSocket_Cleanup(void)

 {
 {

+  if (gs_gui_functions)
+  {
+      gs_gui_functions->GUI_Cleanup();
+  }

 }
 
 }
 

-/* Constructors / Destructors */
+/* Constructors / Destructors for GSocket */

 
 

-GSocket *GSocket_new()
+GSocket *GSocket_new(void)

 {
 {

-  int i;
+  int i, success;

   GSocket *socket;
 
   socket = (GSocket *)malloc(sizeof(GSocket));
   GSocket *socket;
 
   socket = (GSocket *)malloc(sizeof(GSocket));


@@ -109,11 +185,12 @@ GSocket *GSocket_new()
   if (socket == NULL)
     return NULL;
 
   if (socket == NULL)
     return NULL;
 

-  socket->m_fd                  = -1;
-  for (i=0;i<GSOCK_MAX_EVENT;i++) {
+  socket->m_fd                  = INVALID_SOCKET;
+  for (i=0;i<GSOCK_MAX_EVENT;i++)
+  {

     socket->m_cbacks[i]         = NULL;
     socket->m_cbacks[i]         = NULL;

-    socket->m_iocalls[i]        = FALSE;

   }
   }

+  socket->m_detected            = 0;

   socket->m_local               = NULL;
   socket->m_peer                = NULL;
   socket->m_error               = GSOCK_NOERROR;
   socket->m_local               = NULL;
   socket->m_peer                = NULL;
   socket->m_error               = GSOCK_NOERROR;


@@ -125,64 +202,102 @@ GSocket *GSocket_new()
                                 /* 10 minutes * 60 sec * 1000 millisec */
   socket->m_establishing        = FALSE;
 
                                 /* 10 minutes * 60 sec * 1000 millisec */
   socket->m_establishing        = FALSE;
 

-  /* We initialize the GUI specific entries here */
-  _GSocket_GUI_Init(socket);
+  socket->m_functions           = &gs_base_functions;
+
+  /* Per-socket GUI-specific initialization */
+  success = _GSocket_GUI_Init_Socket(socket);
+  if (!success)
+  {
+    free(socket);
+    return NULL;
+  }

 
   return socket;
 }
 
 
   return socket;
 }
 

+void GSocket_close(GSocket *socket)
+{
+    _GSocket_Disable_Events(socket);
+    close(socket->m_fd);
+    socket->m_fd = INVALID_SOCKET;
+}
+

 void GSocket_destroy(GSocket *socket)
 {
   assert(socket != NULL);
 
 void GSocket_destroy(GSocket *socket)
 {
   assert(socket != NULL);
 

-  /* First, we check that the socket is really shutdowned */
-  if (socket->m_fd != -1)
+  /* Check that the socket is really shutdowned */
+  if (socket->m_fd != INVALID_SOCKET)

     GSocket_Shutdown(socket);
 
     GSocket_Shutdown(socket);
 

-  /* We destroy GUI specific variables */
-  _GSocket_GUI_Destroy(socket);
+  /* Per-socket GUI-specific cleanup */
+  _GSocket_GUI_Destroy_Socket(socket);

 
 

-  /* We destroy private addresses */
+  /* Destroy private addresses */

   if (socket->m_local)
     GAddress_destroy(socket->m_local);
 
   if (socket->m_peer)
     GAddress_destroy(socket->m_peer);
 
   if (socket->m_local)
     GAddress_destroy(socket->m_local);
 
   if (socket->m_peer)
     GAddress_destroy(socket->m_peer);
 

-  /* We destroy socket itself */
+  /* Destroy the socket itself */

   free(socket);
 }
 
   free(socket);
 }
 

+/* GSocket_Shutdown:
+ *  Disallow further read/write operations on this socket, close
+ *  the fd and disable all callbacks.
+ */

 void GSocket_Shutdown(GSocket *socket)
 {
   int evt;
 
   assert(socket != NULL);
 
 void GSocket_Shutdown(GSocket *socket)
 {
   int evt;
 
   assert(socket != NULL);
 

-  /* If socket has been created, we shutdown it */
-  if (socket->m_fd != -1) {
+  /* If socket has been created, shutdown it */
+  if (socket->m_fd != INVALID_SOCKET)
+  {

     shutdown(socket->m_fd, 2);
     shutdown(socket->m_fd, 2);

-    close(socket->m_fd);
-    socket->m_fd = -1;
+    GSocket_close(socket);

   }
 
   }
 

-  /* We also disable GUI callbacks */
-  for (evt=0;evt<GSOCK_MAX_EVENT;evt++)
-    _GSocket_Uninstall_Callback(socket, evt);
+  /* Disable GUI callbacks */
+  for (evt = 0; evt < GSOCK_MAX_EVENT; evt++)
+    socket->m_cbacks[evt] = NULL;
+
+  socket->m_detected = GSOCK_LOST_FLAG;

 }
 
 /* Address handling */
 
 }
 
 /* Address handling */
 

+/* GSocket_SetLocal:
+ * GSocket_GetLocal:
+ * GSocket_SetPeer:
+ * GSocket_GetPeer:
+ *  Set or get the local or peer address for this socket. The 'set'
+ *  functions return GSOCK_NOERROR on success, an error code otherwise.
+ *  The 'get' functions return a pointer to a GAddress object on success,
+ *  or NULL otherwise, in which case they set the error code of the
+ *  corresponding GSocket.
+ *
+ *  Error codes:
+ *    GSOCK_INVSOCK - the socket is not valid.
+ *    GSOCK_INVADDR - the address is not valid.
+ */

 GSocketError GSocket_SetLocal(GSocket *socket, GAddress *address)
 {
   assert(socket != NULL);
 
 GSocketError GSocket_SetLocal(GSocket *socket, GAddress *address)
 {
   assert(socket != NULL);
 

-  if ((socket->m_fd != -1 && !socket->m_server)) {
+  /* the socket must be initialized, or it must be a server */
+  if ((socket->m_fd != INVALID_SOCKET && !socket->m_server))
+  {

     socket->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 
     socket->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 

-  if (address == NULL || address->m_family == GSOCK_NOFAMILY) {
+  /* check address */
+  if (address == NULL || address->m_family == GSOCK_NOFAMILY)
+  {

     socket->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
     socket->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }


@@ -199,7 +314,9 @@ GSocketError GSocket_SetPeer(GSocket *socket, GAddress *address)
 {
   assert(socket != NULL);
 
 {
   assert(socket != NULL);
 

-  if (address == NULL || address->m_family == GSOCK_NOFAMILY) {
+  /* check address */
+  if (address == NULL || address->m_family == GSOCK_NOFAMILY)
+  {

     socket->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
     socket->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }


@@ -216,34 +333,41 @@ GAddress *GSocket_GetLocal(GSocket *socket)
 {
   GAddress *address;
   struct sockaddr addr;
 {
   GAddress *address;
   struct sockaddr addr;

-  SOCKLEN_T size;
+  SOCKLEN_T size = sizeof(addr);

   GSocketError err;
 
   assert(socket != NULL);
 
   GSocketError err;
 
   assert(socket != NULL);
 

+  /* try to get it from the m_local var first */

   if (socket->m_local)
     return GAddress_copy(socket->m_local);
 
   if (socket->m_local)
     return GAddress_copy(socket->m_local);
 

-  if (socket->m_fd == -1) {
+  /* else, if the socket is initialized, try getsockname */
+  if (socket->m_fd == INVALID_SOCKET)
+  {

     socket->m_error = GSOCK_INVSOCK;
     return NULL;
   }
 
     socket->m_error = GSOCK_INVSOCK;
     return NULL;
   }
 

-  size = sizeof(addr);
-
-  if (getsockname(socket->m_fd, &addr, &size) < 0) {
+  if (getsockname(socket->m_fd, &addr, (SOCKLEN_T *) &size) < 0)
+  {

     socket->m_error = GSOCK_IOERR;
     return NULL;
   }
 
     socket->m_error = GSOCK_IOERR;
     return NULL;
   }
 

+  /* got a valid address from getsockname, create a GAddress object */

   address = GAddress_new();
   address = GAddress_new();

-  if (address == NULL) {
+  if (address == NULL)
+  {

     socket->m_error = GSOCK_MEMERR;
     return NULL;
   }
     socket->m_error = GSOCK_MEMERR;
     return NULL;
   }

-  socket->m_error = _GAddress_translate_from(address, &addr, size);
-  if (socket->m_error != GSOCK_NOERROR) {
+
+  err = _GAddress_translate_from(address, &addr, size);
+  if (err != GSOCK_NOERROR)
+  {

     GAddress_destroy(address);
     GAddress_destroy(address);

+    socket->m_error = err;

     return NULL;
   }
 
     return NULL;
   }
 


@@ -254,6 +378,7 @@ GAddress *GSocket_GetPeer(GSocket *socket)
 {
   assert(socket != NULL);
 
 {
   assert(socket != NULL);
 

+  /* try to get it from the m_peer var */

   if (socket->m_peer)
     return GAddress_copy(socket->m_peer);
 
   if (socket->m_peer)
     return GAddress_copy(socket->m_peer);
 


@@ -263,237 +388,344 @@ GAddress *GSocket_GetPeer(GSocket *socket)
 /* Server specific parts */
 
 /* GSocket_SetServer:
 /* Server specific parts */
 
 /* GSocket_SetServer:

- *  Sets up the socket as a server. It uses the "Local" field of GSocket.
- *  "Local" must be set by GSocket_SetLocal() before GSocket_SetServer()
- *  is called. Possible error codes are: GSOCK_INVSOCK if socket has not
- *  been initialized, GSOCK_INVADDR if the local address has not been
- *  defined and GSOCK_IOERR for other internal errors.
+ *  Sets up this socket as a server. The local address must have been
+ *  set with GSocket_SetLocal() before GSocket_SetServer() is called.
+ *  Returns GSOCK_NOERROR on success, one of the following otherwise:
+ * 
+ *  Error codes:
+ *    GSOCK_INVSOCK - the socket is in use.
+ *    GSOCK_INVADDR - the local address has not been set.
+ *    GSOCK_IOERR   - low-level error. 

  */
 GSocketError GSocket_SetServer(GSocket *sck)
 {
  */
 GSocketError GSocket_SetServer(GSocket *sck)
 {

-  int type;
+  int arg = 1;

 
   assert(sck != NULL);
 
 
   assert(sck != NULL);
 

-  if (sck->m_fd != -1) {
+  /* must not be in use */
+  if (sck->m_fd != INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 
     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 

-  if (!sck->m_local) {
+  /* the local addr must have been set */
+  if (!sck->m_local)
+  {

     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 
     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 

-  /* We always have a stream here  */
-  sck->m_stream = TRUE;
-  sck->m_server = TRUE;
+  /* Initialize all fields */
+  sck->m_stream   = TRUE;
+  sck->m_server   = TRUE;
+  sck->m_oriented = TRUE;

 
   /* Create the socket */
   sck->m_fd = socket(sck->m_local->m_realfamily, SOCK_STREAM, 0);
 
 
   /* Create the socket */
   sck->m_fd = socket(sck->m_local->m_realfamily, SOCK_STREAM, 0);
 

-  if (sck->m_fd == -1) {
+  if (sck->m_fd == INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 
     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 

-  /* Bind the socket to the LOCAL address */
-  if (bind(sck->m_fd, sck->m_local->m_addr, sck->m_local->m_len) < 0) {
-    close(sck->m_fd);
-    sck->m_fd = -1;
-    sck->m_error = GSOCK_IOERR;
-    return GSOCK_IOERR;
-  }
+  ioctl(sck->m_fd, FIONBIO, &arg);
+  _GSocket_Enable_Events(sck);

 
 

-  /* Enable listening up to 5 connections */
-  if (listen(sck->m_fd, 5) < 0) {
-    close(sck->m_fd);
-    sck->m_fd = -1;
+  /* Bind to the local address,
+   * retrieve the actual address bound,
+   * and listen up to 5 connections.
+   */
+  if ((bind(sck->m_fd, sck->m_local->m_addr, sck->m_local->m_len) != 0) ||
+      (getsockname(sck->m_fd,
+                   sck->m_local->m_addr,
+                   (SOCKLEN_T *) &sck->m_local->m_len) != 0) ||
+      (listen(sck->m_fd, 5) != 0))
+  {
+    GSocket_close(sck);

     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 
     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 

-  _GSocket_Configure_Callbacks(sck);
-  GSocket_SetNonBlocking(sck, sck->m_non_blocking);
-  GSocket_SetTimeout(sck, sck->m_timeout);
-

   return GSOCK_NOERROR;
 }
 
 /* GSocket_WaitConnection:
   return GSOCK_NOERROR;
 }
 
 /* GSocket_WaitConnection:

- *  Waits for an incoming client connection.
+ *  Waits for an incoming client connection. Returns a pointer to
+ *  a GSocket object, or NULL if there was an error, in which case
+ *  the last error field will be updated for the calling GSocket.
+ *
+ *  Error codes (set in the calling GSocket)
+ *    GSOCK_INVSOCK    - the socket is not valid or not a server.
+ *    GSOCK_TIMEDOUT   - timeout, no incoming connections.
+ *    GSOCK_WOULDBLOCK - the call would block and the socket is nonblocking.
+ *    GSOCK_MEMERR     - couldn't allocate memory.
+ *    GSOCK_IOERR      - low-level error. 

  */
 GSocket *GSocket_WaitConnection(GSocket *socket)
 {
  */
 GSocket *GSocket_WaitConnection(GSocket *socket)
 {

+  struct sockaddr from;
+  SOCKLEN_T fromlen = sizeof(from);

   GSocket *connection;
   GSocket *connection;

+  GSocketError err;
+  int arg = 1;

 
   assert(socket != NULL);
 
 
   assert(socket != NULL);
 

+  /* Reenable CONNECTION events */
+  _GSocket_Enable(socket, GSOCK_CONNECTION);
+

   /* If the socket has already been created, we exit immediately */
   /* If the socket has already been created, we exit immediately */

-  if (socket->m_fd == -1 || !socket->m_server) {
+  if (socket->m_fd == INVALID_SOCKET || !socket->m_server)
+  {

     socket->m_error = GSOCK_INVSOCK;
     return NULL;
   }
 
     socket->m_error = GSOCK_INVSOCK;
     return NULL;
   }
 

-  /* Reenable GSOCK_CONNECTION event */
-  _GSocket_Enable(socket, GSOCK_CONNECTION);
-

   /* Create a GSocket object for the new connection */
   connection = GSocket_new();
   /* Create a GSocket object for the new connection */
   connection = GSocket_new();

-  if (!connection) {
-    connection->m_error = GSOCK_MEMERR;
+
+  if (!connection)
+  {
+    socket->m_error = GSOCK_MEMERR;

     return NULL;
   }
 
     return NULL;
   }
 

-  /* Accept the incoming connection */
-  ENABLE_TIMEOUT(connection);
-  connection->m_fd = accept(socket->m_fd, NULL, NULL);
-  DISABLE_TIMEOUT(connection);
-  if (connection->m_fd == -1) {
+  /* Wait for a connection (with timeout) */
+  if (_GSocket_Input_Timeout(socket) == GSOCK_TIMEDOUT)
+  {
+    GSocket_destroy(connection);
+    /* socket->m_error set by _GSocket_Input_Timeout */
+    return NULL;
+  }
+
+  connection->m_fd = accept(socket->m_fd, &from, (SOCKLEN_T *) &fromlen);
+
+  if (connection->m_fd == INVALID_SOCKET)
+  {
+    if (errno == EWOULDBLOCK)
+      socket->m_error = GSOCK_WOULDBLOCK;
+    else
+      socket->m_error = GSOCK_IOERR;
+

     GSocket_destroy(connection);
     GSocket_destroy(connection);

-    switch(errno) {
-    case EINTR:
-    case ETIMEDOUT:
-      connection->m_error = GSOCK_TIMEDOUT;
-      break;
-    case EWOULDBLOCK:
-      connection->m_error = GSOCK_WOULDBLOCK;
-      break;
-    default:
-      connection->m_error = GSOCK_IOERR;
-      break;
-    }

     return NULL;
   }
 
   /* Initialize all fields */
     return NULL;
   }
 
   /* Initialize all fields */

-  connection->m_stream   = TRUE;

   connection->m_server   = FALSE;
   connection->m_server   = FALSE;

+  connection->m_stream   = TRUE;

   connection->m_oriented = TRUE;
 
   connection->m_oriented = TRUE;
 

-  _GSocket_Configure_Callbacks(connection);
-  GSocket_SetNonBlocking(connection, connection->m_non_blocking);
-  GSocket_SetTimeout(connection, connection->m_timeout);
+  /* Setup the peer address field */
+  connection->m_peer = GAddress_new();
+  if (!connection->m_peer)
+  {
+    GSocket_destroy(connection);
+    socket->m_error = GSOCK_MEMERR;
+    return NULL;
+  }
+  err = _GAddress_translate_from(connection->m_peer, &from, fromlen);
+  if (err != GSOCK_NOERROR)
+  {
+    GAddress_destroy(connection->m_peer);
+    GSocket_destroy(connection);
+    socket->m_error = err;
+    return NULL;
+  }
+
+  ioctl(connection->m_fd, FIONBIO, &arg);
+  _GSocket_Enable_Events(connection);

 
   return connection;
 }
 
 
   return connection;
 }
 

-/* Non oriented connections */
+/* Client specific parts */

 
 

-GSocketError GSocket_SetNonOriented(GSocket *sck)
+/* GSocket_Connect:
+ *  For stream (connection oriented) sockets, GSocket_Connect() tries
+ *  to establish a client connection to a server using the peer address
+ *  as established with GSocket_SetPeer(). Returns GSOCK_NOERROR if the
+ *  connection has been succesfully established, or one of the error
+ *  codes listed below. Note that for nonblocking sockets, a return
+ *  value of GSOCK_WOULDBLOCK doesn't mean a failure. The connection
+ *  request can be completed later; you should use GSocket_Select()
+ *  to poll for GSOCK_CONNECTION | GSOCK_LOST, or wait for the
+ *  corresponding asynchronous events.
+ *
+ *  For datagram (non connection oriented) sockets, GSocket_Connect()
+ *  just sets the peer address established with GSocket_SetPeer() as
+ *  default destination.
+ *
+ *  Error codes:
+ *    GSOCK_INVSOCK    - the socket is in use or not valid.
+ *    GSOCK_INVADDR    - the peer address has not been established.
+ *    GSOCK_TIMEDOUT   - timeout, the connection failed.
+ *    GSOCK_WOULDBLOCK - connection in progress (nonblocking sockets only)
+ *    GSOCK_MEMERR     - couldn't allocate memory.
+ *    GSOCK_IOERR      - low-level error. 
+ */
+GSocketError GSocket_Connect(GSocket *sck, GSocketStream stream)

 {
 {

+  int err, ret;
+  int arg = 1;
+

   assert(sck != NULL);
 
   assert(sck != NULL);
 

-  if (sck->m_fd != -1) {
+  /* Enable CONNECTION events (needed for nonblocking connections) */
+  _GSocket_Enable(sck, GSOCK_CONNECTION);
+
+  if (sck->m_fd != INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 
     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 

-  if (!sck->m_local) {
+  if (!sck->m_peer)
+  {

     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 
     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 

-  sck->m_stream   = FALSE;
+  /* Streamed or dgram socket? */
+  sck->m_stream   = (stream == GSOCK_STREAMED);
+  sck->m_oriented = TRUE;

   sck->m_server   = FALSE;
   sck->m_server   = FALSE;

-  sck->m_oriented = FALSE;
+  sck->m_establishing = FALSE;

 
   /* Create the socket */
 
   /* Create the socket */

-  sck->m_fd = socket(sck->m_local->m_realfamily, SOCK_DGRAM, 0);
+  sck->m_fd = socket(sck->m_peer->m_realfamily,
+                     sck->m_stream? SOCK_STREAM : SOCK_DGRAM, 0);

 
 

-  if (sck->m_fd < 0) {
+  if (sck->m_fd == INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 
     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 

-  /* Bind it to the LOCAL address */
-  if (bind(sck->m_fd, sck->m_local->m_addr, sck->m_local->m_len) < 0) {
-    close(sck->m_fd);
-    sck->m_fd    = -1;
+  ioctl(sck->m_fd, FIONBIO, &arg);
+  _GSocket_Enable_Events(sck);
+
+  /* Connect it to the peer address, with a timeout (see below) */
+  ret = connect(sck->m_fd, sck->m_peer->m_addr, sck->m_peer->m_len);
+
+  if (ret == -1)
+  {
+    err = errno;
+
+    /* If connect failed with EINPROGRESS and the GSocket object
+     * is in blocking mode, we select() for the specified timeout
+     * checking for writability to see if the connection request
+     * completes.
+     */
+    if ((err == EINPROGRESS) && (!sck->m_non_blocking))
+    {
+      if (_GSocket_Output_Timeout(sck) == GSOCK_TIMEDOUT)
+      {
+        GSocket_close(sck);
+        /* sck->m_error is set in _GSocket_Output_Timeout */
+        return GSOCK_TIMEDOUT;
+      }
+      else
+      {
+        int error;
+        SOCKLEN_T len = sizeof(error);
+
+        getsockopt(sck->m_fd, SOL_SOCKET, SO_ERROR, (void*) &error, &len);
+
+        if (!error)
+          return GSOCK_NOERROR;
+      }
+    }
+
+    /* If connect failed with EINPROGRESS and the GSocket object
+     * is set to nonblocking, we set m_error to GSOCK_WOULDBLOCK
+     * (and return GSOCK_WOULDBLOCK) but we don't close the socket;
+     * this way if the connection completes, a GSOCK_CONNECTION
+     * event will be generated, if enabled.
+     */
+    if ((err == EINPROGRESS) && (sck->m_non_blocking))
+    {
+      sck->m_establishing = TRUE;
+      sck->m_error = GSOCK_WOULDBLOCK;
+      return GSOCK_WOULDBLOCK;
+    }
+
+    /* If connect failed with an error other than EINPROGRESS,
+     * then the call to GSocket_Connect has failed.
+     */
+    GSocket_close(sck);

     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 
     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 

-  _GSocket_Configure_Callbacks(sck);
-  GSocket_SetNonBlocking(sck, sck->m_non_blocking);
-  GSocket_SetTimeout(sck, sck->m_timeout);
-

   return GSOCK_NOERROR;
 }
 
   return GSOCK_NOERROR;
 }
 

-/* Client specific parts */
+/* Datagram sockets */

 
 

-/* GSocket_Connect:
- *  Establishes a client connection to a server using the "Peer"
- *  field of GSocket. "Peer" must be set by GSocket_SetPeer() before
- *  GSocket_Connect() is called. Possible error codes are GSOCK_INVSOCK,
- *  GSOCK_INVADDR, GSOCK_TIMEDOUT, GSOCK_WOULDBLOCK and GSOCK_IOERR.
- *  If a socket is nonblocking and Connect() returns GSOCK_WOULDBLOCK,
- *  the connection request can be completed later. Use GSocket_Select()
- *  to check or wait for a GSOCK_CONNECTION event.
+/* GSocket_SetNonOriented:
+ *  Sets up this socket as a non-connection oriented (datagram) socket.
+ *  Before using this function, the local address must have been set
+ *  with GSocket_SetLocal(), or the call will fail. Returns GSOCK_NOERROR
+ *  on success, or one of the following otherwise.
+ *
+ *  Error codes:
+ *    GSOCK_INVSOCK - the socket is in use.
+ *    GSOCK_INVADDR - the local address has not been set.
+ *    GSOCK_IOERR   - low-level error.

  */
  */

-GSocketError GSocket_Connect(GSocket *sck, GSocketStream stream)
+GSocketError GSocket_SetNonOriented(GSocket *sck)

 {
 {

-  int type, err;
+  int arg = 1;

 
   assert(sck != NULL);
 
 
   assert(sck != NULL);
 

-  if (sck->m_fd != -1) {
+  if (sck->m_fd != INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 
     sck->m_error = GSOCK_INVSOCK;
     return GSOCK_INVSOCK;
   }
 

-  if (!sck->m_peer) {
+  if (!sck->m_local)
+  {

     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 
     sck->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 

-  /* Test whether we want the socket to be a stream (e.g. TCP) */
-  sck->m_stream = (stream == GSOCK_STREAMED);
-  sck->m_oriented = TRUE;
-
-  if (sck->m_stream)
-    type = SOCK_STREAM;
-  else
-    type = SOCK_DGRAM;
+  /* Initialize all fields */
+  sck->m_stream   = FALSE;
+  sck->m_server   = FALSE;
+  sck->m_oriented = FALSE;

 
   /* Create the socket */
 
   /* Create the socket */

-  sck->m_fd = socket(sck->m_peer->m_realfamily, type, 0);
+  sck->m_fd = socket(sck->m_local->m_realfamily, SOCK_DGRAM, 0);

 
 

-  if (sck->m_fd == -1) {
+  if (sck->m_fd == INVALID_SOCKET)
+  {

     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 
     sck->m_error = GSOCK_IOERR;
     return GSOCK_IOERR;
   }
 

-  _GSocket_Configure_Callbacks(sck);
-  GSocket_SetNonBlocking(sck, sck->m_non_blocking);
-  GSocket_SetTimeout(sck, sck->m_timeout);
-
-  /* Connect it to the PEER address */
-  ENABLE_TIMEOUT(sck);
-  err = connect(sck->m_fd, sck->m_peer->m_addr, sck->m_peer->m_len);
-  DISABLE_TIMEOUT(sck);
-
-  if (err != 0 && errno != EINPROGRESS) {
-    close(sck->m_fd);
-    sck->m_fd = -1;
-    switch (errno) {
-    case EINTR:
-    case ETIMEDOUT:
-      sck->m_error = GSOCK_TIMEDOUT;
-      break;
-    default:
-      sck->m_error = GSOCK_IOERR;
-      break;
-    }
+  ioctl(sck->m_fd, FIONBIO, &arg);
+  _GSocket_Enable_Events(sck);
+
+  /* Bind to the local address,
+   * and retrieve the actual address bound.
+   */
+  if ((bind(sck->m_fd, sck->m_local->m_addr, sck->m_local->m_len) != 0) ||
+      (getsockname(sck->m_fd,
+                   sck->m_local->m_addr,
+                   (SOCKLEN_T *) &sck->m_local->m_len) != 0))
+  {
+    GSocket_close(sck);
+    sck->m_error = GSOCK_IOERR;

     return GSOCK_IOERR;
   }
     return GSOCK_IOERR;
   }

-  
-  /* It is not a server */
-  sck->m_server       = FALSE;
-  sck->m_establishing = (errno == EINPROGRESS);

 
 

-  return (sck->m_establishing) ? GSOCK_WOULDBLOCK : GSOCK_NOERROR;
+  return GSOCK_NOERROR;

 }
 
 /* Generic IO */
 }
 
 /* Generic IO */


@@ -501,38 +733,95 @@ GSocketError GSocket_Connect(GSocket *sck, GSocketStream stream)
 /* Like recv(), send(), ... */
 int GSocket_Read(GSocket *socket, char *buffer, int size)
 {
 /* Like recv(), send(), ... */
 int GSocket_Read(GSocket *socket, char *buffer, int size)
 {

+  int ret;
+

   assert(socket != NULL);
 
   assert(socket != NULL);
 

-  if (socket->m_fd == -1 || socket->m_server) {
+  /* Reenable INPUT events */
+  _GSocket_Enable(socket, GSOCK_INPUT);
+
+  if (socket->m_fd == INVALID_SOCKET || socket->m_server)
+  {

     socket->m_error = GSOCK_INVSOCK;
     return -1;
   }
 
     socket->m_error = GSOCK_INVSOCK;
     return -1;
   }
 

-  /* Reenable GSOCK_INPUT event */
-  _GSocket_Enable(socket, GSOCK_INPUT);
+  /* If the socket is blocking, wait for data (with a timeout) */
+  if (_GSocket_Input_Timeout(socket) == GSOCK_TIMEDOUT)
+    return -1;

 
 

+  /* Read the data */

   if (socket->m_stream)
   if (socket->m_stream)

-    return _GSocket_Recv_Stream(socket, buffer, size);
+    ret = _GSocket_Recv_Stream(socket, buffer, size);

   else
   else

-    return _GSocket_Recv_Dgram(socket, buffer, size);
+    ret = _GSocket_Recv_Dgram(socket, buffer, size);
+    
+  if (ret == -1)
+  {
+    if (errno == EWOULDBLOCK)
+      socket->m_error = GSOCK_WOULDBLOCK;
+    else
+      socket->m_error = GSOCK_IOERR;
+  }
+  
+  return ret;

 }
 
 }
 

-int GSocket_Write(GSocket *socket, const char *buffer,
-                 int size)
-{
+int GSocket_Write(GSocket *socket, const char *buffer, int size)
+{                        
+  int ret;
+

   assert(socket != NULL);
   assert(socket != NULL);

+  
+  GSocket_Debug(( "GSocket_Write #1, size %d\n", size ));

 
 

-  if (socket->m_fd == -1 || socket->m_server) {
+  if (socket->m_fd == INVALID_SOCKET || socket->m_server)
+  {

     socket->m_error = GSOCK_INVSOCK;
     return -1;
   }
 
     socket->m_error = GSOCK_INVSOCK;
     return -1;
   }
 

-  _GSocket_Enable(socket, GSOCK_OUTPUT);
+  GSocket_Debug(( "GSocket_Write #2, size %d\n", size ));
+
+  /* If the socket is blocking, wait for writability (with a timeout) */
+  if (_GSocket_Output_Timeout(socket) == GSOCK_TIMEDOUT)
+    return -1;
+
+  GSocket_Debug(( "GSocket_Write #3, size %d\n", size ));

 
 

+  /* Write the data */

   if (socket->m_stream)
   if (socket->m_stream)

-    return _GSocket_Send_Stream(socket, buffer, size);
+    ret = _GSocket_Send_Stream(socket, buffer, size);

   else
   else

-    return _GSocket_Send_Dgram(socket, buffer, size);
+    ret = _GSocket_Send_Dgram(socket, buffer, size);
+    
+  GSocket_Debug(( "GSocket_Write #4, size %d\n", size ));
+
+  if (ret == -1)
+  {
+    if (errno == EWOULDBLOCK)
+    {
+      socket->m_error = GSOCK_WOULDBLOCK;
+      GSocket_Debug(( "GSocket_Write error WOULDBLOCK\n" ));
+    }
+    else
+    {
+      socket->m_error = GSOCK_IOERR;
+      GSocket_Debug(( "GSocket_Write error IOERR\n" ));
+    }
+
+    /* Only reenable OUTPUT events after an error (just like WSAAsyncSelect
+     * in MSW). Once the first OUTPUT event is received, users can assume
+     * that the socket is writable until a read operation fails. Only then
+     * will further OUTPUT events be posted.
+     */
+    _GSocket_Enable(socket, GSOCK_OUTPUT);
+    return -1;
+  }
+  
+  GSocket_Debug(( "GSocket_Write #5, size %d ret %d\n", size, ret ));
+
+  return ret;

 }
 
 /* GSocket_Select:
 }
 
 /* GSocket_Select:


@@ -540,87 +829,150 @@ int GSocket_Write(GSocket *socket, const char *buffer,
  *  check for the events specified in the 'flags' parameter, and
  *  it will return a mask indicating which operations can be
  *  performed. This function won't block, regardless of the
  *  check for the events specified in the 'flags' parameter, and
  *  it will return a mask indicating which operations can be
  *  performed. This function won't block, regardless of the

- *  mode (blocking|nonblocking) of the socket.
+ *  mode (blocking | nonblocking) of the socket.

  */
 GSocketEventFlags GSocket_Select(GSocket *socket, GSocketEventFlags flags)
 {
  */
 GSocketEventFlags GSocket_Select(GSocket *socket, GSocketEventFlags flags)
 {

-  fd_set readfds, writefds, exceptfds;
-  struct timeval tv;
-  GSocketEventFlags mask;
-  int error, len;
+  if (!USE_GUI())
+  {

 
 

-  assert(socket != NULL);
+    GSocketEventFlags result = 0;
+    fd_set readfds;
+    fd_set writefds;
+    fd_set exceptfds;
+    struct timeval tv;

 
 

-  if (socket->m_fd == -1)
-  {
-    socket->m_error = GSOCK_INVSOCK;
-    return FALSE;
-  }
+    /* Do not use a static struct, Linux can garble it */
+    tv.tv_sec = 0;
+    tv.tv_usec = 0;

 
 

-  FD_ZERO(&readfds);
-  FD_ZERO(&writefds);
-  FD_ZERO(&exceptfds);
-  FD_SET(socket->m_fd, &readfds);
-  FD_SET(socket->m_fd, &writefds);
-  FD_SET(socket->m_fd, &exceptfds);
-
-  tv.tv_sec = 0;
-  tv.tv_usec = 0;
-  select(socket->m_fd + 1, &readfds, &writefds, &exceptfds, &tv);
-
-  mask = 0;
-
-  /* If select() says that the socket is readable, then we have
-   * no way to distinguish if that means 'data available' (to
-   * recv) or 'incoming connection' (to accept). The same goes
-   * for writability: we cannot distinguish between 'you can
-   * send data' and 'connection request completed'. So we will
-   * assume the following: if the flag was set upon entry,
-   * that means that the event was possible.
-   */
-  if (FD_ISSET(socket->m_fd, &readfds))
-  {
-    mask |= (flags & GSOCK_CONNECTION_FLAG);
-    mask |= (flags & GSOCK_INPUT_FLAG);
-  }
-  if (FD_ISSET(socket->m_fd, &writefds))
-  {
-    if (socket->m_establishing)
+    assert(socket != NULL);
+
+    FD_ZERO(&readfds);
+    FD_ZERO(&writefds);
+    FD_ZERO(&exceptfds);
+    FD_SET(socket->m_fd, &readfds);
+    FD_SET(socket->m_fd, &writefds);
+    FD_SET(socket->m_fd, &exceptfds);
+
+    /* Check 'sticky' CONNECTION flag first */
+    result |= (GSOCK_CONNECTION_FLAG & socket->m_detected);
+
+    /* If we have already detected a LOST event, then don't try
+     * to do any further processing.
+     */
+    if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+    {
+      socket->m_establishing = FALSE;
+
+      return (GSOCK_LOST_FLAG & flags);
+    }
+
+    /* Try select now */
+    if (select(socket->m_fd + 1, &readfds, &writefds, &exceptfds, &tv) <= 0)
+    {
+      /* What to do here? */
+      return (result & flags);
+    }
+
+    /* Check for readability */
+    if (FD_ISSET(socket->m_fd, &readfds))

     {
     {

-      getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, &error, &len);
+      char c;

 
 

-      if (error)
-        mask |= (flags & GSOCK_LOST_FLAG);
+      if (recv(socket->m_fd, &c, 1, MSG_PEEK) > 0)
+      {
+        result |= GSOCK_INPUT_FLAG;
+      }

       else
       else

-        mask |= (flags & GSOCK_CONNECTION_FLAG);
+      {
+        if (socket->m_server && socket->m_stream)
+        {
+          result |= GSOCK_CONNECTION_FLAG;
+          socket->m_detected |= GSOCK_CONNECTION_FLAG;
+        }
+        else
+        {
+          socket->m_detected = GSOCK_LOST_FLAG;
+          socket->m_establishing = FALSE;
+      
+          /* LOST event: Abort any further processing */
+          return (GSOCK_LOST_FLAG & flags);
+        }
+      }

     }
     }

-    mask |= (flags & GSOCK_OUTPUT_FLAG);
+
+    /* Check for writability */
+    if (FD_ISSET(socket->m_fd, &writefds))
+    {
+      if (socket->m_establishing && !socket->m_server)
+      {
+        int error;
+        SOCKLEN_T len = sizeof(error);
+
+        socket->m_establishing = FALSE;
+
+        getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, (void*)&error, &len);
+
+        if (error)
+        {
+          socket->m_detected = GSOCK_LOST_FLAG;
+
+          /* LOST event: Abort any further processing */
+          return (GSOCK_LOST_FLAG & flags);
+        }
+        else
+        {
+          result |= GSOCK_CONNECTION_FLAG;
+          socket->m_detected |= GSOCK_CONNECTION_FLAG;
+        }
+      }
+      else
+      {
+        result |= GSOCK_OUTPUT_FLAG;
+      }
+    }
+
+    /* Check for exceptions and errors (is this useful in Unices?) */
+    if (FD_ISSET(socket->m_fd, &exceptfds))
+    {
+      socket->m_establishing = FALSE;
+      socket->m_detected = GSOCK_LOST_FLAG;
+
+      /* LOST event: Abort any further processing */
+      return (GSOCK_LOST_FLAG & flags);
+    }
+
+    return (result & flags);
+

   }
   }

-  if (FD_ISSET(socket->m_fd, &exceptfds))
-    mask |= (flags & GSOCK_LOST_FLAG);
+  else
+  {

 
 

-  return mask;
+    assert(socket != NULL);
+    return flags & socket->m_detected;
+
+  }

 }
 
 /* Flags */
 
 /* GSocket_SetNonBlocking:
 }
 
 /* Flags */
 
 /* GSocket_SetNonBlocking:

- *  Sets the socket to non-blocking mode. This is useful if
- *  we don't want to wait.
+ *  Sets the socket to non-blocking mode. All IO calls will return
+ *  immediately.

  */
  */

-void GSocket_SetNonBlocking(GSocket *socket, bool non_block)
+void GSocket_SetNonBlocking(GSocket *socket, int non_block)

 {
   assert(socket != NULL);
 
 {
   assert(socket != NULL);
 

-  socket->m_non_blocking = non_block;
+  GSocket_Debug( ("GSocket_SetNonBlocking: %d\n", (int)non_block) );

 
 

-  if (socket->m_fd != -1)
-    ioctl(socket->m_fd, FIONBIO, &non_block);
+  socket->m_non_blocking = non_block;

 }
 
 /* GSocket_SetTimeout:
 }
 
 /* GSocket_SetTimeout:

- *  Sets the timeout for blocking calls. Time is
- *  expressed in milliseconds.
+ *  Sets the timeout for blocking calls. Time is expressed in
+ *  milliseconds.

  */
 void GSocket_SetTimeout(GSocket *socket, unsigned long millisec)
 {
  */
 void GSocket_SetTimeout(GSocket *socket, unsigned long millisec)
 {


@@ -630,7 +982,9 @@ void GSocket_SetTimeout(GSocket *socket, unsigned long millisec)
 }
 
 /* GSocket_GetError:
 }
 
 /* GSocket_GetError:

- *  Returns the last error occured for this socket.
+ *  Returns the last error occured for this socket. Note that successful
+ *  operations do not clear this back to GSOCK_NOERROR, so use it only
+ *  after an error.

  */
 GSocketError GSocket_GetError(GSocket *socket)
 {
  */
 GSocketError GSocket_GetError(GSocket *socket)
 {


@@ -641,20 +995,24 @@ GSocketError GSocket_GetError(GSocket *socket)
 
 /* Callbacks */
 
 
 /* Callbacks */
 

-/* Only one callback is possible for each event (INPUT, OUTPUT, CONNECTION
- * and LOST). The callbacks are called in the following situations:
- *
- * INPUT: There is at least one byte in the input buffer
- * OUTPUT: The system is sure that the next write call will not block
- * CONNECTION: Two cases are possible:
- *           Client socket -> the connection is established
- *           Server socket -> a client requests a connection
- * LOST: The connection is lost
- *
- * An event is generated only once and its state is reseted when the
- * relative IO call is requested.
- * For example: INPUT -> GSocket_Read()
- *              CONNECTION -> GSocket_Accept()
+/* GSOCK_INPUT:
+ *   There is data to be read in the input buffer. If, after a read
+ *   operation, there is still data available, the callback function will
+ *   be called again.
+ * GSOCK_OUTPUT:
+ *   The socket is available for writing. That is, the next write call 
+ *   won't block. This event is generated only once, when the connection is
+ *   first established, and then only if a call failed with GSOCK_WOULDBLOCK,
+ *   when the output buffer empties again. This means that the app should
+ *   assume that it can write since the first OUTPUT event, and no more
+ *   OUTPUT events will be generated unless an error occurs.
+ * GSOCK_CONNECTION:
+ *   Connection succesfully established, for client sockets, or incoming
+ *   client connection, for server sockets. Wait for this event (also watch
+ *   out for GSOCK_LOST) after you issue a nonblocking GSocket_Connect() call.
+ * GSOCK_LOST:
+ *   The connection is lost (or a connection request failed); this could
+ *   be due to a failure, or due to the peer closing it gracefully.

  */
 
 /* GSocket_SetCallback:
  */
 
 /* GSocket_SetCallback:


@@ -666,21 +1024,20 @@ GSocketError GSocket_GetError(GSocket *socket)
  *  void function(GSocket *socket, GSocketEvent event, char *cdata)
  */
 void GSocket_SetCallback(GSocket *socket, GSocketEventFlags flags,
  *  void function(GSocket *socket, GSocketEvent event, char *cdata)
  */
 void GSocket_SetCallback(GSocket *socket, GSocketEventFlags flags,

-                        GSocketCallback callback, char *cdata)
+                         GSocketCallback callback, char *cdata)

 {
   int count;
 
 {
   int count;
 

-  assert (socket != NULL);
+  assert(socket != NULL);

 
 

-  for (count=0;count<GSOCK_MAX_EVENT;count++) {
-    /* We test each flag and, if it is enabled, we enable the corresponding
-       event */
-    if ((flags & (1 << count)) != 0) {
+  for (count = 0; count < GSOCK_MAX_EVENT; count++)
+  {
+    if ((flags & (1 << count)) != 0)
+    {

       socket->m_cbacks[count] = callback;
       socket->m_data[count] = cdata;
     }
   }
       socket->m_cbacks[count] = callback;
       socket->m_data[count] = cdata;
     }
   }

-  _GSocket_Configure_Callbacks(socket);

 }
 
 /* GSocket_UnsetCallback:
 }
 
 /* GSocket_UnsetCallback:


@@ -693,109 +1050,159 @@ void GSocket_UnsetCallback(GSocket *socket, GSocketEventFlags flags)
 
   assert(socket != NULL);
 
 
   assert(socket != NULL);
 

-  for (count=0;count<GSOCK_MAX_EVENT;count++) {
-    if ((flags & (1 << count)) != 0) {
+  for (count = 0; count < GSOCK_MAX_EVENT; count++)
+  {
+    if ((flags & (1 << count)) != 0)
+    {

       socket->m_cbacks[count] = NULL;
       socket->m_cbacks[count] = NULL;

+      socket->m_data[count] = NULL;

     }
   }
     }
   }

-  _GSocket_Configure_Callbacks(socket);

 }
 
 }
 

-#define CALL_CALLBACK(socket, event)                                \
-if (socket->m_iocalls[event] && socket->m_cbacks[event]) {          \
-  _GSocket_Disable(socket, event);                                  \
-  socket->m_cbacks[event](socket, event, socket->m_data[event]);    \
+
+#define CALL_CALLBACK(socket, event) {                                  \
+  _GSocket_Disable(socket, event);                                      \
+  if (socket->m_cbacks[event])                                          \
+    socket->m_cbacks[event](socket, event, socket->m_data[event]);      \

 }
 
 }
 

+

 void _GSocket_Enable(GSocket *socket, GSocketEvent event)
 {
 void _GSocket_Enable(GSocket *socket, GSocketEvent event)
 {

-  socket->m_iocalls[event] = TRUE;
-  if (socket->m_cbacks[event])
-    _GSocket_Install_Callback(socket, event);
+  socket->m_detected &= ~(1 << event);
+  _GSocket_Install_Callback(socket, event);

 }
 
 void _GSocket_Disable(GSocket *socket, GSocketEvent event)
 {
 }
 
 void _GSocket_Disable(GSocket *socket, GSocketEvent event)
 {

-  socket->m_iocalls[event] = FALSE;
-  if (socket->m_cbacks[event])
-    _GSocket_Uninstall_Callback(socket, event);
+  socket->m_detected |= (1 << event);
+  _GSocket_Uninstall_Callback(socket, event);

 }
 
 }
 

-void _GSocket_Configure_Callbacks(GSocket *socket)
+/* _GSocket_Input_Timeout:
+ *  For blocking sockets, wait until data is available or
+ *  until timeout ellapses.
+ */
+GSocketError _GSocket_Input_Timeout(GSocket *socket)

 {
 {

-  int count;
-  for (count=0;count<GSOCK_MAX_EVENT;count++) {
-    if ((socket->m_cbacks[count]) != NULL) {
-      GSocket_Enable(socket, count);
-    } else {
-      GSocket_Disable(socket, count);
+  struct timeval tv;
+  fd_set readfds;
+  int ret;
+
+  /* Linux select() will overwrite the struct on return */
+  tv.tv_sec  = (socket->m_timeout / 1000);
+  tv.tv_usec = (socket->m_timeout % 1000) * 1000;
+
+  if (!socket->m_non_blocking)
+  {
+    FD_ZERO(&readfds);
+    FD_SET(socket->m_fd, &readfds);
+    ret = select(socket->m_fd + 1, &readfds, NULL, NULL, &tv);
+    if (ret == 0)
+    {
+      GSocket_Debug(( "GSocket_Input_Timeout, select returned 0\n" ));
+      socket->m_error = GSOCK_TIMEDOUT;
+      return GSOCK_TIMEDOUT;
+    }
+    if (ret == -1)
+    {
+      GSocket_Debug(( "GSocket_Input_Timeout, select returned -1\n" ));
+      if (errno == EBADF) { GSocket_Debug(( "Invalid file descriptor\n" )); }
+      if (errno == EINTR) { GSocket_Debug(( "A non blocked signal was caught\n" )); }
+      if (errno == EINVAL) { GSocket_Debug(( "The highest number descriptor is negative\n" )); }
+      if (errno == ENOMEM) { GSocket_Debug(( "Not enough memory\n" )); }
+      socket->m_error = GSOCK_TIMEDOUT;
+      return GSOCK_TIMEDOUT;

     }
   }
     }
   }

+  return GSOCK_NOERROR;

 }
 
 }
 

-int _GSocket_Recv_Stream(GSocket *socket, char *buffer, int size)
+/* _GSocket_Output_Timeout:
+ *  For blocking sockets, wait until data can be sent without
+ *  blocking or until timeout ellapses.
+ */
+GSocketError _GSocket_Output_Timeout(GSocket *socket)

 {
 {

+  struct timeval tv;
+  fd_set writefds;

   int ret;
 
   int ret;
 

-  MASK_SIGNAL();
-  ENABLE_TIMEOUT(socket);
-  ret = recv(socket->m_fd, buffer, size, 0);
-  DISABLE_TIMEOUT(socket);
-  UNMASK_SIGNAL();
+  /* Linux select() will overwrite the struct on return */
+  tv.tv_sec  = (socket->m_timeout / 1000);
+  tv.tv_usec = (socket->m_timeout % 1000) * 1000;

 
 

-  if (ret == -1 &&
-      errno != ETIMEDOUT && errno != EWOULDBLOCK && errno != EINTR) {
-      socket->m_error = GSOCK_IOERR;
-      return -1;
-  }
-  if (errno == EWOULDBLOCK) {
-    socket->m_error = GSOCK_WOULDBLOCK;
-    return -1;
+  GSocket_Debug( ("m_non_blocking has: %d\n", (int)socket->m_non_blocking) );
+
+  if (!socket->m_non_blocking)
+  {
+    FD_ZERO(&writefds);
+    FD_SET(socket->m_fd, &writefds);
+    ret = select(socket->m_fd + 1, NULL, &writefds, NULL, &tv);
+    if (ret == 0)
+    {
+      GSocket_Debug(( "GSocket_Output_Timeout, select returned 0\n" ));
+      socket->m_error = GSOCK_TIMEDOUT;
+      return GSOCK_TIMEDOUT;
+    }
+    if (ret == -1)
+    {
+      GSocket_Debug(( "GSocket_Output_Timeout, select returned -1\n" ));
+      if (errno == EBADF) { GSocket_Debug(( "Invalid file descriptor\n" )); }
+      if (errno == EINTR) { GSocket_Debug(( "A non blocked signal was caught\n" )); }
+      if (errno == EINVAL) { GSocket_Debug(( "The highest number descriptor is negative\n" )); }
+      if (errno == ENOMEM) { GSocket_Debug(( "Not enough memory\n" )); }
+      socket->m_error = GSOCK_TIMEDOUT;
+      return GSOCK_TIMEDOUT;
+    }
+    if ( ! FD_ISSET(socket->m_fd, &writefds) ) {
+        GSocket_Debug(( "GSocket_Output_Timeout is buggy!\n" ));
+    }
+    else {
+        GSocket_Debug(( "GSocket_Output_Timeout seems correct\n" ));
+    }

   }
   }

-  if (errno == ETIMEDOUT || errno == EINTR) {
-    socket->m_error = GSOCK_TIMEDOUT;
-    return -1;
+  else
+  {
+    GSocket_Debug(( "GSocket_Output_Timeout, didn't try select!\n" ));

   }
   }

-  return ret;
+
+  return GSOCK_NOERROR;
+}
+
+int _GSocket_Recv_Stream(GSocket *socket, char *buffer, int size)
+{
+  return recv(socket->m_fd, buffer, size, 0);

 }
 
 int _GSocket_Recv_Dgram(GSocket *socket, char *buffer, int size)
 {
   struct sockaddr from;
 }
 
 int _GSocket_Recv_Dgram(GSocket *socket, char *buffer, int size)
 {
   struct sockaddr from;

-  SOCKLEN_T fromlen;
+  SOCKLEN_T fromlen = sizeof(from);

   int ret;
   GSocketError err;
 
   fromlen = sizeof(from);
 
   int ret;
   GSocketError err;
 
   fromlen = sizeof(from);
 

-  MASK_SIGNAL();
-  ENABLE_TIMEOUT(socket);
-  ret = recvfrom(socket->m_fd, buffer, size, 0, &from, &fromlen);
-  DISABLE_TIMEOUT(socket);
-  UNMASK_SIGNAL();
-  if (ret == -1 && errno != EWOULDBLOCK && errno != EINTR && errno != ETIMEDOUT) {
-    socket->m_error = GSOCK_IOERR;
-    return -1;
-  }
-  if (errno == EWOULDBLOCK) {
-    socket->m_error = GSOCK_WOULDBLOCK;
-    return -1;
-  }
-  if (errno == ETIMEDOUT || errno == EINTR) {
-    socket->m_error = GSOCK_TIMEDOUT;
+  ret = recvfrom(socket->m_fd, buffer, size, 0, &from, (SOCKLEN_T *) &fromlen);
+
+  if (ret == -1)

     return -1;
     return -1;

-  }

 
   /* Translate a system address into a GSocket address */
 
   /* Translate a system address into a GSocket address */

-  if (!socket->m_peer) {
+  if (!socket->m_peer)
+  {

     socket->m_peer = GAddress_new();
     socket->m_peer = GAddress_new();

-    if (!socket->m_peer) {
+    if (!socket->m_peer)
+    {

       socket->m_error = GSOCK_MEMERR;
       return -1;
     }
   }
   err = _GAddress_translate_from(socket->m_peer, &from, fromlen);
       socket->m_error = GSOCK_MEMERR;
       return -1;
     }
   }
   err = _GAddress_translate_from(socket->m_peer, &from, fromlen);

-  if (err != GSOCK_NOERROR) {
+  if (err != GSOCK_NOERROR)
+  {

     GAddress_destroy(socket->m_peer);
     socket->m_peer  = NULL;
     socket->m_error = err;
     GAddress_destroy(socket->m_peer);
     socket->m_peer  = NULL;
     socket->m_error = err;


@@ -808,25 +1215,11 @@ int _GSocket_Recv_Dgram(GSocket *socket, char *buffer, int size)
 int _GSocket_Send_Stream(GSocket *socket, const char *buffer, int size)
 {
   int ret;
 int _GSocket_Send_Stream(GSocket *socket, const char *buffer, int size)
 {
   int ret;

-  GSocketError err;

 
   MASK_SIGNAL();
 
   MASK_SIGNAL();

-  ENABLE_TIMEOUT(socket);

   ret = send(socket->m_fd, buffer, size, 0);
   ret = send(socket->m_fd, buffer, size, 0);

-  DISABLE_TIMEOUT(socket);

   UNMASK_SIGNAL();
   UNMASK_SIGNAL();

-  if (ret == -1 && errno != EWOULDBLOCK && errno != ETIMEDOUT && errno != EINTR) {
-    socket->m_error = GSOCK_IOERR;
-    return -1;
-  }
-  if (errno == EWOULDBLOCK) {
-    socket->m_error = GSOCK_WOULDBLOCK;
-    return -1;
-  }
-  if (errno == ETIMEDOUT || errno == EINTR) {
-    socket->m_error = GSOCK_TIMEDOUT;
-    return -1;
-  }
+

   return ret;
 }
 
   return ret;
 }
 


@@ -836,78 +1229,105 @@ int _GSocket_Send_Dgram(GSocket *socket, const char *buffer, int size)
   int len, ret;
   GSocketError err;
 
   int len, ret;
   GSocketError err;
 

-  if (!socket->m_peer) {
+  if (!socket->m_peer)
+  {

     socket->m_error = GSOCK_INVADDR;
     return -1;
   }
 
   err = _GAddress_translate_to(socket->m_peer, &addr, &len);
     socket->m_error = GSOCK_INVADDR;
     return -1;
   }
 
   err = _GAddress_translate_to(socket->m_peer, &addr, &len);

-  if (err != GSOCK_NOERROR) {
+  if (err != GSOCK_NOERROR)
+  {

     socket->m_error = err;
     return -1;
   }
 
   MASK_SIGNAL();
     socket->m_error = err;
     return -1;
   }
 
   MASK_SIGNAL();

-  ENABLE_TIMEOUT(socket);

   ret = sendto(socket->m_fd, buffer, size, 0, addr, len);
   ret = sendto(socket->m_fd, buffer, size, 0, addr, len);

-  DISABLE_TIMEOUT(socket);

   UNMASK_SIGNAL();
 
   /* Frees memory allocated from _GAddress_translate_to */
   free(addr);
 
   UNMASK_SIGNAL();
 
   /* Frees memory allocated from _GAddress_translate_to */
   free(addr);
 

-  if (ret == -1 && errno != EWOULDBLOCK) {
-    socket->m_error = GSOCK_IOERR;
-    return -1;
-  }
-  if (errno == EWOULDBLOCK) {
-    socket->m_error = GSOCK_WOULDBLOCK;
-    return -1;
-  }
-

   return ret;
 }
 
 void _GSocket_Detected_Read(GSocket *socket)
 {
   char c;
   return ret;
 }
 
 void _GSocket_Detected_Read(GSocket *socket)
 {
   char c;

-  int ret;

 
 

-  if (socket->m_stream) {
-    ret = recv(socket->m_fd, &c, 1, MSG_PEEK);
+  /* If we have already detected a LOST event, then don't try
+   * to do any further processing.
+   */
+  if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+  {
+    socket->m_establishing = FALSE;

 
 

-    if (ret < 0 && socket->m_server) {
+    CALL_CALLBACK(socket, GSOCK_LOST);
+    GSocket_Shutdown(socket);
+    return;
+  }
+
+  if (recv(socket->m_fd, &c, 1, MSG_PEEK) > 0)
+  {
+    CALL_CALLBACK(socket, GSOCK_INPUT);
+  }
+  else
+  {
+    if (socket->m_server && socket->m_stream)
+    {

       CALL_CALLBACK(socket, GSOCK_CONNECTION);
       CALL_CALLBACK(socket, GSOCK_CONNECTION);

-      return;

     }
     }

-
-    if (ret > 0) {
-      CALL_CALLBACK(socket, GSOCK_INPUT);
-    } else {
+    else
+    {

       CALL_CALLBACK(socket, GSOCK_LOST);
       CALL_CALLBACK(socket, GSOCK_LOST);

+      GSocket_Shutdown(socket);

     }
   }
 }
 
 void _GSocket_Detected_Write(GSocket *socket)
 {
     }
   }
 }
 
 void _GSocket_Detected_Write(GSocket *socket)
 {

-  if (socket->m_establishing) {
-    int error, len;
+  /* If we have already detected a LOST event, then don't try
+   * to do any further processing.
+   */
+  if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+  {
+    socket->m_establishing = FALSE;

 
 

-    len = sizeof(error);
+    CALL_CALLBACK(socket, GSOCK_LOST);
+    GSocket_Shutdown(socket);
+    return;
+  }
+
+  if (socket->m_establishing && !socket->m_server)
+  {
+    int error;
+    SOCKLEN_T len = sizeof(error);

 
     socket->m_establishing = FALSE;
 
     socket->m_establishing = FALSE;

-    getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, &error, &len);

 
 

-    if (error) {
-      socket->m_error = GSOCK_IOERR;
-      GSocket_Shutdown(socket);
-    } else
-      socket->m_error = GSOCK_NOERROR;
+    getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, (void*)&error, &len);

 
 

-    CALL_CALLBACK(socket, GSOCK_CONNECTION);
-  } else
+    if (error)
+    {
+      CALL_CALLBACK(socket, GSOCK_LOST);
+      GSocket_Shutdown(socket);
+    }
+    else
+    {
+      CALL_CALLBACK(socket, GSOCK_CONNECTION);
+      /* We have to fire this event by hand because CONNECTION (for clients)
+       * and OUTPUT are internally the same and we just disabled CONNECTION
+       * events with the above macro.
+       */
+      CALL_CALLBACK(socket, GSOCK_OUTPUT);
+    }
+  }
+  else
+  {

     CALL_CALLBACK(socket, GSOCK_OUTPUT);
     CALL_CALLBACK(socket, GSOCK_OUTPUT);

+  }

 }
 
 /*
 }
 
 /*


@@ -916,29 +1336,43 @@ void _GSocket_Detected_Write(GSocket *socket)
  * -------------------------------------------------------------------------
  */
 
  * -------------------------------------------------------------------------
  */
 

-/* CHECK_ADDRESS verifies that the current family is either GSOCK_NOFAMILY or
- * GSOCK_*family*. In case it is GSOCK_NOFAMILY, it initializes address to be
- * a GSOCK_*family*. In other cases, it returns GSOCK_INVADDR.
+/* CHECK_ADDRESS verifies that the current address family is either
+ * GSOCK_NOFAMILY or GSOCK_*family*, and if it is GSOCK_NOFAMILY, it
+ * initalizes it to be a GSOCK_*family*. In other cases, it returns
+ * an appropiate error code.
+ *
+ * CHECK_ADDRESS_RETVAL does the same but returning 'retval' on error.

  */
  */

-#define CHECK_ADDRESS(address, family, retval) \
-{ \
-  if (address->m_family == GSOCK_NOFAMILY) \
-    if (_GAddress_Init_##family(address) != GSOCK_NOERROR) {\
-      return address->m_error; \
-    }\
-  if (address->m_family != GSOCK_##family) {\
-    address->m_error = GSOCK_INVADDR; \
-    return retval; \
-  } \
+#define CHECK_ADDRESS(address, family)                              \
+{                                                                   \
+  if (address->m_family == GSOCK_NOFAMILY)                          \
+    if (_GAddress_Init_##family(address) != GSOCK_NOERROR)          \
+      return address->m_error;                                      \
+  if (address->m_family != GSOCK_##family)                          \
+  {                                                                 \
+    address->m_error = GSOCK_INVADDR;                               \
+    return GSOCK_INVADDR;                                           \
+  }                                                                 \

 }
 
 }
 

-GAddress *GAddress_new()
+#define CHECK_ADDRESS_RETVAL(address, family, retval)               \
+{                                                                   \
+  if (address->m_family == GSOCK_NOFAMILY)                          \
+    if (_GAddress_Init_##family(address) != GSOCK_NOERROR)          \
+      return retval;                                                \
+  if (address->m_family != GSOCK_##family)                          \
+  {                                                                 \
+    address->m_error = GSOCK_INVADDR;                               \
+    return retval;                                                  \
+  }                                                                 \
+}
+
+
+GAddress *GAddress_new(void)

 {
   GAddress *address;
 
 {
   GAddress *address;
 

-  address = (GAddress *)malloc(sizeof(GAddress));
-
-  if (address == NULL)
+  if ((address = (GAddress *) malloc(sizeof(GAddress))) == NULL)

     return NULL;
 
   address->m_family  = GSOCK_NOFAMILY;
     return NULL;
 
   address->m_family  = GSOCK_NOFAMILY;


@@ -954,16 +1388,16 @@ GAddress *GAddress_copy(GAddress *address)
 
   assert(address != NULL);
 
 
   assert(address != NULL);
 

-  addr2 = (GAddress *)malloc(sizeof(GAddress));
-
-  if (addr2 == NULL)
+  if ((addr2 = (GAddress *) malloc(sizeof(GAddress))) == NULL)

     return NULL;
 
   memcpy(addr2, address, sizeof(GAddress));
 
     return NULL;
 
   memcpy(addr2, address, sizeof(GAddress));
 

-  if (address->m_addr) {
+  if (address->m_addr && address->m_len > 0)
+  {

     addr2->m_addr = (struct sockaddr *)malloc(addr2->m_len);
     addr2->m_addr = (struct sockaddr *)malloc(addr2->m_len);

-    if (addr2->m_addr == NULL) {
+    if (addr2->m_addr == NULL)
+    {

       free(addr2);
       return NULL;
     }
       free(addr2);
       return NULL;
     }


@@ -977,6 +1411,9 @@ void GAddress_destroy(GAddress *address)
 {
   assert(address != NULL);
 
 {
   assert(address != NULL);
 

+  if (address->m_addr)
+    free(address->m_addr);
+

   free(address);
 }
 
   free(address);
 }
 


@@ -994,24 +1431,27 @@ GAddressType GAddress_GetFamily(GAddress *address)
   return address->m_family;
 }
 
   return address->m_family;
 }
 

-GSocketError _GAddress_translate_from(GAddress *address, struct sockaddr *addr, int len){
+GSocketError _GAddress_translate_from(GAddress *address,
+                                      struct sockaddr *addr, int len)
+{

   address->m_realfamily = addr->sa_family;
   address->m_realfamily = addr->sa_family;

-  switch (addr->sa_family) {
-  case AF_INET:
-    address->m_family = GSOCK_INET;
-    break;
-  case AF_UNIX:
-    address->m_family = GSOCK_UNIX;
-    break;
+  switch (addr->sa_family)
+  {
+    case AF_INET:
+      address->m_family = GSOCK_INET;
+      break;
+    case AF_UNIX:
+      address->m_family = GSOCK_UNIX;
+      break;

 #ifdef AF_INET6
 #ifdef AF_INET6

-  case AF_INET6:
-    address->m_family = GSOCK_INET6;
-    break;
+    case AF_INET6:
+      address->m_family = GSOCK_INET6;
+      break;

 #endif
 #endif

-  default:
+    default:

     {
     {

-    address->m_error = GSOCK_INVOP;
-    return GSOCK_INVOP;
+      address->m_error = GSOCK_INVOP;
+      return GSOCK_INVOP;

     }
   }
 
     }
   }
 


@@ -1020,7 +1460,9 @@ GSocketError _GAddress_translate_from(GAddress *address, struct sockaddr *addr,
 
   address->m_len  = len;
   address->m_addr = (struct sockaddr *)malloc(len);
 
   address->m_len  = len;
   address->m_addr = (struct sockaddr *)malloc(len);

-  if (address->m_addr == NULL) {
+
+  if (address->m_addr == NULL)
+  {

     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }


@@ -1032,14 +1474,16 @@ GSocketError _GAddress_translate_from(GAddress *address, struct sockaddr *addr,
 GSocketError _GAddress_translate_to(GAddress *address,
                                     struct sockaddr **addr, int *len)
 {
 GSocketError _GAddress_translate_to(GAddress *address,
                                     struct sockaddr **addr, int *len)
 {

-  if (!address->m_addr) {
+  if (!address->m_addr)
+  {

     address->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 
   *len = address->m_len;
   *addr = (struct sockaddr *)malloc(address->m_len);
     address->m_error = GSOCK_INVADDR;
     return GSOCK_INVADDR;
   }
 
   *len = address->m_len;
   *addr = (struct sockaddr *)malloc(address->m_len);

-  if (*addr == NULL) {
+  if (*addr == NULL)
+  {

     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }


@@ -1056,18 +1500,18 @@ GSocketError _GAddress_translate_to(GAddress *address,
 
 GSocketError _GAddress_Init_INET(GAddress *address)
 {
 
 GSocketError _GAddress_Init_INET(GAddress *address)
 {

-  address->m_addr = (struct sockaddr *)malloc(sizeof(struct sockaddr_in));
-  if (address->m_addr == NULL) {
+  address->m_len  = sizeof(struct sockaddr_in);
+  address->m_addr = (struct sockaddr *) malloc(address->m_len);
+  if (address->m_addr == NULL)
+  {

     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
 
     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
 

-  address->m_len  = sizeof(struct sockaddr_in);
-

   address->m_family = GSOCK_INET;
   address->m_realfamily = PF_INET;
   ((struct sockaddr_in *)address->m_addr)->sin_family = AF_INET;
   address->m_family = GSOCK_INET;
   address->m_realfamily = PF_INET;
   ((struct sockaddr_in *)address->m_addr)->sin_family = AF_INET;

-  ((struct sockaddr_in *)address->m_addr)->sin_addr.s_addr   = INADDR_ANY;
+  ((struct sockaddr_in *)address->m_addr)->sin_addr.s_addr = INADDR_ANY;

 
   return GSOCK_NOERROR;
 }
 
   return GSOCK_NOERROR;
 }


@@ -1079,24 +1523,29 @@ GSocketError GAddress_INET_SetHostName(GAddress *address, const char *hostname)
 
   assert(address != NULL);
 
 
   assert(address != NULL);
 

-  CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, INET);

 
   addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
 
   /* If it is a numeric host name, convert it now */
 #if defined(HAVE_INET_ATON)
 
   addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
 
   /* If it is a numeric host name, convert it now */
 #if defined(HAVE_INET_ATON)

-  if (inet_aton(hostname, addr) == 0) {
+  if (inet_aton(hostname, addr) == 0)
+  {

 #elif defined(HAVE_INET_ADDR)
 #elif defined(HAVE_INET_ADDR)

-  /* Fix from Guillermo Rodriguez Garcia <guille@iies.es> */
-  if ( (addr->s_addr = inet_addr(hostname)) == -1 ) {
+  if ( (addr->s_addr = inet_addr(hostname)) == -1 )
+  {

 #else
   /* Use gethostbyname by default */
 #else
   /* Use gethostbyname by default */

-  if (1) {
+  if (1)
+  {

 #endif
     struct in_addr *array_addr;
 
     /* It is a real name, we solve it */
 #endif
     struct in_addr *array_addr;
 
     /* It is a real name, we solve it */

-    if ((he = gethostbyname(hostname)) == NULL) {
+    if ((he = gethostbyname(hostname)) == NULL)
+    {
+      /* Reset to invalid address */
+      addr->s_addr = INADDR_NONE;

       address->m_error = GSOCK_NOHOST;
       return GSOCK_NOHOST;
     }
       address->m_error = GSOCK_NOHOST;
       return GSOCK_NOHOST;
     }


@@ -1106,6 +1555,11 @@ GSocketError GAddress_INET_SetHostName(GAddress *address, const char *hostname)
   return GSOCK_NOERROR;
 }
 
   return GSOCK_NOERROR;
 }
 

+GSocketError GAddress_INET_SetAnyAddress(GAddress *address)
+{
+  return GAddress_INET_SetHostAddress(address, INADDR_ANY);
+}
+

 GSocketError GAddress_INET_SetHostAddress(GAddress *address,
                                           unsigned long hostaddr)
 {
 GSocketError GAddress_INET_SetHostAddress(GAddress *address,
                                           unsigned long hostaddr)
 {


@@ -1113,7 +1567,7 @@ GSocketError GAddress_INET_SetHostAddress(GAddress *address,
 
   assert(address != NULL);
 
 
   assert(address != NULL);
 

-  CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, INET);

 
   addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
   addr->s_addr = hostaddr;
 
   addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
   addr->s_addr = hostaddr;


@@ -1128,16 +1582,21 @@ GSocketError GAddress_INET_SetPortName(GAddress *address, const char *port,
   struct sockaddr_in *addr;
 
   assert(address != NULL);
   struct sockaddr_in *addr;
 
   assert(address != NULL);

-  CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, INET);

 
 

-  if (!port) {
+  if (!port)
+  {

     address->m_error = GSOCK_INVPORT;
     return GSOCK_INVPORT;
   }
  
   se = getservbyname(port, protocol);
     address->m_error = GSOCK_INVPORT;
     return GSOCK_INVPORT;
   }
  
   se = getservbyname(port, protocol);

-  if (!se) {
-    if (isdigit(port[0])) {
+  if (!se)
+  {
+    /* the cast to int suppresses compiler warnings about subscript having the
+       type char */
+    if (isdigit((int)port[0]))
+    {

       int port_int;
 
       port_int = atoi(port);
       int port_int;
 
       port_int = atoi(port);


@@ -1161,7 +1620,7 @@ GSocketError GAddress_INET_SetPort(GAddress *address, unsigned short port)
   struct sockaddr_in *addr;
 
   assert(address != NULL);
   struct sockaddr_in *addr;
 
   assert(address != NULL);

-  CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, INET);

  
   addr = (struct sockaddr_in *)address->m_addr;
   addr->sin_port = htons(port);
  
   addr = (struct sockaddr_in *)address->m_addr;
   addr->sin_port = htons(port);


@@ -1176,13 +1635,14 @@ GSocketError GAddress_INET_GetHostName(GAddress *address, char *hostname, size_t
   struct sockaddr_in *addr;
 
   assert(address != NULL); 
   struct sockaddr_in *addr;
 
   assert(address != NULL); 

-  CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, INET);

 
   addr = (struct sockaddr_in *)address->m_addr;
   addr_buf = (char *)&(addr->sin_addr);
 
 
   addr = (struct sockaddr_in *)address->m_addr;
   addr_buf = (char *)&(addr->sin_addr);
 

-  he       = gethostbyaddr(addr_buf, sizeof(addr->sin_addr), AF_INET);
-  if (he == NULL) {
+  he = gethostbyaddr(addr_buf, sizeof(addr->sin_addr), AF_INET);
+  if (he == NULL)
+  {

     address->m_error = GSOCK_NOHOST;
     return GSOCK_NOHOST;
   }
     address->m_error = GSOCK_NOHOST;
     return GSOCK_NOHOST;
   }


@@ -1197,7 +1657,7 @@ unsigned long GAddress_INET_GetHostAddress(GAddress *address)
   struct sockaddr_in *addr;
 
   assert(address != NULL); 
   struct sockaddr_in *addr;
 
   assert(address != NULL); 

-  CHECK_ADDRESS(address, INET, 0); 
+  CHECK_ADDRESS_RETVAL(address, INET, 0); 

 
   addr = (struct sockaddr_in *)address->m_addr;
 
 
   addr = (struct sockaddr_in *)address->m_addr;
 


@@ -1209,7 +1669,7 @@ unsigned short GAddress_INET_GetPort(GAddress *address)
   struct sockaddr_in *addr;
 
   assert(address != NULL); 
   struct sockaddr_in *addr;
 
   assert(address != NULL); 

-  CHECK_ADDRESS(address, INET, 0); 
+  CHECK_ADDRESS_RETVAL(address, INET, 0); 

 
   addr = (struct sockaddr_in *)address->m_addr;
   return ntohs(addr->sin_port);
 
   addr = (struct sockaddr_in *)address->m_addr;
   return ntohs(addr->sin_port);


@@ -1223,31 +1683,35 @@ unsigned short GAddress_INET_GetPort(GAddress *address)
 
 GSocketError _GAddress_Init_UNIX(GAddress *address)
 {
 
 GSocketError _GAddress_Init_UNIX(GAddress *address)
 {

+  address->m_len  = sizeof(struct sockaddr_un);

   address->m_addr = (struct sockaddr *)malloc(address->m_len);
   address->m_addr = (struct sockaddr *)malloc(address->m_len);

-  if (address->m_addr == NULL) {
+  if (address->m_addr == NULL)
+  {

     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
 
     address->m_error = GSOCK_MEMERR;
     return GSOCK_MEMERR;
   }
 

-  address->m_len  = sizeof(struct sockaddr_un);

   address->m_family = GSOCK_UNIX;
   address->m_realfamily = PF_UNIX;
   ((struct sockaddr_un *)address->m_addr)->sun_family = AF_UNIX;
   ((struct sockaddr_un *)address->m_addr)->sun_path[0] = 0;
 
   address->m_family = GSOCK_UNIX;
   address->m_realfamily = PF_UNIX;
   ((struct sockaddr_un *)address->m_addr)->sun_family = AF_UNIX;
   ((struct sockaddr_un *)address->m_addr)->sun_path[0] = 0;
 

-  return TRUE;
+  return GSOCK_NOERROR;

 }
 
 }
 

+#define UNIX_SOCK_PATHLEN (sizeof(addr->sun_path)/sizeof(addr->sun_path[0]))
+

 GSocketError GAddress_UNIX_SetPath(GAddress *address, const char *path)
 {
   struct sockaddr_un *addr;
 
   assert(address != NULL); 
 
 GSocketError GAddress_UNIX_SetPath(GAddress *address, const char *path)
 {
   struct sockaddr_un *addr;
 
   assert(address != NULL); 
 

-  CHECK_ADDRESS(address, UNIX, GSOCK_INVADDR); 
+  CHECK_ADDRESS(address, UNIX); 

 
   addr = ((struct sockaddr_un *)address->m_addr);
 
   addr = ((struct sockaddr_un *)address->m_addr);

-  memcpy(addr->sun_path, path, strlen(path));
+  strncpy(addr->sun_path, path, UNIX_SOCK_PATHLEN);
+  addr->sun_path[UNIX_SOCK_PATHLEN - 1] = '\0';

 
   return GSOCK_NOERROR;
 }
 
   return GSOCK_NOERROR;
 }


@@ -1257,7 +1721,7 @@ GSocketError GAddress_UNIX_GetPath(GAddress *address, char *path, size_t sbuf)
   struct sockaddr_un *addr;
 
   assert(address != NULL);
   struct sockaddr_un *addr;
 
   assert(address != NULL);

-  CHECK_ADDRESS(address, UNIX, GSOCK_INVADDR);
+  CHECK_ADDRESS(address, UNIX);

 
   addr = (struct sockaddr_un *)address->m_addr;
 
 
   addr = (struct sockaddr_un *)address->m_addr;
 


@@ -1266,5 +1730,5 @@ GSocketError GAddress_UNIX_GetPath(GAddress *address, char *path, size_t sbuf)
   return GSOCK_NOERROR;
 }
 
   return GSOCK_NOERROR;
 }
 

-#endif
-  /* wxUSE_SOCKETS */
+#endif  /* wxUSE_SOCKETS || defined(__GSOCKET_STANDALONE__) */
+