#include "wx/settings.h"
#endif
-#include "wx/msw/private.h"
+#include "wx/dynlib.h"
-#if wxUSE_EXTENDED_RTTI
-WX_DEFINE_FLAGS( wxChoiceStyle )
-
-wxBEGIN_FLAGS( wxChoiceStyle )
- // new style border flags, we put them first to
- // use them for streaming out
- wxFLAGS_MEMBER(wxBORDER_SIMPLE)
- wxFLAGS_MEMBER(wxBORDER_SUNKEN)
- wxFLAGS_MEMBER(wxBORDER_DOUBLE)
- wxFLAGS_MEMBER(wxBORDER_RAISED)
- wxFLAGS_MEMBER(wxBORDER_STATIC)
- wxFLAGS_MEMBER(wxBORDER_NONE)
-
- // old style border flags
- wxFLAGS_MEMBER(wxSIMPLE_BORDER)
- wxFLAGS_MEMBER(wxSUNKEN_BORDER)
- wxFLAGS_MEMBER(wxDOUBLE_BORDER)
- wxFLAGS_MEMBER(wxRAISED_BORDER)
- wxFLAGS_MEMBER(wxSTATIC_BORDER)
- wxFLAGS_MEMBER(wxBORDER)
-
- // standard window styles
- wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
- wxFLAGS_MEMBER(wxCLIP_CHILDREN)
- wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
- wxFLAGS_MEMBER(wxWANTS_CHARS)
- wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
- wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
- wxFLAGS_MEMBER(wxVSCROLL)
- wxFLAGS_MEMBER(wxHSCROLL)
-
-wxEND_FLAGS( wxChoiceStyle )
-
-IMPLEMENT_DYNAMIC_CLASS_XTI(wxChoice, wxControlWithItems,"wx/choice.h")
-
-wxBEGIN_PROPERTIES_TABLE(wxChoice)
- wxEVENT_PROPERTY( Select , wxEVT_COMMAND_CHOICE_SELECTED , wxCommandEvent )
-
- wxPROPERTY( Font , wxFont , SetFont , GetFont , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
- wxPROPERTY_COLLECTION( Choices , wxArrayString , wxString , AppendString , GetStrings , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
- wxPROPERTY( Selection ,int, SetSelection, GetSelection, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
- wxPROPERTY_FLAGS( WindowStyle , wxChoiceStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
-wxEND_PROPERTIES_TABLE()
-
-wxBEGIN_HANDLERS_TABLE(wxChoice)
-wxEND_HANDLERS_TABLE()
-
-wxCONSTRUCTOR_4( wxChoice , wxWindow* , Parent , wxWindowID , Id , wxPoint , Position , wxSize , Size )
-#else
-IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControlWithItems)
-#endif
-/*
- TODO PROPERTIES
- selection (long)
- content (list)
- item
-*/
+#include "wx/msw/private.h"
// ============================================================================
// implementation
// initialize the controls contents
- for ( int i = 0; i < n; i++ )
- {
- Append(choices[i]);
- }
+ Append(n, choices);
// and now we may finally size the control properly (if needed)
SetInitialSize(size);
// FIXME: Use better dummy window?
wxWindow* wnd = wxTheApp->GetTopWindow();
+ if (!wnd)
+ return attrs;
attrs.font = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
// NB: use EDIT, not COMBOBOX (the latter works in XP but not Vista)
attrs.colBg = wnd->MSWGetThemeColour(L"EDIT",
- EP_EDITTEXT,
+ EP_EDITTEXT,
ETS_NORMAL,
ThemeColourBackground,
wxSYS_COLOUR_WINDOW);
Clear();
}
+bool wxChoice::MSWGetComboBoxInfo(tagCOMBOBOXINFO* info) const
+{
+ // TODO-Win9x: Get rid of this once we officially drop support for Win9x
+ // and just call the function directly.
+#if wxUSE_DYNLIB_CLASS
+ typedef BOOL (WINAPI *GetComboBoxInfo_t)(HWND, tagCOMBOBOXINFO*);
+ static GetComboBoxInfo_t s_pfnGetComboBoxInfo = NULL;
+ static bool s_triedToLoad = false;
+ if ( !s_triedToLoad )
+ {
+ s_triedToLoad = true;
+ wxLoadedDLL dllUser32("user32.dll");
+ wxDL_INIT_FUNC(s_pfn, GetComboBoxInfo, dllUser32);
+ }
+
+ if ( s_pfnGetComboBoxInfo )
+ return (*s_pfnGetComboBoxInfo)(GetHwnd(), info) != 0;
+#endif // wxUSE_DYNLIB_CLASS
+
+ return false;
+}
+
// ----------------------------------------------------------------------------
// adding/deleting items to/from the list
// ----------------------------------------------------------------------------
else
{
int pos = (int)SendMessage(GetHwnd(), CB_FINDSTRINGEXACT,
- (WPARAM)-1, (LPARAM)s.wx_str());
+ (WPARAM)-1, wxMSW_CONV_LPARAM(s));
return pos == LB_ERR ? wxNOT_FOUND : pos;
}
else if ( HasClientObjectData() )
oldObjData = GetClientObject(n);
+ // and also the selection if we're going to delete the item that was
+ // selected
+ const bool wasSelected = static_cast<int>(n) == GetSelection();
+
::SendMessage(GetHwnd(), CB_DELETESTRING, n, 0);
- ::SendMessage(GetHwnd(), CB_INSERTSTRING, n, (LPARAM)s.wx_str() );
+ ::SendMessage(GetHwnd(), CB_INSERTSTRING, n, wxMSW_CONV_LPARAM(s) );
// restore the client data
if ( oldData )
else if ( oldObjData )
SetClientObject(n, oldObjData);
+ // and the selection
+ if ( wasSelected )
+ SetSelection(n);
+
+ // the width could have changed so the best size needs to be recomputed
InvalidateBestSize();
}
void* wxChoice::DoGetItemClientData(unsigned int n) const
{
LPARAM rc = SendMessage(GetHwnd(), CB_GETITEMDATA, n, 0);
- if ( rc == CB_ERR )
+ if ( rc == CB_ERR && GetLastError() != ERROR_SUCCESS )
{
wxLogLastError(wxT("CB_GETITEMDATA"));
int width, int height,
int sizeFlags)
{
+ const int heightBest = GetBestSize().y;
+
// we need the real height below so get the current one if it's not given
- if ( height != wxDefaultCoord && height != GetBestSize().y )
+ if ( height == wxDefaultCoord )
+ {
+ // height not specified, use the same as before
+ DoGetSize(NULL, &height);
+ }
+ else if ( height == heightBest )
+ {
+ // we don't need to manually manage our height, let the system use the
+ // default one
+ m_heightOwn = wxDefaultCoord;
+ }
+ else // non-default height specified
{
// set our new own height but be careful not to make it too big: the
// native control apparently stores it as a single byte and so setting
else if ( m_heightOwn < COMBO_HEIGHT_ADJ )
m_heightOwn = COMBO_HEIGHT_ADJ;
}
- else // height not specified
- {
- DoGetSize(NULL, &height);
- }
// the height which we must pass to Windows should be the total height of
const int hItem = SendMessage(GetHwnd(), CB_GETITEMHEIGHT, 0, 0);
int heightWithItems = 0;
if (!HasFlag(wxCB_SIMPLE))
- heightWithItems = height + hItem*nItems;
+ // The extra item (" + 1") is required to prevent a vertical
+ // scrollbar from appearing with comctl32.dll versions earlier
+ // than 6.0 (such as found in Win2k).
+ heightWithItems = height + hItem*(nItems + 1);
else
heightWithItems = SetHeightSimpleComboBox(nItems);
// make the control itself of the requested height: notice that this
// must be done after changing its size or it has no effect (apparently
// the height is reset to default during the control layout) and that it's
- // useless to to do it when using the deferred sizing -- in this case it
+ // useless to do it when using the deferred sizing -- in this case it
// will be done from MSWEndDeferWindowPos()
#if wxUSE_DEFERRED_SIZING
if ( m_pendingSize == wxDefaultSize )
wxSize wxChoice::DoGetBestSize() const
{
- // find the widest string
- int wChoice = 0;
- int hChoice;
- const unsigned int nItems = GetCount();
- for ( unsigned int i = 0; i < nItems; i++ )
- {
- int wLine;
- GetTextExtent(GetString(i), &wLine, NULL);
- if ( wLine > wChoice )
- wChoice = wLine;
- }
+ // The base version returns the size of the largest string
+ return GetSizeFromTextSize(wxChoiceBase::DoGetBestSize().x);
+}
+
+int wxChoice::SetHeightSimpleComboBox(int nItems) const
+{
+ int cx, cy;
+ wxGetCharSize( GetHWND(), &cx, &cy, GetFont() );
+ int hItem = SendMessage(GetHwnd(), CB_GETITEMHEIGHT, (WPARAM)-1, 0);
+ return EDIT_HEIGHT_FROM_CHAR_HEIGHT( cy ) * wxMin( wxMax( nItems, 3 ), 6 ) + hItem - 1;
+}
- // give it some reasonable default value if there are no strings in the
- // list
- if ( wChoice == 0 )
- wChoice = 100;
+wxSize wxChoice::DoGetSizeFromTextSize(int xlen, int ylen) const
+{
+ int cHeight = GetCharHeight();
- // the combobox should be slightly larger than the widest string
- wChoice += 5*GetCharWidth();
- if( HasFlag( wxCB_SIMPLE ) )
+ // We are interested in the difference of sizes between the whole control
+ // and its child part. I.e. arrow, separators, etc.
+ wxSize tsize(xlen, 0);
+
+ // FIXME-VC6: Only VC6 needs this guard, see WINVER definition in
+ // include/wx/msw/wrapwin.h
+#if defined(WINVER) && WINVER >= 0x0500
+ WinStruct<COMBOBOXINFO> info;
+ if ( MSWGetComboBoxInfo(&info) )
+ {
+ tsize.x += info.rcItem.left + info.rcButton.right - info.rcItem.right
+ + info.rcItem.left + 3; // right and extra margins
+ }
+ else // Just use some rough approximation.
+#endif // WINVER >= 0x0500
{
- hChoice = SetHeightSimpleComboBox( nItems );
+ tsize.x += 4*cHeight;
}
+
+ // set height on our own
+ if( HasFlag( wxCB_SIMPLE ) )
+ tsize.y = SetHeightSimpleComboBox(GetCount());
else
- hChoice = EDIT_HEIGHT_FROM_CHAR_HEIGHT(GetCharHeight());
+ tsize.y = EDIT_HEIGHT_FROM_CHAR_HEIGHT(cHeight);
- wxSize best(wChoice, hChoice);
- CacheBestSize(best);
- return best;
+ // Perhaps the user wants something different from CharHeight
+ if ( ylen > 0 )
+ tsize.IncBy(0, ylen - cHeight);
+
+ return tsize;
}
-int wxChoice::SetHeightSimpleComboBox(int nItems) const
+// ----------------------------------------------------------------------------
+// Popup operations
+// ----------------------------------------------------------------------------
+
+void wxChoice::MSWDoPopupOrDismiss(bool show)
{
- int cx, cy;
- wxGetCharSize( GetHWND(), &cx, &cy, GetFont() );
- int hItem = SendMessage(GetHwnd(), CB_GETITEMHEIGHT, (WPARAM)-1, 0);
- return EDIT_HEIGHT_FROM_CHAR_HEIGHT( cy ) * wxMin( wxMax( nItems, 3 ), 6 ) + hItem - 1;
+ wxASSERT_MSG( !HasFlag(wxCB_SIMPLE),
+ wxT("can't popup/dismiss the list for simple combo box") );
+
+ // we *must* set focus to the combobox before showing or hiding the drop
+ // down as without this we get WM_LBUTTONDOWN messages with invalid HWND
+ // when hiding it (whether programmatically or manually) resulting in a
+ // crash when we pass them to IsDialogMessage()
+ //
+ // this can be seen in the combo page of the widgets sample under Windows 7
+ SetFocus();
+
+ ::SendMessage(GetHwnd(), CB_SHOWDROPDOWN, show, 0);
+}
+
+bool wxChoice::Show(bool show)
+{
+ if ( !wxChoiceBase::Show(show) )
+ return false;
+
+ // When hiding the combobox, we also need to hide its popup part as it
+ // doesn't happen automatically.
+ if ( !show && ::SendMessage(GetHwnd(), CB_GETDROPPEDSTATE, 0, 0) )
+ MSWDoPopupOrDismiss(false);
+
+ return true;
}
// ----------------------------------------------------------------------------
/*
The native control provides a great variety in the events it sends in
the different selection scenarios (undoubtedly for greater amusement of
- the programmers using it). For the reference, here are the cases when
- the final selection is accepted (things are quite interesting when it
- is cancelled too):
+ the programmers using it). Here are the different cases:
A. Selecting with just the arrows without opening the dropdown:
1. CBN_SELENDOK
Admire the different order of messages in all of those cases, it must
surely have taken a lot of effort to Microsoft developers to achieve
such originality.
+
+ Additionally, notice that CBN_SELENDCANCEL doesn't seem to actually
+ cancel anything, if we get CBN_SELCHANGE before it, as it happens in
+ the case (B), the selection is still accepted. This doesn't make much
+ sense and directly contradicts MSDN documentation but is how the native
+ comboboxes behave and so we do the same thing.
*/
switch ( param )
{
break;
case CBN_CLOSEUP:
- // if the selection was accepted by the user, it should have been
- // reset to wxID_NONE by CBN_SELENDOK, otherwise the selection was
- // cancelled and we must restore the old one
- if ( m_lastAcceptedSelection != wxID_NONE )
+ if ( m_pendingSelection != wxID_NONE )
{
- SetSelection(m_lastAcceptedSelection);
- m_lastAcceptedSelection = wxID_NONE;
+ // This can only happen in the case (B), so set the item
+ // selected in the drop down as our real selection.
+ SendSelectionChangedEvent(wxEVT_CHOICE);
+ m_pendingSelection = wxID_NONE;
}
break;
case CBN_SELENDOK:
- // reset it to prevent CBN_CLOSEUP from undoing the selection (it's
- // ok to reset it now as GetCurrentSelection() will now return the
- // same thing anyhow)
- m_lastAcceptedSelection = wxID_NONE;
+ // Reset the variables to prevent CBN_CLOSEUP from doing anything,
+ // it's not needed if we do get CBN_SELENDOK.
+ m_lastAcceptedSelection =
+ m_pendingSelection = wxID_NONE;
- {
- const int n = GetSelection();
-
- wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, m_windowId);
- event.SetInt(n);
- event.SetEventObject(this);
-
- if ( n > -1 )
- {
- event.SetString(GetStringSelection());
- InitCommandEventWithItems(event, n);
- }
-
- ProcessCommand(event);
- }
+ SendSelectionChangedEvent(wxEVT_CHOICE);
break;
- // don't handle CBN_SELENDCANCEL: just leave m_lastAcceptedSelection
- // valid and the selection will be undone in CBN_CLOSEUP above
+ case CBN_SELCHANGE:
+ // If we get this event after CBN_SELENDOK, i.e. cases (A) or (C)
+ // above, we don't have anything to do. But in the case (B) we need
+ // to remember that the selection should really change once the
+ // drop down is closed.
+ if ( m_lastAcceptedSelection != wxID_NONE )
+ m_pendingSelection = GetCurrentSelection();
+ break;
- // don't handle CBN_SELCHANGE neither, we don't want to generate events
- // while the dropdown is opened -- but do add it if we ever need this
+ case CBN_SELENDCANCEL:
+ // Do not reset m_pendingSelection here -- it would make sense but,
+ // as described above, native controls keep the selection even when
+ // closing the drop down by pressing Escape or TAB, so conform to
+ // their behaviour.
+ m_lastAcceptedSelection = wxID_NONE;
+ break;
default:
return false;
WXHBRUSH wxChoice::MSWControlColor(WXHDC hDC, WXHWND hWnd)
{
- if ( !IsEnabled() )
+ if ( !IsThisEnabled() )
return MSWControlColorDisabled(hDC);
return wxChoiceBase::MSWControlColor(hDC, hWnd);
projects / wxWidgets.git / blobdiff