really show the window after creation (calling Show(TRUE) doesn't do it any more)

[wxWidgets.git] / src / common / choiccmn.cpp

diff --git a/src/common/choiccmn.cpp b/src/common/choiccmn.cpp
index 9f5dfeade9af6fa7c78533b0877ebacea7efd1de..9fc8861528cfc41c81608adeafdb705bf4cf29ef 100644 (file)
--- a/src/common/choiccmn.cpp
+++ b/src/common/choiccmn.cpp
@@ -6,7 +6,7 @@
 // Created:     26.07.99
 // RCS-ID:      $Id$
 // Copyright:   (c) wxWindows team
-// Licence:     wxWindows license
+// Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // ============================================================================
@@ -17,7 +17,7 @@
 // headers
 // ----------------------------------------------------------------------------
 
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
     #pragma implementation "choicebase.h"
 #endif
 
@@ -28,90 +28,45 @@
     #pragma hdrstop
 #endif
 
+#if wxUSE_CHOICE
+
 #ifndef WX_PRECOMP
     #include "wx/choice.h"
-    #include "wx/log.h"
 #endif
 
 // ============================================================================
 // implementation
 // ============================================================================
 
-// ----------------------------------------------------------------------------
-// events
-// ----------------------------------------------------------------------------
-
-void wxChoiceBase::Command(wxCommandEvent &event)
+wxChoiceBase::~wxChoiceBase()
 {
-    SetSelection(event.GetInt());
-    (void)ProcessEvent(event);
+    // this destructor is required for Darwin
 }
 
 // ----------------------------------------------------------------------------
-// string selection management
+// selection
 // ----------------------------------------------------------------------------
 
-wxString wxChoiceBase::GetStringSelection() const
-{
-    int sel = GetSelection();
-    wxString str;
-    wxCHECK_MSG( sel != wxNOT_FOUND, str, _T("no selection, hence no string") );
-
-    str = GetString(sel);
-    return str;
-}
-
-bool wxChoiceBase::SetStringSelection(const wxString& sel)
+bool wxChoiceBase::SetStringSelection(const wxString& s)
 {
-    int selIndex = FindString(sel);
-    wxCHECK_MSG( selIndex != wxNOT_FOUND, FALSE,
-                 _T("can't set selection to string not in the control") );
+    int sel = FindString(s);
+    wxCHECK_MSG( sel != -1, FALSE,
+                 wxT("invalid string in wxChoice::SetStringSelection") );
 
-    SetSelection(selIndex);
+    Select(sel);
 
     return TRUE;
 }
 
 // ----------------------------------------------------------------------------
-// client data
+// misc
 // ----------------------------------------------------------------------------
 
-void wxChoiceBase::SetClientObject(int n, wxClientData *data)
-{
-    wxASSERT_MSG( m_clientDataItemsType != ClientData_Void,
-                  _T("can't have both object and void client data") );
-
-    wxClientData *clientDataOld = DoGetClientObject(n);
-    if ( clientDataOld )
-        delete clientDataOld;
-
-    DoSetClientObject(n, data);
-    m_clientDataItemsType = ClientData_Object;
-}
-
-wxClientData *wxChoiceBase::GetClientObject(int n) const
-{
-    wxASSERT_MSG( m_clientDataItemsType == ClientData_Object,
-                  _T("this window doesn't have object client data") );
-
-    return DoGetClientObject(n);
-}
-
-void wxChoiceBase::SetClientData(int n, void *data)
+void wxChoiceBase::Command(wxCommandEvent& event)
 {
-    wxASSERT_MSG( m_clientDataItemsType != ClientData_Object,
-                  _T("can't have both object and void client data") );
-
-    DoSetClientData(n, data);
-    m_clientDataItemsType = ClientData_Void;
-}
-
-void *wxChoiceBase::GetClientData(int n) const
-{
-    wxASSERT_MSG( m_clientDataItemsType == ClientData_Void,
-                  _T("this window doesn't have void client data") );
-
-    return DoGetClientData(n);
+    SetSelection(event.m_commandInt);
+    (void)ProcessEvent(event);
 }
 
+#endif // wxUSE_CHOICE