no message

[wxWidgets.git] / src / unix / dialup.cpp

diff --git a/src/unix/dialup.cpp b/src/unix/dialup.cpp
index 2dac8544b89e67ee3e155386c1556fb97098da2e..cec1aa24d1969f8c2566422d38754205b464023c 100644 (file)
--- a/src/unix/dialup.cpp
+++ b/src/unix/dialup.cpp
@@ -104,7 +104,7 @@ public:
    virtual bool IsOnline() const
       {
          if( (! m_timer) // we are not polling, so test now:
-             || m_IsOnline == -1
+             || m_IsOnline < 0
             )
             CheckStatus();
          return m_IsOnline != 0;
@@ -124,7 +124,7 @@ public:
    // NB: this won't result in DISCONNECTED event being sent
    virtual bool CancelDialing();
 
-   unsigned int GetISPNames(class wxArrayString &) const
+   size_t GetISPNames(class wxArrayString &) const
       { return 0; }
    
    // sometimes the built-in logic for determining the online status may fail,
@@ -228,10 +228,14 @@ public:
       {
          m_DupMan = dupman;
       }
+   void Disconnect(void) { m_DupMan = NULL; }
    void OnTerminate(int WXUNUSED(pid), int WXUNUSED(status)) const
       {
-         m_DupMan->m_DialProcess = NULL;
-         m_DupMan->CheckStatus(TRUE);
+         if(m_DupMan)
+         {
+            m_DupMan->m_DialProcess = NULL;
+            m_DupMan->CheckStatus(TRUE);
+         }
       }
 private:
       wxDialUpManagerImpl *m_DupMan;
@@ -240,7 +244,7 @@ private:
 
 wxDialUpManagerImpl::wxDialUpManagerImpl()
 {
-   m_IsOnline = -1; // unknown
+   m_IsOnline = -2; // -1 or -2, unknown
    m_DialProcess = NULL;
    m_timer = NULL;
    m_CanUseIfconfig = -1; // unknown
@@ -257,7 +261,11 @@ wxDialUpManagerImpl::wxDialUpManagerImpl()
 wxDialUpManagerImpl::~wxDialUpManagerImpl()
 {
    if(m_timer) delete m_timer;
-   if(m_DialProcess) m_DialProcess->Detach();
+   if(m_DialProcess)
+   {
+      m_DialProcess->Disconnect();
+      m_DialProcess->Detach();
+   }
 }
 
 bool
@@ -338,10 +346,12 @@ wxDialUpManagerImpl::EnableAutoCheckOnlineStatus(size_t nSeconds)
 void
 wxDialUpManagerImpl::DisableAutoCheckOnlineStatus()
 {
-   wxASSERT(m_timer != NULL);
-   m_timer->Stop();
-   delete m_timer;
-   m_timer = NULL;
+   if(m_timer != NULL)
+   {
+      m_timer->Stop();
+      delete m_timer;
+      m_timer = NULL;
+   }
 }
 
 
@@ -373,7 +383,7 @@ wxDialUpManagerImpl::CheckStatus(bool fromAsync) const
    ( /* non-const */ (wxDialUpManagerImpl *)this)->CheckStatusInternal();
 
    // now send the events as appropriate:
-   if(m_IsOnline != oldIsOnline && oldIsOnline != -1)
+   if(m_IsOnline != oldIsOnline && m_IsOnline != -1 && oldIsOnline != -2) // -2: first time!
    {
       wxDialUpEvent event(m_IsOnline, ! fromAsync);
       (void)wxTheApp->ProcessEvent(event);
@@ -421,30 +431,6 @@ wxDialUpManagerImpl::CheckStatusInternal(void)
          so we could let ifconfig write directly to the tmpfile, but
          this does not work. That should be faster, as it doesn´t call
          the shell first. I have no idea why. :-(  (KB) */
-#if 0
-      // temporarily redirect stdout/stderr:
-      int
-         new_stdout = dup(STDOUT_FILENO),
-         new_stderr = dup(STDERR_FILENO);
-      close(STDOUT_FILENO);
-      close(STDERR_FILENO);
-
-      int
-         // new stdout:
-         output_fd = open(tmpfile, O_CREAT|O_TRUNC, S_IRUSR|S_IWUSR),
-         // new stderr:
-         null_fd = open("/dev/null", O_CREAT, S_IRUSR|S_IWUSR);
-      // verify well behaved unix behaviour:
-      wxASSERT(output_fd == STDOUT_FILENO);
-      wxASSERT(null_fd == STDERR_FILENO);
-      int rc = wxExecute(m_IfconfigPath,TRUE /* sync */,NULL ,wxEXECUTE_DONT_CLOSE_FDS);
-      close(null_fd); close(output_fd);
-      // restore old stdout, stderr:
-      int test;
-      test = dup(new_stdout); close(new_stdout); wxASSERT(test == STDOUT_FILENO);
-      test = dup(new_stderr); close(new_stderr); wxASSERT(test == STDERR_FILENO);
-      if(rc == 0)
-#endif
       if(wxExecute(cmd,TRUE /* sync */) == 0)
       {
          m_CanUseIfconfig = 1;
@@ -475,7 +461,8 @@ wxDialUpManagerImpl::CheckStatusInternal(void)
          return;
    }
 
-   // second method: try to connect to well known host:
+   // this was supposed to work like ping(8), but doesn´t.
+   // second method: try to connect to a well known host:
    // This can be used under Win 9x, too!
    struct hostent     *hp;
    struct sockaddr_in  serv_addr;
@@ -497,6 +484,8 @@ wxDialUpManagerImpl::CheckStatusInternal(void)
       return;
    }
    
+#if 0
+   // this "ping" method does not work.
    if(sendto(sockfd, "hello",
              strlen("hello"), /* flags */ 0,
              (struct  sockaddr *) &serv_addr,
@@ -505,15 +494,15 @@ wxDialUpManagerImpl::CheckStatusInternal(void)
       close(sockfd);
       return;
    }
-
-#if 0
+#endif
+   
    if( connect(sockfd, (struct sockaddr *) &serv_addr, sizeof(serv_addr)) < 0)
    {
       //sys_error("cannot connect to server");
+      close(sockfd);
       return;
    }
    //connected!
-#endif
    close(sockfd);
    m_IsOnline = TRUE;
 }