1. minor fixes in wxDynLib

[wxWidgets.git] / src / msw / timer.cpp

diff --git a/src/msw/timer.cpp b/src/msw/timer.cpp
index 0896d3648d3e870336de4fc1a8b39b50f24d27f5..6189c291602ff92ad86b83ec1b271e3828a65e8c 100644 (file)
--- a/src/msw/timer.cpp
+++ b/src/msw/timer.cpp
@@ -10,106 +10,142 @@
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
-#pragma implementation "timer.h"
+    #pragma implementation "timer.h"
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
-#pragma hdrstop
+    #pragma hdrstop
 #endif
 
+#include "wx/window.h"
+#include "wx/msw/private.h"
+
 #ifndef WX_PRECOMP
-#include "wx/setup.h"
-#include "wx/list.h"
-#include "wx/app.h"
+    #include "wx/setup.h"
+    #include "wx/list.h"
+    #include "wx/event.h"
+    #include "wx/app.h"
 #endif
 
+#include "wx/intl.h"
+#include "wx/log.h"
+
 #include "wx/timer.h"
-#include "wx/msw/private.h"
 
 #include <time.h>
 #include <sys/types.h>
 
-#if !defined(__SC__) && !defined(__GNUWIN32__)
-#include <sys/timeb.h>
-#endif
-#ifdef __WIN32__
-#define _EXPORT /**/
-#else
-#define _EXPORT _export
+#if !defined(__SC__) && !defined(__GNUWIN32__) && !defined(__MWERKS__)
+    #include <sys/timeb.h>
 #endif
 
-#include <windows.h>
+// ----------------------------------------------------------------------------
+// private functions
+// ----------------------------------------------------------------------------
 
 wxList wxTimerList(wxKEY_INTEGER);
 UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
 
+// ----------------------------------------------------------------------------
+// macros
+// ----------------------------------------------------------------------------
+
+#ifdef __WIN32__
+    #define _EXPORT /**/
+#else
+    #define _EXPORT _export
+#endif
+
 #if !USE_SHARED_LIBRARY
-IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
+    IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
 #endif
 
+// ============================================================================
+// implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// wxTimer class
+// ----------------------------------------------------------------------------
 wxTimer::wxTimer(void)
 {
-  milli = 0 ;
-  lastMilli = -1 ;
-  id = 0;
+    milli = 0 ;
+    lastMilli = -1 ;
+    id = 0;
 }
 
 wxTimer::~wxTimer(void)
 {
-  Stop();
+    Stop();
 
-  wxTimerList.DeleteObject(this);
+    wxTimerList.DeleteObject(this);
 }
 
-bool wxTimer::Start(int milliseconds,bool mode)
+bool wxTimer::Start(int milliseconds, bool mode)
 {
-  oneShot = mode ;
-  if (milliseconds < 0)
-    milliseconds = lastMilli;
-
-  if (milliseconds <= 0)
-    return FALSE;
-
-  lastMilli = milli = milliseconds;
-
-  wxTimerList.DeleteObject(this);
-  TIMERPROC wxTimerProcInst = (TIMERPROC) MakeProcInstance((FARPROC)wxTimerProc,
-                                          wxGetInstance());
-
-  id = SetTimer(NULL, (UINT)(id ? id : 1), (UINT)milliseconds, wxTimerProcInst);
-  if (id > 0)
-  {
-    wxTimerList.Append(id, this);
-    return TRUE;
-  }
-  else return FALSE;
+    oneShot = mode ;
+    if (milliseconds < 0)
+        milliseconds = lastMilli;
+
+    wxCHECK_MSG( milliseconds > 0, FALSE, _T("invalid value for timer timeour") );
+
+    lastMilli = milli = milliseconds;
+
+    wxTimerList.DeleteObject(this);
+    TIMERPROC wxTimerProcInst = (TIMERPROC)
+        MakeProcInstance((FARPROC)wxTimerProc, wxGetInstance());
+
+    id = SetTimer(NULL, (UINT)(id ? id : 1),
+                  (UINT)milliseconds, wxTimerProcInst);
+    if (id > 0)
+    {
+        wxTimerList.Append(id, this);
+
+        return TRUE;
+    }
+    else
+    {
+        wxLogSysError(_("Couldn't create a timer"));
+
+        return FALSE;
+    }
 }
 
 void wxTimer::Stop(void)
 {
-  if (id) {
-    KillTimer(NULL, (UINT)id);
-    wxTimerList.DeleteObject(this); /* @@@@ */
-  }
-  id = 0 ;
-  milli = 0 ;
+    if (id) {
+        KillTimer(NULL, (UINT)id);
+        wxTimerList.DeleteObject(this); /* @@@@ */
+    }
+    id = 0 ;
+    milli = 0 ;
 }
 
-UINT WINAPI _EXPORT wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
+// ----------------------------------------------------------------------------
+// private functions
+// ----------------------------------------------------------------------------
+void wxProcessTimer(wxTimer& timer)
 {
-  wxNode *node = wxTimerList.Find((long)idTimer);
-  if (node)
-  {
-    wxTimer *timer = (wxTimer *)node->Data();
-    if (timer->id==0)
-      return(0) ; // Avoid to process spurious timer events
-    if (timer->oneShot)
-      timer->Stop() ;
-    timer->Notify();
-  }
-  return 0;
+    // Avoid to process spurious timer events
+    if ( timer.id == 0)
+        return;
+
+    if ( timer.oneShot )
+        timer.Stop();
+
+    timer.Notify();
 }
 
+UINT WINAPI _EXPORT wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
+{
+    wxNode *node = wxTimerList.Find((long)idTimer);
+
+    wxCHECK_MSG( node, 0, _T("bogus timer id in wxTimerProc") );
+
+    wxProcessTimer(*(wxTimer *)node->Data());
+
+    return 0;
+}