fixes bug 414369

[wxWidgets.git] / src / msw / taskbar.cpp

diff --git a/src/msw/taskbar.cpp b/src/msw/taskbar.cpp
index be8f8cd3c7a069eea27559ddbdcaf675430a4b73..13235cea9d9c39a58e433db87e6488ba04a1add3 100644 (file)
--- a/src/msw/taskbar.cpp
+++ b/src/msw/taskbar.cpp
@@ -1,13 +1,13 @@
 /////////////////////////////////////////////////////////////////////////
 // File:        taskbar.cpp
 /////////////////////////////////////////////////////////////////////////
 // File:        taskbar.cpp

-// Purpose:        Implements wxTaskBarIcon class for manipulating icons on
+// Purpose:     Implements wxTaskBarIcon class for manipulating icons on

 //              the Windows task bar.
 // Author:      Julian Smart
 // Modified by:
 // Created:     24/3/98
 // RCS-ID:      $Id$
 // Copyright:   (c)
 //              the Windows task bar.
 // Author:      Julian Smart
 // Modified by:
 // Created:     24/3/98
 // RCS-ID:      $Id$
 // Copyright:   (c)

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 /////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__


@@ -23,28 +23,56 @@
 
 #ifndef WX_PRECOMP
 #include "wx/defs.h"
 
 #ifndef WX_PRECOMP
 #include "wx/defs.h"

+#include "wx/window.h"
+#include "wx/frame.h"
+#include "wx/utils.h"
+#include "wx/menu.h"

 #endif
 
 #endif
 

-#ifdef __WIN95__
+#if defined(__WIN95__) && !defined(__TWIN32__)

 
 

-#include <wx/msw/taskbar.h>
-#include <string.h>

 #include <windows.h>
 #include <windows.h>

-#include <wx/msw/private.h>

 
 

-#ifdef __GNUWIN32__
-#include <wx/msw/gnuwin32/extra.h>
+#include "wx/msw/winundef.h"
+
+#include <string.h>
+#include "wx/msw/taskbar.h"
+#include "wx/msw/private.h"
+
+#ifndef __TWIN32__
+    #ifdef __GNUWIN32_OLD__
+        #include "wx/msw/gnuwin32/extra.h"
+    #endif
+#endif
+
+#ifdef __SALFORDC__
+    #include <shellapi.h>

 #endif
 
 LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,
 #endif
 
 LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,

-                                    UINT wParam, LONG lParam );
+                                     UINT wParam, LONG lParam );

 
 

-char *wxTaskBarWindowClass = "wxTaskBarWindowClass";
+wxChar *wxTaskBarWindowClass = wxT("wxTaskBarWindowClass");

 
 wxList wxTaskBarIcon::sm_taskBarIcons;
 bool   wxTaskBarIcon::sm_registeredClass = FALSE;
 UINT   wxTaskBarIcon::sm_taskbarMsg = 0;
 
 
 wxList wxTaskBarIcon::sm_taskBarIcons;
 bool   wxTaskBarIcon::sm_registeredClass = FALSE;
 UINT   wxTaskBarIcon::sm_taskbarMsg = 0;
 

+
+BEGIN_EVENT_TABLE(wxTaskBarIcon, wxEvtHandler)
+    EVT_TASKBAR_MOVE         (wxTaskBarIcon::_OnMouseMove)
+    EVT_TASKBAR_LEFT_DOWN    (wxTaskBarIcon::_OnLButtonDown)
+    EVT_TASKBAR_LEFT_UP      (wxTaskBarIcon::_OnLButtonUp)
+    EVT_TASKBAR_RIGHT_DOWN   (wxTaskBarIcon::_OnRButtonDown)
+    EVT_TASKBAR_RIGHT_UP     (wxTaskBarIcon::_OnRButtonUp)
+    EVT_TASKBAR_LEFT_DCLICK  (wxTaskBarIcon::_OnLButtonDClick)
+    EVT_TASKBAR_RIGHT_DCLICK (wxTaskBarIcon::_OnRButtonDClick)
+END_EVENT_TABLE()
+
+
+IMPLEMENT_DYNAMIC_CLASS(wxTaskBarIcon, wxEvtHandler)
+
+

 wxTaskBarIcon::wxTaskBarIcon(void)
 {
     m_hWnd = 0;
 wxTaskBarIcon::wxTaskBarIcon(void)
 {
     m_hWnd = 0;


@@ -81,20 +109,20 @@ bool wxTaskBarIcon::SetIcon(const wxIcon& icon, const wxString& tooltip)
     NOTIFYICONDATA notifyData;
 
     memset(&notifyData, 0, sizeof(notifyData));
     NOTIFYICONDATA notifyData;
 
     memset(&notifyData, 0, sizeof(notifyData));

-       notifyData.cbSize = sizeof(notifyData);
-       notifyData.hWnd = (HWND) m_hWnd;
-       notifyData.uCallbackMessage = sm_taskbarMsg;
-       notifyData.uFlags = NIF_MESSAGE ;
-       if (icon.Ok())
+        notifyData.cbSize = sizeof(notifyData);
+        notifyData.hWnd = (HWND) m_hWnd;
+        notifyData.uCallbackMessage = sm_taskbarMsg;
+        notifyData.uFlags = NIF_MESSAGE ;
+        if (icon.Ok())

     {
     {

-               notifyData.uFlags |= NIF_ICON;
-           notifyData.hIcon = (HICON) icon.GetHICON();
+                notifyData.uFlags |= NIF_ICON;
+            notifyData.hIcon = (HICON) icon.GetHICON();

     }
 
     }
 

-    if (((const char*) tooltip != NULL) && (tooltip != ""))
+    if (((const wxChar*) tooltip != NULL) && (tooltip != wxT("")))

     {
         notifyData.uFlags |= NIF_TIP ;
     {
         notifyData.uFlags |= NIF_TIP ;

-               lstrcpyn(notifyData.szTip, (char*) (const char*) tooltip, sizeof(notifyData.szTip));
+                lstrcpyn(notifyData.szTip, WXSTRINGCAST tooltip, sizeof(notifyData.szTip));

     }
 
     notifyData.uID = 99;
     }
 
     notifyData.uID = 99;


@@ -116,46 +144,100 @@ bool wxTaskBarIcon::RemoveIcon(void)
     NOTIFYICONDATA notifyData;
 
     memset(&notifyData, 0, sizeof(notifyData));
     NOTIFYICONDATA notifyData;
 
     memset(&notifyData, 0, sizeof(notifyData));

-       notifyData.cbSize = sizeof(notifyData);
-       notifyData.hWnd = (HWND) m_hWnd;
-       notifyData.uCallbackMessage = sm_taskbarMsg;
-       notifyData.uFlags = NIF_MESSAGE;
-       notifyData.hIcon = 0 ; // hIcon;
+        notifyData.cbSize = sizeof(notifyData);
+        notifyData.hWnd = (HWND) m_hWnd;
+        notifyData.uCallbackMessage = sm_taskbarMsg;
+        notifyData.uFlags = NIF_MESSAGE;
+        notifyData.hIcon = 0 ; // hIcon;

     notifyData.uID = 99;
     m_iconAdded = FALSE;
 
     return (Shell_NotifyIcon(NIM_DELETE, & notifyData) != 0);
 }
 
     notifyData.uID = 99;
     m_iconAdded = FALSE;
 
     return (Shell_NotifyIcon(NIM_DELETE, & notifyData) != 0);
 }
 

+bool wxTaskBarIcon::PopupMenu(wxMenu *menu) //, int x, int y);
+{
+    // OK, so I know this isn't thread-friendly, but
+    // what to do? We need this check.
+
+    static bool s_inPopup = FALSE;
+
+    if (s_inPopup)
+        return FALSE;
+
+    s_inPopup = TRUE;
+
+    bool        rval = FALSE;
+    wxWindow*   win;
+    int         x, y;
+    wxGetMousePosition(&x, &y);
+
+    // is wxFrame the best window type to use???
+    win = new wxFrame(NULL, -1, "", wxPoint(x,y), wxSize(-1,-1), 0);
+    win->PushEventHandler(this);
+
+    // Remove from record of top-level windows, or will confuse wxWindows
+    // if we try to exit right now.
+    wxTopLevelWindows.DeleteObject(win);
+
+    menu->UpdateUI();
+
+    // Work around a WIN32 bug
+    ::SetForegroundWindow ((HWND) win->GetHWND ());
+
+    rval = win->PopupMenu(menu, 0, 0);
+
+    // Work around a WIN32 bug
+    ::PostMessage ((HWND) win->GetHWND(),WM_NULL,0,0L);
+
+    win->PopEventHandler(FALSE);
+    win->Destroy();
+    delete win;
+
+    s_inPopup = FALSE;
+
+    return rval;
+}
+
+

 // Overridables
 // Overridables

-void wxTaskBarIcon::OnMouseMove(void)
+void wxTaskBarIcon::OnMouseMove(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnLButtonDown(void)
+void wxTaskBarIcon::OnLButtonDown(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnLButtonUp(void)
+void wxTaskBarIcon::OnLButtonUp(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnRButtonDown(void)
+void wxTaskBarIcon::OnRButtonDown(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnRButtonUp(void)
+void wxTaskBarIcon::OnRButtonUp(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnLButtonDClick(void)
+void wxTaskBarIcon::OnLButtonDClick(wxEvent&)

 {
 }
 
 {
 }
 

-void wxTaskBarIcon::OnRButtonDClick(void)
+void wxTaskBarIcon::OnRButtonDClick(wxEvent&)

 {
 }
 
 {
 }
 

+void wxTaskBarIcon::_OnMouseMove(wxEvent& e)      { OnMouseMove(e);     }
+void wxTaskBarIcon::_OnLButtonDown(wxEvent& e)    { OnLButtonDown(e);   }
+void wxTaskBarIcon::_OnLButtonUp(wxEvent& e)      { OnLButtonUp(e);     }
+void wxTaskBarIcon::_OnRButtonDown(wxEvent& e)    { OnRButtonDown(e);   }
+void wxTaskBarIcon::_OnRButtonUp(wxEvent& e)      { OnRButtonUp(e);     }
+void wxTaskBarIcon::_OnLButtonDClick(wxEvent& e)  { OnLButtonDClick(e); }
+void wxTaskBarIcon::_OnRButtonDClick(wxEvent& e)  { OnRButtonDClick(e); }
+
+

 wxTaskBarIcon* wxTaskBarIcon::FindObjectForHWND(WXHWND hWnd)
 {
     wxNode*node = sm_taskBarIcons.First();
 wxTaskBarIcon* wxTaskBarIcon::FindObjectForHWND(WXHWND hWnd)
 {
     wxNode*node = sm_taskBarIcons.First();


@@ -185,10 +267,10 @@ bool wxTaskBarIcon::RegisterWindowClass()
         return TRUE;
 
     // Also register the taskbar message here
         return TRUE;
 
     // Also register the taskbar message here

-    sm_taskbarMsg = ::RegisterWindowMessage("wxTaskBarIconMessage");
+    sm_taskbarMsg = ::RegisterWindowMessage(wxT("wxTaskBarIconMessage"));

 
 

-    WNDCLASS   wc;
-    bool       rc;
+    WNDCLASS        wc;
+    bool        rc;

 
     HINSTANCE hInstance = GetModuleHandle(NULL);
 
 
     HINSTANCE hInstance = GetModuleHandle(NULL);
 


@@ -217,7 +299,7 @@ WXHWND wxTaskBarIcon::CreateTaskBarWindow()
     HINSTANCE hInstance = GetModuleHandle(NULL);
 
     HWND hWnd = CreateWindowEx (0, wxTaskBarWindowClass,
     HINSTANCE hInstance = GetModuleHandle(NULL);
 
     HWND hWnd = CreateWindowEx (0, wxTaskBarWindowClass,

-            "wxTaskBarWindow",
+            wxT("wxTaskBarWindow"),

             WS_OVERLAPPED,
             0,
             0,
             WS_OVERLAPPED,
             0,
             0,


@@ -233,47 +315,57 @@ WXHWND wxTaskBarIcon::CreateTaskBarWindow()
 
 long wxTaskBarIcon::WindowProc( WXHWND hWnd, unsigned int msg, unsigned int wParam, long lParam )
 {
 
 long wxTaskBarIcon::WindowProc( WXHWND hWnd, unsigned int msg, unsigned int wParam, long lParam )
 {

+    wxEventType eventType = 0;
+

     if (msg != sm_taskbarMsg)
         return DefWindowProc((HWND) hWnd, msg, wParam, lParam);
 
     switch (lParam)
     {
     if (msg != sm_taskbarMsg)
         return DefWindowProc((HWND) hWnd, msg, wParam, lParam);
 
     switch (lParam)
     {

-       case WM_LBUTTONDOWN:
-               OnLButtonDown();
-               break;
+        case WM_LBUTTONDOWN:
+            eventType = wxEVT_TASKBAR_LEFT_DOWN;
+            break;
+
+        case WM_LBUTTONUP:
+            eventType = wxEVT_TASKBAR_LEFT_UP;
+            break;

 
 

-       case WM_LBUTTONUP:
-               OnLButtonUp();
-               break;
+        case WM_RBUTTONDOWN:
+            eventType = wxEVT_TASKBAR_RIGHT_DOWN;
+            break;

 
 

-       case WM_RBUTTONDOWN:
-               OnRButtonDown();
-               break;
+        case WM_RBUTTONUP:
+            eventType = wxEVT_TASKBAR_RIGHT_UP;
+            break;

 
 

-       case WM_RBUTTONUP:
-               OnRButtonUp();
-               break;
+        case WM_LBUTTONDBLCLK:
+            eventType = wxEVT_TASKBAR_LEFT_DCLICK;
+            break;

 
 

-       case WM_LBUTTONDBLCLK:
-               OnLButtonDClick();
-               break;
+        case WM_RBUTTONDBLCLK:
+            eventType = wxEVT_TASKBAR_RIGHT_DCLICK;
+            break;

 
 

-       case WM_RBUTTONDBLCLK:
-               OnRButtonDClick();
-               break;
+        case WM_MOUSEMOVE:
+            eventType = wxEVT_TASKBAR_MOVE;
+            break;

 
 

-       case WM_MOUSEMOVE:
-               OnMouseMove();
-               break;
+        default:
+            break;
+        }

 
 

-       default:
-        break;
-       }
+    if (eventType) {
+        wxEvent event;
+        event.SetEventType(eventType);
+        event.SetEventObject(this);
+
+        ProcessEvent(event);
+    }

     return 0;
 }
 
 LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,
     return 0;
 }
 
 LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,

-                                    UINT wParam, LONG lParam )
+                                     UINT wParam, LONG lParam )

 {
     wxTaskBarIcon* obj = wxTaskBarIcon::FindObjectForHWND((WXHWND) hWnd);
     if (obj)
 {
     wxTaskBarIcon* obj = wxTaskBarIcon::FindObjectForHWND((WXHWND) hWnd);
     if (obj)