no message

[wxWidgets.git] / src / msw / radiobut.cpp

diff --git a/src/msw/radiobut.cpp b/src/msw/radiobut.cpp
index f3a4b655d8e96117711a16c81935d3114cc08903..a9957ebc0524443173928d348753f3835b5ebc55 100644 (file)
--- a/src/msw/radiobut.cpp
+++ b/src/msw/radiobut.cpp
@@ -6,7 +6,7 @@
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:    wxWindows license
+// Licence:     wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
@@ -33,10 +33,10 @@ IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)
 // IMPLEMENT_DYNAMIC_CLASS(wxBitmapRadioButton, wxRadioButton)
 #endif
 
-bool wxRadioButton::Create(wxWindow *parent, const wxWindowID id,
-                  const wxString& label,
+bool wxRadioButton::Create(wxWindow *parent, wxWindowID id,
+       const wxString& label,
            const wxPoint& pos,
-           const wxSize& size, const long style,
+           const wxSize& size, long style,
            const wxValidator& validator,
            const wxString& name)
 {
@@ -45,13 +45,13 @@ bool wxRadioButton::Create(wxWindow *parent, const wxWindowID id,
 
   if (parent) parent->AddChild(this);
 
-  SetBackgroundColour(parent->GetDefaultBackgroundColour());
-  SetForegroundColour(parent->GetDefaultForegroundColour());
+  SetBackgroundColour(parent->GetBackgroundColour());
+  SetForegroundColour(parent->GetForegroundColour());
 
   if ( id == -1 )
-       m_windowId = (int)NewControlId();
+    m_windowId = (int)NewControlId();
   else
-       m_windowId = id;
+  m_windowId = id;
 
   int x = pos.x;
   int y = pos.y;
@@ -72,18 +72,20 @@ bool wxRadioButton::Create(wxWindow *parent, const wxWindowID id,
 
   // Even with extended styles, need to combine with WS_BORDER
   // for them to look right.
-  if (want3D && ((m_windowStyle & wxSIMPLE_BORDER) || (m_windowStyle & wxRAISED_BORDER) ||
-       (m_windowStyle & wxSUNKEN_BORDER) || (m_windowStyle & wxDOUBLE_BORDER)))
+  if ( want3D || wxStyleHasBorder(m_windowStyle) )
     msStyle |= WS_BORDER;
 
   m_hWnd = (WXHWND) CreateWindowEx(exStyle, RADIO_CLASS, (const char *)label,
                           msStyle,0,0,0,0,
                           (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL);
+
+  wxCHECK_MSG( m_hWnd, FALSE, "Failed to create radiobutton" );
+
 #if CTL3D
   if (want3D)
   {
     Ctl3dSubclassCtl((HWND) m_hWnd);
-       m_useCtl3D = TRUE;
+   m_useCtl3D = TRUE;
   }
 #endif
 
@@ -97,7 +99,7 @@ bool wxRadioButton::Create(wxWindow *parent, const wxWindowID id,
   // start GRW fix
   if (label != "")
   {
-    float label_width, label_height;
+    int label_width, label_height;
     GetTextExtent(label, &label_width, &label_height, NULL, NULL, GetFont());
     if (width < 0)
       width = (int)(label_width + RADIO_SIZE);
@@ -128,7 +130,7 @@ void wxRadioButton::SetLabel(const wxString& label)
   SetWindowText((HWND) GetHWND(), (const char *)label);
 }
 
-void wxRadioButton::SetValue(const bool value)
+void wxRadioButton::SetValue(bool value)
 {
 // Following necessary for Win32s, because Win32s translate BM_SETCHECK
   SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L);
@@ -140,8 +142,8 @@ bool wxRadioButton::GetValue(void) const
   return (SendMessage((HWND) GetHWND(), BM_SETCHECK, 0, 0L) != 0);
 }
 
-WXHBRUSH wxRadioButton::OnCtlColor(const WXHDC pDC, const WXHWND pWnd, const WXUINT nCtlColor,
-                       WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
+WXHBRUSH wxRadioButton::OnCtlColor(WXHDC pDC, WXHWND pWnd, WXUINT nCtlColor,
+      WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
 {
 #if CTL3D
   if ( m_useCtl3D )
@@ -176,10 +178,10 @@ void wxRadioButton::Command (wxCommandEvent & event)
 
 // Not implemented
 #if 0
-bool wxBitmapRadioButton::Create(wxWindow *parent, const wxWindowID id,
-                  const wxBitmap *bitmap,
+bool wxBitmapRadioButton::Create(wxWindow *parent, wxWindowID id,
+       const wxBitmap *bitmap,
            const wxPoint& pos,
-           const wxSize& size, const long style,
+           const wxSize& size, long style,
            const wxValidator& validator,
            const wxString& name)
 {
@@ -187,13 +189,13 @@ bool wxBitmapRadioButton::Create(wxWindow *parent, const wxWindowID id,
   SetValidator(validator);
 
   if (parent) parent->AddChild(this);
-  SetBackgroundColour(parent->GetDefaultBackgroundColour());
-  SetForegroundColour(parent->GetDefaultForegroundColour());
+  SetBackgroundColour(parent->GetBackgroundColour());
+  SetForegroundColour(parent->GetForegroundColour());
 
   if ( id == -1 )
-       m_windowId = (int)NewControlId();
+    m_windowId = (int)NewControlId();
   else
-       m_windowId = id;
+  m_windowId = id;
 
   int x = pos.x;
   int y = pos.y;
@@ -211,11 +213,14 @@ bool wxBitmapRadioButton::Create(wxWindow *parent, const wxWindowID id,
   m_hWnd = (WXHWND) CreateWindowEx(MakeExtendedStyle(m_windowStyle), RADIO_CLASS, "toggle",
                           msStyle,0,0,0,0,
                           (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL);
+
+  wxCHECK_MSG( m_hWnd, "Failed to create radio button", FALSE );
+
 #if CTL3D
   if (!(GetParent()->GetWindowStyleFlag() & wxUSER_COLOURS))
   {
     Ctl3dSubclassCtl((HWND) GetHWND());
-         m_useCtl3D = TRUE;
+    m_useCtl3D = TRUE;
   }
 #endif
 
@@ -231,7 +236,7 @@ void wxBitmapRadioButton::SetLabel(const wxBitmap *bitmap)
 {
 }
 
-void wxBitmapRadioButton::SetValue(const bool value)
+void wxBitmapRadioButton::SetValue(bool value)
 {
 // Following necessary for Win32s, because Win32s translate BM_SETCHECK
   SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L);