A few compile fixes,

[wxWidgets.git] / src / msw / checkbox.cpp

diff --git a/src/msw/checkbox.cpp b/src/msw/checkbox.cpp
index eca9672ea34dddc0507081cee8383a5e7e66a297..bb9566506981cabdb7cea2282697865aea132aca 100644 (file)
--- a/src/msw/checkbox.cpp
+++ b/src/msw/checkbox.cpp
@@ -6,195 +6,187 @@
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem

-// Licence:    wxWindows license
+// Licence:     wxWindows license

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+

 #ifdef __GNUG__
 #ifdef __GNUG__

-#pragma implementation "checkbox.h"
+    #pragma implementation "checkbox.h"

 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__

-#pragma hdrstop
+    #pragma hdrstop

 #endif
 
 #ifndef WX_PRECOMP
 #endif
 
 #ifndef WX_PRECOMP

-#include "wx/checkbox.h"
+    #include "wx/checkbox.h"
+    #include "wx/brush.h"

 #endif
 
 #include "wx/msw/private.h"
 
 #endif
 
 #include "wx/msw/private.h"
 

+// ----------------------------------------------------------------------------
+// macros
+// ----------------------------------------------------------------------------
+

 #if !USE_SHARED_LIBRARY
 #if !USE_SHARED_LIBRARY

-IMPLEMENT_DYNAMIC_CLASS(wxCheckBox, wxControl)
-IMPLEMENT_DYNAMIC_CLASS(wxBitmapCheckBox, wxCheckBox)
+    IMPLEMENT_DYNAMIC_CLASS(wxCheckBox, wxControl)
+    IMPLEMENT_DYNAMIC_CLASS(wxBitmapCheckBox, wxCheckBox)

 #endif
 
 #endif
 

-bool wxCheckBox::MSWCommand(const WXUINT WXUNUSED(param), const WXWORD WXUNUSED(id))
+// ============================================================================
+// implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// wxCheckBox
+// ----------------------------------------------------------------------------
+
+bool wxCheckBox::MSWCommand(WXUINT WXUNUSED(param), WXWORD WXUNUSED(id))

 {
 {

-  wxCommandEvent event(wxEVENT_TYPE_CHECKBOX_COMMAND, m_windowId);
-  event.SetInt(GetValue());
-  event.SetEventObject(this);
-  ProcessCommand(event);
-  return TRUE;
+    wxCommandEvent event(wxEVT_COMMAND_CHECKBOX_CLICKED, m_windowId);
+    event.SetInt(GetValue());
+    event.SetEventObject(this);
+    ProcessCommand(event);
+    return TRUE;

 }
 
 // Single check box item
 }
 
 // Single check box item

-bool wxCheckBox::Create(wxWindow *parent, const wxWindowID id, const wxString& label,
+bool wxCheckBox::Create(wxWindow *parent, wxWindowID id, const wxString& label,

            const wxPoint& pos,
            const wxPoint& pos,

-           const wxSize& size, const long style,
+           const wxSize& size, long style,

            const wxValidator& validator,
            const wxString& name)
 {
            const wxValidator& validator,
            const wxString& name)
 {

-  SetName(name);
-  SetValidator(validator);
-  if (parent) parent->AddChild(this);
-
-  SetBackgroundColour(parent->GetDefaultBackgroundColour()) ;
-  SetForegroundColour(parent->GetDefaultForegroundColour()) ;
-
-  m_windowStyle = style;
-
-  wxString Label = label;
-  if (Label == "")
-    Label = " "; // Apparently needed or checkbox won't show
-
-       if ( id == -1 )
-               m_windowId = NewControlId();
-       else
-               m_windowId = id;
-
-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
-
-  long msStyle = BS_AUTOCHECKBOX|WS_TABSTOP|WS_CHILD;
+    SetName(name);
+    SetValidator(validator);
+    if (parent) parent->AddChild(this);

 
 

-  // We perhaps have different concepts of 3D here - a 3D border,
-  // versus a 3D button.
-  // So we only wish to give a border if this is specified
-  // in the style.
-  bool want3D;
-  WXDWORD exStyle = Determine3DEffects(0, &want3D) ;
+    SetBackgroundColour(parent->GetBackgroundColour()) ;
+    SetForegroundColour(parent->GetForegroundColour()) ;

 
 

-  // Even with extended styles, need to combine with WS_BORDER
-  // for them to look right.
-  if (want3D && ((m_windowStyle & wxSIMPLE_BORDER) || (m_windowStyle & wxRAISED_BORDER) ||
-       (m_windowStyle & wxSUNKEN_BORDER) || (m_windowStyle & wxDOUBLE_BORDER)))
-    msStyle |= WS_BORDER;
+    m_windowStyle = style;

 
 

-  HWND wx_button = CreateWindowEx(exStyle, "BUTTON", (const char *)Label,
-                    msStyle,
-                    0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)m_windowId,
-                    wxGetInstance(), NULL);
+    wxString Label = label;
+    if (Label == _T(""))
+        Label = _T(" "); // Apparently needed or checkbox won't show

 
 

-#if CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl(wx_button);
-    m_useCtl3D = TRUE;
-  }
+    if ( id == -1 )
+        m_windowId = NewControlId();
+    else
+        m_windowId = id;
+
+    int x = pos.x;
+    int y = pos.y;
+    int width = size.x;
+    int height = size.y;
+
+    long msStyle = BS_AUTOCHECKBOX | WS_TABSTOP | WS_CHILD | WS_VISIBLE;
+    if ( style & wxALIGN_RIGHT )
+        msStyle |= BS_LEFTTEXT;
+
+    // We perhaps have different concepts of 3D here - a 3D border,
+    // versus a 3D button.
+    // So we only wish to give a border if this is specified
+    // in the style.
+    bool want3D;
+    WXDWORD exStyle = Determine3DEffects(0, &want3D) ;
+
+    // Even with extended styles, need to combine with WS_BORDER
+    // for them to look right.
+    /*
+       if ( want3D || wxStyleHasBorder(m_windowStyle) )
+       msStyle |= WS_BORDER;
+     */
+
+    m_hWnd = (WXHWND)CreateWindowEx(exStyle, _T("BUTTON"), Label,
+            msStyle,
+            0, 0, 0, 0,
+            (HWND)parent->GetHWND(), (HMENU)m_windowId,
+            wxGetInstance(), NULL);
+
+#if wxUSE_CTL3D
+    if (want3D)
+    {
+        Ctl3dSubclassCtl(GetHwnd());
+        m_useCtl3D = TRUE;
+    }

 #endif
 
 #endif
 

-  m_hWnd = (WXHWND) wx_button;
+    // Subclass again for purposes of dialog editing mode
+    SubclassWin(m_hWnd);

 
 

-  // Subclass again for purposes of dialog editing mode
-  SubclassWin((WXHWND) wx_button);
-  
-  SetFont(* parent->GetFont());
+    SetFont(parent->GetFont());

 
 

-  SetSize(x, y, width, height);
+    SetSize(x, y, width, height);

 
 

-  ShowWindow(wx_button, SW_SHOW);
-  return TRUE;
+    return TRUE;

 }
 
 void wxCheckBox::SetLabel(const wxString& label)
 {
 }
 
 void wxCheckBox::SetLabel(const wxString& label)
 {

-  SetWindowText((HWND) GetHWND(), (const char *)label);
+  SetWindowText(GetHwnd(), label);

 }
 
 }
 

-void wxCheckBox::SetSize(const int x, const int y, const int width, const int height, const int sizeFlags)
+wxSize wxCheckBox::DoGetBestSize()

 {
 {

-  int currentX, currentY;
-  GetPosition(&currentX, &currentY);
-  int x1 = x;
-  int y1 = y;
-  int w1 = width;
-  int h1 = height;
-
-  if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    x1 = currentX;
-  if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    y1 = currentY;
-
-  char buf[300];
+    int wCheckbox, hCheckbox;

 
 

-  float current_width;
+    wxString str = wxGetWindowText(GetHWND());

 
 

-  float cyf;
-
-  HWND button = (HWND) GetHWND();
-
-    GetWindowText(button, buf, 300);
-    if (buf[0])
+    if ( !str.IsEmpty() )

     {
     {

-      GetTextExtent(buf, &current_width, &cyf, NULL, NULL, GetFont());
-      if (w1 < 0)
-        w1 = (int)(current_width + RADIO_SIZE);
-      if (h1 < 0)
-      {
-        h1 = (int)(cyf);
-        if (h1 < RADIO_SIZE)
-          h1 = RADIO_SIZE;
-      }
+        GetTextExtent(str, &wCheckbox, &hCheckbox);
+        wCheckbox += RADIO_SIZE;
+
+        if ( hCheckbox < RADIO_SIZE )
+            hCheckbox = RADIO_SIZE;

     }
     else
     {
     }
     else
     {

-      if (w1 < 0)
-        w1 = RADIO_SIZE;
-      if (h1 < 0)
-        h1 = RADIO_SIZE;
+        wCheckbox = RADIO_SIZE;
+        hCheckbox = RADIO_SIZE;

     }
 
     }
 

-  MoveWindow(button, x1, y1, w1, h1, TRUE);
-
-/*
-#if WXWIN_COMPATIBILITY
-  GetEventHandler()->OldOnSize(width, height);
-#else
-  wxSizeEvent event(wxSize(width, height), m_windowId);
-  event.eventObject = this;
-  GetEventHandler()->ProcessEvent(event);
-#endif
-*/
-
+    return wxSize(wCheckbox, hCheckbox);

 }
 
 }
 

-void wxCheckBox::SetValue(const bool val)
+void wxCheckBox::SetValue(bool val)

 {
 {

-  SendMessage((HWND) GetHWND(), BM_SETCHECK, val, 0);
+    SendMessage(GetHwnd(), BM_SETCHECK, val, 0);

 }
 
 }
 

-bool wxCheckBox::GetValue(void) const
+#ifndef BST_CHECKED
+#define BST_CHECKED 0x0001
+#endif
+
+bool wxCheckBox::GetValue() const

 {
 #ifdef __WIN32__
 {
 #ifdef __WIN32__

-  return (SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0) == BST_CHECKED);
+  return (SendMessage(GetHwnd(), BM_GETCHECK, 0, 0) == BST_CHECKED);

 #else
 #else

-  return ((0x003 & SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0)) == 0x003);
+  return ((0x003 & SendMessage(GetHwnd(), BM_GETCHECK, 0, 0)) == 0x003);

 #endif
 }
 
 #endif
 }
 

-WXHBRUSH wxCheckBox::OnCtlColor(const WXHDC pDC, const WXHWND pWnd, const WXUINT nCtlColor,
-                       WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
+WXHBRUSH wxCheckBox::OnCtlColor(WXHDC pDC, WXHWND pWnd, WXUINT nCtlColor,
+                                WXUINT message, WXWPARAM wParam, WXLPARAM lParam)

 {
 {

-#if CTL3D
+#if wxUSE_CTL3D

   if ( m_useCtl3D )
   {
     HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);
   if ( m_useCtl3D )
   {
     HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);

-      
+

       return (WXHBRUSH) hbrush;
   }
 #endif
       return (WXHBRUSH) hbrush;
   }
 #endif


@@ -221,9 +213,13 @@ void wxCheckBox::Command (wxCommandEvent & event)
   ProcessCommand (event);
 }
 
   ProcessCommand (event);
 }
 

-bool wxBitmapCheckBox::Create(wxWindow *parent, const wxWindowID id, const wxBitmap *label,
+// ----------------------------------------------------------------------------
+// wxBitmapCheckBox
+// ----------------------------------------------------------------------------
+
+bool wxBitmapCheckBox::Create(wxWindow *parent, wxWindowID id, const wxBitmap *label,

            const wxPoint& pos,
            const wxPoint& pos,

-           const wxSize& size, const long style,
+           const wxSize& size, long style,

            const wxValidator& validator,
            const wxString& name)
 {
            const wxValidator& validator,
            const wxString& name)
 {


@@ -231,14 +227,14 @@ bool wxBitmapCheckBox::Create(wxWindow *parent, const wxWindowID id, const wxBit
   SetValidator(validator);
   if (parent) parent->AddChild(this);
 
   SetValidator(validator);
   if (parent) parent->AddChild(this);
 

-  SetBackgroundColour(parent->GetDefaultBackgroundColour()) ;
-  SetForegroundColour(parent->GetDefaultForegroundColour()) ;
+  SetBackgroundColour(parent->GetBackgroundColour()) ;
+  SetForegroundColour(parent->GetForegroundColour()) ;

   m_windowStyle = style;
 
   m_windowStyle = style;
 

-       if ( id == -1 )
-               m_windowId = NewControlId();
-       else
-               m_windowId = id;
+  if ( id == -1 )
+      m_windowId = NewControlId();
+  else
+      m_windowId = id;

 
   int x = pos.x;
   int y = pos.y;
 
   int x = pos.x;
   int y = pos.y;


@@ -249,16 +245,16 @@ bool wxBitmapCheckBox::Create(wxWindow *parent, const wxWindowID id, const wxBit
   checkHeight = -1 ;
   long msStyle = CHECK_FLAGS;
 
   checkHeight = -1 ;
   long msStyle = CHECK_FLAGS;
 

-  HWND wx_button = CreateWindowEx(MakeExtendedStyle(m_windowStyle), CHECK_CLASS, "toggle",
+  HWND wx_button = CreateWindowEx(MakeExtendedStyle(m_windowStyle), CHECK_CLASS, _T("toggle"),

                     msStyle,
                     0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)m_windowId,
                     wxGetInstance(), NULL);
 
                     msStyle,
                     0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)m_windowId,
                     wxGetInstance(), NULL);
 

-#if CTL3D
+#if wxUSE_CTL3D

   if (!(GetParent()->GetWindowStyleFlag() & wxUSER_COLOURS))
   {
     Ctl3dSubclassCtl(wx_button);
   if (!(GetParent()->GetWindowStyleFlag() & wxUSER_COLOURS))
   {
     Ctl3dSubclassCtl(wx_button);

-         m_useCtl3D = TRUE;
+    m_useCtl3D = TRUE;

   }
 #endif
 
   }
 #endif
 


@@ -267,59 +263,14 @@ bool wxBitmapCheckBox::Create(wxWindow *parent, const wxWindowID id, const wxBit
   // Subclass again for purposes of dialog editing mode
   SubclassWin((WXHWND)wx_button);
 
   // Subclass again for purposes of dialog editing mode
   SubclassWin((WXHWND)wx_button);
 

-//  SetFont(parent->GetFont());
-

   SetSize(x, y, width, height);
 
   ShowWindow(wx_button, SW_SHOW);
   SetSize(x, y, width, height);
 
   ShowWindow(wx_button, SW_SHOW);

-  return TRUE;
-}
-
-void wxBitmapCheckBox::SetLabel(const wxBitmap *bitmap)
-{
-}
-
-void wxBitmapCheckBox::SetSize(const int x, const int y, const int width, const int height, const int sizeFlags)
-{
-  int currentX, currentY;
-  GetPosition(&currentX, &currentY);
-
-  int x1 = x;
-  int y1 = y;
-  int w1 = width;
-  int h1 = height;
-
-  if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    x1 = currentX;
-  if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    y1 = currentY;
-
-  HWND button = (HWND) GetHWND();
-/*
-    if (w1<0)
-      w1 = checkWidth + FB_MARGIN ;
-    if (h1<0)
-      h1 = checkHeight + FB_MARGIN ;
-*/
-  MoveWindow(button, x1, y1, w1, h1, TRUE);
-
-#if WXWIN_COMPATIBILITY
-  GetEventHandler()->OldOnSize(width, height);
-#else
-  wxSizeEvent event(wxSize(width, height), m_windowId);
-  event.eventObject = this;
-  GetEventHandler()->ProcessEvent(event);
-#endif
-}

 
 

-void wxBitmapCheckBox::SetValue(const bool val)
-{
-  SendMessage((HWND) GetHWND(), BM_SETCHECK, val, 0);
+  return TRUE;

 }
 
 }
 

-bool wxBitmapCheckBox::GetValue(void) const
+void wxBitmapCheckBox::SetLabel(const wxBitmap& bitmap)

 {
 {

-  return ((0x003 & SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0)) == 0x003);
+    wxFAIL_MSG(_T("not implemented"));

 }
 }

-
-