Fix memory leak when a spacer is added, and crash when a window is added before wxSiz...

[wxWidgets.git] / src / gtk1 / colour.cpp

diff --git a/src/gtk1/colour.cpp b/src/gtk1/colour.cpp
index 51fde80c114a5e9e1743c5170f3a5764fd1b57d0..60735789ebf5aa0454b50134af65711de57b3a2a 100644 (file)
--- a/src/gtk1/colour.cpp
+++ b/src/gtk1/colour.cpp
@@ -8,14 +8,20 @@
 /////////////////////////////////////////////////////////////////////////////
 
 
 /////////////////////////////////////////////////////////////////////////////
 
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "colour.h"
 #endif
 
 #pragma implementation "colour.h"
 #endif
 

+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
+#include "wx/colour.h"

 #include "wx/gdicmn.h"
 #include "wx/gdicmn.h"

+#include "wx/gtk/private.h"

 
 

-#include "gdk/gdk.h"
-#include "gdk/gdkprivate.h"
+#include <gdk/gdk.h>
+#include <gdk/gdkx.h>
+#include <gdk/gdkprivate.h>

 
 //-----------------------------------------------------------------------------
 // wxColour
 
 //-----------------------------------------------------------------------------
 // wxColour


@@ -23,51 +29,128 @@
 
 class wxColourRefData: public wxObjectRefData
 {
 
 class wxColourRefData: public wxObjectRefData
 {

-  public:
+public:
+    wxColourRefData()
+    {
+        m_color.red = 0;
+        m_color.green = 0;
+        m_color.blue = 0;
+        m_color.pixel = 0;
+        m_colormap = (GdkColormap *) NULL;
+        m_hasPixel = false;
+    }
+
+    wxColourRefData(const wxColourRefData& data)
+        : wxObjectRefData()
+    {
+        m_color = data.m_color;
+        m_colormap = data.m_colormap;
+        m_hasPixel = data.m_hasPixel;
+    }
+
+    ~wxColourRefData()
+    {
+        FreeColour();
+    }
+
+    bool operator == (const wxColourRefData& data) const
+    {
+        return (m_colormap == data.m_colormap &&
+                m_hasPixel == data.m_hasPixel &&
+                m_color.red == data.m_color.red &&
+                m_color.green == data.m_color.green &&
+                m_color.blue == data.m_color.blue &&
+                m_color.pixel == data.m_color.pixel);
+    }

 
 

-    wxColourRefData();
-    ~wxColourRefData();

     void FreeColour();
     void FreeColour();

+    void AllocColour( GdkColormap* cmap );

 
     GdkColor     m_color;
     GdkColormap *m_colormap;
     bool         m_hasPixel;
 
 
     GdkColor     m_color;
     GdkColormap *m_colormap;
     bool         m_hasPixel;
 

-    friend wxColour;
+    friend class wxColour;
+
+    // reference counter for systems with <= 8-Bit display
+    static gushort colMapAllocCounter[ 256 ];

 };
 
 };
 

-wxColourRefData::wxColourRefData()
+gushort wxColourRefData::colMapAllocCounter[ 256 ] =

 {
 {

-    m_color.red = 0;
-    m_color.green = 0;
-    m_color.blue = 0;
-    m_color.pixel = 0;
-    m_colormap = (GdkColormap *) NULL;
-    m_hasPixel = FALSE;
-}
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
+};

 
 

-wxColourRefData::~wxColourRefData()
+void wxColourRefData::FreeColour()

 {
 {

-    FreeColour();
+    if (m_colormap)
+    {
+#ifdef __WXGTK20__
+        if ((m_colormap->visual->type == GDK_VISUAL_GRAYSCALE) ||
+            (m_colormap->visual->type == GDK_VISUAL_PSEUDO_COLOR))
+#else
+        GdkColormapPrivate *private_colormap = (GdkColormapPrivate*) m_colormap;
+        if ((private_colormap->visual->type == GDK_VISUAL_GRAYSCALE) ||
+            (private_colormap->visual->type == GDK_VISUAL_PSEUDO_COLOR))
+#endif
+        {
+            int idx = m_color.pixel;
+            colMapAllocCounter[ idx ] = colMapAllocCounter[ idx ] - 1;
+
+            if (colMapAllocCounter[ idx ] == 0)
+            gdk_colormap_free_colors( m_colormap, &m_color, 1 );
+        }
+    }

 }
 
 }
 

-void wxColourRefData::FreeColour()
+void wxColourRefData::AllocColour( GdkColormap *cmap )

 {
 {

-//  if (m_hasPixel) gdk_colors_free( m_colormap, &m_color, 1, 0 );
+    if (m_hasPixel && (m_colormap == cmap))
+        return;
+
+    FreeColour();
+
+#ifdef __WXGTK20__
+    if ( (cmap->visual->type == GDK_VISUAL_GRAYSCALE) ||
+            (cmap->visual->type == GDK_VISUAL_PSEUDO_COLOR) )
+#else
+    GdkColormapPrivate *private_colormap = (GdkColormapPrivate*) cmap;
+    if ((private_colormap->visual->type == GDK_VISUAL_GRAYSCALE) ||
+        (private_colormap->visual->type == GDK_VISUAL_PSEUDO_COLOR))
+#endif
+    {
+        m_hasPixel = gdk_colormap_alloc_color( cmap, &m_color, FALSE, TRUE );
+        int idx = m_color.pixel;
+        colMapAllocCounter[ idx ] = colMapAllocCounter[ idx ] + 1;
+    }
+    else
+    {
+        m_hasPixel = gdk_color_alloc( cmap, &m_color );
+    }
+    m_colormap = cmap;

 }
 
 //-----------------------------------------------------------------------------
 
 #define M_COLDATA ((wxColourRefData *)m_refData)
 
 }
 
 //-----------------------------------------------------------------------------
 
 #define M_COLDATA ((wxColourRefData *)m_refData)
 

-#define SHIFT (8*(sizeof(short int)-sizeof(char)))
+// GDK's values are in 0..65535 range, our are in 0..255
+#define SHIFT  8

 
 IMPLEMENT_DYNAMIC_CLASS(wxColour,wxGDIObject)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxColour,wxGDIObject)
 

-wxColour::wxColour()
-{
-}
-

 wxColour::wxColour( unsigned char red, unsigned char green, unsigned char blue )
 {
     m_refData = new wxColourRefData();
 wxColour::wxColour( unsigned char red, unsigned char green, unsigned char blue )
 {
     m_refData = new wxColourRefData();


@@ -77,148 +160,127 @@ wxColour::wxColour( unsigned char red, unsigned char green, unsigned char blue )
     M_COLDATA->m_color.pixel = 0;
 }
 
     M_COLDATA->m_color.pixel = 0;
 }
 

+/* static */
+wxColour wxColour::CreateByName(const wxString& name)
+{
+    wxColour col;
+
+    GdkColor colGDK;
+    if ( gdk_color_parse( wxGTK_CONV( name ), &colGDK ) )
+    {
+        wxColourRefData *refData = new wxColourRefData;
+        refData->m_color = colGDK;
+        col.m_refData = refData;
+    }
+
+    return col;
+}
+
+

 void wxColour::InitFromName( const wxString &colourName )
 {
 void wxColour::InitFromName( const wxString &colourName )
 {

-    wxNode *node = (wxNode *) NULL;
-    if ( (wxTheColourDatabase) && (node = wxTheColourDatabase->Find(colourName)) )
+    // check the cache first
+    wxColour col;
+    if ( wxTheColourDatabase )

     {
     {

-        wxColour *col = (wxColour*)node->Data();
-        UnRef();
-        if (col) Ref( *col );
+        col = wxTheColourDatabase->Find(colourName);

     }
     }

-    else
+
+    if ( !col.Ok() )

     {
     {

-        m_refData = new wxColourRefData();
-        if (!gdk_color_parse( colourName.mb_str(), &M_COLDATA->m_color ))
-        {
-            wxFAIL_MSG( _T("wxColour: couldn't find colour") );
-           wxPrintf( _T("Colourname %s.\n"), WXSTRINGCAST colourName );
-      
-            delete m_refData;
-            m_refData = (wxObjectRefData *) NULL;
-        }
+        col = CreateByName(colourName);

     }
     }

-}

 
 

-wxColour::wxColour( const wxColour& col )
-{
-    Ref( col );
+    if ( col.Ok() )
+    {
+        *this = col;
+    }
+    else
+    {
+        wxFAIL_MSG( wxT("wxColour: couldn't find colour") );
+    }

 }
 
 wxColour::~wxColour()
 {
 }
 
 }
 
 wxColour::~wxColour()
 {
 }
 

-wxColour& wxColour::operator = ( const wxColour& col )
-{
-    if (*this == col) return (*this);
-    Ref( col );
-    return *this;
-}
-

 bool wxColour::operator == ( const wxColour& col ) const
 {
 bool wxColour::operator == ( const wxColour& col ) const
 {

-    if (m_refData == col.m_refData) return TRUE;
-    
-    if (!m_refData) return FALSE;
-    if (!col.m_refData) return FALSE;
-    
+    if (m_refData == col.m_refData)
+        return true;
+
+    if (!m_refData || !col.m_refData)
+        return false;
+

     GdkColor *own = &(((wxColourRefData*)m_refData)->m_color);
     GdkColor *other = &(((wxColourRefData*)col.m_refData)->m_color);
     GdkColor *own = &(((wxColourRefData*)m_refData)->m_color);
     GdkColor *other = &(((wxColourRefData*)col.m_refData)->m_color);

-    if (own->red != other->red) return FALSE;
-    if (own->blue != other->blue) return FALSE;
-    if (own->green != other->green) return FALSE;
-    
-    return TRUE;
+    return own->red == other->red &&
+                own->blue == other->blue &&
+                     own->green == other->green;
+}
+
+wxObjectRefData *wxColour::CreateRefData() const
+{
+    return new wxColourRefData;

 }
 
 }
 

-bool wxColour::operator != ( const wxColour& col) const
+wxObjectRefData *wxColour::CloneRefData(const wxObjectRefData *data) const

 {
 {

-    return m_refData != col.m_refData;
+    return new wxColourRefData(*(wxColourRefData *)data);

 }
 
 void wxColour::Set( unsigned char red, unsigned char green, unsigned char blue )
 {
 }
 
 void wxColour::Set( unsigned char red, unsigned char green, unsigned char blue )
 {

-    UnRef();
-    m_refData = new wxColourRefData();
+    AllocExclusive();
+

     M_COLDATA->m_color.red = ((unsigned short)red) << SHIFT;
     M_COLDATA->m_color.green = ((unsigned short)green) << SHIFT;
     M_COLDATA->m_color.blue = ((unsigned short)blue) << SHIFT;
     M_COLDATA->m_color.pixel = 0;
     M_COLDATA->m_color.red = ((unsigned short)red) << SHIFT;
     M_COLDATA->m_color.green = ((unsigned short)green) << SHIFT;
     M_COLDATA->m_color.blue = ((unsigned short)blue) << SHIFT;
     M_COLDATA->m_color.pixel = 0;

+
+    M_COLDATA->m_colormap = (GdkColormap*) NULL;
+    M_COLDATA->m_hasPixel = false;

 }
 
 unsigned char wxColour::Red() const
 {
 }
 
 unsigned char wxColour::Red() const
 {

-    wxCHECK_MSG( Ok(), 0, _T("invalid colour") );
+    wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );

 
     return (unsigned char)(M_COLDATA->m_color.red >> SHIFT);
 }
 
 unsigned char wxColour::Green() const
 {
 
     return (unsigned char)(M_COLDATA->m_color.red >> SHIFT);
 }
 
 unsigned char wxColour::Green() const
 {

-    wxCHECK_MSG( Ok(), 0, _T("invalid colour") );
+    wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );

 
     return (unsigned char)(M_COLDATA->m_color.green >> SHIFT);
 }
 
 unsigned char wxColour::Blue() const
 {
 
     return (unsigned char)(M_COLDATA->m_color.green >> SHIFT);
 }
 
 unsigned char wxColour::Blue() const
 {

-    wxCHECK_MSG( Ok(), 0, _T("invalid colour") );
+    wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );

 
     return (unsigned char)(M_COLDATA->m_color.blue >> SHIFT);
 }
 
 
     return (unsigned char)(M_COLDATA->m_color.blue >> SHIFT);
 }
 

-bool wxColour::Ok() const
-{
-    return (m_refData != NULL);
-}
-

 void wxColour::CalcPixel( GdkColormap *cmap )
 {
     if (!Ok()) return;
 
 void wxColour::CalcPixel( GdkColormap *cmap )
 {
     if (!Ok()) return;
 

-    if ((M_COLDATA->m_hasPixel) && (M_COLDATA->m_colormap == cmap)) return;
-    
-    M_COLDATA->FreeColour();
-
-    GdkColormapPrivate *private_colormap = (GdkColormapPrivate*) cmap;
-    if ((private_colormap->visual->type == GDK_VISUAL_GRAYSCALE) ||
-        (private_colormap->visual->type == GDK_VISUAL_PSEUDO_COLOR))
-    {
-        GdkColor *colors = cmap->colors;
-        int max = 3 * (65536);
-        int index = -1;
-
-        for (int i = 0; i < cmap->size; i++)
-        {
-            int rdiff = (M_COLDATA->m_color.red - colors[i].red);
-            int gdiff = (M_COLDATA->m_color.green - colors[i].green);
-            int bdiff = (M_COLDATA->m_color.blue - colors[i].blue);
-            int sum = ABS (rdiff) + ABS (gdiff) + ABS (bdiff);
-            if (sum < max) { index = i; max = sum; }
-        }
-
-        M_COLDATA->m_hasPixel = TRUE;
-        M_COLDATA->m_color.pixel = index;
-    }
-    else
-    { 
-        M_COLDATA->m_hasPixel = gdk_color_alloc( cmap, &M_COLDATA->m_color );
-    }
-
-    M_COLDATA->m_colormap = cmap;
+    M_COLDATA->AllocColour( cmap );

 }
 
 int wxColour::GetPixel() const
 {
 }
 
 int wxColour::GetPixel() const
 {

-    wxCHECK_MSG( Ok(), 0, _T("invalid colour") );
+    wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );

 
     return M_COLDATA->m_color.pixel;
 }
 
 GdkColor *wxColour::GetColor() const
 {
 
     return M_COLDATA->m_color.pixel;
 }
 
 GdkColor *wxColour::GetColor() const
 {

-    wxCHECK_MSG( Ok(), (GdkColor *) NULL, _T("invalid colour") );
+    wxCHECK_MSG( Ok(), (GdkColor *) NULL, wxT("invalid colour") );

 
     return &M_COLDATA->m_color;
 }
 
     return &M_COLDATA->m_color;
 }