fixing overrelease and out-of-bounds write, fixes #13725

[wxWidgets.git] / src / common / encconv.cpp

diff --git a/src/common/encconv.cpp b/src/common/encconv.cpp
index 92c8b04362f0092e81484acd7091b1c3fa300f1e..e666b9f245ba2e33bcf05bafa4c229a7581e59a1 100644 (file)
--- a/src/common/encconv.cpp
+++ b/src/common/encconv.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        encconv.cpp
+// Name:        src/common/encconv.cpp

 // Purpose:     wxEncodingConverter class for converting between different
 //              font encodings
 // Author:      Vaclav Slavik
 // Purpose:     wxEncodingConverter class for converting between different
 //              font encodings
 // Author:      Vaclav Slavik


@@ -25,12 +25,6 @@
     #include "unictabl.inc"
 #endif
 
     #include "unictabl.inc"
 #endif
 

-#if wxUSE_WCHAR_T
-    typedef wchar_t tchar;
-#else
-    typedef char tchar;
-#endif
-

 #ifdef __WXMAC__
     #include "wx/osx/core/cfstring.h"
     #include <CoreFoundation/CFStringEncodingExt.h>
 #ifdef __WXMAC__
     #include "wx/osx/core/cfstring.h"
     #include <CoreFoundation/CFStringEncodingExt.h>


@@ -122,11 +116,7 @@ bool wxEncodingConverter::Init(wxFontEncoding input_enc, wxFontEncoding output_e
     const wxUint16 *in_tbl;
     const wxUint16 *out_tbl = NULL;
 
     const wxUint16 *in_tbl;
     const wxUint16 *out_tbl = NULL;
 

-    if (m_Table) {delete[] m_Table; m_Table = NULL;}
-
-#if !wxUSE_WCHAR_T
-    if (input_enc == wxFONTENCODING_UNICODE || output_enc == wxFONTENCODING_UNICODE) return false;
-#endif
+    wxDELETEA(m_Table);

 
     if (input_enc == output_enc) {m_JustCopy = true; return true;}
 
 
     if (input_enc == output_enc) {m_JustCopy = true; return true;}
 


@@ -137,18 +127,18 @@ bool wxEncodingConverter::Init(wxFontEncoding input_enc, wxFontEncoding output_e
     {
         if ((out_tbl = GetEncTable(output_enc)) == NULL) return false;
 
     {
         if ((out_tbl = GetEncTable(output_enc)) == NULL) return false;
 

-        m_Table = new tchar[65536];
-        for (i = 0; i < 128; i++)  m_Table[i] = (tchar)i; // 7bit ASCII
-        for (i = 128; i < 65536; i++)  m_Table[i] = (tchar)0;
+        m_Table = new wchar_t[65536];
+        for (i = 0; i < 128; i++)  m_Table[i] = (wchar_t)i; // 7bit ASCII
+        for (i = 128; i < 65536; i++)  m_Table[i] = (wchar_t)0;

 
         if (method == wxCONVERT_SUBSTITUTE)
         {
             for (i = 0; i < encoding_unicode_fallback_count; i++)
 
         if (method == wxCONVERT_SUBSTITUTE)
         {
             for (i = 0; i < encoding_unicode_fallback_count; i++)

-                m_Table[encoding_unicode_fallback[i].c] = (tchar) encoding_unicode_fallback[i].s;
+                m_Table[encoding_unicode_fallback[i].c] = (wchar_t) encoding_unicode_fallback[i].s;

         }
 
         for (i = 0; i < 128; i++)
         }
 
         for (i = 0; i < 128; i++)

-            m_Table[out_tbl[i]] = (tchar)(128 + i);
+            m_Table[out_tbl[i]] = (wchar_t)(128 + i);

 
         m_UnicodeInput = true;
     }
 
         m_UnicodeInput = true;
     }


@@ -160,12 +150,12 @@ bool wxEncodingConverter::Init(wxFontEncoding input_enc, wxFontEncoding output_e
 
         m_UnicodeInput = false;
 
 
         m_UnicodeInput = false;
 

-        m_Table = new tchar[256];
-        for (i = 0; i < 128; i++)  m_Table[i] = (tchar)i; // 7bit ASCII
+        m_Table = new wchar_t[256];
+        for (i = 0; i < 128; i++)  m_Table[i] = (wchar_t)i; // 7bit ASCII

 
         if (output_enc == wxFONTENCODING_UNICODE)
         {
 
         if (output_enc == wxFONTENCODING_UNICODE)
         {

-            for (i = 0; i < 128; i++)  m_Table[128 + i] = (tchar)in_tbl[i];
+            for (i = 0; i < 128; i++)  m_Table[128 + i] = (wchar_t)in_tbl[i];

             return true;
         }
         else // output !Unicode
             return true;
         }
         else // output !Unicode


@@ -182,13 +172,9 @@ bool wxEncodingConverter::Init(wxFontEncoding input_enc, wxFontEncoding output_e
                     item = (CharsetItem*) bsearch(&key, encoding_unicode_fallback,
                                 encoding_unicode_fallback_count, sizeof(CharsetItem), CompareCharsetItems);
                 if (item)
                     item = (CharsetItem*) bsearch(&key, encoding_unicode_fallback,
                                 encoding_unicode_fallback_count, sizeof(CharsetItem), CompareCharsetItems);
                 if (item)

-                    m_Table[128 + i] = (tchar)item -> c;
+                    m_Table[128 + i] = (wchar_t)item -> c;

                 else
                 else

-#if wxUSE_WCHAR_T

                     m_Table[128 + i] = (wchar_t)(128 + i);
                     m_Table[128 + i] = (wchar_t)(128 + i);

-#else
-                    m_Table[128 + i] = (char)(128 + i);
-#endif

             }
 
             delete[] rev;
             }
 
             delete[] rev;


@@ -199,11 +185,11 @@ bool wxEncodingConverter::Init(wxFontEncoding input_enc, wxFontEncoding output_e
 }
 
 
 }
 
 

-#define REPLACEMENT_CHAR  ((tchar)'?')
+#define REPLACEMENT_CHAR  (L'?')

 
 

-inline tchar GetTableValue(const tchar *table, tchar value, bool& repl)
+inline wchar_t GetTableValue(const wchar_t *table, wchar_t value, bool& repl)

 {
 {

-    tchar r = table[value];
+    wchar_t r = table[value];

     if (r == 0 && value != 0)
     {
         r = REPLACEMENT_CHAR;
     if (r == 0 && value != 0)
     {
         r = REPLACEMENT_CHAR;


@@ -240,8 +226,6 @@ bool wxEncodingConverter::Convert(const char* input, char* output) const
 }
 
 
 }
 
 

-#if wxUSE_WCHAR_T
-

 bool wxEncodingConverter::Convert(const char* input, wchar_t* output) const
 {
     wxASSERT_MSG(m_UnicodeOutput, wxT("You cannot convert to 8-bit if output is const wchar_t*!"));
 bool wxEncodingConverter::Convert(const char* input, wchar_t* output) const
 {
     wxASSERT_MSG(m_UnicodeOutput, wxT("You cannot convert to 8-bit if output is const wchar_t*!"));


@@ -331,8 +315,6 @@ bool wxEncodingConverter::Convert(const wchar_t* input, wchar_t* output) const
     return !replaced;
 }
 
     return !replaced;
 }
 

-#endif // wxUSE_WCHAR_T
-

 
 wxString wxEncodingConverter::Convert(const wxString& input) const
 {
 
 wxString wxEncodingConverter::Convert(const wxString& input) const
 {


@@ -462,7 +444,7 @@ wxFontEncodingArray wxEncodingConverter::GetPlatformEquivalents(wxFontEncoding e
 {
     if (platform == wxPLATFORM_CURRENT)
     {
 {
     if (platform == wxPLATFORM_CURRENT)
     {

-#if defined(__WXMSW__)
+#if defined(__WINDOWS__)

         platform = wxPLATFORM_WINDOWS;
 #elif defined(__WXGTK__) || defined(__WXMOTIF__)
         platform = wxPLATFORM_UNIX;
         platform = wxPLATFORM_WINDOWS;
 #elif defined(__WXGTK__) || defined(__WXMOTIF__)
         platform = wxPLATFORM_UNIX;