Applied #15375 to stop event-sending in generic wxSpinCtrl ctor (eco)

[wxWidgets.git] / src / common / containr.cpp

diff --git a/src/common/containr.cpp b/src/common/containr.cpp
index 29756da6960d4e1bd0f2217e81767aa8e3af0f8f..50bbd6aefaba84856e3dbe32fa476686c522b385 100644 (file)
--- a/src/common/containr.cpp
+++ b/src/common/containr.cpp
@@ -4,7 +4,6 @@
 // Author:      Vadim Zeitlin
 // Modified by:
 // Created:     06.08.01
 // Author:      Vadim Zeitlin
 // Modified by:
 // Created:     06.08.01

-// RCS-ID:      $Id$

 // Copyright:   (c) 2001 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 // Copyright:   (c) 2001 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////


@@ -47,14 +46,25 @@
 // wxControlContainerBase
 // ----------------------------------------------------------------------------
 
 // wxControlContainerBase
 // ----------------------------------------------------------------------------
 

-void wxControlContainerBase::SetCanFocus(bool acceptsFocus)
+void wxControlContainerBase::UpdateParentCanFocus()

 {
 {

-    if ( acceptsFocus == m_acceptsFocus )
-        return;
+    // In the ports where it does something non trivial, the parent window
+    // should only be focusable if it doesn't have any focusable children
+    // (e.g. native focus handling in wxGTK totally breaks down otherwise).
+    m_winParent->SetCanFocus(m_acceptsFocusSelf && !m_acceptsFocusChildren);
+}
+
+bool wxControlContainerBase::UpdateCanFocusChildren()
+{
+    const bool acceptsFocusChildren = HasAnyFocusableChildren();
+    if ( acceptsFocusChildren != m_acceptsFocusChildren )
+    {
+        m_acceptsFocusChildren = acceptsFocusChildren;

 
 

-    m_acceptsFocus = acceptsFocus;
+        UpdateParentCanFocus();
+    }

 
 

-    m_winParent->SetCanFocus(m_acceptsFocus);
+    return m_acceptsFocusChildren;

 }
 
 bool wxControlContainerBase::HasAnyFocusableChildren() const
 }
 
 bool wxControlContainerBase::HasAnyFocusableChildren() const


@@ -70,6 +80,30 @@ bool wxControlContainerBase::HasAnyFocusableChildren() const
         if ( !m_winParent->IsClientAreaChild(child) )
             continue;
 
         if ( !m_winParent->IsClientAreaChild(child) )
             continue;
 

+        // Here we check whether the child can accept the focus at all, as we
+        // want to try focusing it later even if it can't accept it right now.
+        if ( child->AcceptsFocusRecursively() )
+            return true;
+    }
+
+    return false;
+}
+
+bool wxControlContainerBase::HasAnyChildrenAcceptingFocus() const
+{
+    const wxWindowList& children = m_winParent->GetChildren();
+    for ( wxWindowList::const_iterator i = children.begin(),
+                                     end = children.end();
+          i != end;
+          ++i )
+    {
+        const wxWindow * const child = *i;
+
+        if ( !m_winParent->IsClientAreaChild(child) )
+            continue;
+
+        // Here we check if the child accepts focus right now as we need to
+        // know if we can give the focus to it or not.

         if ( child->CanAcceptFocus() )
             return true;
     }
         if ( child->CanAcceptFocus() )
             return true;
     }


@@ -118,6 +152,11 @@ bool wxControlContainerBase::DoSetFocus()
     return ret;
 }
 
     return ret;
 }
 

+bool wxControlContainerBase::AcceptsFocus() const
+{
+    return m_acceptsFocusSelf && m_winParent->CanBeFocused();
+}
+

 bool wxControlContainerBase::SetFocusToChild()
 {
     return wxSetFocusToChild(m_winParent, &m_winLastFocused);
 bool wxControlContainerBase::SetFocusToChild()
 {
     return wxSetFocusToChild(m_winParent, &m_winLastFocused);


@@ -174,19 +213,6 @@ void wxControlContainer::SetLastFocus(wxWindow *win)
             wxLogTrace(TRACE_FOCUS, wxT("No more last focus"));
         }
     }
             wxLogTrace(TRACE_FOCUS, wxT("No more last focus"));
         }
     }

-
-    // propagate the last focus upwards so that our parent can set focus back
-    // to us if it loses it now and regains later; do *not* do this if we are
-    // a toplevel window (e.g. wxDialog) that has another frame as its parent
-    if ( !m_winParent->IsTopLevel() )
-    {
-        wxWindow *parent = m_winParent->GetParent();
-        if ( parent )
-        {
-            wxChildFocusEvent eventFocus(m_winParent);
-            parent->GetEventHandler()->ProcessEvent(eventFocus);
-        }
-    }

 }
 
 // --------------------------------------------------------------------
 }
 
 // --------------------------------------------------------------------


@@ -194,7 +220,7 @@ void wxControlContainer::SetLastFocus(wxWindow *win)
 // within the same group. Used by wxSetFocusToChild on wxMSW
 // --------------------------------------------------------------------
 
 // within the same group. Used by wxSetFocusToChild on wxMSW
 // --------------------------------------------------------------------
 

-#if defined(__WXMSW__) && wxUSE_RADIOBTN
+#if wxUSE_RADIOBTN 

 
 wxRadioButton* wxGetPreviousButtonInGroup(wxRadioButton *btn)
 {
 
 wxRadioButton* wxGetPreviousButtonInGroup(wxRadioButton *btn)
 {


@@ -472,18 +498,21 @@ void wxControlContainer::HandleOnNavigationKey( wxNavigationKeyEvent& event )
                 // looping inside this panel (normally, the focus will go to
                 // the next/previous item after this panel in the parent
                 // panel).
                 // looping inside this panel (normally, the focus will go to
                 // the next/previous item after this panel in the parent
                 // panel).

-                wxWindow *focussed_child_of_parent = m_winParent;
+                wxWindow *focusedParent = m_winParent;

                 while ( parent )
                 {
                 while ( parent )
                 {

-                    // we don't want to tab into a different dialog or frame
-                    if ( focussed_child_of_parent->IsTopLevel() )
+                    // We don't want to tab into a different dialog or frame or
+                    // even an MDI child frame, so test for this explicitly
+                    // (and in particular don't just use IsTopLevel() which
+                    // would return false in the latter case).
+                    if ( focusedParent->IsTopNavigationDomain() )

                         break;
 
                         break;
 

-                    event.SetCurrentFocus( focussed_child_of_parent );
+                    event.SetCurrentFocus( focusedParent );

                     if ( parent->GetEventHandler()->ProcessEvent( event ) )
                         return;
 
                     if ( parent->GetEventHandler()->ProcessEvent( event ) )
                         return;
 

-                    focussed_child_of_parent = parent;
+                    focusedParent = parent;

 
                     parent = parent->GetParent();
                 }
 
                     parent = parent->GetParent();
                 }


@@ -650,17 +679,27 @@ bool wxSetFocusToChild(wxWindow *win, wxWindow **childLastFocused)
         // It might happen that the window got reparented
         if ( (*childLastFocused)->GetParent() == win )
         {
         // It might happen that the window got reparented
         if ( (*childLastFocused)->GetParent() == win )
         {

-            // And it also could have become hidden in the meanwhile, in this
-            // case focus its parent instead.
-            while ( !(*childLastFocused)->IsShown() )
+            // And it also could have become hidden in the meanwhile
+            // We want to focus on the deepest widget visible
+            wxWindow *deepestVisibleWindow = NULL;
+
+            while ( *childLastFocused )

             {
             {

+                if ( (*childLastFocused)->IsShown() )
+                {
+                    if ( !deepestVisibleWindow )
+                        deepestVisibleWindow = *childLastFocused;
+                }
+                else
+                    deepestVisibleWindow = NULL;
+

                 *childLastFocused = (*childLastFocused)->GetParent();
                 *childLastFocused = (*childLastFocused)->GetParent();

-                if ( !*childLastFocused )
-                    break;

             }
 
             }
 

-            if ( *childLastFocused )
+            if ( deepestVisibleWindow )

             {
             {

+                *childLastFocused = deepestVisibleWindow;
+

                 wxLogTrace(TRACE_FOCUS,
                            wxT("SetFocusToChild() => last child (0x%p)."),
                            (*childLastFocused)->GetHandle());
                 wxLogTrace(TRACE_FOCUS,
                            wxT("SetFocusToChild() => last child (0x%p)."),
                            (*childLastFocused)->GetHandle());