got rid of wxSocketBase::m_error which could get out of sync with wxSocketImpl::m_err...

[wxWidgets.git] / src / common / init.cpp

diff --git a/src/common/init.cpp b/src/common/init.cpp
index bb5693e4a99e9f650fdc725a78c8d5c8ff1713ab..49e211f064ec8f8b8dec40ba8196ef2ad2117c5d 100644 (file)
--- a/src/common/init.cpp
+++ b/src/common/init.cpp
@@ -27,12 +27,12 @@
     #include "wx/app.h"
     #include "wx/filefn.h"
     #include "wx/log.h"
     #include "wx/app.h"
     #include "wx/filefn.h"
     #include "wx/log.h"

-    #include "wx/thread.h"

     #include "wx/intl.h"
     #include "wx/module.h"
 #endif
 
 #include "wx/init.h"
     #include "wx/intl.h"
     #include "wx/module.h"
 #endif
 
 #include "wx/init.h"

+#include "wx/thread.h"

 
 #include "wx/ptr_scpd.h"
 #include "wx/except.h"
 
 #include "wx/ptr_scpd.h"
 #include "wx/except.h"


@@ -179,7 +179,11 @@ static void ConvertArgsToUnicode(int argc, char **argv)
     int wargc = 0;
     for ( int i = 0; i < argc; i++ )
     {
     int wargc = 0;
     for ( int i = 0; i < argc; i++ )
     {

+#ifdef __DARWIN__
+        wxWCharBuffer buf(wxConvFileName->cMB2WX(argv[i]));
+#else

         wxWCharBuffer buf(wxConvLocal.cMB2WX(argv[i]));
         wxWCharBuffer buf(wxConvLocal.cMB2WX(argv[i]));

+#endif

         if ( !buf )
         {
             wxLogWarning(_("Command line argument %d couldn't be converted to Unicode and will be ignored."),
         if ( !buf )
         {
             wxLogWarning(_("Command line argument %d couldn't be converted to Unicode and will be ignored."),


@@ -220,6 +224,9 @@ static void FreeConvertedArgs()
 static bool DoCommonPreInit()
 {
 #if wxUSE_LOG
 static bool DoCommonPreInit()
 {
 #if wxUSE_LOG

+    // Reset logging in case we were cleaned up and are being reinitialized.
+    wxLog::DoCreateOnDemand();
+

     // install temporary log sink: we can't use wxLogGui before wxApp is
     // constructed and if we use wxLogStderr, all messages during
     // initialization simply disappear under Windows
     // install temporary log sink: we can't use wxLogGui before wxApp is
     // constructed and if we use wxLogStderr, all messages during
     // initialization simply disappear under Windows


@@ -242,6 +249,43 @@ static bool DoCommonPostInit()
         return false;
     }
 
         return false;
     }
 

+#if defined(__WXDEBUG__)
+    // check if event classes implement Clone() correctly
+    // NOTE: the check is done against _all_ event classes which are linked to
+    //       the executable currently running, which are not necessarily all
+    //       wxWidgets event classes.
+    const wxClassInfo *ci = wxClassInfo::GetFirst();
+    for (; ci; ci = ci->GetNext())
+    {
+        // is this class derived from wxEvent?
+        if (!ci->IsKindOf(CLASSINFO(wxEvent)) || wxString(ci->GetClassName()) == "wxEvent")
+            continue;
+
+        if (!ci->IsDynamic())
+        {
+            wxLogWarning("The event class '%s' should have a DECLARE_DYNAMIC_CLASS macro!",
+                         ci->GetClassName());
+            continue;
+        }
+
+        // yes; test if it implements Clone() correctly
+        wxEvent* test = dynamic_cast<wxEvent*>(ci->CreateObject());
+        if (test == NULL)
+        {
+            wxLogWarning("The event class '%s' should have a DECLARE_DYNAMIC_CLASS macro!",
+                         ci->GetClassName());
+            continue;
+        }
+
+        wxEvent* cloned = test->Clone();
+        if (!cloned || cloned->GetClassInfo() != ci)
+            wxLogWarning("The event class '%s' does not correctly implement Clone()!",
+                         ci->GetClassName());
+
+        delete test;
+    }
+#endif
+

     return true;
 }
 
     return true;
 }
 


@@ -291,6 +335,12 @@ bool wxEntryStart(int& argc, wxChar **argv)
         return false;
     }
 
         return false;
     }
 

+    // remember, possibly modified (e.g. due to removal of toolkit-specific
+    // parameters), command line arguments in member variables
+    app->argc = argc;
+    app->argv = argv;
+
+

     wxCallAppCleanup callAppCleanup(app.get());
 
     // for compatibility call the old initialization function too
     wxCallAppCleanup callAppCleanup(app.get());
 
     // for compatibility call the old initialization function too


@@ -391,8 +441,12 @@ void wxEntryCleanup()
     {
         wxTheApp->CleanUp();
 
     {
         wxTheApp->CleanUp();
 

-        delete wxTheApp;
+        // reset the global pointer to it to NULL before destroying it as in
+        // some circumstances this can result in executing the code using
+        // wxTheApp and using half-destroyed object is no good
+        wxAppConsole * const app = wxApp::GetInstance();

         wxApp::SetInstance(NULL);
         wxApp::SetInstance(NULL);

+        delete app;

     }
 
 
     }