]> git.saurik.com Git - wxWidgets.git/blobdiff - src/gtk/dnd.cpp
projects / wxWidgets.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
Don't scale 16x15 to 16x16 - fixes corruption of bookmark icons in help window
[wxWidgets.git] / src / gtk / dnd.cpp
diff --git a/src/gtk/dnd.cpp b/src/gtk/dnd.cpp
index ff56d90299eaeaa436ba63bf66ae2a7756585584..c7bdf480a8d6f1260a6c309424c8f5c07dd3ee61 100644 (file)
--- a/src/gtk/dnd.cpp
+++ b/src/gtk/dnd.cpp
@@ -1,31 +1,32 @@
 ///////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////
-// Name:        dnd.cpp
+// Name:        src/gtk/dnd.cpp
 // Purpose:     wxDropTarget class
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Purpose:     wxDropTarget class
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
-// Licence:    wxWindows licence
+// Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
 ///////////////////////////////////////////////////////////////////////////////
 
-#ifdef __GNUG__
-#pragma implementation "dnd.h"
-#endif
-
-#include "wx/dnd.h"
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
 
 #if wxUSE_DRAG_AND_DROP
 
 
 #if wxUSE_DRAG_AND_DROP
 
-#include "wx/window.h"
-#include "wx/app.h"
-#include "wx/gdicmn.h"
-#include "wx/intl.h"
-#include "wx/utils.h"
+#include "wx/dnd.h"
+
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/log.h"
+    #include "wx/app.h"
+    #include "wx/utils.h"
+    #include "wx/window.h"
+    #include "wx/gdicmn.h"
+#endif
 
 
-#include "gdk/gdk.h"
-#include "gtk/gtk.h"
-#include "gdk/gdkprivate.h"
+#include "wx/scopeguard.h"
 
 
-#include <X11/Xlib.h>
+#include <gtk/gtk.h>
+#include "wx/gtk/private/gtk2-compat.h"
 
 //----------------------------------------------------------------------------
 // global data
 
 //----------------------------------------------------------------------------
 // global data
@@ -33,1246 +34,866 @@
 
 extern bool g_blockEventsOnDrag;
 
 
 extern bool g_blockEventsOnDrag;
 
+// the flags used for the last DoDragDrop()
+static long gs_flagsForDrag = 0;
+
+// the trace mask we use with wxLogTrace() - call
+// wxLog::AddTraceMask(TRACE_DND) to enable the trace messages from here
+// (there are quite a few of them, so don't enable this by default)
+#define TRACE_DND "dnd"
+
+// global variables because GTK+ DnD want to have the
+// mouse event that caused it
+extern GdkEvent *g_lastMouseEvent;
+extern int       g_lastButtonNumber;
+
 //----------------------------------------------------------------------------
 // standard icons
 //----------------------------------------------------------------------------
 
 //----------------------------------------------------------------------------
 // standard icons
 //----------------------------------------------------------------------------
 
-/* XPM */
-static char * gv_xpm[] = {
-"40 34 3 1",
-"      s None c None",
-".     c black",
-"X     c white",
-"                                        ",
-"                                        ",
-"                  ......                ",
-"                ..XXXXXX..              ",
-"               .XXXXXXXXXX.             ",
-"              .XXXXXXXXXXXX.            ",
-"              .XXXXXXXXXXXX.            ",
-"             .XXXXXXXXXXXXXX.           ",
-"             .XXX..XXXX..XXX.           ",
-"          ....XX....XX....XX.           ",
-"         .XXX.XXX..XXXX..XXX....        ",
-"        .XXXXXXXXXXXXXXXXXXX.XXX.       ",
-"        .XXXXXXXXXXXXXXXXXXXXXXXX.      ",
-"        .XXXXXXXXXXXXXXXXXXXXXXXX.      ",
-"         ..XXXXXXXXXXXXXXXXXXXXXX.      ",
-"           .XXXXXXXXXXXXXXXXXX...       ",
-"           ..XXXXXXXXXXXXXXXX.          ",
-"            .XXXXXXXXXXXXXXXX.          ",
-"            .XXXXXXXXXXXXXXXX.          ",
-"            .XXXXXXXXXXXXXXXXX.         ",
-"            .XXXXXXXXXXXXXXXXX.         ",
-"            .XXXXXXXXXXXXXXXXXX.        ",
-"            .XXXXXXXXXXXXXXXXXXX.       ",
-"           .XXXXXXXXXXXXXXXXXXXXX.      ",
-"           .XXXXXXXXXXXXXX.XXXXXXX.     ",
-"          .XXXXXXX.XXXXXXX.XXXXXXX.     ",
-"         .XXXXXXXX.XXXXXXX.XXXXXXX.     ",
-"         .XXXXXXX...XXXXX...XXXXX.      ",
-"         .XXXXXXX.  .....   .....       ",
-"         ..XXXX..                       ",
-"           ....                         ",
-"                                        ",
-"                                        ",
-"                                        "};
-                             
-/* XPM */
-static char * page_xpm[] = {
-/* width height ncolors chars_per_pixel */
-"32 32 5 1",
-/* colors */
-"      s None  c None",
-".     c black",
-"X     c wheat",
-"o     c tan",
-"O     c #6699FF",
+/* Copyright (c) Julian Smart */
+static const char * page_xpm[] = {
+/* columns rows colors chars-per-pixel */
+"32 32 37 1",
+"5 c #7198D9",
+", c #769CDA",
+"2 c #DCE6F6",
+"i c #FFFFFF",
+"e c #779DDB",
+": c #9AB6E4",
+"9 c #EAF0FA",
+"- c #B1C7EB",
+"$ c #6992D7",
+"y c #F7F9FD",
+"= c #BED0EE",
+"q c #F0F5FC",
+"; c #A8C0E8",
+"@ c #366BC2",
+"  c None",
+"u c #FDFEFF",
+"8 c #5987D3",
+"* c #C4D5F0",
+"7 c #7CA0DC",
+"O c #487BCE",
+"< c #6B94D7",
+"& c #CCDAF2",
+"> c #89A9DF",
+"3 c #5584D1",
+"w c #82A5DE",
+"1 c #3F74CB",
+"+ c #3A70CA",
+". c #3569BF",
+"% c #D2DFF4",
+"# c #3366BB",
+"r c #F5F8FD",
+"0 c #FAFCFE",
+"4 c #DFE8F7",
+"X c #5E8AD4",
+"o c #5282D0",
+"t c #B8CCEC",
+"6 c #E5EDF9",
 /* pixels */
 /* pixels */
-"    ...................         ",
-"    .XXXXXXXXXXXXXXXXX..        ",
-"    .XXXXXXXXXXXXXXXXX.o.       ",
-"    .XXXXXXXXXXXXXXXXX.oo.      ",
-"    .XXXXXXXXXXXXXXXXX.ooo.     ",
-"    .XXXXXXXXXXXXXXXXX.oooo.    ",
-"    .XXXXXXXXXXXXXXXXX.......   ",
-"    .XXXXXOOOOOOOOOOXXXooooo.   ",
-"    .XXXXXXXXXXXXXXXXXXooooo.   ",
-"    .XXXXXOOOOOOOOOOXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXOOOOOOOOOXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXOOOOOOOOOOXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXOOOOOOOOOOXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXOOOOOOOOOXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXOOOOOOOOOOXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXOOOOOOOOOOXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXOOOOOOOOOOXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXOOOOOOOXXXXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .XXXXXXXXXXXXXXXXXXXXXXX.   ",
-"    .........................   "};
-                             
-                             
-#if (GTK_MINOR_VERSION > 0)
-
-#include "gtk/gtkdnd.h"
-#include "gtk/gtkselection.h"
+"                                ",
+"                                ",
+"                                ",
+"                                ",
+"                                ",
+"       .XXXooOO++@#             ",
+"       $%&*=-;::>,<1            ",
+"       $2%&*=-;::><:3           ",
+"       $42%&*=-;::<&:3          ",
+"       56477<<<<8<<9&:X         ",
+"       59642%&*=-;<09&:5        ",
+"       5q9642%&*=-<<<<<#        ",
+"       5qqw777<<<<<88:>+        ",
+"       erqq9642%&*=t;::+        ",
+"       eyrqq9642%&*=t;:O        ",
+"       eyywwww777<<<<t;O        ",
+"       e0yyrqq9642%&*=to        ",
+"       e00yyrqq9642%&*=o        ",
+"       eu0wwwwwww777<&*X        ",
+"       euu00yyrqq9642%&X        ",
+"       eiuu00yyrqq9642%X        ",
+"       eiiwwwwwwwwww742$        ",
+"       eiiiuu00yyrqq964$        ",
+"       eiiiiuu00yyrqq96$        ",
+"       eiiiiiuu00yyrqq95        ",
+"       eiiiiiiuu00yyrqq5        ",
+"       eeeeeeeeeeeeee55e        ",
+"                                ",
+"                                ",
+"                                ",
+"                                ",
+"                                "
+};
+
+
+// ============================================================================
+// private functions
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// convert between GTK+ and wxWidgets DND constants
+// ----------------------------------------------------------------------------
+
+static wxDragResult ConvertFromGTK(long action)
+{
+    switch ( action )
+    {
+        case GDK_ACTION_COPY:
+            return wxDragCopy;
+
+        case GDK_ACTION_LINK:
+            return wxDragLink;
+
+        case GDK_ACTION_MOVE:
+            return wxDragMove;
+    }
+
+    return wxDragNone;
+}
 
 // ----------------------------------------------------------------------------
 // "drag_leave"
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // "drag_leave"
 // ----------------------------------------------------------------------------
 
+extern "C" {
 static void target_drag_leave( GtkWidget *WXUNUSED(widget),
 static void target_drag_leave( GtkWidget *WXUNUSED(widget),
-                              GdkDragContext *context,
-                              guint WXUNUSED(time),
-                              wxDropTarget *dt )
+                               GdkDragContext *context,
+                               guint WXUNUSED(time),
+                               wxDropTarget *drop_target )
 {
 {
-    dt->SetDragContext( context );
-    dt->OnLeave();
-    dt->SetDragContext( (GdkDragContext*) NULL );
+    /* inform the wxDropTarget about the current GdkDragContext.
+       this is only valid for the duration of this call */
+    drop_target->GTKSetDragContext( context );
+
+    /* we don't need return values. this event is just for
+       information */
+    drop_target->OnLeave();
+
+    /* this has to be done because GDK has no "drag_enter" event */
+    drop_target->m_firstMotion = true;
+
+    /* after this, invalidate the drop_target's GdkDragContext */
+    drop_target->GTKSetDragContext( NULL );
+}
 }
 
 // ----------------------------------------------------------------------------
 // "drag_motion"
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // "drag_motion"
 // ----------------------------------------------------------------------------
 
+extern "C" {
 static gboolean target_drag_motion( GtkWidget *WXUNUSED(widget),
 static gboolean target_drag_motion( GtkWidget *WXUNUSED(widget),
-                                   GdkDragContext *context,
-                                   gint x,
-                                   gint y,
-                                   guint time,
-                                   wxDropTarget *dt )
-{
-    dt->SetDragContext( context );
-    
-    if (dt->OnMove( x, y ))
+                                    GdkDragContext *context,
+                                    gint x,
+                                    gint y,
+                                    guint time,
+                                    wxDropTarget *drop_target )
+{
+    /* Owen Taylor: "if the coordinates not in a drop zone,
+       return FALSE, otherwise call gtk_drag_status() and
+       return TRUE" */
+
+#if 0
+    wxPrintf( "motion\n" );
+    GList *tmp_list;
+    for (tmp_list = context->targets; tmp_list; tmp_list = tmp_list->next)
+    {
+        wxString atom = wxString::FromAscii( gdk_atom_name (GDK_POINTER_TO_ATOM (tmp_list->data)) );
+        wxPrintf( "Atom: %s\n", atom );
+    }
+#endif
+
+    // Inform the wxDropTarget about the current GdkDragContext.
+    // This is only valid for the duration of this call.
+    drop_target->GTKSetDragContext( context );
+
+    // Does the source actually accept the data type?
+    if (drop_target->GTKGetMatchingPair() == (GdkAtom) 0)
+    {
+        drop_target->GTKSetDragContext( NULL );
+        return FALSE;
+    }
+
+    wxDragResult suggested_action = drop_target->GTKFigureOutSuggestedAction();
+
+    wxDragResult result = wxDragNone;
+
+    if (drop_target->m_firstMotion)
     {
     {
-        gdk_drag_status( context, context->suggested_action, time );
+        // the first "drag_motion" event substitutes a "drag_enter" event
+        result = drop_target->OnEnter( x, y, suggested_action );
     }
     else
     {
     }
     else
     {
-        gdk_drag_status( context, (GdkDragAction)0, time );
+        // give program a chance to react (i.e. to say no by returning FALSE)
+        result = drop_target->OnDragOver( x, y, suggested_action );
     }
     }
-    
-    dt->SetDragContext( (GdkDragContext*) NULL );
-    return TRUE;
+
+    GdkDragAction result_action = GDK_ACTION_DEFAULT;
+    if (result == wxDragCopy)
+        result_action = GDK_ACTION_COPY;
+    else if (result == wxDragLink)
+        result_action = GDK_ACTION_LINK;
+    else
+        result_action = GDK_ACTION_MOVE;
+
+    // is result action actually supported
+    bool ret ((result_action != GDK_ACTION_DEFAULT) &&
+              (context->actions & result_action));
+
+    if (ret)
+        gdk_drag_status( context, result_action, time );
+
+    // after this, invalidate the drop_target's GdkDragContext
+    drop_target->GTKSetDragContext( NULL );
+
+    // this has to be done because GDK has no "drag_enter" event
+    drop_target->m_firstMotion = false;
+
+    return ret;
+}
 }
 
 // ----------------------------------------------------------------------------
 // "drag_drop"
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // "drag_drop"
 // ----------------------------------------------------------------------------
 
+extern "C" {
 static gboolean target_drag_drop( GtkWidget *widget,
 static gboolean target_drag_drop( GtkWidget *widget,
-                                 GdkDragContext *context,
-                                 gint x,
-                                 gint y,
-                                 guint time )
-{
-    printf( "drop at: %d,%d.\n", x, y );
-  
-    if (context->targets)
+                                  GdkDragContext *context,
+                                  gint x,
+                                  gint y,
+                                  guint time,
+                                  wxDropTarget *drop_target )
+{
+    /* Owen Taylor: "if the drop is not in a drop zone,
+       return FALSE, otherwise, if you aren't accepting
+       the drop, call gtk_drag_finish() with success == FALSE
+       otherwise call gtk_drag_data_get()" */
+
+    /* inform the wxDropTarget about the current GdkDragContext.
+       this is only valid for the duration of this call */
+    drop_target->GTKSetDragContext( context );
+
+    // Does the source actually accept the data type?
+    if (drop_target->GTKGetMatchingPair() == (GdkAtom) 0)
+    {
+        // cancel the whole thing
+        gtk_drag_finish( context,
+                          FALSE,        // no success
+                          FALSE,        // don't delete data on dropping side
+                          time );
+
+        drop_target->GTKSetDragContext( NULL );
+
+        drop_target->m_firstMotion = true;
+
+        return FALSE;
+    }
+
+    /* inform the wxDropTarget about the current drag widget.
+       this is only valid for the duration of this call */
+    drop_target->GTKSetDragWidget( widget );
+
+    /* inform the wxDropTarget about the current drag time.
+       this is only valid for the duration of this call */
+    drop_target->GTKSetDragTime( time );
+
+    /* reset the block here as someone might very well
+       show a dialog as a reaction to a drop and this
+       wouldn't work without events */
+    g_blockEventsOnDrag = false;
+
+    bool ret = drop_target->OnDrop( x, y );
+
+    if (!ret)
+    {
+        wxLogTrace(TRACE_DND, wxT( "Drop target: OnDrop returned FALSE") );
+
+        /* cancel the whole thing */
+        gtk_drag_finish( context,
+                          FALSE,        /* no success */
+                          FALSE,        /* don't delete data on dropping side */
+                          time );
+    }
+    else
     {
     {
-        gtk_drag_get_data( widget, 
-                          context, 
-                          GPOINTER_TO_INT (context->targets->data), 
-                          time );
+        wxLogTrace(TRACE_DND, wxT( "Drop target: OnDrop returned true") );
+
+        GdkAtom format = drop_target->GTKGetMatchingPair();
+
+        // this does happen somehow, see bug 555111
+        wxCHECK_MSG( format, FALSE, wxT("no matching GdkAtom for format?") );
+
+        /* this should trigger an "drag_data_received" event */
+        gtk_drag_get_data( widget,
+                           context,
+                           format,
+                           time );
     }
     }
-    return FALSE;
+
+    /* after this, invalidate the drop_target's GdkDragContext */
+    drop_target->GTKSetDragContext( NULL );
+
+    /* after this, invalidate the drop_target's drag widget */
+    drop_target->GTKSetDragWidget( NULL );
+
+    /* this has to be done because GDK has no "drag_enter" event */
+    drop_target->m_firstMotion = true;
+
+    return ret;
+}
 }
 
 // ----------------------------------------------------------------------------
 // "drag_data_received"
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // "drag_data_received"
 // ----------------------------------------------------------------------------
 
+extern "C" {
 static void target_drag_data_received( GtkWidget *WXUNUSED(widget),
 static void target_drag_data_received( GtkWidget *WXUNUSED(widget),
-                                      GdkDragContext *context,
-                                      gint x,
-                                      gint y,
-                                      GtkSelectionData *data,
-                                      guint WXUNUSED(info),
-                                      guint time )
-{
-    printf( "data receive at: %d,%d.\n", x, y );
-  
-    if ((data->length >= 0) && (data->format == 8))
+                                       GdkDragContext *context,
+                                       gint x,
+                                       gint y,
+                                       GtkSelectionData *data,
+                                       guint WXUNUSED(info),
+                                       guint time,
+                                       wxDropTarget *drop_target )
+{
+    /* Owen Taylor: "call gtk_drag_finish() with
+       success == TRUE" */
+
+    if (gtk_selection_data_get_length(data) <= 0 || gtk_selection_data_get_format(data) != 8)
     {
     {
-        wxString str = (const char*)data->data;
-        printf( "Received %s\n.", WXSTRINGCAST str );
-        gtk_drag_finish( context, TRUE, FALSE, time );
+        /* negative data length and non 8-bit data format
+           qualifies for junk */
+        gtk_drag_finish (context, FALSE, FALSE, time);
+
         return;
     }
         return;
     }
-  
-    gtk_drag_finish (context, FALSE, FALSE, time);
+
+    wxLogTrace(TRACE_DND, wxT( "Drop target: data received event") );
+
+    /* inform the wxDropTarget about the current GtkSelectionData.
+       this is only valid for the duration of this call */
+    drop_target->GTKSetDragData( data );
+
+    wxDragResult result = ConvertFromGTK(context->action);
+
+    if ( wxIsDragResultOk( drop_target->OnData( x, y, result ) ) )
+    {
+        wxLogTrace(TRACE_DND, wxT( "Drop target: OnData returned true") );
+
+        /* tell GTK that data transfer was successful */
+        gtk_drag_finish( context, TRUE, FALSE, time );
+    }
+    else
+    {
+        wxLogTrace(TRACE_DND, wxT( "Drop target: OnData returned FALSE") );
+
+        /* tell GTK that data transfer was not successful */
+        gtk_drag_finish( context, FALSE, FALSE, time );
+    }
+
+    /* after this, invalidate the drop_target's drag data */
+    drop_target->GTKSetDragData( NULL );
+}
 }
 
 }
 
-// ----------------------------------------------------------------------------
+//----------------------------------------------------------------------------
 // wxDropTarget
 // wxDropTarget
-// ----------------------------------------------------------------------------
+//----------------------------------------------------------------------------
 
 
-wxDropTarget::wxDropTarget()
+wxDropTarget::wxDropTarget( wxDataObject *data )
+            : wxDropTargetBase( data )
 {
 {
+    m_firstMotion = true;
+    m_dragContext = NULL;
+    m_dragWidget = NULL;
+    m_dragData = NULL;
+    m_dragTime = 0;
 }
 
 }
 
-wxDropTarget::~wxDropTarget()
+wxDragResult wxDropTarget::OnDragOver( wxCoord WXUNUSED(x),
+                                       wxCoord WXUNUSED(y),
+                                       wxDragResult def )
 {
 {
+    return def;
 }
 
 }
 
-void wxDropTarget::OnEnter()
+bool wxDropTarget::OnDrop( wxCoord WXUNUSED(x), wxCoord WXUNUSED(y) )
 {
 {
+    return true;
 }
 
 }
 
-void wxDropTarget::OnLeave()
+wxDragResult wxDropTarget::OnData( wxCoord WXUNUSED(x), wxCoord WXUNUSED(y),
+                                   wxDragResult def )
 {
 {
+    return GetData() ? def : wxDragNone;
 }
 
 }
 
-bool wxDropTarget::OnMove( int x, int y )
+wxDragResult wxDropTarget::GTKFigureOutSuggestedAction()
 {
 {
-    printf( "generic move %d  %d.\n", x, y );
-    
-    return TRUE;
+    if (!m_dragContext)
+        return wxDragError;
+
+    // GTK+ always supposes that we want to copy the data by default while we
+    // might want to move it, so examine not only suggested_action - which is
+    // only good if we don't have our own preferences - but also the actions
+    // field
+    wxDragResult suggested_action = wxDragNone;
+    if (GetDefaultAction() == wxDragNone)
+    {
+        // use default action set by wxDropSource::DoDragDrop()
+        if ( (gs_flagsForDrag & wxDrag_DefaultMove) == wxDrag_DefaultMove &&
+            (m_dragContext->actions & GDK_ACTION_MOVE ) )
+        {
+            // move is requested by the program and allowed by GTK+ - do it, even
+            // though suggested_action may be currently wxDragCopy
+            suggested_action = wxDragMove;
+        }
+        else // use whatever GTK+ says we should
+        {
+            suggested_action = ConvertFromGTK(m_dragContext->suggested_action);
+
+#if 0
+            // RR: I don't understand the code below: if the drag comes from
+            //     a different app, the gs_flagsForDrag is invalid; if it
+            //     comes from the same wx app, then GTK+ hopefully won't
+            //     suggest something we didn't allow in the frist place
+            //     in DoDrop()
+            if ( (suggested_action == wxDragMove) && !(gs_flagsForDrag & wxDrag_AllowMove) )
+            {
+                // we're requested to move but we can't
+                suggested_action = wxDragCopy;
+            }
+#endif
+        }
+    }
+    else if (GetDefaultAction() == wxDragMove &&
+            (m_dragContext->actions & GDK_ACTION_MOVE))
+    {
+
+        suggested_action = wxDragMove;
+    }
+    else
+    {
+        if (m_dragContext->actions & GDK_ACTION_COPY)
+            suggested_action = wxDragCopy;
+        else if (m_dragContext->actions & GDK_ACTION_MOVE)
+            suggested_action = wxDragMove;
+        else if (m_dragContext->actions & GDK_ACTION_LINK)
+            suggested_action = wxDragLink;
+        else
+            suggested_action = wxDragNone;
+    }
+
+    return suggested_action;
 }
 
 }
 
-bool wxDropTarget::OnDrop( int x, int y )
+wxDataFormat wxDropTarget::GetMatchingPair()
 {
 {
-    printf( "generic drop %d  %d.\n", x, y );
-    
-    return TRUE;
+    return wxDataFormat( GTKGetMatchingPair() );
 }
 
 }
 
-bool wxDropTarget::IsSupported( wxDataFormat format )
-{ 
-    printf( "generic is supported.\n" );
-    
-    if (!m_dragContext) return FALSE;
-    
+GdkAtom wxDropTarget::GTKGetMatchingPair(bool quiet)
+{
+    if (!m_dataObject)
+        return (GdkAtom) 0;
+
+    if (!m_dragContext)
+        return (GdkAtom) 0;
+
     GList *child = m_dragContext->targets;
     while (child)
     {
     GList *child = m_dragContext->targets;
     while (child)
     {
-        GdkAtom formatAtom = (GdkAtom) GPOINTER_TO_INT(child->data);
-        char *name = gdk_atom_name( formatAtom );
-        if (name) printf( "Format available: %s.\n", name );
+        GdkAtom formatAtom = (GdkAtom)(child->data);
+        wxDataFormat format( formatAtom );
+
+        if ( !quiet )
+        {
+            wxLogTrace(TRACE_DND, wxT("Drop target: drag has format: %s"),
+                       format.GetId().c_str());
+        }
+
+        if (m_dataObject->IsSupportedFormat( format ))
+            return formatAtom;
 
         child = child->next;
     }
 
         child = child->next;
     }
-    
- 
-    return TRUE;
-}
-  
-bool wxDropTarget::GetData( wxDataObject *data )
-{
-    return FALSE;
-}
-  
-void wxDropTarget::UnregisterWidget( GtkWidget *widget )
-{
-    wxCHECK_RET( widget != NULL, "unregister widget is NULL" );
-  
-    gtk_drag_dest_set( widget,
-                    (GtkDestDefaults) 0,
-                    (GtkTargetEntry*) NULL, 
-                    0,
-                    (GdkDragAction) 0 );
-                    
-    gtk_signal_disconnect_by_func( GTK_OBJECT(widget),
-                     GTK_SIGNAL_FUNC(target_drag_leave), (gpointer) this );
-
-    gtk_signal_disconnect_by_func( GTK_OBJECT(widget),
-                     GTK_SIGNAL_FUNC(target_drag_motion), (gpointer) this );
-
-    gtk_signal_disconnect_by_func( GTK_OBJECT(widget),
-                     GTK_SIGNAL_FUNC(target_drag_drop), (gpointer) this );
-
-    gtk_signal_disconnect_by_func( GTK_OBJECT(widget),
-                     GTK_SIGNAL_FUNC(target_drag_data_received), (gpointer) this );
+
+    return (GdkAtom) 0;
 }
 
 }
 
-void wxDropTarget::RegisterWidget( GtkWidget *widget )
+bool wxDropTarget::GetData()
 {
 {
-    wxCHECK_RET( widget != NULL, "register widget is NULL" );
-  
-    GtkTargetEntry format;
-    format.info = 0;
-    format.flags = 0;
-    char buf[100];
-    strcpy( buf, "text/plain" );
-    format.target = buf;
-  
-    gtk_drag_dest_set( widget,
-                    GTK_DEST_DEFAULT_ALL,
-                    &format, 
-                    1,
-                    (GdkDragAction)(GDK_ACTION_COPY | GDK_ACTION_MOVE) ); 
-                    
-    gtk_signal_connect( GTK_OBJECT(widget), "drag_leave",
-                     GTK_SIGNAL_FUNC(target_drag_leave), (gpointer) this );
-
-    gtk_signal_connect( GTK_OBJECT(widget), "drag_motion",
-                     GTK_SIGNAL_FUNC(target_drag_motion), (gpointer) this );
-
-    gtk_signal_connect( GTK_OBJECT(widget), "drag_drop",
-                     GTK_SIGNAL_FUNC(target_drag_drop), (gpointer) this );
-
-    gtk_signal_connect( GTK_OBJECT(widget), "drag_data_received",
-                     GTK_SIGNAL_FUNC(target_drag_data_received), (gpointer) this );
-}
+    if (!m_dragData)
+        return false;
 
 
-//-------------------------------------------------------------------------
-// wxTextDropTarget
-//-------------------------------------------------------------------------
+    if (!m_dataObject)
+        return false;
 
 
-bool wxTextDropTarget::OnMove( int WXUNUSED(x), int WXUNUSED(y) )
-{
-    printf( "text move.\n" );
+    wxDataFormat dragFormat(gtk_selection_data_get_target(m_dragData));
+
+    if (!m_dataObject->IsSupportedFormat( dragFormat ))
+        return false;
+
+    m_dataObject->SetData(dragFormat,
+        (size_t)gtk_selection_data_get_length(m_dragData),
+        (const void*)gtk_selection_data_get_data(m_dragData));
 
 
-    return IsSupported( wxDF_TEXT );  // same as "TEXT"
+    return true;
 }
 
 }
 
-bool wxTextDropTarget::OnDrop( int x, int y )
+void wxDropTarget::GtkUnregisterWidget( GtkWidget *widget )
 {
 {
-    printf( "text drop.\n" );
+    wxCHECK_RET( widget != NULL, wxT("unregister widget is NULL") );
 
 
-    if (!IsSupported( wxDF_TEXT )) return FALSE;
+    gtk_drag_dest_unset( widget );
 
 
-    wxTextDataObject data;
-    if (!GetData( &data )) return FALSE;
-    
-    return OnDropText( x, y, data.GetText() );
+    g_signal_handlers_disconnect_by_func (widget,
+                                          (gpointer) target_drag_leave, this);
+    g_signal_handlers_disconnect_by_func (widget,
+                                          (gpointer) target_drag_motion, this);
+    g_signal_handlers_disconnect_by_func (widget,
+                                          (gpointer) target_drag_drop, this);
+    g_signal_handlers_disconnect_by_func (widget,
+                                          (gpointer) target_drag_data_received, this);
 }
 
 }
 
-//-------------------------------------------------------------------------
-// wxPrivateDropTarget
-//-------------------------------------------------------------------------
-
-wxPrivateDropTarget::wxPrivateDropTarget()
+void wxDropTarget::GtkRegisterWidget( GtkWidget *widget )
 {
 {
-    m_id = wxTheApp->GetAppName();
-}
+    wxCHECK_RET( widget != NULL, wxT("register widget is NULL") );
 
 
-wxPrivateDropTarget::wxPrivateDropTarget( const wxString &id )
-{
-    m_id = id;
-}
+    /* gtk_drag_dest_set() determines what default behaviour we'd like
+       GTK to supply. we don't want to specify out targets (=formats)
+       or actions in advance (i.e. not GTK_DEST_DEFAULT_MOTION and
+       not GTK_DEST_DEFAULT_DROP). instead we react individually to
+       "drag_motion" and "drag_drop" events. this makes it possible
+       to allow dropping on only a small area. we should set
+       GTK_DEST_DEFAULT_HIGHLIGHT as this will switch on the nice
+       highlighting if dragging over standard controls, but this
+       seems to be broken without the other two. */
 
 
-bool wxPrivateDropTarget::OnMove( int WXUNUSED(x), int WXUNUSED(y) )
-{
-    return IsSupported( m_id );
-}
+    gtk_drag_dest_set( widget,
+                       (GtkDestDefaults) 0,         /* no default behaviour */
+                       NULL,      /* we don't supply any formats here */
+                       0,                           /* number of targets = 0 */
+                       (GdkDragAction) 0 );         /* we don't supply any actions here */
 
 
-bool wxPrivateDropTarget::OnDrop( int x, int y )
-{
-    if (!IsSupported( m_id )) return FALSE;
+    g_signal_connect (widget, "drag_leave",
+                      G_CALLBACK (target_drag_leave), this);
+
+    g_signal_connect (widget, "drag_motion",
+                      G_CALLBACK (target_drag_motion), this);
+
+    g_signal_connect (widget, "drag_drop",
+                      G_CALLBACK (target_drag_drop), this);
 
 
-    wxPrivateDataObject data;
-    if (!GetData( &data )) return FALSE;
-    
-    return OnDropData( x, y, data.GetData(), data.GetSize() );
+    g_signal_connect (widget, "drag_data_received",
+                      G_CALLBACK (target_drag_data_received), this);
 }
 
 //----------------------------------------------------------------------------
 }
 
 //----------------------------------------------------------------------------
-// A drop target which accepts files (dragged from File Manager or Explorer)
+// "drag_data_get"
 //----------------------------------------------------------------------------
 
 //----------------------------------------------------------------------------
 
-bool wxFileDropTarget::OnMove( int WXUNUSED(x), int WXUNUSED(y) )
-{
-    return IsSupported( wxDF_FILENAME );  // same as "file:ALL"
-}
-
-bool wxFileDropTarget::OnDrop( int x, int y )
+extern "C" {
+static void
+source_drag_data_get  (GtkWidget          *WXUNUSED(widget),
+                       GdkDragContext     *context,
+                       GtkSelectionData   *selection_data,
+                       guint               WXUNUSED(info),
+                       guint               WXUNUSED(time),
+                       wxDropSource       *drop_source )
 {
 {
-    if (!IsSupported( wxDF_FILENAME )) return FALSE;
-    
-    wxFileDataObject data;
-    if (!GetData( &data )) return FALSE;
-
-    /* get number of substrings /root/mytext.txt/0/root/myothertext.txt/0/0 */
-    size_t number = 0;
-    size_t i;
-    size_t size = data.GetFiles().Length();
-    char *text = WXSTRINGCAST data.GetFiles();
-    for ( i = 0; i < size; i++)
-        if (text[i] == 0) number++;
-
-    if (number == 0) return TRUE;    
-    
-    char **files = new char*[number];
-  
-    text = WXSTRINGCAST data.GetFiles();
-    for (i = 0; i < number; i++)
-    {
-        files[i] = text;
-        int len = strlen( text );
-        text += len+1;
-    }
-
-    bool ret = OnDropFiles( x, y, number, files ); 
-  
-    free( files );
-  
-    return ret;
-}
-
-//-------------------------------------------------------------------------
-// wxDropSource
-//-------------------------------------------------------------------------
+    wxDataFormat format(gtk_selection_data_get_target(selection_data));
 
 
+    wxLogTrace(TRACE_DND, wxT("Drop source: format requested: %s"),
+               format.GetId().c_str());
 
 
-wxDropSource::wxDropSource( wxWindow *win, const wxIcon &go, const wxIcon &stop )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
-  
-    m_data = (wxDataBroker*) NULL;
-    m_retValue = wxDragCancel;
+    drop_source->m_retValue = wxDragError;
 
 
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-    
-    m_goIcon = go;
-    if (wxNullIcon == go) m_goIcon = wxIcon( page_xpm );
-    m_stopIcon = stop;
-    if (wxNullIcon == stop) m_stopIcon = wxIcon( gv_xpm );
-}
+    wxDataObject *data = drop_source->GetDataObject();
 
 
-wxDropSource::wxDropSource( wxDataObject *data, wxWindow *win, const wxIcon &go, const wxIcon &stop )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
-    m_retValue = wxDragCancel;
-  
-    if (data)
-    {
-        m_data = new wxDataBroker();
-       m_data->Add( data );
-    }
-    else
+    if (!data)
     {
     {
-        m_data = (wxDataBroker*) NULL;
+        wxLogTrace(TRACE_DND, wxT("Drop source: no data object") );
+        return;
     }
 
     }
 
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-    
-    m_goIcon = go;
-    if (wxNullIcon == go) m_goIcon = wxIcon( page_xpm );
-    m_stopIcon = stop;
-    if (wxNullIcon == stop) m_stopIcon = wxIcon( gv_xpm );
-}
-
-wxDropSource::wxDropSource( wxDataBroker *data, wxWindow *win )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
-    m_retValue = wxDragCancel;
-  
-    m_data = data;
-
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-}
-
-void wxDropSource::SetData( wxDataObject *data )
-{
-    if (m_data) delete m_data;
-    
-    if (data)
+    if (!data->IsSupportedFormat(format))
     {
     {
-        m_data = new wxDataBroker();
-       m_data->Add( data );
+        wxLogTrace(TRACE_DND, wxT("Drop source: unsupported format") );
+        return;
     }
     }
-    else
+
+    if (data->GetDataSize(format) == 0)
     {
     {
-        m_data = (wxDataBroker*) NULL;
+        wxLogTrace(TRACE_DND, wxT("Drop source: empty data") );
+        return;
     }
     }
-}
 
 
-void wxDropSource::SetData( wxDataBroker *data )
-{
-    if (m_data) delete m_data;
-    
-    m_data = data;
-}
+    size_t size = data->GetDataSize(format);
 
 
-wxDropSource::~wxDropSource(void)
-{
-    if (m_data) delete m_data;
+//  printf( "data size: %d.\n", (int)data_size );
 
 
-    g_blockEventsOnDrag = FALSE;
-}
-   
-wxDragResult wxDropSource::DoDragDrop( bool WXUNUSED(bAllowMove) )
-{
-    wxASSERT_MSG( m_data, "wxDragSource: no data" );
-  
-    if (!m_data) return (wxDragResult) wxDragNone;
-  
-    static GtkWidget *drag_icon = (GtkWidget*) NULL;
-    static GtkWidget *drop_icon = (GtkWidget*) NULL;
-
-    GdkPoint hotspot_1 = {0,-5 };
-      
-    if (!drag_icon)
-    {
-/*
-         drag_icon = shape_create_icon ( m_stopIcon,
-                                        440, 140, 0,0, GTK_WINDOW_POPUP);
-         
-         gtk_signal_connect (GTK_OBJECT (drag_icon), "destroy",
-                             GTK_SIGNAL_FUNC(gtk_widget_destroyed),
-                             &drag_icon);
-
-         gtk_widget_hide (drag_icon);
-*/
-    }
-      
-    GdkPoint hotspot_2 = {-5,-5};
-       
-    if (!drop_icon)
+    guchar *d = new guchar[size];
+
+    if (!data->GetDataHere( format, (void*)d ))
     {
     {
-/*
-         drop_icon = shape_create_icon ( m_goIcon,
-                                        440, 140, 0,0, GTK_WINDOW_POPUP);
-         
-         gtk_signal_connect (GTK_OBJECT (drop_icon), "destroy",
-                             GTK_SIGNAL_FUNC(gtk_widget_destroyed),
-                             &drop_icon);
-
-         gtk_widget_hide (drop_icon);
-*/
+        delete[] d;
+        return;
     }
     }
-       
 
 
-    return FALSE;
-}
+    drop_source->m_retValue = ConvertFromGTK( context->action );
 
 
-void wxDropSource::RegisterWindow(void)
-{
-    if (!m_data) return;
-}
+    gtk_selection_data_set( selection_data,
+                            gtk_selection_data_get_target(selection_data),
+                            8,   // 8-bit
+                            d,
+                            size );
 
 
-void wxDropSource::UnregisterWindow(void)
-{
-    if (!m_widget) return;
+    delete[] d;
+}
 }
 }
-
-
-#else  // NEW_CODE
 
 //----------------------------------------------------------------------------
 
 //----------------------------------------------------------------------------
-// forward
+// "drag_end"
 //----------------------------------------------------------------------------
 
 //----------------------------------------------------------------------------
 
-GtkWidget *shape_create_icon ( const wxIcon &shape,
-                             gint      x,
-                             gint      y,
-                             gint      px,
-                             gint      py,
-                             gint      window_type);
-
-//-----------------------------------------------------------------------------
-// globals
-//-----------------------------------------------------------------------------
-
-wxDropSource *gs_currentDropSource = (wxDropSource*) NULL;
-
-//-----------------------------------------------------------------------------
-// "drop_enter_event"
-//-----------------------------------------------------------------------------
-
-static void gtk_target_enter_callback( GtkWidget *WXUNUSED(widget), 
-                                       GdkEventDropEnter *WXUNUSED(event), 
-                                      wxDropTarget *target )
+extern "C" {
+static void source_drag_end( GtkWidget          *WXUNUSED(widget),
+                             GdkDragContext     *WXUNUSED(context),
+                             wxDropSource       *drop_source )
 {
 {
-    if (target)
-        target->OnEnter();
+    drop_source->m_waiting = false;
+}
 }
 
 //-----------------------------------------------------------------------------
 }
 
 //-----------------------------------------------------------------------------
-// "drop_leave_event"
+// "configure_event" from m_iconWindow
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 
-static void gtk_target_leave_callback( GtkWidget *WXUNUSED(widget), 
-                                       GdkEventDropLeave *WXUNUSED(event), 
-                                      wxDropTarget *target )
+extern "C" {
+static gint
+gtk_dnd_window_configure_callback( GtkWidget *WXUNUSED(widget), GdkEventConfigure *WXUNUSED(event), wxDropSource *source )
 {
 {
-    if (target)
-        target->OnLeave();
+    source->GiveFeedback( ConvertFromGTK(source->m_dragContext->action) );
+
+    return 0;
+}
 }
 
 }
 
-//-----------------------------------------------------------------------------
-// "drop_data_available_event"
-//-----------------------------------------------------------------------------
+//---------------------------------------------------------------------------
+// wxDropSource
+//---------------------------------------------------------------------------
 
 
-static void gtk_target_callback( GtkWidget *widget, 
-                                 GdkEventDropDataAvailable *event, 
-                                wxDropTarget *target )
+wxDropSource::wxDropSource(wxWindow *win,
+                           const wxIcon &iconCopy,
+                           const wxIcon &iconMove,
+                           const wxIcon &iconNone)
 {
 {
-    if (target)
-    {
-        int x = 0;
-        int y = 0;
-        gdk_window_get_pointer( widget->window, &x, &y, (GdkModifierType *) NULL );
-/*
-        printf( "Drop data is of type %s.\n", event->data_type );
-*/
-        target->OnDrop( x, y, (const void*)event->data, (size_t)event->data_numbytes );
-    }
+    m_waiting = true;
 
 
-/*
-    g_free (event->data);
-    g_free (event->data_type);
-*/
-}
+    m_iconWindow = NULL;
 
 
-// ----------------------------------------------------------------------------
-// wxDropTarget
-// ----------------------------------------------------------------------------
+    m_window = win;
+    m_widget = win->m_widget;
+    if (win->m_wxwindow) m_widget = win->m_wxwindow;
 
 
-wxDropTarget::wxDropTarget()
-{
-    m_format = (wxDataFormat*) NULL;
-}
+    m_retValue = wxDragNone;
 
 
-wxDropTarget::~wxDropTarget()
-{
-    if (m_format) delete m_format;
+    SetIcons(iconCopy, iconMove, iconNone);
 }
 
 }
 
-wxDataFormat &wxDropTarget::GetFormat(size_t n) const
+wxDropSource::wxDropSource(wxDataObject& data,
+                           wxWindow *win,
+                           const wxIcon &iconCopy,
+                           const wxIcon &iconMove,
+                           const wxIcon &iconNone)
 {
 {
-    return (*m_format);
-}
+    m_waiting = true;
 
 
-void wxDropTarget::UnregisterWidget( GtkWidget *widget )
-{
-    if (!widget) return;
-  
-    gtk_signal_disconnect_by_func( GTK_OBJECT(widget),
-      GTK_SIGNAL_FUNC(gtk_target_callback), (gpointer) this );
+    SetData( data );
 
 
-    gtk_widget_dnd_drop_set( widget, FALSE, (gchar **) NULL, 0, FALSE );
-}
+    m_iconWindow = NULL;
 
 
-void wxDropTarget::RegisterWidget( GtkWidget *widget )
-{
-    wxString formats;
-    int valid = 0;
-  
-    for ( size_t i = 0; i < GetFormatCount(); i++ )
-    {
-        switch (GetFormat(i).GetType()) 
-        {
-            case wxDF_TEXT:
-           {
-               if (i > 0) formats += ";";
-                formats += "text/plain";
-               valid++;
-               break;
-           }
-            case wxDF_FILENAME:
-           {
-               if (i > 0) formats += ";";
-                formats += "file:ALL";
-               valid++;
-               break;
-           }
-            case wxDF_PRIVATE:
-           {
-               if (i > 0) formats += ";";
-                wxPrivateDropTarget *pdt = (wxPrivateDropTarget *)this;
-                formats += pdt->GetId();
-               valid++;
-               break;
-           }
-            default:
-              break;
-        }
-    }
-  
-    char *str = WXSTRINGCAST formats;
-    
-    gtk_widget_dnd_drop_set( widget, TRUE, &str, valid, FALSE );
-  
-    gtk_signal_connect( GTK_OBJECT(widget), "drop_data_available_event",
-      GTK_SIGNAL_FUNC(gtk_target_callback), (gpointer) this );
-      
-    gtk_signal_connect( GTK_OBJECT(widget), "drop_enter_event",
-      GTK_SIGNAL_FUNC(gtk_target_enter_callback), (gpointer) this );
-      
-    gtk_signal_connect( GTK_OBJECT(widget), "drop_leave_event",
-      GTK_SIGNAL_FUNC(gtk_target_leave_callback), (gpointer) this );
-}
+    m_window = win;
+    m_widget = win->m_widget;
+    if (win->m_wxwindow) m_widget = win->m_wxwindow;
 
 
-// ----------------------------------------------------------------------------
-// wxTextDropTarget
-// ----------------------------------------------------------------------------
+    m_retValue = wxDragNone;
 
 
-wxTextDropTarget::wxTextDropTarget()
-{
-    m_format = new wxDataFormat( wxDF_TEXT );
+    SetIcons(iconCopy, iconMove, iconNone);
 }
 
 }
 
-bool wxTextDropTarget::OnDrop( long x, long y, const void *data, size_t WXUNUSED(size) )
+void wxDropSource::SetIcons(const wxIcon &iconCopy,
+                            const wxIcon &iconMove,
+                            const wxIcon &iconNone)
 {
 {
-    OnDropText( x, y, (const char*)data );
-    return TRUE;
+    m_iconCopy = iconCopy;
+    m_iconMove = iconMove;
+    m_iconNone = iconNone;
+
+    if ( !m_iconCopy.IsOk() )
+        m_iconCopy = wxIcon(page_xpm);
+    if ( !m_iconMove.IsOk() )
+        m_iconMove = m_iconCopy;
+    if ( !m_iconNone.IsOk() )
+        m_iconNone = m_iconCopy;
 }
 
 }
 
-bool wxTextDropTarget::OnDropText( long x, long y, const char *psz )
+wxDropSource::~wxDropSource()
 {
 {
-/*
-    printf( "Got dropped text: %s.\n", psz );
-    printf( "At x: %d, y: %d.\n", (int)x, (int)y );
-*/
-    return TRUE;
 }
 
 }
 
-size_t wxTextDropTarget::GetFormatCount() const
+void wxDropSource::PrepareIcon( int action, GdkDragContext *context )
 {
 {
-    return 1;
-}
+    // get the right icon to display
+    wxIcon *icon = NULL;
+    if ( action & GDK_ACTION_MOVE )
+        icon = &m_iconMove;
+    else if ( action & GDK_ACTION_COPY )
+        icon = &m_iconCopy;
+    else
+        icon = &m_iconNone;
 
 
-// ----------------------------------------------------------------------------
-// wxPrivateDropTarget
-// ----------------------------------------------------------------------------
+    GdkBitmap *mask;
+    if ( icon->GetMask() )
+        mask = icon->GetMask()->GetBitmap();
+    else
+        mask = NULL;
 
 
-wxPrivateDropTarget::wxPrivateDropTarget()
-{
-    m_id = wxTheApp->GetAppName();
-    m_format = new wxDataFormat( m_id );
-}
+    GdkPixmap *pixmap = icon->GetPixmap();
 
 
-void wxPrivateDropTarget::SetId( const wxString& id )
-{
-    m_id = id;
-    m_format->SetId( id );
-}
+    gint width,height;
+    gdk_drawable_get_size (pixmap, &width, &height);
 
 
-size_t wxPrivateDropTarget::GetFormatCount() const
-{
-    return 1;
-}
+    GdkColormap *colormap = gtk_widget_get_colormap( m_widget );
+    gtk_widget_push_colormap (colormap);
 
 
-// ----------------------------------------------------------------------------
-// wxFileDropTarget
-// ----------------------------------------------------------------------------
+    m_iconWindow = gtk_window_new (GTK_WINDOW_POPUP);
+    gtk_widget_set_events (m_iconWindow, GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK);
+    gtk_widget_set_app_paintable (m_iconWindow, TRUE);
 
 
-wxFileDropTarget::wxFileDropTarget()
-{
-    m_format = new wxDataFormat( wxDF_FILENAME );
-}    
+    gtk_widget_pop_colormap ();
 
 
-bool wxFileDropTarget::OnDropFiles( long x, long y, size_t nFiles, const char * const aszFiles[] )
-{
-    printf( "Got %d dropped files.\n", (int)nFiles );
-    printf( "At x: %d, y: %d.\n", (int)x, (int)y );
+    gtk_widget_set_size_request (m_iconWindow, width, height);
+    gtk_widget_realize (m_iconWindow);
 
 
-    for (size_t i = 0; i < nFiles; i++)
-    {
-        printf( aszFiles[i] );
-        printf( "\n" );
-    }
-    
-    return TRUE;
-}
+    g_signal_connect (m_iconWindow, "configure_event",
+                      G_CALLBACK (gtk_dnd_window_configure_callback), this);
 
 
-bool wxFileDropTarget::OnDrop(long x, long y, const void *data, size_t size )
-{
-    size_t number = 0;
-    size_t i;
-    char *text = (char*) data;
-    for ( i = 0; i < size; i++)
-        if (text[i] == 0) number++;
-
-    if (number == 0) return TRUE;    
-    
-    char **files = new char*[number];
-  
-    text = (char*) data;
-    for (i = 0; i < number; i++)
-    {
-        files[i] = text;
-        int len = strlen( text );
-        text += len+1;
-    }
+    gdk_window_set_back_pixmap(gtk_widget_get_window(m_iconWindow), pixmap, false);
 
 
-    bool ret = OnDropFiles( x, y, 1, files ); 
-  
-    free( files );
-  
-    return ret;
+    if (mask)
+        gtk_widget_shape_combine_mask (m_iconWindow, mask, 0, 0);
+
+    gtk_drag_set_icon_widget( context, m_iconWindow, 0, 0 );
 }
 
 }
 
-size_t wxFileDropTarget::GetFormatCount() const
+wxDragResult wxDropSource::DoDragDrop(int flags)
 {
 {
-    return 1;
-}
+    wxCHECK_MSG( m_data && m_data->GetFormatCount(), wxDragNone,
+                 wxT("Drop source: no data") );
 
 
-//-------------------------------------------------------------------------
-// wxDropSource
-//-------------------------------------------------------------------------
+    // still in drag
+    if (g_blockEventsOnDrag)
+        return wxDragNone;
 
 
-static void
-shape_motion (GtkWidget      *widget, 
-             GdkEventMotion * /*event*/);
-             
-//-----------------------------------------------------------------------------
-// "drag_request_event"
-//-----------------------------------------------------------------------------
+    // don't start dragging if no button is down
+    if (g_lastButtonNumber == 0)
+        return wxDragNone;
 
 
-void gtk_drag_callback( GtkWidget *widget, GdkEventDragRequest *event, wxDropSource *source )
-{
-    wxDataBroker *data = source->m_data;
-    
-    if (!data) return;
-    
-    wxNode *node = data->m_dataObjects.First();
-    {
-        wxDataObject *dobj = (wxDataObject*) node->Data();
-       
-       if ((strcmp(event->data_type,"file:ALL") == 0) &&
-           (dobj->GetFormat().GetType() == wxDF_FILENAME))
-       {
-           wxFileDataObject *file_object = (wxFileDataObject*) dobj;
-           
-           wxString text = file_object->GetFiles();
-           
-           char *s = WXSTRINGCAST text;
-           
-            gtk_widget_dnd_data_set( widget, 
-                                    (GdkEvent*)event, 
-                                    (unsigned char*) s, 
-                                    (int) text.Length()+1 );
-       
-            source->m_retValue = wxDragCopy;
-           
-           return;
-       }
-       
-       if ((strcmp(event->data_type,"text/plain") == 0) &&
-           (dobj->GetFormat().GetType() == wxDF_TEXT))
-       {
-           wxTextDataObject *text_object = (wxTextDataObject*) dobj;
-           
-           wxString text = text_object->GetText();
-           
-           char *s = WXSTRINGCAST text;
-           
-            gtk_widget_dnd_data_set( widget, 
-                                    (GdkEvent*)event, 
-                                    (unsigned char*) s, 
-                                    (int) text.Length()+1 );
-       
-            source->m_retValue = wxDragCopy;
-           
-           return;
-       }
-       
-       if (dobj->GetFormat().GetType() == wxDF_PRIVATE)
-       {
-            wxPrivateDataObject *pdo = (wxPrivateDataObject*) dobj;
-           
-           if (pdo->GetId() == event->data_type)
-           {
-                gtk_widget_dnd_data_set( widget, 
-                                    (GdkEvent*)event,
-                                    (unsigned char*) pdo->GetData(), 
-                                    (int) pdo->GetSize() );
-                                    
-                source->m_retValue = wxDragCopy;
-           
-               return;
-           }
-       }
-       
-       node = node->Next();
-   }
-}
+    // we can only start a drag after a mouse event
+    if (g_lastMouseEvent == NULL)
+        return wxDragNone;
 
 
-wxDropSource::wxDropSource( wxWindow *win, const wxIcon &go, const wxIcon &stop )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
-  
-    m_data = (wxDataBroker*) NULL;
-    m_retValue = wxDragCancel;
+    GTKConnectDragSignals();
+    wxON_BLOCK_EXIT_OBJ0(*this, wxDropSource::GTKDisconnectDragSignals);
 
 
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-    
-    m_goIcon = go;
-    if (wxNullIcon == go) m_goIcon = wxIcon( page_xpm );
-    m_stopIcon = stop;
-    if (wxNullIcon == stop) m_stopIcon = wxIcon( gv_xpm );
-}
+    m_waiting = true;
 
 
-wxDropSource::wxDropSource( wxDataObject *data, wxWindow *win, const wxIcon &go, const wxIcon &stop )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
-    m_retValue = wxDragCancel;
-  
-    if (data)
-    {
-        m_data = new wxDataBroker();
-       m_data->Add( data );
-    }
-    else
+    GtkTargetList *target_list = gtk_target_list_new( NULL, 0 );
+
+    wxDataFormat *array = new wxDataFormat[ m_data->GetFormatCount() ];
+    m_data->GetAllFormats( array );
+    size_t count = m_data->GetFormatCount();
+    for (size_t i = 0; i < count; i++)
     {
     {
-        m_data = (wxDataBroker*) NULL;
+        GdkAtom atom = array[i];
+        wxLogTrace(TRACE_DND, wxT("Drop source: Supported atom %s"),
+                   gdk_atom_name( atom ));
+        gtk_target_list_add( target_list, atom, 0, 0 );
     }
     }
+    delete[] array;
 
 
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-    
-    m_goIcon = go;
-    if (wxNullIcon == go) m_goIcon = wxIcon( page_xpm );
-    m_stopIcon = stop;
-    if (wxNullIcon == stop) m_stopIcon = wxIcon( gv_xpm );
-}
+    int allowed_actions = GDK_ACTION_COPY;
+    if ( flags & wxDrag_AllowMove )
+        allowed_actions |= GDK_ACTION_MOVE;
+
+    // VZ: as we already use g_blockEventsOnDrag it shouldn't be that bad
+    //     to use a global to pass the flags to the drop target but I'd
+    //     surely prefer a better way to do it
+    gs_flagsForDrag = flags;
 
 
-wxDropSource::wxDropSource( wxDataBroker *data, wxWindow *win )
-{
-    g_blockEventsOnDrag = TRUE;
-  
-    m_window = win;
-    m_widget = win->m_widget;
-    if (win->m_wxwindow) m_widget = win->m_wxwindow;
     m_retValue = wxDragCancel;
     m_retValue = wxDragCancel;
-  
-    m_data = data;
 
 
-    m_defaultCursor = wxCursor( wxCURSOR_NO_ENTRY );
-    m_goaheadCursor = wxCursor( wxCURSOR_HAND );
-}
+    GdkDragContext *context = gtk_drag_begin( m_widget,
+                target_list,
+                (GdkDragAction)allowed_actions,
+                g_lastButtonNumber,  // number of mouse button which started drag
+                (GdkEvent*) g_lastMouseEvent );
 
 
-void wxDropSource::SetData( wxDataObject *data )
-{
-    if (m_data) delete m_data;
-    
-    if (data)
-    {
-        m_data = new wxDataBroker();
-       m_data->Add( data );
-    }
-    else
+    if ( !context )
     {
     {
-        m_data = (wxDataBroker*) NULL;
+        // this can happen e.g. if gdk_pointer_grab() failed
+        return wxDragError;
     }
     }
-}
-
-void wxDropSource::SetData( wxDataBroker *data )
-{
-    if (m_data) delete m_data;
-    
-    m_data = data;
-}
 
 
-wxDropSource::~wxDropSource(void)
-{
-    if (m_data) delete m_data;
+    m_dragContext = context;
 
 
-    g_blockEventsOnDrag = FALSE;
-}
-   
-wxDragResult wxDropSource::DoDragDrop( bool WXUNUSED(bAllowMove) )
-{
-    if (gdk_dnd.dnd_grabbed) return (wxDragResult) wxDragNone;
-    if (gdk_dnd.drag_really) return (wxDragResult) wxDragNone;
-  
-    wxASSERT_MSG( m_data, "wxDragSource: no data" );
-  
-    if (!m_data) return (wxDragResult) wxDragNone;
-  
-    static GtkWidget *drag_icon = (GtkWidget*) NULL;
-    static GtkWidget *drop_icon = (GtkWidget*) NULL;
-
-    GdkPoint hotspot_1 = {0,-5 };
-      
-    if (!drag_icon)
-    {
-         drag_icon = shape_create_icon ( m_stopIcon,
-                                        440, 140, 0,0, GTK_WINDOW_POPUP);
-         
-         gtk_signal_connect (GTK_OBJECT (drag_icon), "destroy",
-                             GTK_SIGNAL_FUNC(gtk_widget_destroyed),
-                             &drag_icon);
-
-         gtk_widget_hide (drag_icon);
-    }
-      
-    GdkPoint hotspot_2 = {-5,-5};
-       
-    if (!drop_icon)
-    {
-         drop_icon = shape_create_icon ( m_goIcon,
-                                        440, 140, 0,0, GTK_WINDOW_POPUP);
-         
-         gtk_signal_connect (GTK_OBJECT (drop_icon), "destroy",
-                             GTK_SIGNAL_FUNC(gtk_widget_destroyed),
-                             &drop_icon);
-
-         gtk_widget_hide (drop_icon);
-    }
-       
-
-    gdk_dnd_set_drag_shape( drag_icon->window,
-                            &hotspot_1,
-                            drop_icon->window,
-                            &hotspot_2);
-  
-  
-    GdkWindowPrivate *wp = (GdkWindowPrivate*) m_widget->window;
-  
-    RegisterWindow();
-  
-    gdk_dnd.drag_perhaps = TRUE;
-
-    gdk_dnd.dnd_drag_start.x = 5;
-    gdk_dnd.dnd_drag_start.y = 5;
-    gdk_dnd.real_sw = wp;
-         
-    if (gdk_dnd.drag_startwindows)
-    {
-        g_free( gdk_dnd.drag_startwindows );
-        gdk_dnd.drag_startwindows = (GdkWindow **) NULL;
-    }
-    gdk_dnd.drag_numwindows = gdk_dnd.drag_really = 0;
-  
-    XWindowAttributes dnd_winattr;
-    XGetWindowAttributes( gdk_display, wp->xwindow, &dnd_winattr );
-    wp->dnd_drag_savedeventmask = dnd_winattr.your_event_mask;
-  
-    gdk_dnd_drag_addwindow( m_widget->window );
-  
-    GdkEventDragBegin ev;
-    ev.type = GDK_DRAG_BEGIN;
-    ev.window = m_widget->window;
-    ev.u.allflags = 0;
-    ev.u.flags.protocol_version = DND_PROTOCOL_VERSION;
-  
-    gdk_event_put( (GdkEvent*)&ev );
-  
-    XGrabPointer( gdk_display, wp->xwindow, False, 
-                  ButtonMotionMask | ButtonPressMask | ButtonReleaseMask | PointerMotionMask,
-                 GrabModeAsync, GrabModeAsync, gdk_root_window, None, CurrentTime );
-               
-    gdk_dnd_set_drag_cursors( m_defaultCursor.GetCursor(), m_goaheadCursor.GetCursor() );
-  
-    gdk_dnd.dnd_grabbed = TRUE;
-    gdk_dnd.drag_really = 1;
-  
-    int x = 0;
-    int y = 0;
-    wxGetMousePosition( &x, &y );  
-  
-    gdk_dnd_display_drag_cursor( x, y, FALSE, TRUE );
-    
-    gs_currentDropSource = this;
-    
-    while (gdk_dnd.drag_really || gdk_dnd.drag_perhaps) wxYield();
-    
-    gs_currentDropSource = (wxDropSource*) NULL;
-  
-    UnregisterWindow();
-  
-    g_blockEventsOnDrag = FALSE;
-  
-    return m_retValue;
-}
+    PrepareIcon( allowed_actions, context );
 
 
-void wxDropSource::RegisterWindow(void)
-{
-    if (!m_data) return;
+    while (m_waiting)
+        gtk_main_iteration();
 
 
-    wxString formats;
-    
-    wxNode *node = m_data->m_dataObjects.First();
-    while (node)
-    {
-        wxDataObject* dobj = (wxDataObject*) node->Data();
-    
-        switch (dobj->GetFormat().GetType()) 
-        {
-            case wxDF_TEXT:
-           { 
-                  formats += "text/plain";
-                 break;
-           }
-            case wxDF_FILENAME:
-           {
-                  formats += "file:ALL";
-                 break;
-           }
-            case wxDF_PRIVATE:
-           {
-                 wxPrivateDataObject* pdo = (wxPrivateDataObject*) m_data;
-                 formats += pdo->GetId();
-                 break;
-           }
-            default:
-              break;
-       }
-       node = node->Next();
-    }
-  
-    char *str = WXSTRINGCAST formats;
-  
-    gtk_widget_dnd_drag_set( m_widget, TRUE, &str, 1 );
+    g_signal_handlers_disconnect_by_func (m_iconWindow,
+                                          (gpointer) gtk_dnd_window_configure_callback, this);
 
 
-    gtk_signal_connect( GTK_OBJECT(m_widget), "drag_request_event",
-      GTK_SIGNAL_FUNC(gtk_drag_callback), (gpointer)this );
+    return m_retValue;
 }
 
 }
 
-void wxDropSource::UnregisterWindow(void)
+void wxDropSource::GTKConnectDragSignals()
 {
 {
-    if (!m_widget) return;
-  
-    gtk_widget_dnd_drag_set( m_widget, FALSE, (gchar **) NULL, 0 );
-  
-    gtk_signal_disconnect_by_data( GTK_OBJECT(m_widget), (gpointer)this );
-}
-
+    if (!m_widget)
+        return;
 
 
-/*
- * Shaped Windows
- */
-static GdkWindow *root_win = (GdkWindow*) NULL;
+    g_blockEventsOnDrag = true;
 
 
-typedef struct _cursoroffset {gint x,y;} CursorOffset;
+    g_signal_connect (m_widget, "drag_data_get",
+                      G_CALLBACK (source_drag_data_get), this);
+    g_signal_connect (m_widget, "drag_end",
+                      G_CALLBACK (source_drag_end), this);
 
 
-static void
-shape_pressed (GtkWidget *widget, GdkEventButton *event)
-{
-  CursorOffset *p;
-
-  /* ignore double and triple click */
-  if (event->type != GDK_BUTTON_PRESS)
-    return;
-
-  p = (CursorOffset *)gtk_object_get_user_data (GTK_OBJECT(widget));
-  p->x = (int) event->x;
-  p->y = (int) event->y;
-
-  gtk_grab_add (widget);
-  gdk_pointer_grab (widget->window, TRUE,
-                   (GdkEventMask)
-                     (GDK_BUTTON_RELEASE_MASK |
-                      GDK_BUTTON_MOTION_MASK |
-                      GDK_POINTER_MOTION_HINT_MASK),
-                   (GdkWindow*)NULL, 
-                   (GdkCursor*) NULL, 0);
 }
 
 }
 
-
-static void
-shape_released (GtkWidget *widget)
+void wxDropSource::GTKDisconnectDragSignals()
 {
 {
-  gtk_grab_remove (widget);
-  gdk_pointer_ungrab (0);
-}
+    if (!m_widget)
+        return;
 
 
-static void
-shape_motion (GtkWidget      *widget, 
-             GdkEventMotion * /*event*/ )
-{
-  gint xp, yp;
-  CursorOffset * p;
-  GdkModifierType mask;
-
-  p = (CursorOffset *)gtk_object_get_user_data (GTK_OBJECT (widget));
-
-  /*
-   * Can't use event->x / event->y here 
-   * because I need absolute coordinates.
-   */
-   
-  gdk_window_get_pointer (root_win, &xp, &yp, &mask);
-  gtk_widget_set_uposition (widget, xp  - p->x, yp  - p->y);
-  
-  if (gs_currentDropSource) gs_currentDropSource->GiveFeedback( wxDragCopy, FALSE );
-}
+    g_blockEventsOnDrag = false;
 
 
-GtkWidget *
-shape_create_icon (const wxIcon &shape,
-                  gint      x,
-                  gint      y,
-                  gint      px,
-                  gint      py,
-                  gint      window_type)
-{
-  /*
-   * GDK_WINDOW_TOPLEVEL works also, giving you a title border
-   */
-  GtkWidget *window = gtk_window_new ((GtkWindowType)window_type);
-  
-  GtkWidget *fixed = gtk_fixed_new ();
-  gtk_widget_set_usize (fixed, 100,100);
-  gtk_container_add (GTK_CONTAINER (window), fixed);
-  gtk_widget_show (fixed);
-  
-  gtk_widget_set_events (window, 
-                        gtk_widget_get_events (window) |
-                        GDK_BUTTON_MOTION_MASK |
-                        GDK_POINTER_MOTION_HINT_MASK |
-                        GDK_BUTTON_PRESS_MASK);
-
-  gtk_widget_realize (window);
-  
-  GdkBitmap *mask = (GdkBitmap*) NULL;
-  if (shape.GetMask()) mask = shape.GetMask()->GetBitmap();
-
-  GtkWidget *pixmap = gtk_pixmap_new (shape.GetPixmap(), mask);
-  gtk_fixed_put (GTK_FIXED (fixed), pixmap, px,py);
-  gtk_widget_show (pixmap);
-  
-  gtk_widget_shape_combine_mask (window, mask, px,py);
-
-
-  gtk_signal_connect (GTK_OBJECT (window), "button_press_event",
-                     GTK_SIGNAL_FUNC (shape_pressed),NULL);
-  gtk_signal_connect (GTK_OBJECT (window), "button_release_event",
-                     GTK_SIGNAL_FUNC (shape_released),NULL);
-  gtk_signal_connect (GTK_OBJECT (window), "motion_notify_event",
-                     GTK_SIGNAL_FUNC (shape_motion),NULL);
-
-  CursorOffset*icon_pos = g_new (CursorOffset, 1);
-  gtk_object_set_user_data(GTK_OBJECT(window), icon_pos);
-
-  gtk_widget_set_uposition (window, x, y);
-  gtk_widget_show (window);
-  
-  return window;
+    g_signal_handlers_disconnect_by_func (m_widget,
+                                          (gpointer) source_drag_data_get,
+                                          this);
+    g_signal_handlers_disconnect_by_func (m_widget,
+                                          (gpointer) source_drag_end,
+                                          this);
 }
 
 }
 
-#endif 
-       // NEW_GTK_DND_CODE
-       
 #endif
 #endif
-
-      // wxUSE_DRAG_AND_DROP
\ No newline at end of file
+      // wxUSE_DRAG_AND_DROP
wxWidgets (Impactor)