// Modified by:
// Created: 05.11.00
// RCS-ID: $Id$
-// Copyright: (c) wxWindows team
+// Copyright: (c) wxWidgets team
// Licence: wxWindows licence
///////////////////////////////////////////////////////////////////////////////
// headers
// ----------------------------------------------------------------------------
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
#pragma implementation "cmdproc.h"
#endif
m_commandName = name;
}
-wxCommand::~wxCommand()
-{
-}
-
// ----------------------------------------------------------------------------
// Command processor
// ----------------------------------------------------------------------------
#endif // wxUSE_MENUS
m_undoAccelerator = wxT("\tCtrl+Z");
m_redoAccelerator = wxT("\tCtrl+Y");
+
+ m_lastSavedCommand =
+ m_currentCommand = wxList::compatibility_iterator();
}
wxCommandProcessor::~wxCommandProcessor()
// Pass a command to the processor. The processor calls Do();
// if successful, is appended to the command history unless
-// storeIt is FALSE.
+// storeIt is false.
bool wxCommandProcessor::Submit(wxCommand *command, bool storeIt)
{
- wxCHECK_MSG( command, FALSE, _T("no command in wxCommandProcessor::Submit") );
+ wxCHECK_MSG( command, false, _T("no command in wxCommandProcessor::Submit") );
if ( !DoCommand(*command) )
{
// the user code expects the command to be deleted anyhow
delete command;
- return FALSE;
+ return false;
}
if ( storeIt )
Store(command);
+ else
+ delete command;
- return TRUE;
+ return true;
}
void wxCommandProcessor::Store(wxCommand *command)
wxCommand *firstCommand = (wxCommand *)firstNode->GetData();
delete firstCommand;
m_commands.Erase(firstNode);
+
+ // Make sure m_lastSavedCommand won't point to freed memory
+ if ( m_lastSavedCommand == firstNode )
+ m_lastSavedCommand = wxList::compatibility_iterator();
}
// Correct a bug: we must chop off the current 'branch'
wxList::compatibility_iterator next = node->GetNext();
delete (wxCommand *)node->GetData();
m_commands.Erase(node);
+
+ // Make sure m_lastSavedCommand won't point to freed memory
+ if ( m_lastSavedCommand == node )
+ m_lastSavedCommand = wxList::compatibility_iterator();
+
node = next;
}
}
{
m_currentCommand = m_currentCommand->GetPrevious();
SetMenuStrings();
- return TRUE;
+ return true;
}
}
- return FALSE;
+ return false;
}
bool wxCommandProcessor::Redo()
{
wxCommand *redoCommand = (wxCommand *) NULL;
- wxList::compatibility_iterator redoNode;
+ wxList::compatibility_iterator redoNode
+#if !wxUSE_STL
+ = NULL // just to avoid warnings
+#endif // !wxUSE_STL
+ ;
if ( m_currentCommand )
{
{
m_currentCommand = redoNode;
SetMenuStrings();
- return TRUE;
+ return true;
}
}
- return FALSE;
+ return false;
}
bool wxCommandProcessor::CanUndo() const
bool wxCommandProcessor::CanRedo() const
{
if (m_currentCommand && !m_currentCommand->GetNext())
- return FALSE;
+ return false;
if (m_currentCommand && m_currentCommand->GetNext())
- return TRUE;
+ return true;
if (!m_currentCommand && (m_commands.GetCount() > 0))
- return TRUE;
+ return true;
- return FALSE;
+ return false;
}
void wxCommandProcessor::Initialize()
{
wxString undoLabel = GetUndoMenuLabel();
wxString redoLabel = GetRedoMenuLabel();
-
+
m_commandEditMenu->SetLabel(wxID_UNDO, undoLabel);
m_commandEditMenu->Enable(wxID_UNDO, CanUndo());
{
wxCommand *command = (wxCommand *)m_currentCommand->GetData();
wxString commandName(command->GetName());
- if (commandName == wxT("")) commandName = _("Unnamed command");
+ if (commandName.empty()) commandName = _("Unnamed command");
bool canUndo = command->CanUndo();
if (canUndo)
buf = wxString(_("&Undo ")) + commandName + m_undoAccelerator;
{
buf = _("&Undo") + m_undoAccelerator;
}
-
+
return buf;
}
{
wxCommand *redoCommand = (wxCommand *)m_currentCommand->GetNext()->GetData();
wxString redoCommandName(redoCommand->GetName());
- if (redoCommandName == wxT("")) redoCommandName = _("Unnamed command");
+ if (redoCommandName.empty()) redoCommandName = _("Unnamed command");
buf = wxString(_("&Redo ")) + redoCommandName + m_redoAccelerator;
}
else
// we've undone to the start of the list, but can redo the first.
wxCommand *redoCommand = (wxCommand *)m_commands.GetFirst()->GetData();
wxString redoCommandName(redoCommand->GetName());
- if (redoCommandName == wxT("")) redoCommandName = _("Unnamed command");
+ if (redoCommandName.empty()) redoCommandName = _("Unnamed command");
buf = wxString(_("&Redo ")) + redoCommandName + m_redoAccelerator;
}
}
m_commands.Erase(node);
node = m_commands.GetFirst();
}
+
m_currentCommand = wxList::compatibility_iterator();
+ m_lastSavedCommand = wxList::compatibility_iterator();
}