tree ctrl sorting shouldn't crash when items don't have data

[wxWidgets.git] / src / common / datstrm.cpp

diff --git a/src/common/datstrm.cpp b/src/common/datstrm.cpp
index 15a5ef78a8e74e92e6573546149534cb1364cd6b..bdf796f7c2f94fb8bd7ee63b5ee9c740500ad006 100644 (file)
--- a/src/common/datstrm.cpp
+++ b/src/common/datstrm.cpp
@@ -26,10 +26,9 @@
 
 #include "wx/datstrm.h"
 
-#if !USE_SHARED_LIBRARY
-IMPLEMENT_CLASS(wxDataInputStream, wxFilterInputStream)
-IMPLEMENT_CLASS(wxDataOutputStream, wxFilterOutputStream)
-#endif
+// ---------------------------------------------------------------------------
+// wxDataInputStream
+// ---------------------------------------------------------------------------
 
 wxDataInputStream::wxDataInputStream(wxInputStream& s)
   : wxFilterInputStream(s)
@@ -44,9 +43,6 @@ unsigned long wxDataInputStream::Read32()
 {
   char buf[4];
 
-  if (!m_parent_i_stream)
-    return 0;
-
   Read(buf, 4);
 
   return (unsigned long)buf[0] |
@@ -59,9 +55,6 @@ unsigned short wxDataInputStream::Read16()
 {
   char buf[2];
 
-  if (!m_parent_i_stream)
-    return 0;
-
   Read(buf, 2);
 
   return (unsigned short)buf[0] |
@@ -72,9 +65,6 @@ unsigned char wxDataInputStream::Read8()
 {
   char buf;
 
-  if (!m_parent_i_stream)
-    return 0;
-
   Read(&buf, 1);
   return (unsigned char)buf;
 }
@@ -84,12 +74,9 @@ extern "C" double ConvertFromIeeeExtended(const unsigned char *bytes);
 
 double wxDataInputStream::ReadDouble()
 {
-#if USE_APPLE_IEEE
+#if wxUSE_APPLE_IEEE
   char buf[10];
 
-  if (!m_parent_i_stream)
-    return 0.0;
-
   Read(buf, 10);
   return ConvertFromIeeeExtended((unsigned char *)buf);
 #else
@@ -99,13 +86,30 @@ double wxDataInputStream::ReadDouble()
 
 wxString wxDataInputStream::ReadLine()
 {
-  char i_strg[255];
-
-  if (!m_parent_i_stream)
-    return "";
-
-  // TODO: Implement ReadLine
-  return i_strg;
+  char c, last_endl = 0;
+  bool end_line = FALSE;
+  wxString line;
+
+  while (!end_line) {
+    c = GetC();
+    switch (c) {
+    case '\n':
+      end_line = TRUE;
+      break;
+    case '\r':
+      last_endl = '\r';
+      break;
+    default:
+      if (last_endl == '\r') {
+        end_line = TRUE;
+        InputStreamBuffer()->WriteBack(c);
+        break;
+      }
+      line += c;
+      break;
+    } 
+  }
+  return line;
 }
 
 wxString wxDataInputStream::ReadString()
@@ -114,9 +118,6 @@ wxString wxDataInputStream::ReadString()
   char *string;
   unsigned long len;
 
-  if (!m_parent_i_stream)
-    return "";
-
   len = Read32();
   string = new char[len+1];
 
@@ -126,21 +127,26 @@ wxString wxDataInputStream::ReadString()
   wx_string = string;
   delete string;
 
-  return wx_string; 
+  return wx_string;
 }
 
+// ---------------------------------------------------------------------------
+// wxDataOutputStream
+// ---------------------------------------------------------------------------
+
 wxDataOutputStream::wxDataOutputStream(wxOutputStream& s)
  : wxFilterOutputStream(s)
 {
 }
 
+wxDataOutputStream::~wxDataOutputStream()
+{
+}
+
 void wxDataOutputStream::Write32(unsigned long i)
 {
   char buf[4];
 
-  if (!m_parent_o_stream)
-    return;
-
   buf[0] = i & 0xff;
   buf[1] = (i >> 8) & 0xff;
   buf[2] = (i >> 16) & 0xff;
@@ -152,9 +158,6 @@ void wxDataOutputStream::Write16(unsigned short i)
 {
   char buf[2];
 
-  if (!m_parent_o_stream)
-    return;
-
   buf[0] = i & 0xff;
   buf[1] = (i >> 8) & 0xff;
   Write(buf, 2);
@@ -162,33 +165,24 @@ void wxDataOutputStream::Write16(unsigned short i)
 
 void wxDataOutputStream::Write8(unsigned char i)
 {
-  if (!m_parent_o_stream)
-    return;
-
   Write(&i, 1);
 }
 
 void wxDataOutputStream::WriteLine(const wxString& line)
 {
 #ifdef __WXMSW__
-  wxString tmp_string = line + "\r\n";
+  wxString tmp_string = line + _T("\r\n");
 #else
-  wxString tmp_string = line + '\n';
+  wxString tmp_string = line + _T('\n');
 #endif
 
-  if (!m_parent_o_stream)
-    return;
-
-  Write((const char *) tmp_string, tmp_string.Length());
+  Write((const wxChar *) tmp_string, tmp_string.Length()*sizeof(wxChar));
 }
 
 void wxDataOutputStream::WriteString(const wxString& string)
 {
-  if (!m_parent_o_stream)
-    return;
-
   Write32(string.Length());
-  Write((const char *) string, string.Length());
+  Write((const wxChar *) string, string.Length()*sizeof(wxChar));
 }
 
 // Must be at global scope for VC++ 5
@@ -198,13 +192,10 @@ void wxDataOutputStream::WriteDouble(double d)
 {
   char buf[10];
 
-  if (!m_parent_o_stream)
-    return;
-
-#if USE_APPLE_IEEE
+#if wxUSE_APPLE_IEEE
   ConvertToIeeeExtended(d, (unsigned char *)buf);
 #else
-#      pragma warning "wxDataStream::WriteDouble() not using IeeeExtended - will not work!"
+#  pragma warning "wxDataOutputStream::WriteDouble() not using IeeeExtended - will not work!"
  buf[0] = '\0';
 #endif
   Write(buf, 10);