optimized default GUI font loading

[wxWidgets.git] / src / msw / statbmp.cpp

diff --git a/src/msw/statbmp.cpp b/src/msw/statbmp.cpp
index f51c590ce6900871319c77fb04b736557d9f4724..a93d50a7a5077e4e815e3327b83f08ecf15e64e7 100644 (file)
--- a/src/msw/statbmp.cpp
+++ b/src/msw/statbmp.cpp
@@ -54,6 +54,42 @@ IMPLEMENT_DYNAMIC_CLASS(wxStaticBitmap, wxControl)
 // wxStaticBitmap
 // ---------------------------------------------------------------------------
 
+// we may have either bitmap or icon: if a bitmap with mask is passed, we
+// will transform it to an icon ourselves because otherwise the mask will
+// be ignored by Windows
+// note that this function will create a new object every time
+// it is called even if the image needs no conversion
+
+#ifndef __WIN16__
+
+static wxGDIImage* ConvertImage( const wxGDIImage& bitmap )
+{
+    bool isIcon = bitmap.IsKindOf( CLASSINFO(wxIcon) );
+
+    if( !isIcon )
+    {
+        wxASSERT_MSG( wxDynamicCast(&bitmap, wxBitmap),
+                      _T("not an icon and not a bitmap?") );
+
+        const wxBitmap& bmp = (const wxBitmap&)bitmap;
+        wxMask *mask = bmp.GetMask();
+        if ( mask && mask->GetMaskBitmap() )
+        {
+            wxIcon* icon = new wxIcon;
+            icon->CopyFromBitmap(bmp);
+
+            return icon;
+        }
+
+        return new wxBitmap( bmp );
+    }
+
+    // copying a bitmap is a cheap operation
+    return new wxIcon( (const wxIcon&)bitmap );
+}
+
+#endif
+
 bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
                             const wxGDIImage& bitmap,
                             const wxPoint& pos,
@@ -85,26 +121,17 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
     // we may have either bitmap or icon: if a bitmap with mask is passed, we
     // will transform it to an icon ourselves because otherwise the mask will
     // be ignored by Windows
-    wxIcon *icon = (wxIcon *)NULL;
+    wxGDIImage *image = (wxGDIImage *)NULL;
     m_isIcon = bitmap.IsKindOf(CLASSINFO(wxIcon));
 
 #ifdef __WIN16__
     wxASSERT_MSG( !m_isIcon, "Icons are not supported in wxStaticBitmap under WIN16." );
+    image = &bitmap;
 #endif
 
 #ifndef __WIN16__
-    if ( !m_isIcon )
-    {
-        const wxBitmap& bmp = (const wxBitmap&)bitmap;
-        wxMask *mask = bmp.GetMask();
-        if ( mask && mask->GetMaskBitmap() )
-        {
-            icon = new wxIcon;
-            icon->CopyFromBitmap(bmp);
-
-            m_isIcon = TRUE;
-        }
-    }
+    image = ConvertImage( bitmap );
+    m_isIcon = image->IsKindOf( CLASSINFO(wxIcon) );
 #endif
 
 #ifdef __WIN32__
@@ -136,8 +163,8 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
 
     wxCHECK_MSG( m_hWnd, FALSE, wxT("Failed to create static bitmap") );
 
-    SetImage(icon ? icon : &bitmap);
-    delete icon; // may be NULL, ok
+    // no need to delete the new image
+    SetImageNoCopy( image );
 
     // Subclass again for purposes of dialog editing mode
     SubclassWin(m_hWnd);
@@ -168,25 +195,19 @@ wxSize wxStaticBitmap::DoGetBestSize() const
     return wxWindow::DoGetBestSize();
 }
 
-void wxStaticBitmap::SetImage(const wxGDIImage* image)
+void wxStaticBitmap::SetImage( const wxGDIImage* image )
 {
-    Free();
-
-    const wxIcon *icon = wxDynamicCast(image, wxIcon);
-    m_isIcon = icon != NULL;
-    if ( m_isIcon )
-    {
-        m_image = new wxIcon(*icon);
-    }
-    else
-    {
-        wxASSERT_MSG( wxDynamicCast(image, wxBitmap),
-                      _T("not an icon and not a bitmap?") );
+    wxGDIImage* convertedImage = ConvertImage( *image );
+    SetImageNoCopy( convertedImage );
+}
 
-        const wxBitmap *bitmap = (wxBitmap *)image;
+void wxStaticBitmap::SetImageNoCopy( wxGDIImage* image)
+{
+    Free();
 
-        m_image = new wxBitmap(*bitmap);
-    }
+    m_isIcon = image->IsKindOf( CLASSINFO(wxIcon) );
+    // the image has already been copied
+    m_image = image;
 
     int x, y;
     int w, h;
@@ -195,6 +216,9 @@ void wxStaticBitmap::SetImage(const wxGDIImage* image)
 
 #ifdef __WIN32__
     HANDLE handle = (HANDLE)m_image->GetHandle();
+    LONG style = ::GetWindowLong( (HWND)GetHWND(), GWL_STYLE ) ;
+    ::SetWindowLong( (HWND)GetHWND(), GWL_STYLE, ( style & ~( SS_BITMAP|SS_ICON ) ) |
+                     ( m_isIcon ? SS_ICON : SS_BITMAP ) );
     ::SendMessage(GetHwnd(), STM_SETIMAGE,
                   m_isIcon ? IMAGE_ICON : IMAGE_BITMAP, (LPARAM)handle);
 #endif // Win32