fixed sorting the items which have indirect data (i.e. images set for open/closed...

[wxWidgets.git] / src / msw / menu.cpp

diff --git a/src/msw/menu.cpp b/src/msw/menu.cpp
index e15df2c855634e7892cac270b1e39cac33ddbc52..93e92056ef02f1f94f3d2b4e323ac341e7eee8df 100644 (file)
--- a/src/msw/menu.cpp
+++ b/src/msw/menu.cpp
@@ -172,7 +172,7 @@ void wxMenu::UpdateAccel(wxMenuItem *item)
             if ( accel )
                 m_accels[n] = accel;
             else
             if ( accel )
                 m_accels[n] = accel;
             else

-                m_accels.Remove(n);
+                m_accels.RemoveAt(n);

         }
 
         if ( IsAttached() )
         }
 
         if ( IsAttached() )


@@ -317,7 +317,7 @@ wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)
     {
         delete m_accels[n];
 
     {
         delete m_accels[n];
 

-        m_accels.Remove(n);
+        m_accels.RemoveAt(n);

     }
     //else: this item doesn't have an accel, nothing to do
 #endif // wxUSE_ACCEL
     }
     //else: this item doesn't have an accel, nothing to do
 #endif // wxUSE_ACCEL


@@ -649,8 +649,6 @@ bool wxMenuBar::Insert(size_t pos, wxMenu *menu, const wxString& title)
 
     m_titles.Insert(title, pos);
 
 
     m_titles.Insert(title, pos);
 

-    menu->Attach(this);
-

     if ( IsAttached() )
     {
         if ( !::InsertMenu(GetHmenu(), pos,
     if ( IsAttached() )
     {
         if ( !::InsertMenu(GetHmenu(), pos,


@@ -682,7 +680,8 @@ bool wxMenuBar::Append(wxMenu *menu, const wxString& title)
     if ( !wxMenuBarBase::Append(menu, title) )
         return FALSE;
 
     if ( !wxMenuBarBase::Append(menu, title) )
         return FALSE;
 

-    menu->Attach(this);
+    // Already done in Append above
+    //menu->Attach(this);

 
     m_titles.Add(title);
 
 
     m_titles.Add(title);
 


@@ -721,8 +720,6 @@ wxMenu *wxMenuBar::Remove(size_t pos)
             wxLogLastError(wxT("RemoveMenu"));
         }
 
             wxLogLastError(wxT("RemoveMenu"));
         }
 

-        menu->Detach();
-

 #if wxUSE_ACCEL
         if ( menu->HasAccels() )
         {
 #if wxUSE_ACCEL
         if ( menu->HasAccels() )
         {