String corrections

[wxWidgets.git] / src / common / regex.cpp

diff --git a/src/common/regex.cpp b/src/common/regex.cpp
index 44599dfa90fdc155785711cb7df30e2b9d91c438..12d49ee971737968bbf92a7d8ed56246e6297ee8 100644 (file)
--- a/src/common/regex.cpp
+++ b/src/common/regex.cpp
@@ -38,22 +38,17 @@
     #include "wx/intl.h"
 #endif //WX_PRECOMP
 
-// FreeBSD & Watcom require this, it probably doesn't hurt for others
+// FreeBSD, Watcom and DMars require this, CW doesn't have nor need it.
+// Others also don't seem to need it. If you have an error related to
+// (not) including <sys/types.h> please report details to
+// wx-dev@lists.wxwindows.org
 #if defined(__UNIX__) || defined(__WATCOMC__) || defined(__DIGITALMARS__)
-    #include <sys/types.h>
+#   include <sys/types.h>
 #endif
 
-#ifndef __WXWINCE__
 #include <regex.h>
-#endif
-
 #include "wx/regex.h"
 
-#ifdef wxUSE_UNICODE
-    #define regerror wx_regerror
-    #define regfree wx_regfree
-#endif
-
 // ----------------------------------------------------------------------------
 // private classes
 // ----------------------------------------------------------------------------
@@ -138,32 +133,25 @@ wxRegExImpl::~wxRegExImpl()
 
 wxString wxRegExImpl::GetErrorMsg(int errorcode) const
 {
-    wxString msg;
+    wxString szError;
 
     // first get the string length needed
     int len = regerror(errorcode, &m_RegEx, NULL, 0);
     if ( len > 0 )
     {
-        len++;
-
-#if wxUSE_UNICODE
-        wxCharBuffer buf(len);
+        char* szcmbError = new char[++len];
 
-        (void)regerror(errorcode, &m_RegEx, (char *)buf.data(), len);
+        (void)regerror(errorcode, &m_RegEx, szcmbError, len);
 
-        msg = wxString(buf.data(), wxConvLibc);
-#else // !Unicode
-        (void)regerror(errorcode, &m_RegEx, msg.GetWriteBuf(len), len);
-
-        msg.UngetWriteBuf();
-#endif // Unicode/!Unicode
+        szError = wxConvertMB2WX(szcmbError);
+        delete [] szcmbError;
     }
     else // regerror() returned 0
     {
-        msg = _("unknown error");
+        szError = _("unknown error");
     }
 
-    return msg;
+    return szError;
 }
 
 bool wxRegExImpl::Compile(const wxString& expr, int flags)
@@ -186,12 +174,8 @@ bool wxRegExImpl::Compile(const wxString& expr, int flags)
         flagsRE |= REG_NEWLINE;
 
 
-    // compile it
-#if wxUSE_UNICODE
-    int errorcode = wx_regcomp(&m_RegEx, expr, expr.Length(), flagsRE);
-#else
-    int errorcode = regcomp(&m_RegEx, expr.mb_str(), flagsRE);
-#endif
+
+    int errorcode = regcomp(&m_RegEx, expr, flagsRE);
 
      if ( errorcode )
     {
@@ -266,12 +250,7 @@ bool wxRegExImpl::Matches(const wxChar *str, int flags) const
     }
 
     // do match it
-#ifdef wxUSE_UNICODE
-       rm_detail_t rd;
-    int rc = wx_regexec(&self->m_RegEx, str, wxStrlen(str), &rd, m_nMatches, m_Matches, flagsRE);
-#else
-    int rc = regexec(&self->m_RegEx, wxConvertWX2MB(str), m_nMatches, m_Matches, flagsRE);
-#endif
+    int rc = regexec(&self->m_RegEx, str, m_nMatches, m_Matches, flagsRE);
 
     switch ( rc )
     {