if ( !MSWCreateControl(clsname, wxEmptyString, pos, size) )
return false;
- // initialize the control
+ // initialize the control
UpdateFirstDayOfWeek();
SetDate(dt.IsValid() ? dt : wxDateTime::Today());
{
wxCHECK_MSG( dt.IsValid(), false, "invalid date" );
+ const wxDateTime date = dt.GetDateOnly();
+
SYSTEMTIME st;
- dt.GetAsMSWSysTime(&st);
+ date.GetAsMSWSysTime(&st);
if ( !MonthCal_SetCurSel(GetHwnd(), &st) )
{
wxLogDebug(wxT("DateTime_SetSystemtime() failed"));
return false;
}
- m_date = dt;
+ m_date = date;
return true;
}
wxDateTime dt(st);
- wxASSERT_MSG( dt == m_date, "mismatch between data and control" );
+ // Windows XP and earlier didn't include the time component into the
+ // returned date but Windows 7 does, so we can't compare the full objects
+ // in the same way under all the Windows versions, just compare their date
+ // parts
+ wxASSERT_MSG( dt.GetDateOnly() == m_date.GetDateOnly(),
+ "mismatch between data and control" );
#endif // wxDEBUG_LEVEL
return m_date;
// before it and from the one after it so days from 3 different months can
// be partially shown
MONTHDAYSTATE states[3] = { 0 };
- const int nMonths = MonthCal_GetMonthRange(GetHwnd(), GMR_DAYSTATE, NULL);
+ const DWORD nMonths = MonthCal_GetMonthRange(GetHwnd(), GMR_DAYSTATE, NULL);
// although in principle the calendar might not show any days from the
// preceding months, it seems like it always does, consider e.g. Feb 2010
// which starts on Monday and ends on Sunday and so could fit on 4 lines
// without showing any subsequent months -- the standard control still
// shows it on 6 lines and the number of visible months is still 3
- wxCHECK_RET( nMonths == (int)WXSIZEOF(states), "unexpected months range" );
-
- // the fully visible month is the one in the middle
- states[1] = m_marks | m_holidays;
-
- if ( !MonthCal_SetDayState(GetHwnd(), nMonths, states) )
+ //
+ // OTOH Windows 7 control can show all 12 months or even years or decades
+ // in its window if you "zoom out" of it by double clicking on free areas
+ // so the return value can be (much, in case of decades view) greater than
+ // 3 but in this case marks are not visible anyhow so simply ignore it
+ if ( nMonths < WXSIZEOF(states) )
+ {
+ wxFAIL_MSG("unexpectedly few months shown in the control");
+ }
+ else if ( nMonths == WXSIZEOF(states) )
{
- wxLogLastError(wxT("MonthCal_SetDayState"));
+ // the fully visible month is the one in the middle
+ states[1] = m_marks | m_holidays;
+
+ if ( !MonthCal_SetDayState(GetHwnd(), nMonths, states) )
+ {
+ wxLogLastError(wxT("MonthCal_SetDayState"));
+ }
}
+ //else: not a month view at all
}
void wxCalendarCtrl::UpdateFirstDayOfWeek()