removed compiler warnings about assignments in logical expressions

[wxWidgets.git] / src / common / dlgcmn.cpp

diff --git a/src/common/dlgcmn.cpp b/src/common/dlgcmn.cpp
index 73d1bcd7dcb5c44953720c990607167bcde27fbb..235f5416da6d7ac55f0e0b66c4636164940afb42 100644 (file)
--- a/src/common/dlgcmn.cpp
+++ b/src/common/dlgcmn.cpp
@@ -29,12 +29,14 @@
 #endif
 
 #ifndef WX_PRECOMP
 #endif
 
 #ifndef WX_PRECOMP

+    #include "wx/button.h"

     #include "wx/dialog.h"
     #include "wx/dcclient.h"
     #include "wx/intl.h"
     #include "wx/settings.h"
     #include "wx/stattext.h"
     #include "wx/sizer.h"
     #include "wx/dialog.h"
     #include "wx/dcclient.h"
     #include "wx/intl.h"
     #include "wx/settings.h"
     #include "wx/stattext.h"
     #include "wx/sizer.h"

+    #include "wx/button.h"

 #endif
 
 //--------------------------------------------------------------------------
 #endif
 
 //--------------------------------------------------------------------------


@@ -47,9 +49,10 @@ wxSizer *wxDialogBase::CreateTextSizer( const wxString &message )
 
     // get line height for empty lines
     int y = 0;
 
     // get line height for empty lines
     int y = 0;

-    wxFont new_font( GetFont() );
-    if (!new_font.Ok()) new_font = *wxSWISS_FONT;
-    GetTextExtent( "H", (int*)NULL, &y, (int*)NULL, (int*)NULL, &new_font );
+    wxFont font( GetFont() );
+    if (!font.Ok())
+        font = *wxSWISS_FONT;
+    GetTextExtent(_T("H"), (int*)NULL, &y, (int*)NULL, (int*)NULL, &font);

 
     wxString line;
     for (size_t pos = 0; pos < message.Len(); pos++)
 
     wxString line;
     for (size_t pos = 0; pos < message.Len(); pos++)


@@ -59,13 +62,13 @@ wxSizer *wxDialogBase::CreateTextSizer( const wxString &message )
             if (!line.IsEmpty())
             {
                 wxStaticText *s1 = new wxStaticText( this, -1, line );
             if (!line.IsEmpty())
             {
                 wxStaticText *s1 = new wxStaticText( this, -1, line );

-               box->Add( s1 );
+                box->Add( s1 );

                 line = wxT("");
             }
                 line = wxT("");
             }

-           else
-           {
-               box->Add( 5, y );
-           }
+            else
+            {
+                box->Add( 5, y );
+            }

         }
         else
         {
         }
         else
         {


@@ -77,7 +80,7 @@ wxSizer *wxDialogBase::CreateTextSizer( const wxString &message )
     if (!line.IsEmpty())
     {
         wxStaticText *s2 = new wxStaticText( this, -1, line );
     if (!line.IsEmpty())
     {
         wxStaticText *s2 = new wxStaticText( this, -1, line );

-       box->Add( s2 );
+        box->Add( s2 );

     }
 
     return box;
     }
 
     return box;


@@ -88,9 +91,9 @@ wxSizer *wxDialogBase::CreateButtonSizer( long flags )
     wxBoxSizer *box = new wxBoxSizer( wxHORIZONTAL );
 
 #if defined(__WXMSW__) || defined(__WXMAC__)
     wxBoxSizer *box = new wxBoxSizer( wxHORIZONTAL );
 
 #if defined(__WXMSW__) || defined(__WXMAC__)

-    int margin = 6;
+    static const int margin = 6;

 #else
 #else

-    int margin = 10;
+    static const int margin = 10;

 #endif
 
     wxButton *ok = (wxButton *) NULL;
 #endif
 
     wxButton *ok = (wxButton *) NULL;


@@ -103,46 +106,46 @@ wxSizer *wxDialogBase::CreateButtonSizer( long flags )
 
     if (flags & wxYES_NO)
     {
 
     if (flags & wxYES_NO)
     {

-        yes = new wxButton( this, wxID_YES, _("Yes") );
+        yes = new wxButton( this, wxID_YES, _("Yes"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS );

         box->Add( yes, 0, wxLEFT|wxRIGHT, margin );
         box->Add( yes, 0, wxLEFT|wxRIGHT, margin );

-        no = new wxButton( this, wxID_NO, _("No") );
+        no = new wxButton( this, wxID_NO, _("No") ,wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS);

         box->Add( no, 0, wxLEFT|wxRIGHT, margin );
     } else
     if (flags & wxYES)
     {
         box->Add( no, 0, wxLEFT|wxRIGHT, margin );
     } else
     if (flags & wxYES)
     {

-        yes = new wxButton( this, wxID_YES, _("Yes") );
+        yes = new wxButton( this, wxID_YES, _("Yes"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS );

         box->Add( yes, 0, wxLEFT|wxRIGHT, margin );
     } else
     if (flags & wxNO)
     {
         box->Add( yes, 0, wxLEFT|wxRIGHT, margin );
     } else
     if (flags & wxNO)
     {

-        no = new wxButton( this, wxID_NO, _("No") );
+        no = new wxButton( this, wxID_NO, _("No"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS );

         box->Add( no, 0, wxLEFT|wxRIGHT, margin );
     }
 
     if (flags & wxOK)
     {
         box->Add( no, 0, wxLEFT|wxRIGHT, margin );
     }
 
     if (flags & wxOK)
     {

-        ok = new wxButton( this, wxID_OK, _("OK") );
+        ok = new wxButton( this, wxID_OK, _("OK"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS );

         box->Add( ok, 0, wxLEFT|wxRIGHT, margin );
     }
 
     if (flags & wxFORWARD)
         box->Add( ok, 0, wxLEFT|wxRIGHT, margin );
     }
 
     if (flags & wxFORWARD)

-        box->Add( new wxButton( this, wxID_FORWARD, _("Forward")  ), 0, wxLEFT|wxRIGHT, margin );
+        box->Add( new wxButton( this, wxID_FORWARD, _("Forward"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS  ), 0, wxLEFT|wxRIGHT, margin );

 
     if (flags & wxBACKWARD)
 
     if (flags & wxBACKWARD)

-        box->Add( new wxButton( this, wxID_BACKWARD, _("Backward")  ), 0, wxLEFT|wxRIGHT, margin );
+        box->Add( new wxButton( this, wxID_BACKWARD, _("Backward"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS  ), 0, wxLEFT|wxRIGHT, margin );

 
     if (flags & wxSETUP)
 
     if (flags & wxSETUP)

-        box->Add( new wxButton( this, wxID_SETUP, _("Setup")  ), 0, wxLEFT|wxRIGHT, margin );
+        box->Add( new wxButton( this, wxID_SETUP, _("Setup"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS  ), 0, wxLEFT|wxRIGHT, margin );

 
     if (flags & wxMORE)
 
     if (flags & wxMORE)

-        box->Add( new wxButton( this, wxID_MORE, _("More...")  ), 0, wxLEFT|wxRIGHT, margin );
+        box->Add( new wxButton( this, wxID_MORE, _("More..."),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS  ), 0, wxLEFT|wxRIGHT, margin );

 
     if (flags & wxHELP)
 
     if (flags & wxHELP)

-        box->Add( new wxButton( this, wxID_HELP, _("Help")  ), 0, wxLEFT|wxRIGHT, margin );
+        box->Add( new wxButton( this, wxID_HELP, _("Help"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS  ), 0, wxLEFT|wxRIGHT, margin );

 
     if (flags & wxCANCEL)
     {
 
     if (flags & wxCANCEL)
     {

-        cancel = new wxButton( this, wxID_CANCEL, _("Cancel") );
+        cancel = new wxButton( this, wxID_CANCEL, _("Cancel"),wxDefaultPosition,wxDefaultSize,wxCLIP_SIBLINGS );

         box->Add( cancel, 0, wxLEFT|wxRIGHT, margin );
     }
 
         box->Add( cancel, 0, wxLEFT|wxRIGHT, margin );
     }