combobox buglet when inserting item

[wxWidgets.git] / src / common / list.cpp

diff --git a/src/common/list.cpp b/src/common/list.cpp
index 041d609db325ed59a9bdcdaa5931b6291bb5dbb2..49e32680592641e58b1f0a6efa94c75f1d4104cd 100644 (file)
--- a/src/common/list.cpp
+++ b/src/common/list.cpp
@@ -37,13 +37,12 @@
     #include "wx/utils.h"   // for copystring() (beurk...)
 #endif
 
     #include "wx/utils.h"   // for copystring() (beurk...)
 #endif
 

-// Sun CC compatibility (interference with xview/pkg.h, apparently...)
-#if defined(SUN_CC) && defined(__XVIEW__)
-    #undef va_start
-    #undef va_end
-    #undef va_arg
-    #undef va_list
-#endif
+// -----------------------------------------------------------------------------
+// implementation of standard lists
+// -----------------------------------------------------------------------------
+
+#include "wx/listimpl.cpp"
+WX_DEFINE_LIST(wxWindowList);

 
 // =============================================================================
 // implementation
 
 // =============================================================================
 // implementation


@@ -53,17 +52,19 @@
 // wxListKey
 // -----------------------------------------------------------------------------
 
 // wxListKey
 // -----------------------------------------------------------------------------
 

+wxListKey wxDefaultListKey;
+

 bool wxListKey::operator==(wxListKeyValue value) const
 {
     switch ( m_keyType )
     {
         default:
 bool wxListKey::operator==(wxListKeyValue value) const
 {
     switch ( m_keyType )
     {
         default:

-            wxFAIL_MSG("bad key type.");
+            wxFAIL_MSG(_T("bad key type."));

             // let compiler optimize the line above away in release build
             // by not putting return here...
 
         case wxKEY_STRING:
             // let compiler optimize the line above away in release build
             // by not putting return here...
 
         case wxKEY_STRING:

-            return strcmp(m_key.string, value.string) == 0;
+            return wxStrcmp(m_key.string, value.string) == 0;

 
         case wxKEY_INTEGER:
             return m_key.integer == value.integer;
 
         case wxKEY_INTEGER:
             return m_key.integer == value.integer;


@@ -94,11 +95,11 @@ wxNodeBase::wxNodeBase(wxListBase *list,
 
         case wxKEY_STRING:
             // to be free()d later
 
         case wxKEY_STRING:
             // to be free()d later

-            m_key.string = strdup(key.GetString());
+            m_key.string = wxStrdup(key.GetString());

             break;
 
         default:
             break;
 
         default:

-            wxFAIL_MSG("invalid key type");
+            wxFAIL_MSG(_T("invalid key type"));

     }
 
     if ( previous )
     }
 
     if ( previous )


@@ -115,13 +116,18 @@ wxNodeBase::~wxNodeBase()
     // compatibility with old code
     if ( m_list != NULL )
     {
     // compatibility with old code
     if ( m_list != NULL )
     {

+        if ( m_list->m_keyType == wxKEY_STRING )
+        {
+            free(m_key.string);
+        }
+

         m_list->DetachNode(this);
     }
 }
 
 int wxNodeBase::IndexOf() const
 {
         m_list->DetachNode(this);
     }
 }
 
 int wxNodeBase::IndexOf() const
 {

-    wxCHECK_MSG( m_list, NOT_FOUND, "node doesn't belong to a list in IndexOf");
+    wxCHECK_MSG( m_list, wxNOT_FOUND, _T("node doesn't belong to a list in IndexOf"));

 
     // It would be more efficient to implement IndexOf() completely inside
     // wxListBase (only traverse the list once), but this is probably a more
 
     // It would be more efficient to implement IndexOf() completely inside
     // wxListBase (only traverse the list once), but this is probably a more


@@ -142,7 +148,7 @@ int wxNodeBase::IndexOf() const
 // wxListBase
 // -----------------------------------------------------------------------------
 
 // wxListBase
 // -----------------------------------------------------------------------------
 

-void wxListBase::Init(wxKeyType keyType = wxKEY_NONE)
+void wxListBase::Init(wxKeyType keyType)

 {
   m_nodeFirst =
   m_nodeLast = (wxNodeBase *) NULL;
 {
   m_nodeFirst =
   m_nodeLast = (wxNodeBase *) NULL;


@@ -164,7 +170,7 @@ wxListBase::wxListBase(size_t count, void *elements[])
 void wxListBase::DoCopy(const wxListBase& list)
 {
     wxASSERT_MSG( !list.m_destroy,
 void wxListBase::DoCopy(const wxListBase& list)
 {
     wxASSERT_MSG( !list.m_destroy,

-                  "copying list which owns it's elements is a bad idea" );
+                  _T("copying list which owns it's elements is a bad idea") );

 
     m_count = list.m_count;
     m_destroy = list.m_destroy;
 
     m_count = list.m_count;
     m_destroy = list.m_destroy;


@@ -211,7 +217,7 @@ wxNodeBase *wxListBase::Append(void *object)
 {
     // all objects in a keyed list should have a key
     wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,
 {
     // all objects in a keyed list should have a key
     wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,

-                 "need a key for the object to append" );
+                 _T("need a key for the object to append") );

 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object);
 
 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object);
 


@@ -223,18 +229,18 @@ wxNodeBase *wxListBase::Append(long key, void *object)
     wxCHECK_MSG( (m_keyType == wxKEY_INTEGER) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
                  (wxNodeBase *)NULL,
     wxCHECK_MSG( (m_keyType == wxKEY_INTEGER) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
                  (wxNodeBase *)NULL,

-                 "can't append object with numeric key to this list" );
+                 _T("can't append object with numeric key to this list") );

 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
     return AppendCommon(node);
 }
 
 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
     return AppendCommon(node);
 }
 

-wxNodeBase *wxListBase::Append (const char *key, void *object)
+wxNodeBase *wxListBase::Append (const wxChar *key, void *object)

 {
     wxCHECK_MSG( (m_keyType == wxKEY_STRING) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
                  (wxNodeBase *)NULL,
 {
     wxCHECK_MSG( (m_keyType == wxKEY_STRING) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
                  (wxNodeBase *)NULL,

-                 "can't append object with string key to this list" );
+                 _T("can't append object with string key to this list") );

 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
     return AppendCommon(node);
 
     wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
     return AppendCommon(node);


@@ -244,10 +250,10 @@ wxNodeBase *wxListBase::Insert(wxNodeBase *position, void *object)
 {
     // all objects in a keyed list should have a key
     wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,
 {
     // all objects in a keyed list should have a key
     wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,

-                 "need a key for the object to insert" );
+                 _T("need a key for the object to insert") );

 
     wxCHECK_MSG( !position || position->m_list == this, (wxNodeBase *)NULL,
 
     wxCHECK_MSG( !position || position->m_list == this, (wxNodeBase *)NULL,

-                 "can't insert before a node from another list" );
+                 _T("can't insert before a node from another list") );

 
     // previous and next node for the node being inserted
     wxNodeBase *prev, *next;
 
     // previous and next node for the node being inserted
     wxNodeBase *prev, *next;


@@ -289,7 +295,7 @@ wxNodeBase *wxListBase::Item(size_t n) const
         }
     }
 
         }
     }
 

-//    wxFAIL_MSG( "invalid index in wxListBase::Item" );
+    wxFAIL_MSG( _T("invalid index in wxListBase::Item") );

 
     return (wxNodeBase *)NULL;
 }
 
     return (wxNodeBase *)NULL;
 }


@@ -297,7 +303,7 @@ wxNodeBase *wxListBase::Item(size_t n) const
 wxNodeBase *wxListBase::Find(const wxListKey& key) const
 {
     wxASSERT_MSG( m_keyType == key.GetKeyType(),
 wxNodeBase *wxListBase::Find(const wxListKey& key) const
 {
     wxASSERT_MSG( m_keyType == key.GetKeyType(),

-                  "this list is not keyed on the type of this key" );
+                  _T("this list is not keyed on the type of this key") );

 
     for ( wxNodeBase *current = GetFirst(); current; current = current->GetNext() )
     {
 
     for ( wxNodeBase *current = GetFirst(); current; current = current->GetNext() )
     {


@@ -327,7 +333,7 @@ int wxListBase::IndexOf(void *object) const
 {
     wxNodeBase *node = Find( object );
 
 {
     wxNodeBase *node = Find( object );
 

-    return node ? node->IndexOf() : NOT_FOUND;
+    return node ? node->IndexOf() : wxNOT_FOUND;

 }
 
 void wxListBase::DoDeleteNode(wxNodeBase *node)
 }
 
 void wxListBase::DoDeleteNode(wxNodeBase *node)


@@ -343,14 +349,16 @@ void wxListBase::DoDeleteNode(wxNodeBase *node)
         node->DeleteData();
     }
 
         node->DeleteData();
     }
 

+    // so that the node knows that it's being deleted by the list
+    node->m_list = NULL;

     delete node;
 }
 
 wxNodeBase *wxListBase::DetachNode(wxNodeBase *node)
 {
     delete node;
 }
 
 wxNodeBase *wxListBase::DetachNode(wxNodeBase *node)
 {

-    wxCHECK_MSG( node, NULL, "detaching NULL wxNodeBase" );
+    wxCHECK_MSG( node, NULL, _T("detaching NULL wxNodeBase") );

     wxCHECK_MSG( node->m_list == this, NULL,
     wxCHECK_MSG( node->m_list == this, NULL,

-                 "detaching node which is not from this list" );
+                 _T("detaching node which is not from this list") );

 
     // update the list
     wxNodeBase **prevNext = node->GetPrevious() ? &node->GetPrevious()->m_next
 
     // update the list
     wxNodeBase **prevNext = node->GetPrevious() ? &node->GetPrevious()->m_next


@@ -394,7 +402,6 @@ bool wxListBase::DeleteObject(void *object)
     return FALSE;
 }
 
     return FALSE;
 }
 

-

 void wxListBase::Clear()
 {
     wxNodeBase *current = m_nodeFirst;
 void wxListBase::Clear()
 {
     wxNodeBase *current = m_nodeFirst;


@@ -517,6 +524,23 @@ void wxStringListNode::DeleteData()
     delete [] (char *)GetData();
 }
 
     delete [] (char *)GetData();
 }
 

+bool wxStringList::Delete(const wxChar *s)
+{
+    wxStringListNode *current;
+
+    for ( current = GetFirst(); current; current = current->GetNext() )
+    {
+        if ( wxStrcmp(current->GetData(), s) == 0 )
+        {
+            DeleteNode(current);
+            return TRUE;
+        }
+    }
+
+    // not found
+    return FALSE;
+}
+

 void wxStringList::DoCopy(const wxStringList& other)
 {
     wxASSERT( GetCount() == 0 );    // this list must be empty before copying!
 void wxStringList::DoCopy(const wxStringList& other)
 {
     wxASSERT( GetCount() == 0 );    // this list must be empty before copying!


@@ -530,7 +554,7 @@ void wxStringList::DoCopy(const wxStringList& other)
 
 // Variable argument list, terminated by a zero
 // Makes new storage for the strings
 
 // Variable argument list, terminated by a zero
 // Makes new storage for the strings

-wxStringList::wxStringList (const char *first, ...)
+wxStringList::wxStringList (const wxChar *first, ...)

 {
   if ( !first )
     return;
 {
   if ( !first )
     return;


@@ -538,12 +562,12 @@ wxStringList::wxStringList (const char *first, ...)
   va_list ap;
   va_start(ap, first);
 
   va_list ap;
   va_start(ap, first);
 

-  const char *s = first;
+  const wxChar *s = first;

   for (;;)
   {
       Add(s);
 
   for (;;)
   {
       Add(s);
 

-      s = va_arg(ap, const char *);
+      s = va_arg(ap, const wxChar *);

       //    if (s == NULL)
 #ifdef __WXMSW__
       if ((int) s == 0)
       //    if (s == NULL)
 #ifdef __WXMSW__
       if ((int) s == 0)


@@ -557,13 +581,13 @@ wxStringList::wxStringList (const char *first, ...)
 }
 
 // Only makes new strings if arg is TRUE
 }
 
 // Only makes new strings if arg is TRUE

-char **wxStringList::ListToArray(bool new_copies) const
+wxChar **wxStringList::ListToArray(bool new_copies) const

 {
 {

-    char **string_array = new char *[GetCount()];
+    wxChar **string_array = new wxChar *[GetCount()];

     wxStringListNode *node = GetFirst();
     for (size_t i = 0; i < GetCount(); i++)
     {
     wxStringListNode *node = GetFirst();
     for (size_t i = 0; i < GetCount(); i++)
     {

-        char *s = node->GetData();
+        wxChar *s = node->GetData();

         if ( new_copies )
             string_array[i] = copystring(s);
         else
         if ( new_copies )
             string_array[i] = copystring(s);
         else


@@ -575,12 +599,12 @@ char **wxStringList::ListToArray(bool new_copies) const
 }
 
 // Checks whether s is a member of the list
 }
 
 // Checks whether s is a member of the list

-bool wxStringList::Member(const char *s) const
+bool wxStringList::Member(const wxChar *s) const

 {
     for ( wxStringListNode *node = GetFirst(); node; node = node->GetNext() )
     {
 {
     for ( wxStringListNode *node = GetFirst(); node; node = node->GetNext() )
     {

-        const char *s1 = node->GetData();
-        if (s == s1 || strcmp (s, s1) == 0)
+        const wxChar *s1 = node->GetData();
+        if (s == s1 || wxStrcmp (s, s1) == 0)

             return TRUE;
     }
 
             return TRUE;
     }
 


@@ -590,30 +614,30 @@ bool wxStringList::Member(const char *s) const
 static int
 wx_comparestrings(const void *arg1, const void *arg2)
 {
 static int
 wx_comparestrings(const void *arg1, const void *arg2)
 {

-  char **s1 = (char **) arg1;
-  char **s2 = (char **) arg2;
+  wxChar **s1 = (wxChar **) arg1;
+  wxChar **s2 = (wxChar **) arg2;

 
 

-  return strcmp (*s1, *s2);
+  return wxStrcmp (*s1, *s2);

 }
 
 // Sort a list of strings - deallocates old nodes, allocates new
 void wxStringList::Sort()
 {
     size_t N = GetCount();
 }
 
 // Sort a list of strings - deallocates old nodes, allocates new
 void wxStringList::Sort()
 {
     size_t N = GetCount();

-    char **array = new char *[N];
+    wxChar **array = new wxChar *[N];
+    wxStringListNode *node;

 
     size_t i = 0;
 
     size_t i = 0;

-    for ( wxStringListNode *node = GetFirst(); node; node = node->GetNext() )
+    for ( node = GetFirst(); node; node = node->GetNext() )

     {
         array[i++] = node->GetData();
     }
 
     {
         array[i++] = node->GetData();
     }
 

-    qsort (array, N, sizeof (char *), wx_comparestrings);
-    Clear();
+    qsort (array, N, sizeof (wxChar *), wx_comparestrings);

 
 

-    for (i = 0; i < N; i++)
-        Append (array[i]);
+    i = 0;
+    for ( node = GetFirst(); node; node = node->GetNext() )
+        node->SetData( array[i++] );

 
 

-    delete[]array;
+    delete [] array;

 }
 }

-