Use the same logic for closing dialogs as for handling Escape key.

[wxWidgets.git] / include / wx / os2 / dialog.h

diff --git a/include/wx/os2/dialog.h b/include/wx/os2/dialog.h
index 49f5af72ec8139479c470a1bd06ce53f271aab03..c4497ef4660599426d0d15fe7919b6732eae8a51 100644 (file)
--- a/include/wx/os2/dialog.h
+++ b/include/wx/os2/dialog.h
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        dialog.h
+// Name:        wx/os2/dialog.h

 // Purpose:     wxDialog class
 // Author:      David Webster
 // Modified by:
 // Purpose:     wxDialog class
 // Author:      David Webster
 // Modified by:


@@ -14,64 +14,30 @@
 
 #include "wx/panel.h"
 
 
 #include "wx/panel.h"
 

-WXDLLEXPORT_DATA(extern const char*) wxDialogNameStr;
+WXDLLIMPEXP_DATA_CORE(extern const char) wxDialogNameStr[];
+
+class WXDLLIMPEXP_FWD_CORE wxDialogModalData;

 
 //
 // Dialog boxes
 //
 
 //
 // Dialog boxes
 //

-class WXDLLEXPORT wxDialog: public wxDialogBase
+class WXDLLIMPEXP_CORE wxDialog: public wxDialogBase

 {
 public:
 
   inline wxDialog() { Init(); }
 
 {
 public:
 
   inline wxDialog() { Init(); }
 

-  //
-  // Constructor with a modal flag, but no window id - the old convention
-  //
-  inline wxDialog( wxWindow*       pParent
-                  ,const wxString& rsTitle
-                  ,bool            bModal
-                  ,int             nX = -1
-                  ,int             nY = -1
-                  ,int             nWidth = 500
-                  ,int             nHeight = 500
-                  ,long            lStyle = wxDEFAULT_DIALOG_STYLE
-                  ,const wxString& rsName = wxDialogNameStr
-                 )
+    // full ctor
+    wxDialog(wxWindow *parent, wxWindowID id,
+             const wxString& title,
+             const wxPoint& pos = wxDefaultPosition,
+             const wxSize& size = wxDefaultSize,
+             long style = wxDEFAULT_DIALOG_STYLE,
+             const wxString& name = wxDialogNameStr)

     {
     {

-        long                        lModalStyle = lStyle ? wxDIALOG_MODAL : wxDIALOG_MODELESS ;
-
-        bModal = false;
-        Create( pParent
-               ,-1
-               ,rsTitle
-               ,wxPoint(nX, nY)
-               ,wxSize(nWidth, nHeight)
-               ,lStyle | lModalStyle
-               ,rsName
-              );
-    }
+        Init();

 
 

-    //
-    // Constructor with no modal flag - the new convention.
-    //
-    inline wxDialog( wxWindow*       pParent
-                    ,wxWindowID      vId
-                    ,const wxString& rsTitle
-                    ,const wxPoint&  rPos = wxDefaultPosition
-                    ,const wxSize&   rSize = wxDefaultSize
-                    ,long            lStyle = wxDEFAULT_DIALOG_STYLE
-                    ,const wxString& rsName = wxDialogNameStr
-                   )
-    {
-        Create( pParent
-               ,vId
-               ,rsTitle
-               ,rPos
-               ,rSize
-               ,lStyle
-               ,rsName
-              );
+        (void)Create(parent, id, title, pos, size, style, name);

     }
 
     bool Create( wxWindow*       pParent
     }
 
     bool Create( wxWindow*       pParent


@@ -82,60 +48,22 @@ public:
                 ,long            lStyle = wxDEFAULT_DIALOG_STYLE
                 ,const wxString& rsName = wxDialogNameStr
                );
                 ,long            lStyle = wxDEFAULT_DIALOG_STYLE
                 ,const wxString& rsName = wxDialogNameStr
                );

-    ~wxDialog();
+    virtual ~wxDialog();

 
 

-    virtual bool Destroy(void);
-    virtual bool Show(bool bShow);
-    virtual void Iconize(bool bIconize);
-    virtual bool IsIconized(void) const;
+    // return true if we're showing the dialog modally
+    virtual bool IsModal() const { return m_modalData != NULL; }

 
 

-    virtual bool IsTopLevel(void) const { return TRUE; }
+    // show the dialog modally and return the value passed to EndModal()
+    virtual int ShowModal();

 
 

-    void         SetModal(bool bFlag);
-    virtual bool IsModal(void) const;
+    // may be called to terminate the dialog with the given return code
+    virtual void EndModal(int retCode);

 
 

-    //
-    // For now, same as Show(TRUE) but returns return code
-    //
-    virtual int  ShowModal(void);
-    virtual void EndModal(int nRetCode);
-
-    //
-    // Returns TRUE if we're in a modal loop
-    //
-    bool IsModalShowing() const;
-
-#if WXWIN_COMPATIBILITY
-    bool Iconized() const { return IsIconized(); };
-#endif
-
-    //
-    // Implementation only from now on
+    // implementation only from now on

     // -------------------------------
     // -------------------------------

-    //

 
 

-    //
-    // Event handlers
-    //
-    bool OnClose(void);
-    void OnCharHook(wxKeyEvent& rEvent);
-    void OnCloseWindow(wxCloseEvent& rEvent);
-
-    //
-    // May be called to terminate the dialog with the given return code
-    //
-
-    //
-    // Standard buttons
-    //
-    void     OnOK(wxCommandEvent& rEvent);
-    void     OnApply(wxCommandEvent& rEvent);
-    void     OnCancel(wxCommandEvent& rEvent);
-
-    //
-    // Responds to colour changes
-    //
-    void     OnSysColourChanged(wxSysColourChangedEvent& rEvent);
+    // override some base class virtuals
+    virtual bool Show(bool show = true);

 
     //
     // Callbacks
 
     //
     // Callbacks


@@ -144,28 +72,40 @@ public:
                                   ,WXWPARAM wParam
                                   ,WXLPARAM lParam
                                  );
                                   ,WXWPARAM wParam
                                   ,WXLPARAM lParam
                                  );

-protected:
-    //
-    // Override more base class virtuals
-    //
-    virtual void DoSetClientSize( int nWidth
-                                 ,int nHeight
-                                );
-    virtual void DoGetPosition( int* pnX
-                               ,int* pnY
-                              ) const;
-    //
-    // Show modal dialog and enter modal loop
-    //
-    void DoShowModal(void);
+#if WXWIN_COMPATIBILITY_2_6
+
+    // Constructor with a modal flag, but no window id - the old convention
+    wxDEPRECATED( wxDialog( wxWindow*       pParent
+                           ,const wxString& rsTitle
+                           ,bool            bModal
+                           ,int             nX = -1
+                           ,int             nY = -1
+                           ,int             nWidth = 500
+                           ,int             nHeight = 500
+                           ,long            lStyle = wxDEFAULT_DIALOG_STYLE
+                           ,const wxString& rsName = wxDialogNameStr
+                          ) );
+
+    // just call Show() or ShowModal()
+    wxDEPRECATED( void SetModal(bool bFlag) );
+
+    // use IsModal()
+    wxDEPRECATED( bool IsModalShowing() const );

 
 

+#endif // WXWIN_COMPATIBILITY_2_6
+
+protected:

     //
     // Common part of all ctors
     //
     //
     // Common part of all ctors
     //

-    void Init();
+    void Init(void);

 
 private:
     wxWindow*                       m_pOldFocus;
 
 private:
     wxWindow*                       m_pOldFocus;

+    bool        m_endModalCalled; // allow for closing within InitDialog
+
+    // this pointer is non-NULL only while the modal event loop is running
+    wxDialogModalData *m_modalData;

 
     //
     // While we are showing a modal dialog we disable the other windows using
 
     //
     // While we are showing a modal dialog we disable the other windows using


@@ -174,8 +114,7 @@ private:
     class wxWindowDisabler*         m_pWindowDisabler;
 
     DECLARE_DYNAMIC_CLASS(wxDialog)
     class wxWindowDisabler*         m_pWindowDisabler;
 
     DECLARE_DYNAMIC_CLASS(wxDialog)

-    DECLARE_EVENT_TABLE()
+    wxDECLARE_NO_COPY_CLASS(wxDialog);

 }; // end of CLASS wxDialog
 
 #endif // _WX_DIALOG_H_
 }; // end of CLASS wxDialog
 
 #endif // _WX_DIALOG_H_

-