Better fix

[wxWidgets.git] / src / gtk1 / gsockgtk.cpp

diff --git a/src/gtk1/gsockgtk.cpp b/src/gtk1/gsockgtk.cpp
index 0115e520db9d43b6a3a0af9e1a1d5be03d46bfa4..9a284628e1bf77402cb1ee8fa85f03860d0c02cf 100644 (file)
--- a/src/gtk1/gsockgtk.cpp
+++ b/src/gtk1/gsockgtk.cpp
@@ -1,16 +1,18 @@
-/* -------------------------------------------------------------------------
- * Project: GSocket (Generic Socket) for WX
- * Name:    gsockgtk.c
- * Purpose: GSocket: GTK part
- * Licence: The wxWindows licence
- * CVSID:   $Id$
- * -------------------------------------------------------------------------
- */
-#include "wx/setup.h"
+///////////////////////////////////////////////////////////////////////////////
+// Name:        gtk/gsockgtk.cpp
+// Purpose:     implementation of wxGTK-specific socket event handling
+// Author:      Guilhem Lavaux, Vadim Zeitlin
+// Created:     1999
+// RCS-ID:      $Id$
+// Copyright:   (c) 1999, 2007 wxWidgets dev team
+// Licence:     wxWindows licence
+///////////////////////////////////////////////////////////////////////////////
+
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
 
 #if wxUSE_SOCKETS
 
-#include <assert.h>
 #include <stdlib.h>
 #include <stdio.h>
 
@@ -18,111 +20,47 @@
 #include <glib.h>
 
 #include "wx/gsocket.h"
-#include "wx/unix/gsockunx.h"
-
+#include "wx/apptrait.h"
 
+extern "C" {
+static
 void _GSocket_GDK_Input(gpointer data,
-                        gint source,
+                        gint WXUNUSED(source),
                         GdkInputCondition condition)
 {
   GSocket *socket = (GSocket *)data;
 
   if (condition & GDK_INPUT_READ)
-    socket->m_functions->Detected_Read(socket);
+    socket->Detected_Read();
   if (condition & GDK_INPUT_WRITE)
-    socket->m_functions->Detected_Write(socket);
-}
-
-int _GSocket_GUI_Init(void)
-{
-    return 1;
-}
-
-void _GSocket_GUI_Cleanup(void)
-{
-}
-    
-int _GSocket_GUI_Init_Socket(GSocket *socket)
-{
-  gint *m_id;
-
-  socket->m_gui_dependent = (char *)malloc(sizeof(gint)*2);
-  m_id = (gint *)(socket->m_gui_dependent);
-
-  m_id[0] = -1;
-  m_id[1] = -1;
-
-  return TRUE;
-}
-
-void _GSocket_GUI_Destroy_Socket(GSocket *socket)
-{
-  free(socket->m_gui_dependent);
-}
-
-void _GSocket_Install_Callback(GSocket *socket, GSocketEvent event)
-{
-  gint *m_id = (gint *)(socket->m_gui_dependent);
-  int c;
-
-  if (socket->m_fd == -1)
-    return;
-
-  switch (event)
-  {
-    case GSOCK_LOST:       /* fall-through */
-    case GSOCK_INPUT:      c = 0; break;
-    case GSOCK_OUTPUT:     c = 1; break;
-    case GSOCK_CONNECTION: c = ((socket->m_server) ? 0 : 1); break;
-    default: return;
-  }
-
-  if (m_id[c] != -1)
-    gdk_input_remove(m_id[c]);
-
-  m_id[c] = gdk_input_add(socket->m_fd,
-                          (c ? GDK_INPUT_WRITE : GDK_INPUT_READ),
-                          _GSocket_GDK_Input,
-                          (gpointer)socket);
+    socket->Detected_Write();
 }
-
-void _GSocket_Uninstall_Callback(GSocket *socket, GSocketEvent event)
-{
-  gint *m_id = (gint *)(socket->m_gui_dependent);
-  int c;
-
-  assert( m_id != NULL );
-
-  switch (event)
-  {
-    case GSOCK_LOST:       /* fall-through */
-    case GSOCK_INPUT:      c = 0; break;
-    case GSOCK_OUTPUT:     c = 1; break;
-    case GSOCK_CONNECTION: c = ((socket->m_server) ? 0 : 1); break;
-    default: return;
-  }
-
-  if (m_id[c] != -1)
-    gdk_input_remove(m_id[c]);
-
-  m_id[c] = -1;
 }
 
-void _GSocket_Enable_Events(GSocket *socket)
+class GTKSocketManager : public GSocketInputBasedManager
 {
-  _GSocket_Install_Callback(socket, GSOCK_INPUT);
-  _GSocket_Install_Callback(socket, GSOCK_OUTPUT);
-}
-
-void _GSocket_Disable_Events(GSocket *socket)
+public:
+    virtual int AddInput(GSocket *socket, SocketDir d)
+    {
+        return gdk_input_add
+               (
+                    socket->m_fd,
+                    d == FD_OUTPUT ? GDK_INPUT_WRITE : GDK_INPUT_READ,
+                    _GSocket_GDK_Input,
+                    socket
+               );
+    }
+
+    virtual void RemoveInput(int fd)
+    {
+        gdk_input_remove(fd);
+    }
+};
+
+GSocketManager *wxGUIAppTraits::GetSocketManager()
 {
-  _GSocket_Uninstall_Callback(socket, GSOCK_INPUT);
-  _GSocket_Uninstall_Callback(socket, GSOCK_OUTPUT);
+    static GTKSocketManager s_manager;
+    return &s_manager;
 }
 
-#else /* !wxUSE_SOCKETS */
-
-/* some compilers don't like having empty source files */
-static int wxDummyGsockVar = 0;
-
-#endif /* wxUSE_SOCKETS/!wxUSE_SOCKETS */
+#endif // wxUSE_SOCKETS