fix another memory leak in SetCommand() (coverity checker CID 52)

[wxWidgets.git] / src / motif / evtloop.cpp

diff --git a/src/motif/evtloop.cpp b/src/motif/evtloop.cpp
index c2f7d4ac31d3b036a9ec5c3b427f4915c937896e..424b96c5abde10f1f3d2f445ddce6334a761e67c 100644 (file)
--- a/src/motif/evtloop.cpp
+++ b/src/motif/evtloop.cpp
@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////

-// Name:        motif/evtloop.cpp
+// Name:        src/motif/evtloop.cpp

 // Purpose:     implements wxEventLoop for Motif
 // Author:      Mattia Barbon
 // Modified by:
 // Purpose:     implements wxEventLoop for Motif
 // Author:      Mattia Barbon
 // Modified by:


@@ -96,8 +96,6 @@ bool wxEventLoopImpl::SendIdleMessage()
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 

-wxEventLoop *wxEventLoopBase::ms_activeLoop = NULL;
-

 wxEventLoop::~wxEventLoop()
 {
     wxASSERT_MSG( !m_impl, _T("should have been deleted in Run()") );
 wxEventLoop::~wxEventLoop()
 {
     wxASSERT_MSG( !m_impl, _T("should have been deleted in Run()") );


@@ -108,8 +106,7 @@ int wxEventLoop::Run()
     // event loops are not recursive, you need to create another loop!
     wxCHECK_MSG( !IsRunning(), -1, _T("can't reenter a message loop") );
 
     // event loops are not recursive, you need to create another loop!
     wxCHECK_MSG( !IsRunning(), -1, _T("can't reenter a message loop") );
 

-    wxEventLoop *oldLoop = ms_activeLoop;
-    ms_activeLoop = this;
+    wxEventLoopActivator activate(this);

 
     m_impl = new wxEventLoopImpl;
     m_impl->SetKeepGoing( true );
 
     m_impl = new wxEventLoopImpl;
     m_impl->SetKeepGoing( true );


@@ -124,8 +121,6 @@ int wxEventLoop::Run()
     delete m_impl;
     m_impl = NULL;
 
     delete m_impl;
     m_impl = NULL;
 

-    ms_activeLoop = oldLoop;
-

     return exitcode;
 }
 
     return exitcode;
 }
 


@@ -257,7 +252,7 @@ bool CheckForAccelerator(XEvent* event)
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

             widget = XtParent(widget);
 
         if (!widget || !win)
             widget = XtParent(widget);
 
         if (!widget || !win)


@@ -291,7 +286,7 @@ bool CheckForKeyDown(XEvent* event)
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

             widget = XtParent(widget);
 
         if (!widget || !win)
             widget = XtParent(widget);
 
         if (!widget || !win)


@@ -317,7 +312,7 @@ bool CheckForKeyUp(XEvent* event)
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

                 widget = XtParent(widget);
 
         if (!widget || !win)
                 widget = XtParent(widget);
 
         if (!widget || !win)


@@ -410,7 +405,7 @@ private:
     DECLARE_DYNAMIC_CLASS(wxIdlePipeModule)
 };
 
     DECLARE_DYNAMIC_CLASS(wxIdlePipeModule)
 };
 

-IMPLEMENT_DYNAMIC_CLASS(wxIdlePipeModule, wxModule);
+IMPLEMENT_DYNAMIC_CLASS(wxIdlePipeModule, wxModule)

 
 static void wxInputCallback( XtPointer, int* fd, XtInputId* )
 {
 
 static void wxInputCallback( XtPointer, int* fd, XtInputId* )
 {


@@ -472,7 +467,7 @@ bool wxAddIdleCallback()
 {
     if (!wxInitIdleFds())
         return false;
 {
     if (!wxInitIdleFds())
         return false;

-    
+

     // install input handler for wxWakeUpIdle
     XtAppAddInput((XtAppContext) wxTheApp->GetAppContext(),
                   idleFds[0],
     // install input handler for wxWakeUpIdle
     XtAppAddInput((XtAppContext) wxTheApp->GetAppContext(),
                   idleFds[0],