DLL compilation fixes

[wxWidgets.git] / src / unix / fontenum.cpp

diff --git a/src/unix/fontenum.cpp b/src/unix/fontenum.cpp
index cf11e65ba8eea7076cc86dec31e355daf748d1d3..3e0766599a9c15917c1175288f8629f5a7ac1678 100644 (file)
--- a/src/unix/fontenum.cpp
+++ b/src/unix/fontenum.cpp
@@ -20,13 +20,17 @@
 // for compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 // for compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 

-#include "wx/dynarray.h"
-#include "wx/string.h"
+#include "wx/fontenum.h"
+
+#ifndef WX_PRECOMP
+    #include "wx/dynarray.h"
+    #include "wx/string.h"
+    #include "wx/app.h"
+    #include "wx/utils.h"
+#endif
+

 #include "wx/regex.h"
 #include "wx/regex.h"

-#include "wx/utils.h"
-#include "wx/app.h"

 #include "wx/fontmap.h"
 #include "wx/fontmap.h"

-#include "wx/fontenum.h"

 #include "wx/fontutil.h"
 #include "wx/encinfo.h"
 
 #include "wx/fontutil.h"
 #include "wx/encinfo.h"
 


@@ -41,7 +45,7 @@
 #ifdef __WXGTK20__
 #include "gtk/gtk.h"
 extern GtkWidget *wxGetRootWindow();
 #ifdef __WXGTK20__
 #include "gtk/gtk.h"
 extern GtkWidget *wxGetRootWindow();

-#endif
+#endif // __WXGTK20__

 
 extern "C" int wxCMPFUNC_CONV
 wxCompareFamilies (const void *a, const void *b)
 
 extern "C" int wxCMPFUNC_CONV
 wxCompareFamilies (const void *a, const void *b)


@@ -66,11 +70,11 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
         OnFacename( wxT("monospace") );
     }
     else
         OnFacename( wxT("monospace") );
     }
     else

-#endif
+#endif // __WXGTK20__ || !HAVE_PANGO_FONT_FAMILY_IS_MONOSPACE

     {
         PangoFontFamily **families = NULL;
         gint n_families = 0;
     {
         PangoFontFamily **families = NULL;
         gint n_families = 0;

-        pango_context_list_families ( 
+        pango_context_list_families (

 #ifdef __WXGTK20__
             gtk_widget_get_pango_context( wxGetRootWindow() ),
 #else
 #ifdef __WXGTK20__
             gtk_widget_get_pango_context( wxGetRootWindow() ),
 #else


@@ -97,12 +101,12 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
         g_free(families);
     }
 
         g_free(families);
     }
 

-    return TRUE;
+    return true;

 }
 
 bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
 {
 }
 
 bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
 {

-    return FALSE;
+    return false;

 }
 
 
 }
 
 


@@ -194,6 +198,7 @@ static bool ProcessFamiliesFromFontList(wxFontEnumerator *This,
             continue;
         }
 
             continue;
         }
 

+        // coverity[returned_null]

         char *dash = strchr(font + 1, '-');
         char *family = dash + 1;
         dash = strchr(family, '-');
         char *dash = strchr(font + 1, '-');
         char *family = dash + 1;
         dash = strchr(family, '-');


@@ -205,7 +210,7 @@ static bool ProcessFamiliesFromFontList(wxFontEnumerator *This,
             if ( !This->OnFacename(fam) )
             {
                 // stop enumerating
             if ( !This->OnFacename(fam) )
             {
                 // stop enumerating

-                return FALSE;
+                return false;

             }
 
             families.Add(fam);
             }
 
             families.Add(fam);


@@ -213,7 +218,7 @@ static bool ProcessFamiliesFromFontList(wxFontEnumerator *This,
         //else: already seen
     }
 
         //else: already seen
     }
 

-    return TRUE;
+    return true;

 }
 #endif
   // wxUSE_NANOX
 }
 #endif
   // wxUSE_NANOX


@@ -226,14 +231,14 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
                                           bool fixedWidthOnly)
 {
 #if wxUSE_NANOX
                                           bool fixedWidthOnly)
 {
 #if wxUSE_NANOX

-    return FALSE;
+    return false;

 #else
     int nFonts;
     char **fonts;
 
     if ( fixedWidthOnly )
     {
 #else
     int nFonts;
     char **fonts;
 
     if ( fixedWidthOnly )
     {

-        bool cont = TRUE;
+        bool cont = true;

         fonts = CreateFontList(wxT('m'), encoding, &nFonts);
         if ( fonts )
         {
         fonts = CreateFontList(wxT('m'), encoding, &nFonts);
         if ( fonts )
         {


@@ -244,13 +249,13 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
 
         if ( !cont )
         {
 
         if ( !cont )
         {

-            return TRUE;
+            return true;

         }
 
         fonts = CreateFontList(wxT('c'), encoding, &nFonts);
         if ( !fonts )
         {
         }
 
         fonts = CreateFontList(wxT('c'), encoding, &nFonts);
         if ( !fonts )
         {

-            return TRUE;
+            return true;

         }
     }
     else
         }
     }
     else


@@ -264,14 +269,14 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
             wxASSERT_MSG(encoding != wxFONTENCODING_SYSTEM,
                          wxT("No fonts at all on this system?"));
 
             wxASSERT_MSG(encoding != wxFONTENCODING_SYSTEM,
                          wxT("No fonts at all on this system?"));
 

-            return FALSE;
+            return false;

         }
     }
 
     (void)ProcessFamiliesFromFontList(this, fonts, nFonts);
 
     XFreeFontNames(fonts);
         }
     }
 
     (void)ProcessFamiliesFromFontList(this, fonts, nFonts);
 
     XFreeFontNames(fonts);

-    return TRUE;
+    return true;

 #endif
     // wxUSE_NANOX
 }
 #endif
     // wxUSE_NANOX
 }


@@ -279,11 +284,11 @@ bool wxFontEnumerator::EnumerateFacenames(wxFontEncoding encoding,
 bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
 {
 #if wxUSE_NANOX
 bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
 {
 #if wxUSE_NANOX

-    return FALSE;
+    return false;

 #else
     wxString pattern;
     pattern.Printf(wxT("-*-%s-*-*-*-*-*-*-*-*-*-*-*-*"),
 #else
     wxString pattern;
     pattern.Printf(wxT("-*-%s-*-*-*-*-*-*-*-*-*-*-*-*"),

-                   family.IsEmpty() ? wxT("*") : family.c_str());
+                   family.empty() ? wxT("*") : family.c_str());

 
     // get the list of all fonts
     int nFonts;
 
     // get the list of all fonts
     int nFonts;


@@ -293,7 +298,7 @@ bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
     if ( !fonts )
     {
         // unknown family?
     if ( !fonts )
     {
         // unknown family?

-        return FALSE;
+        return false;

     }
 
     // extract the list of (unique) encodings
     }
 
     // extract the list of (unique) encodings


@@ -313,7 +318,7 @@ bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
         dash = strchr(familyFont, '-');
         *dash = '\0'; // !NULL because Matches() above succeeded
 
         dash = strchr(familyFont, '-');
         *dash = '\0'; // !NULL because Matches() above succeeded
 

-        if ( !family.IsEmpty() && (family != familyFont) )
+        if ( !family.empty() && (family != familyFont) )

         {
             // family doesn't match
             continue;
         {
             // family doesn't match
             continue;


@@ -344,10 +349,9 @@ bool wxFontEnumerator::EnumerateEncodings(const wxString& family)
 
     XFreeFontNames(fonts);
 
 
     XFreeFontNames(fonts);
 

-    return TRUE;
+    return true;

 #endif
     // wxUSE_NANOX
 }
 
 #endif
     // wxUSE_NANOX
 }
 

-#endif
-   // __WXGTK20__
+#endif // !wxUSE_PANGO