Lots of OS/2 updates

[wxWidgets.git] / src / gtk / cursor.cpp

diff --git a/src/gtk/cursor.cpp b/src/gtk/cursor.cpp
index c4b56c61723c5b952d566b6b731993698d74c9dd..dc03ce10db83ba99f5833335f94eba5c38c18cdd 100644 (file)
--- a/src/gtk/cursor.cpp
+++ b/src/gtk/cursor.cpp
@@ -142,87 +142,90 @@ wxCursor::wxCursor(const char bits[], int width, int  height,
 
 
 wxCursor::wxCursor( const wxCursor &cursor )
 
 
 wxCursor::wxCursor( const wxCursor &cursor )

+    : wxObject()

 {
     Ref( cursor );
 }
 
 #if wxUSE_IMAGE
 {
     Ref( cursor );
 }
 
 #if wxUSE_IMAGE

+

 wxCursor::wxCursor( const wxImage & image )
 {
     unsigned char * rgbBits = image.GetData();
 wxCursor::wxCursor( const wxImage & image )
 {
     unsigned char * rgbBits = image.GetData();

-    int w = image.GetWidth()  ;
-    int h = image.GetHeight() ;
-    bool bHasMask = image.HasMask() ;
+    int w = image.GetWidth() ;
+    int h = image.GetHeight();
+    bool bHasMask = image.HasMask();

     int imagebitcount = (w*h)/8;
 
     int imagebitcount = (w*h)/8;
 

-    unsigned char r, g, b ;

     unsigned char * bits = new unsigned char [imagebitcount];
     unsigned char * maskBits = new unsigned char [imagebitcount];
 
     unsigned char * bits = new unsigned char [imagebitcount];
     unsigned char * maskBits = new unsigned char [imagebitcount];
 

-    int i,j, i8; unsigned char c, cMask;
+    int i, j, i8; unsigned char c, cMask;

     for (i=0; i<imagebitcount; i++)
     for (i=0; i<imagebitcount; i++)

-        {
+    {

         bits[i] = 0;
         i8 = i * 8;
 
         cMask = 1;
         for (j=0; j<8; j++)
         bits[i] = 0;
         i8 = i * 8;
 
         cMask = 1;
         for (j=0; j<8; j++)

-           {
-           // possible overflow if we do the summation first ?
-           c = rgbBits[(i8+j)*3]/3 + rgbBits[(i8+j)*3+1]/3 + rgbBits[(i8+j)*3+2]/3 ;
-           //if average value is > mid grey
-           if (c>127)
-              bits[i] = bits[i] | cMask ;
-           cMask = cMask * 2 ;
-           }
+        {
+            // possible overflow if we do the summation first ?
+            c = rgbBits[(i8+j)*3]/3 + rgbBits[(i8+j)*3+1]/3 + rgbBits[(i8+j)*3+2]/3;
+            //if average value is > mid grey
+            if (c>127)
+                bits[i] = bits[i] | cMask;
+            cMask = cMask * 2;

         }
         }

+    }
+
+    unsigned long keyMaskColor;

     if (bHasMask)
     if (bHasMask)

-        {
-        r = image.GetMaskRed() ;
-        g = image.GetMaskGreen() ;
-        b = image.GetMaskBlue() ;
+    {
+        unsigned char
+            r = image.GetMaskRed(),
+            g = image.GetMaskGreen(),
+            b = image.GetMaskBlue();

 
         for (i=0; i<imagebitcount; i++)
         {
 
         for (i=0; i<imagebitcount; i++)
         {

-        maskBits[i] = 0x0;
-        i8 = i * 8;
+            maskBits[i] = 0x0;
+            i8 = i * 8;

 
 

-        cMask = 1;
-        for (j=0; j<8; j++)
-           {
-           if (rgbBits[(i8+j)*3] != r || rgbBits[(i8+j)*3+1] != g || rgbBits[(i8+j)*3+2] != b)
-              maskBits[i] = maskBits[i] | cMask ;
-           cMask = cMask * 2 ;
-           }
-        }
+            cMask = 1;
+            for (j=0; j<8; j++)
+            {
+                if (rgbBits[(i8+j)*3] != r || rgbBits[(i8+j)*3+1] != g || rgbBits[(i8+j)*3+2] != b)
+                    maskBits[i] = maskBits[i] | cMask;
+                cMask = cMask * 2;
+            }

         }
         }

-      else
-        {
+
+        keyMaskColor = (r << 16) | (g << 8) | b;
+    }
+    else // no mask
+    {

         for (i=0; i<imagebitcount; i++)
         for (i=0; i<imagebitcount; i++)

-            maskBits[i]= 0xFF ;
-        }
-    //find the most frequent color(s)
-    //it seems a waste of effort to copy the image
-    //but otherwise we need to remove the const modifier ??
-    wxImage tmpImage = image.Copy();
+            maskBits[i] = 0xFF;
+
+        // init it to avoid compiler warnings
+        keyMaskColor = 0;
+    }
+
+    // find the most frequent color(s)

     wxImageHistogram histogram;
     wxImageHistogram histogram;

+    image.ComputeHistogram(histogram);

 
 

-    //colors as rrggbb
+    // colors as rrggbb

     unsigned long key;
     unsigned long value;
     unsigned long key;
     unsigned long value;

-    unsigned long keyMaskColor = 0;
-    if (bHasMask)
-        keyMaskColor = (r << 16) | (g << 8) | b;

 
 

-    tmpImage.ComputeHistogram(histogram);
-
-    long MostFreqCol = 0;
+    long colMostFreq = 0;

     unsigned long nMost = 0;
     unsigned long nMost = 0;

-    long NextFreqCol = 0;
+    long colNextMostFreq = 0;

     unsigned long nNext = 0;
     unsigned long nNext = 0;

-    wxImageHistogram::iterator entry = histogram.begin();
-
-    while ( entry != histogram.end() )
+    for ( wxImageHistogram::iterator entry = histogram.begin();
+          entry != histogram.end();
+          ++entry )

     {
         value = entry->second.value;
         key = entry->first;
     {
         value = entry->second.value;
         key = entry->first;


@@ -231,53 +234,63 @@ wxCursor::wxCursor( const wxImage & image )
             if (value > nMost)
             {
                 nMost = value;
             if (value > nMost)
             {
                 nMost = value;

-                MostFreqCol = key;
+                colMostFreq = key;

             }
             else if (value > nNext)
             {
                 nNext = value;
             }
             else if (value > nNext)
             {
                 nNext = value;

-                NextFreqCol = key;
+                colNextMostFreq = key;

             }
         }
     }
 
             }
         }
     }
 

-    wxColour fg = wxColour ( (unsigned char)(MostFreqCol >> 16),
-                             (unsigned char)(MostFreqCol >> 8),
-                             (unsigned char)(MostFreqCol) ) ;
+    wxColour fg = wxColour ( (unsigned char)(colMostFreq >> 16),
+                             (unsigned char)(colMostFreq >> 8),
+                             (unsigned char)(colMostFreq) );

 
 

-    wxColour bg = wxColour ( (unsigned char)(NextFreqCol >> 16),
-                             (unsigned char)(NextFreqCol >> 8),
-                             (unsigned char)(NextFreqCol) ) ;
+    wxColour bg = wxColour ( (unsigned char)(colNextMostFreq >> 16),
+                             (unsigned char)(colNextMostFreq >> 8),
+                             (unsigned char)(colNextMostFreq) );

 
 

-    int hotSpotX=0;
-    int hotSpotY=0;
+    int hotSpotX;
+    int hotSpotY;

 
     if (image.HasOption(wxCUR_HOTSPOT_X))
         hotSpotX = image.GetOptionInt(wxCUR_HOTSPOT_X);
 
     if (image.HasOption(wxCUR_HOTSPOT_X))
         hotSpotX = image.GetOptionInt(wxCUR_HOTSPOT_X);

+    else
+        hotSpotX = 0;
+

     if (image.HasOption(wxCUR_HOTSPOT_Y))
         hotSpotY = image.GetOptionInt(wxCUR_HOTSPOT_Y);
     if (image.HasOption(wxCUR_HOTSPOT_Y))
         hotSpotY = image.GetOptionInt(wxCUR_HOTSPOT_Y);

+    else
+        hotSpotY = 0;

 
     if (hotSpotX < 0 || hotSpotX >= w)
         hotSpotX = 0;
     if (hotSpotY < 0 || hotSpotY >= h)
         hotSpotY = 0;
 
 
     if (hotSpotX < 0 || hotSpotX >= w)
         hotSpotX = 0;
     if (hotSpotY < 0 || hotSpotY >= h)
         hotSpotY = 0;
 

-    GdkBitmap *data = gdk_bitmap_create_from_data( wxGetRootWindow()->window, (gchar *) bits,
-        w, h );
-    GdkBitmap *mask = gdk_bitmap_create_from_data( wxGetRootWindow()->window, (gchar *) maskBits,
-        w, h );
+    GdkBitmap *data = gdk_bitmap_create_from_data(wxGetRootWindow()->window,
+                                                  (gchar *) bits, w, h);
+    GdkBitmap *mask = gdk_bitmap_create_from_data(wxGetRootWindow()->window,
+                                                  (gchar *) maskBits, w, h);

 
     m_refData = new wxCursorRefData;
 
     m_refData = new wxCursorRefData;

-    M_CURSORDATA->m_cursor = gdk_cursor_new_from_pixmap(
-        data, mask, fg.GetColor(), bg.GetColor(),
-        hotSpotX, hotSpotY );
+    M_CURSORDATA->m_cursor = gdk_cursor_new_from_pixmap
+                             (
+                                data,
+                                mask,
+                                fg.GetColor(), bg.GetColor(),
+                                hotSpotX, hotSpotY
+                             );

 
     gdk_bitmap_unref( data );
     gdk_bitmap_unref( mask );
 
     gdk_bitmap_unref( data );
     gdk_bitmap_unref( mask );

-    delete [] bits ;
+    delete [] bits;

     delete [] maskBits;
 }
     delete [] maskBits;
 }

-#endif
+
+#endif // wxUSE_IMAGE

 
 wxCursor::~wxCursor()
 {
 
 wxCursor::~wxCursor()
 {