GetLabelTop should return the stripped label, for compatibility.

[wxWidgets.git] / src / gtk / slider.cpp

diff --git a/src/gtk/slider.cpp b/src/gtk/slider.cpp
index c2ba63e207eebe9e1ea0d3bf37fcf68e4912b1b4..13e84b797410776f182687d28f32fd239b611d5e 100644 (file)
--- a/src/gtk/slider.cpp
+++ b/src/gtk/slider.cpp
@@ -16,9 +16,10 @@
 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"
 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"

+    #include "wx/math.h"

 #endif
 
 #endif
 

-#include "wx/gtk/private.h"
+#include <gtk/gtk.h>

 
 //-----------------------------------------------------------------------------
 // data
 
 //-----------------------------------------------------------------------------
 // data


@@ -123,15 +124,14 @@ extern "C" {
 static void
 gtk_value_changed(GtkRange* range, wxSlider* win)
 {
 static void
 gtk_value_changed(GtkRange* range, wxSlider* win)
 {

-    if (g_isIdle) wxapp_install_idle_handler();
-
-    if (!win->m_hasVMT) return;
-    if (g_blockEventsOnDrag) return;
-
-    GtkAdjustment* adj = range->adjustment;
-    const int pos = int(round(adj->value));
+    GtkAdjustment* adj = gtk_range_get_adjustment (range);
+    const int pos = wxRound(adj->value);

     const double oldPos = win->m_pos;
     win->m_pos = adj->value;
     const double oldPos = win->m_pos;
     win->m_pos = adj->value;

+
+    if (!win->m_hasVMT || g_blockEventsOnDrag)
+        return;
+

     if (win->m_blockScrollEvent)
     {
         win->m_scrollEventType = GTK_SCROLL_NONE;
     if (win->m_blockScrollEvent)
     {
         win->m_scrollEventType = GTK_SCROLL_NONE;


@@ -178,9 +178,8 @@ gtk_value_changed(GtkRange* range, wxSlider* win)
     win->m_scrollEventType = GTK_SCROLL_NONE;
 
     // If integral position has changed
     win->m_scrollEventType = GTK_SCROLL_NONE;
 
     // If integral position has changed

-    if (int(round(oldPos)) != pos)
+    if (wxRound(oldPos) != pos)

     {
     {

-        wxCHECK_RET(eventType != wxEVT_NULL, _T("Unknown slider scroll event type"));

         ProcessScrollEvent(win, eventType);
         win->m_needThumbRelease = eventType == wxEVT_SCROLL_THUMBTRACK;
     }
         ProcessScrollEvent(win, eventType);
         win->m_needThumbRelease = eventType == wxEVT_SCROLL_THUMBTRACK;
     }


@@ -214,25 +213,28 @@ gtk_button_press_event(GtkWidget*, GdkEventButton*, wxSlider* win)
 }
 }
 
 }
 }
 

-// Single shot idle callback, to generate thumb release event, and
-//  truncate position to integral value.  Idle callback is used
-//  because position cannot be changed from button release event.
+//-----------------------------------------------------------------------------
+// "event_after"
+//-----------------------------------------------------------------------------
+

 extern "C" {
 extern "C" {

-static gboolean
-idle_thumbrelease(void* data)
+static void
+gtk_event_after(GtkRange* range, GdkEvent* event, wxSlider* win)

 {
 {

-    wxSlider* win = (wxSlider*)data;
-    win->m_isScrolling = false;
-    if (win->m_needThumbRelease)
+    if (event->type == GDK_BUTTON_RELEASE)

     {
     {

-        win->m_needThumbRelease = false;
-        ProcessScrollEvent(win, wxEVT_SCROLL_THUMBRELEASE);
+        g_signal_handlers_block_by_func(range, (gpointer) gtk_event_after, win);
+
+        if (win->m_needThumbRelease)
+        {
+            win->m_needThumbRelease = false;
+            ProcessScrollEvent(win, wxEVT_SCROLL_THUMBRELEASE);
+        }
+        // Keep slider at an integral position
+        win->BlockScrollEvent();
+        gtk_range_set_value(GTK_RANGE (win->m_widget), win->GetValue());
+        win->UnblockScrollEvent();

     }
     }

-    // Keep slider at an integral position
-    win->BlockScrollEvent();
-    gtk_range_set_value((GtkRange*)win->m_widget, win->GetValue());
-    win->UnblockScrollEvent();
-    return false;

 }
 }
 
 }
 }
 


@@ -242,12 +244,13 @@ idle_thumbrelease(void* data)
 
 extern "C" {
 static gboolean
 
 extern "C" {
 static gboolean

-gtk_button_release_event(GtkWidget*, GdkEventButton*, wxSlider* win)
+gtk_button_release_event(GtkRange* range, GdkEventButton*, wxSlider* win)

 {
     win->m_mouseButtonDown = false;
     if (win->m_isScrolling)
     {
 {
     win->m_mouseButtonDown = false;
     if (win->m_isScrolling)
     {

-        g_idle_add(idle_thumbrelease, win);
+        win->m_isScrolling = false;
+        g_signal_handlers_unblock_by_func(range, (gpointer) gtk_event_after, win);

     }
     return false;
 }
     }
     return false;
 }


@@ -261,7 +264,7 @@ extern "C" {
 static gchar* gtk_format_value(GtkScale*, double value, void*)
 {
     // Format value as nearest integer
 static gchar* gtk_format_value(GtkScale*, double value, void*)
 {
     // Format value as nearest integer

-    return g_strdup_printf("%d", int(round(value)));
+    return g_strdup_printf("%d", wxRound(value));

 }
 }
 
 }
 }
 


@@ -278,14 +281,17 @@ wxSlider::wxSlider()
     m_needThumbRelease = false;
 }
 
     m_needThumbRelease = false;
 }
 

-bool wxSlider::Create(wxWindow *parent, wxWindowID id,
-        int value, int minValue, int maxValue,
-        const wxPoint& pos, const wxSize& size,
-        long style, const wxValidator& validator, const wxString& name )
+bool wxSlider::Create(wxWindow *parent,
+                      wxWindowID id,
+                      int value,
+                      int minValue,
+                      int maxValue,
+                      const wxPoint& pos,
+                      const wxSize& size,
+                      long style,
+                      const wxValidator& validator,
+                      const wxString& name)

 {
 {

-    m_acceptsFocus = true;
-    m_needParent = true;
-

     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {


@@ -302,9 +308,9 @@ bool wxSlider::Create(wxWindow *parent, wxWindowID id,
     else
         m_widget = gtk_hscale_new( (GtkAdjustment *) NULL );
 
     else
         m_widget = gtk_hscale_new( (GtkAdjustment *) NULL );
 

-    gtk_scale_set_draw_value((GtkScale*)m_widget, (style & wxSL_LABELS) != 0);
+    gtk_scale_set_draw_value(GTK_SCALE (m_widget), (style & wxSL_LABELS) != 0);

     // Keep full precision in position value
     // Keep full precision in position value

-    gtk_scale_set_digits((GtkScale*)m_widget, -1);
+    gtk_scale_set_digits(GTK_SCALE (m_widget), -1);

 
     if (style & wxSL_INVERSE)
         gtk_range_set_inverted( GTK_RANGE(m_widget), TRUE );
 
     if (style & wxSL_INVERSE)
         gtk_range_set_inverted( GTK_RANGE(m_widget), TRUE );


@@ -314,6 +320,10 @@ bool wxSlider::Create(wxWindow *parent, wxWindowID id,
     g_signal_connect(m_widget, "move_slider", G_CALLBACK(gtk_move_slider), this);
     g_signal_connect(m_widget, "format_value", G_CALLBACK(gtk_format_value), NULL);
     g_signal_connect(m_widget, "value_changed", G_CALLBACK(gtk_value_changed), this);
     g_signal_connect(m_widget, "move_slider", G_CALLBACK(gtk_move_slider), this);
     g_signal_connect(m_widget, "format_value", G_CALLBACK(gtk_format_value), NULL);
     g_signal_connect(m_widget, "value_changed", G_CALLBACK(gtk_value_changed), this);

+    gulong handler_id;
+    handler_id = g_signal_connect(
+        m_widget, "event_after", G_CALLBACK(gtk_event_after), this);
+    g_signal_handler_block(m_widget, handler_id);

 
     SetRange( minValue, maxValue );
     SetValue( value );
 
     SetRange( minValue, maxValue );
     SetValue( value );


@@ -327,7 +337,7 @@ bool wxSlider::Create(wxWindow *parent, wxWindowID id,
 
 int wxSlider::GetValue() const
 {
 
 int wxSlider::GetValue() const
 {

-    return int(round(m_pos));
+    return wxRound(m_pos);

 }
 
 void wxSlider::SetValue( int value )
 }
 
 void wxSlider::SetValue( int value )


@@ -335,7 +345,7 @@ void wxSlider::SetValue( int value )
     if (GetValue() != value)
     {
         BlockScrollEvent();
     if (GetValue() != value)
     {
         BlockScrollEvent();

-        gtk_range_set_value((GtkRange*)m_widget, value);
+        gtk_range_set_value(GTK_RANGE (m_widget), value);

         UnblockScrollEvent();
     }
 }
         UnblockScrollEvent();
     }
 }


@@ -343,31 +353,31 @@ void wxSlider::SetValue( int value )
 void wxSlider::SetRange( int minValue, int maxValue )
 {
     BlockScrollEvent();
 void wxSlider::SetRange( int minValue, int maxValue )
 {
     BlockScrollEvent();

-    gtk_range_set_range((GtkRange*)m_widget, minValue, maxValue);
-    gtk_range_set_increments((GtkRange*)m_widget, 1, (maxValue - minValue + 9) / 10);
+    gtk_range_set_range(GTK_RANGE (m_widget), minValue, maxValue);
+    gtk_range_set_increments(GTK_RANGE (m_widget), 1, (maxValue - minValue + 9) / 10);

     UnblockScrollEvent();
 }
 
 int wxSlider::GetMin() const
 {
     UnblockScrollEvent();
 }
 
 int wxSlider::GetMin() const
 {

-    return int(((GtkRange*)m_widget)->adjustment->lower);
+    return int(gtk_range_get_adjustment (GTK_RANGE (m_widget))->lower);

 }
 
 int wxSlider::GetMax() const
 {
 }
 
 int wxSlider::GetMax() const
 {

-    return int(((GtkRange*)m_widget)->adjustment->upper);
+    return int(gtk_range_get_adjustment (GTK_RANGE (m_widget))->upper);

 }
 
 void wxSlider::SetPageSize( int pageSize )
 {
     BlockScrollEvent();
 }
 
 void wxSlider::SetPageSize( int pageSize )
 {
     BlockScrollEvent();

-    gtk_range_set_increments((GtkRange*)m_widget, 1, pageSize);
+    gtk_range_set_increments(GTK_RANGE (m_widget), GetLineSize(), pageSize);

     UnblockScrollEvent();
 }
 
 int wxSlider::GetPageSize() const
 {
     UnblockScrollEvent();
 }
 
 int wxSlider::GetPageSize() const
 {

-    return int(((GtkRange*)m_widget)->adjustment->page_increment);
+    return int(gtk_range_get_adjustment (GTK_RANGE (m_widget))->page_increment);

 }
 
 // GTK does not support changing the size of the slider
 }
 
 // GTK does not support changing the size of the slider


@@ -380,19 +390,21 @@ int wxSlider::GetThumbLength() const
     return 0;
 }
 
     return 0;
 }
 

-void wxSlider::SetLineSize( int WXUNUSED(lineSize) )
+void wxSlider::SetLineSize( int lineSize )

 {
 {

+    BlockScrollEvent();
+    gtk_range_set_increments(GTK_RANGE (m_widget), lineSize, GetPageSize());
+    UnblockScrollEvent();

 }
 
 int wxSlider::GetLineSize() const
 {
 }
 
 int wxSlider::GetLineSize() const
 {

-    return 0;
+    return int(gtk_range_get_adjustment (GTK_RANGE (m_widget))->step_increment);

 }
 
 }
 

-bool wxSlider::IsOwnGtkWindow( GdkWindow *window )
+GdkWindow *wxSlider::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const

 {
 {

-    GtkRange *range = GTK_RANGE(m_widget);
-    return (range->event_window == window);
+    return GTK_RANGE(m_widget)->event_window;

 }
 
 // static
 }
 
 // static