Removed comment

[wxWidgets.git] / src / gtk / tglbtn.cpp

diff --git a/src/gtk/tglbtn.cpp b/src/gtk/tglbtn.cpp
index 50b319394fe82fe6247d269ab2acb3d3a42d2b8a..503382712c93c4b9e1328268a42c6b1d9e1470f2 100644 (file)
--- a/src/gtk/tglbtn.cpp
+++ b/src/gtk/tglbtn.cpp
@@ -31,8 +31,6 @@ static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxTog
     if (!cb->m_hasVMT || g_blockEventsOnDrag)
         return;
 
     if (!cb->m_hasVMT || g_blockEventsOnDrag)
         return;
 

-    if (cb->m_blockEvent) return;
-

     // Generate a wx event.
     wxCommandEvent event(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, cb->GetId());
     event.SetInt(cb->GetValue());
     // Generate a wx event.
     wxCommandEvent event(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, cb->GetId());
     event.SetInt(cb->GetValue());


@@ -41,7 +39,7 @@ static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxTog
 }
 }
 
 }
 }
 

-DEFINE_EVENT_TYPE(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED)
+wxDEFINE_EVENT( wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, wxCommandEvent );

 
 // ------------------------------------------------------------------------
 // wxBitmapToggleButton
 
 // ------------------------------------------------------------------------
 // wxBitmapToggleButton


@@ -55,8 +53,6 @@ bool wxBitmapToggleButton::Create(wxWindow *parent, wxWindowID id,
                             const wxValidator& validator,
                             const wxString &name)
 {
                             const wxValidator& validator,
                             const wxString &name)
 {

-    m_blockEvent = false;
-

     if (!PreCreation(parent, pos, size) ||
        !CreateBase(parent, id, pos, size, style, validator, name ))
     {
     if (!PreCreation(parent, pos, size) ||
        !CreateBase(parent, id, pos, size, style, validator, name ))
     {


@@ -66,6 +62,7 @@ bool wxBitmapToggleButton::Create(wxWindow *parent, wxWindowID id,
 
     // Create the gtk widget.
     m_widget = gtk_toggle_button_new();
 
     // Create the gtk widget.
     m_widget = gtk_toggle_button_new();

+    g_object_ref(m_widget);

 
     if (style & wxNO_BORDER)
         gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );
 
     if (style & wxNO_BORDER)
         gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );


@@ -84,6 +81,18 @@ bool wxBitmapToggleButton::Create(wxWindow *parent, wxWindowID id,
     return true;
 }
 
     return true;
 }
 

+void wxBitmapToggleButton::GTKDisableEvents()
+{
+    g_signal_handlers_block_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+
+void wxBitmapToggleButton::GTKEnableEvents()
+{
+    g_signal_handlers_unblock_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+

 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxBitmapToggleButton::SetValue(bool state)
 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxBitmapToggleButton::SetValue(bool state)


@@ -93,11 +102,11 @@ void wxBitmapToggleButton::SetValue(bool state)
     if (state == GetValue())
         return;
 
     if (state == GetValue())
         return;
 

-    m_blockEvent = true;
+    GTKDisableEvents();

 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 
 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 

-    m_blockEvent = false;
+    GTKEnableEvents();

 }
 
 // bool GetValue() const
 }
 
 // bool GetValue() const


@@ -126,24 +135,29 @@ void wxBitmapToggleButton::OnSetBitmap()
     GtkWidget* image = ((GtkBin*)m_widget)->child;
     if (image == NULL)
     {
     GtkWidget* image = ((GtkBin*)m_widget)->child;
     if (image == NULL)
     {

-        // initial bitmap
-        image = gtk_image_new_from_pixbuf(m_bitmap.GetPixbuf());
+        image = gtk_image_new();

         gtk_widget_show(image);
         gtk_container_add((GtkContainer*)m_widget, image);
     }
         gtk_widget_show(image);
         gtk_container_add((GtkContainer*)m_widget, image);
     }

-    else
-    {   // subsequent bitmaps
-        gtk_image_set_from_pixbuf((GtkImage*)image, m_bitmap.GetPixbuf());
-    }
+    // always use pixbuf, because pixmap mask does not
+    // work with disabled images in some themes
+    gtk_image_set_from_pixbuf((GtkImage*)image, m_bitmap.GetPixbuf());

 }
 
 bool wxBitmapToggleButton::Enable(bool enable /*=true*/)
 {
 }
 
 bool wxBitmapToggleButton::Enable(bool enable /*=true*/)
 {

+    bool isEnabled = IsEnabled();
+

     if (!wxControl::Enable(enable))
         return false;
 
     gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
 
     if (!wxControl::Enable(enable))
         return false;
 
     gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
 

+    if (!isEnabled && enable)
+    {
+        GTKFixSensitivity();
+    }
+

     return true;
 }
 
     return true;
 }
 


@@ -195,8 +209,6 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
                             const wxValidator& validator,
                             const wxString &name)
 {
                             const wxValidator& validator,
                             const wxString &name)
 {

-    m_blockEvent = false;
-

     if (!PreCreation(parent, pos, size) ||
         !CreateBase(parent, id, pos, size, style, validator, name ))
     {
     if (!PreCreation(parent, pos, size) ||
         !CreateBase(parent, id, pos, size, style, validator, name ))
     {


@@ -206,6 +218,7 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
 
     // Create the gtk widget.
     m_widget = gtk_toggle_button_new_with_mnemonic("");
 
     // Create the gtk widget.
     m_widget = gtk_toggle_button_new_with_mnemonic("");

+    g_object_ref(m_widget);

 
     SetLabel(label);
 
 
     SetLabel(label);
 


@@ -220,6 +233,18 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
     return true;
 }
 
     return true;
 }
 

+void wxToggleButton::GTKDisableEvents()
+{
+    g_signal_handlers_block_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+
+void wxToggleButton::GTKEnableEvents()
+{
+    g_signal_handlers_unblock_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+

 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxToggleButton::SetValue(bool state)
 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxToggleButton::SetValue(bool state)


@@ -229,11 +254,11 @@ void wxToggleButton::SetValue(bool state)
     if (state == GetValue())
         return;
 
     if (state == GetValue())
         return;
 

-    m_blockEvent = true;
+    GTKDisableEvents();

 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 
 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 

-    m_blockEvent = false;
+    GTKEnableEvents();

 }
 
 // bool GetValue() const
 }
 
 // bool GetValue() const


@@ -255,16 +280,23 @@ void wxToggleButton::SetLabel(const wxString& label)
 
     gtk_button_set_label(GTK_BUTTON(m_widget), wxGTK_CONV(labelGTK));
 
 
     gtk_button_set_label(GTK_BUTTON(m_widget), wxGTK_CONV(labelGTK));
 

-    ApplyWidgetStyle( false );
+    GTKApplyWidgetStyle( false );

 }
 
 bool wxToggleButton::Enable(bool enable /*=true*/)
 {
 }
 
 bool wxToggleButton::Enable(bool enable /*=true*/)
 {

+    bool isEnabled = IsEnabled();
+

     if (!wxControl::Enable(enable))
         return false;
 
     gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
 
     if (!wxControl::Enable(enable))
         return false;
 
     gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
 

+    if (!isEnabled && enable)
+    {
+        GTKFixSensitivity();
+    }
+

     return true;
 }
 
     return true;
 }