added test for writing empty value to the config

[wxWidgets.git] / src / common / wincmn.cpp

diff --git a/src/common/wincmn.cpp b/src/common/wincmn.cpp
index 760d49efc846583af740cd3e6628e6bd99e94113..4c5ebcc5da795b8db66265e7cf235bec621d371a 100644 (file)
--- a/src/common/wincmn.cpp
+++ b/src/common/wincmn.cpp
@@ -35,6 +35,7 @@
     #include "wx/frame.h"
     #include "wx/defs.h"
     #include "wx/window.h"
     #include "wx/frame.h"
     #include "wx/defs.h"
     #include "wx/window.h"

+    #include "wx/control.h"

     #include "wx/checkbox.h"
     #include "wx/radiobut.h"
     #include "wx/textctrl.h"
     #include "wx/checkbox.h"
     #include "wx/radiobut.h"
     #include "wx/textctrl.h"


@@ -116,7 +117,7 @@ void wxWindowBase::InitBase()
 
     // no client data (yet)
     m_clientData = NULL;
 
     // no client data (yet)
     m_clientData = NULL;

-    m_clientDataType = ClientData_None;
+    m_clientDataType = wxClientData_None;

 
     // the default event handler is just this window
     m_eventHandler = this;
 
     // the default event handler is just this window
     m_eventHandler = this;


@@ -127,14 +128,16 @@ void wxWindowBase::InitBase()
 #endif // wxUSE_VALIDATORS
 
     // use the system default colours
 #endif // wxUSE_VALIDATORS
 
     // use the system default colours

-    wxSystemSettings settings;
-
-    m_backgroundColour = settings.GetSystemColour(wxSYS_COLOUR_BTNFACE);
-    // m_foregroundColour = *wxBLACK;  // TODO take this from sys settings too?
+    m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_BTNFACE);

     m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOWTEXT);
 
     m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOWTEXT);
 

-    // GRG, changed Mar/2000
-    m_font = settings.GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
+    // don't set the font here for wxMSW as we don't call WM_SETFONT here and
+    // so the font is *not* really set - but calls to SetFont() later won't do
+    // anything because m_font appears to be already set!
+#ifndef __WXMSW__
+    m_font = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
+#endif // __WXMSW__
+

     // no style bits
     m_exStyle =
     m_windowStyle = 0;
     // no style bits
     m_exStyle =
     m_windowStyle = 0;


@@ -223,16 +226,6 @@ wxWindowBase::~wxWindowBase()
 
     wxASSERT_MSG( GetChildren().GetCount() == 0, wxT("children not destroyed") );
 
 
     wxASSERT_MSG( GetChildren().GetCount() == 0, wxT("children not destroyed") );
 

-    // make sure that there are no dangling pointers left pointing to us
-    wxPanel *panel = wxDynamicCast(GetParent(), wxPanel);
-    if ( panel )
-    {
-        if ( panel->GetLastFocus() == this )
-        {
-            panel->SetLastFocus((wxWindow *)NULL);
-        }
-    }
-

 #if wxUSE_CARET
     if ( m_caret )
         delete m_caret;
 #if wxUSE_CARET
     if ( m_caret )
         delete m_caret;


@@ -244,7 +237,7 @@ wxWindowBase::~wxWindowBase()
 #endif // wxUSE_VALIDATORS
 
     // we only delete object data, not untyped
 #endif // wxUSE_VALIDATORS
 
     // we only delete object data, not untyped

-    if ( m_clientDataType == ClientData_Object )
+    if ( m_clientDataType == wxClientData_Object )

         delete m_clientObject;
 
 #if wxUSE_CONSTRAINTS
         delete m_clientObject;
 
 #if wxUSE_CONSTRAINTS


@@ -312,6 +305,7 @@ bool wxWindowBase::DestroyChildren()
 
         wxASSERT_MSG( child, wxT("children list contains empty nodes") );
 
 
         wxASSERT_MSG( child, wxT("children list contains empty nodes") );
 

+        child->Show(FALSE);

         delete child;
 
         wxASSERT_MSG( !GetChildren().Find(child),
         delete child;
 
         wxASSERT_MSG( !GetChildren().Find(child),


@@ -393,9 +387,33 @@ void wxWindowBase::Centre(int direction)
     xNew += posParent.x;
     yNew += posParent.y;
 
     xNew += posParent.x;
     yNew += posParent.y;
 

+    // Base size of the visible dimensions of the display
+    // to take into account the taskbar
+    wxRect rect = wxGetClientDisplayRect();
+    wxSize size (rect.width,rect.height);
+
+    if (posParent.x >= 0)  // if parent is on the main display
+    {
+        if (xNew < 0)
+            xNew = 0;
+        else if (xNew+width > size.x)
+            xNew = size.x-width-1;
+    }
+    if (posParent.y >= 0)  // if parent is on the main display
+    {
+        if (yNew+height > size.y)
+            yNew = size.y-height-1;
+
+        // Make certain that the title bar is initially visible
+        // always, even if this would push the bottom of the
+        // dialog of the visible area of the display
+        if (yNew < 0)
+            yNew = 0;
+    }
+

     // move the window to this position (keeping the old size but using
     // SetSize() and not Move() to allow xNew and/or yNew to be -1)
     // move the window to this position (keeping the old size but using
     // SetSize() and not Move() to allow xNew and/or yNew to be -1)

-    SetSize(xNew, yNew, -1, -1, wxSIZE_ALLOW_MINUS_ONE);
+    SetSize(xNew, yNew, width, height, wxSIZE_ALLOW_MINUS_ONE);

 }
 
 // fits the window around the children
 }
 
 // fits the window around the children


@@ -429,7 +447,11 @@ wxSize wxWindowBase::DoGetBestSize() const
               node = node->GetNext() )
         {
             wxWindow *win = node->GetData();
               node = node->GetNext() )
         {
             wxWindow *win = node->GetData();

-            if ( win->IsTopLevel() || wxDynamicCast(win, wxStatusBar) || !win->IsShown())
+            if ( win->IsTopLevel()
+#if wxUSE_STATUSBAR
+                    || wxDynamicCast(win, wxStatusBar)
+#endif // wxUSE_STATUSBAR
+               )

             {
                 // dialogs and frames lie in different top level windows -
                 // don't deal with them here; as for the status bars, they
             {
                 // dialogs and frames lie in different top level windows -
                 // don't deal with them here; as for the status bars, they


@@ -464,6 +486,12 @@ wxSize wxWindowBase::DoGetBestSize() const
     }
 }
 
     }
 }
 

+// by default the origin is not shifted
+wxPoint wxWindowBase::GetClientAreaOrigin() const
+{
+    return wxPoint(0, 0);
+}
+

 // set the min/max size of the window
 void wxWindowBase::SetSizeHints(int minW, int minH,
                                 int maxW, int maxH,
 // set the min/max size of the window
 void wxWindowBase::SetSizeHints(int minW, int minH,
                                 int maxW, int maxH,


@@ -644,7 +672,7 @@ bool wxWindowBase::SetFont(const wxFont& font)
     // don't try to set invalid font, always fall back to the default
     const wxFont& fontOk = font.Ok() ? font : *wxSWISS_FONT;
 
     // don't try to set invalid font, always fall back to the default
     const wxFont& fontOk = font.Ok() ? font : *wxSWISS_FONT;
 

-    if ( (wxFont&)fontOk == m_font )
+    if ( fontOk == m_font )

     {
         // no change
         return FALSE;
     {
         // no change
         return FALSE;


@@ -691,9 +719,21 @@ void wxWindowBase::SetValidator(const wxValidator& validator)
 #endif // wxUSE_VALIDATORS
 
 // ----------------------------------------------------------------------------
 #endif // wxUSE_VALIDATORS
 
 // ----------------------------------------------------------------------------

-// update region testing
+// update region stuff

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

+wxRect wxWindowBase::GetUpdateClientRect() const
+{
+    wxRegion rgnUpdate = GetUpdateRegion();
+    rgnUpdate.Intersect(GetClientRect());
+    wxRect rectUpdate = rgnUpdate.GetBox();
+    wxPoint ptOrigin = GetClientAreaOrigin();
+    rectUpdate.x -= ptOrigin.x;
+    rectUpdate.y -= ptOrigin.y;
+
+    return rectUpdate;
+}
+

 bool wxWindowBase::IsExposed(int x, int y) const
 {
     return m_updateRegion.Contains(x, y) != wxOutRegion;
 bool wxWindowBase::IsExposed(int x, int y) const
 {
     return m_updateRegion.Contains(x, y) != wxOutRegion;


@@ -1333,6 +1373,7 @@ void wxWindowBase::GetPositionConstraint(int *x, int *y) const
 // of control classes.
 void wxWindowBase::UpdateWindowUI()
 {
 // of control classes.
 void wxWindowBase::UpdateWindowUI()
 {

+#if wxUSE_CONTROLS

     wxUpdateUIEvent event(GetId());
     event.m_eventObject = this;
 
     wxUpdateUIEvent event(GetId());
     event.m_eventObject = this;
 


@@ -1343,19 +1384,21 @@ void wxWindowBase::UpdateWindowUI()
 
         if ( event.GetSetText() )
         {
 
         if ( event.GetSetText() )
         {

-            wxControl *control = wxDynamicCast(this, wxControl);
+            wxControl *control = wxDynamicCastThis(wxControl);

             if ( control )
             {
             if ( control )
             {

+#if wxUSE_TEXTCTRL

                 wxTextCtrl *text = wxDynamicCast(control, wxTextCtrl);
                 if ( text )
                     text->SetValue(event.GetText());
                 else
                 wxTextCtrl *text = wxDynamicCast(control, wxTextCtrl);
                 if ( text )
                     text->SetValue(event.GetText());
                 else

+#endif // wxUSE_TEXTCTRL

                     control->SetLabel(event.GetText());
             }
         }
 
 #if wxUSE_CHECKBOX
                     control->SetLabel(event.GetText());
             }
         }
 
 #if wxUSE_CHECKBOX

-        wxCheckBox *checkbox = wxDynamicCast(this, wxCheckBox);
+        wxCheckBox *checkbox = wxDynamicCastThis(wxCheckBox);

         if ( checkbox )
         {
             if ( event.GetSetChecked() )
         if ( checkbox )
         {
             if ( event.GetSetChecked() )


@@ -1364,7 +1407,7 @@ void wxWindowBase::UpdateWindowUI()
 #endif // wxUSE_CHECKBOX
 
 #if wxUSE_RADIOBTN
 #endif // wxUSE_CHECKBOX
 
 #if wxUSE_RADIOBTN

-        wxRadioButton *radiobtn = wxDynamicCast(this, wxRadioButton);
+        wxRadioButton *radiobtn = wxDynamicCastThis(wxRadioButton);

         if ( radiobtn )
         {
             if ( event.GetSetChecked() )
         if ( radiobtn )
         {
             if ( event.GetSetChecked() )


@@ -1372,6 +1415,7 @@ void wxWindowBase::UpdateWindowUI()
         }
 #endif // wxUSE_RADIOBTN
     }
         }
 #endif // wxUSE_RADIOBTN
     }

+#endif // wxUSE_CONTROLS

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1410,21 +1454,21 @@ wxPoint wxWindowBase::ConvertDialogToPixels(const wxPoint& pt)
 
 void wxWindowBase::DoSetClientObject( wxClientData *data )
 {
 
 void wxWindowBase::DoSetClientObject( wxClientData *data )
 {

-    wxASSERT_MSG( m_clientDataType != ClientData_Void,
+    wxASSERT_MSG( m_clientDataType != wxClientData_Void,

                   wxT("can't have both object and void client data") );
 
     if ( m_clientObject )
         delete m_clientObject;
 
     m_clientObject = data;
                   wxT("can't have both object and void client data") );
 
     if ( m_clientObject )
         delete m_clientObject;
 
     m_clientObject = data;

-    m_clientDataType = ClientData_Object;
+    m_clientDataType = wxClientData_Object;

 }
 
 wxClientData *wxWindowBase::DoGetClientObject() const
 {
     // it's not an error to call GetClientObject() on a window which doesn't
     // have client data at all - NULL will be returned
 }
 
 wxClientData *wxWindowBase::DoGetClientObject() const
 {
     // it's not an error to call GetClientObject() on a window which doesn't
     // have client data at all - NULL will be returned

-    wxASSERT_MSG( m_clientDataType != ClientData_Void,
+    wxASSERT_MSG( m_clientDataType != wxClientData_Void,

                   wxT("this window doesn't have object client data") );
 
     return m_clientObject;
                   wxT("this window doesn't have object client data") );
 
     return m_clientObject;


@@ -1432,18 +1476,18 @@ wxClientData *wxWindowBase::DoGetClientObject() const
 
 void wxWindowBase::DoSetClientData( void *data )
 {
 
 void wxWindowBase::DoSetClientData( void *data )
 {

-    wxASSERT_MSG( m_clientDataType != ClientData_Object,
+    wxASSERT_MSG( m_clientDataType != wxClientData_Object,

                   wxT("can't have both object and void client data") );
 
     m_clientData = data;
                   wxT("can't have both object and void client data") );
 
     m_clientData = data;

-    m_clientDataType = ClientData_Void;
+    m_clientDataType = wxClientData_Void;

 }
 
 void *wxWindowBase::DoGetClientData() const
 {
     // it's not an error to call GetClientData() on a window which doesn't have
     // client data at all - NULL will be returned
 }
 
 void *wxWindowBase::DoGetClientData() const
 {
     // it's not an error to call GetClientData() on a window which doesn't have
     // client data at all - NULL will be returned

-    wxASSERT_MSG( m_clientDataType != ClientData_Object,
+    wxASSERT_MSG( m_clientDataType != wxClientData_Object,

                   wxT("this window doesn't have void client data") );
 
     return m_clientData;
                   wxT("this window doesn't have void client data") );
 
     return m_clientData;


@@ -1481,6 +1525,7 @@ void wxWindowBase::OnInitDialog( wxInitDialogEvent &WXUNUSED(event) )
 // process Ctrl-Alt-mclick
 void wxWindowBase::OnMiddleClick( wxMouseEvent& event )
 {
 // process Ctrl-Alt-mclick
 void wxWindowBase::OnMiddleClick( wxMouseEvent& event )
 {

+#if wxUSE_MSGDLG

     if ( event.ControlDown() && event.AltDown() )
     {
         // don't translate these strings
     if ( event.ControlDown() && event.AltDown() )
     {
         // don't translate these strings


@@ -1525,6 +1570,7 @@ void wxWindowBase::OnMiddleClick( wxMouseEvent& event )
                      (wxWindow *)this);
     }
     else
                      (wxWindow *)this);
     }
     else

+#endif // wxUSE_MSGDLG

     {
         event.Skip();
     }
     {
         event.Skip();
     }


@@ -1539,3 +1585,43 @@ void wxWindowListNode::DeleteData()
     delete (wxWindow *)GetData();
 }
 
     delete (wxWindow *)GetData();
 }
 

+// ----------------------------------------------------------------------------
+// borders
+// ----------------------------------------------------------------------------
+
+wxBorder wxWindowBase::GetBorder() const
+{
+    wxBorder border = (wxBorder)(m_windowStyle & wxBORDER_MASK);
+    if ( border == wxBORDER_DEFAULT )
+    {
+        border = GetDefaultBorder();
+    }
+
+    return border;
+}
+
+wxBorder wxWindowBase::GetDefaultBorder() const
+{
+    return wxBORDER_NONE;
+}
+
+// ----------------------------------------------------------------------------
+// hit testing
+// ----------------------------------------------------------------------------
+
+wxHitTest wxWindowBase::DoHitTest(wxCoord x, wxCoord y) const
+{
+    // here we just check if the point is inside the window or not
+
+    // check the top and left border first
+    bool outside = x < 0 || y < 0;
+    if ( !outside )
+    {
+        // check the right and bottom borders too
+        wxSize size = GetSize();
+        outside = x >= size.x || y >= size.y;
+    }
+
+    return outside ? wxHT_WINDOW_OUTSIDE : wxHT_WINDOW_INSIDE;
+}
+