[ 1216436 ] cleanup 'shadow variable' warnings from gcc in headers.

[wxWidgets.git] / src / os2 / control.cpp

diff --git a/src/os2/control.cpp b/src/os2/control.cpp
index 592ea3f48e881157e69e95bf55e1067af77f9429..83a67ce7ee1e847d805b4108d6a84e00017ed5df 100644 (file)
--- a/src/os2/control.cpp
+++ b/src/os2/control.cpp
@@ -5,7 +5,7 @@
 // Modified by:
 // Created:     09/17/99
 // RCS-ID:      $Id$
 // Modified by:
 // Created:     09/17/99
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
+// Copyright:   (c) Julian Smart

 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 


@@ -20,6 +20,8 @@
 #include "wx/event.h"
 #include "wx/app.h"
 #include "wx/dcclient.h"
 #include "wx/event.h"
 #include "wx/app.h"
 #include "wx/dcclient.h"

+#include "wx/scrolwin.h"
+#include "wx/log.h"

 #endif
 #include "wx/os2/private.h"
 #include "wx/control.h"
 #endif
 #include "wx/os2/private.h"
 #include "wx/control.h"


@@ -33,12 +35,6 @@ END_EVENT_TABLE()
 // Item members
 wxControl::wxControl()
 {
 // Item members
 wxControl::wxControl()
 {

-  m_backgroundColour = *wxWHITE;
-  m_foregroundColour = *wxBLACK;
-
-#if WXWIN_COMPATIBILITY
-  m_callback = 0;
-#endif // WXWIN_COMPATIBILITY

 } // end of wxControl::wxControl
 
 bool wxControl::Create(
 } // end of wxControl::wxControl
 
 bool wxControl::Create(


@@ -47,9 +43,7 @@ bool wxControl::Create(
 , const wxPoint&                    rPos
 , const wxSize&                     rSize
 , long                              lStyle
 , const wxPoint&                    rPos
 , const wxSize&                     rSize
 , long                              lStyle

-#if wxUSE_VALIDATORS

 , const wxValidator&                rValidator
 , const wxValidator&                rValidator

-#endif

 , const wxString&                   rsName
 )
 {
 , const wxString&                   rsName
 )
 {


@@ -75,35 +69,25 @@ wxControl::~wxControl()
 }
 
 bool wxControl::OS2CreateControl(
 }
 
 bool wxControl::OS2CreateControl(

-  wxWindow*                         pParent
-, wxWindowID                        vId
+  const wxChar*                     zClassname
+, const wxString&                   rsLabel

 , const wxPoint&                    rPos
 , const wxSize&                     rSize
 , long                              lStyle
 , const wxPoint&                    rPos
 , const wxSize&                     rSize
 , long                              lStyle

-#if wxUSE_VALIDATORS
-, const wxValidator&                rValidator
-#endif
-, const wxString&                   rsName

 )
 {
 )
 {

-    //
-    // Even if it's possible to create controls without parents in some port,
-    // it should surely be discouraged because it doesn't work at all under
-    // Windows
-    //
-    if (!CreateBase( pParent
-                    ,vId
-                    ,rPos
-                    ,rSize
-                    ,lStyle
-#if wxUSE_VALIDATORS
-                    ,rValidator
-#endif
-                    ,rsName
-                   ))
-        return FALSE;
-    pParent->AddChild(this);
-    return TRUE;
+    WXDWORD                         dwExstyle;
+    WXDWORD                         dwStyle = OS2GetStyle( lStyle
+                                                          ,&dwExstyle
+                                                         );
+
+    return OS2CreateControl( zClassname
+                            ,dwStyle
+                            ,rPos
+                            ,rSize
+                            ,rsLabel
+                            ,dwExstyle
+                           );

 } // end of wxControl::OS2CreateControl
 
 bool wxControl::OS2CreateControl(
 } // end of wxControl::OS2CreateControl
 
 bool wxControl::OS2CreateControl(


@@ -120,8 +104,50 @@ bool wxControl::OS2CreateControl(
     //
     if (dwExstyle == (WXDWORD)-1)
     {
     //
     if (dwExstyle == (WXDWORD)-1)
     {

-        dwExstyle = GetExStyle(dwStyle);
+        dwExstyle = 0;
+       (void) OS2GetStyle(GetWindowStyle(), &dwExstyle);

     }
     }

+    //
+    // All controls should have these styles (wxWidgets creates all controls
+    // visible by default)
+    //
+    if (m_isShown )
+        dwStyle |= WS_VISIBLE;
+
+    wxWindow*                       pParent = GetParent();
+    PSZ                             zClass = "";
+
+    if (!pParent)
+        return FALSE;
+
+    if ((wxStrcmp(zClassname, _T("COMBOBOX"))) == 0)
+        zClass = WC_COMBOBOX;
+    else if ((wxStrcmp(zClassname, _T("STATIC"))) == 0)
+        zClass = WC_STATIC;
+    else if ((wxStrcmp(zClassname, _T("BUTTON"))) == 0)
+        zClass = WC_BUTTON;
+    else if ((wxStrcmp(zClassname, _T("NOTEBOOK"))) == 0)
+        zClass = WC_NOTEBOOK;
+    else if ((wxStrcmp(zClassname, _T("CONTAINER"))) == 0)
+        zClass = WC_CONTAINER;
+    dwStyle |= WS_VISIBLE;
+
+    wxString                        sLabel = ::wxPMTextToLabel(rsLabel);
+
+    m_hWnd = (WXHWND)::WinCreateWindow( (HWND)GetHwndOf(pParent) // Parent window handle
+                                       ,(PSZ)zClass              // Window class
+                                       ,(PSZ)sLabel.c_str()      // Initial Text
+                                       ,(ULONG)dwStyle           // Style flags
+                                       ,(LONG)0                  // X pos of origin
+                                       ,(LONG)0                  // Y pos of origin
+                                       ,(LONG)0                  // control width
+                                       ,(LONG)0                  // control height
+                                       ,(HWND)GetHwndOf(pParent) // owner window handle (same as parent
+                                       ,HWND_TOP                 // initial z position
+                                       ,(ULONG)GetId()           // Window identifier
+                                       ,NULL                     // no control data
+                                       ,NULL                     // no Presentation parameters
+                                      );

 
     if ( !m_hWnd )
     {
 
     if ( !m_hWnd )
     {


@@ -131,36 +157,27 @@ bool wxControl::OS2CreateControl(
 
         return FALSE;
     }
 
         return FALSE;
     }

-
-    PSZ                             zClass;
-
-    if ((strcmp(zClassname, "COMBOBOX")) == 0)
-        zClass = WC_COMBOBOX;
-    dwStyle |= WS_VISIBLE;
-    m_hWnd = (WXHWND)::WinCreateWindow( (HWND)GetHwndOf(GetParent()) // Parent window handle
-                                       ,(PSZ)zClassname              // Window class
-                                       ,(PSZ)rsLabel.c_str()         // Initial Text
-                                       ,(ULONG)dwStyle               // Style flags
-                                       ,(LONG)rPos.x                 // X pos of origin
-                                       ,(LONG)rPos.y                 // Y pos of origin
-                                       ,(LONG)rSize.x                // control width
-                                       ,(LONG)rSize.y                // control height
-                                       ,(HWND)GetHwndOf(GetParent()) // owner window handle (same as parent
-                                       ,HWND_TOP                     // initial z position
-                                       ,(ULONG)GetId()               // Window identifier
-                                       ,NULL                         // no control data
-                                       ,NULL                         // no Presentation parameters
-                                      );
-

     //
     // Subclass again for purposes of dialog editing mode
     //
     SubclassWin(m_hWnd);
 
     //
     //
     // Subclass again for purposes of dialog editing mode
     //
     SubclassWin(m_hWnd);
 
     //

-    // Controls use the same font and colours as their parent dialog by default
+    // Controls use the same colours as their parent dialog by default

     //
     InheritAttributes();
     //
     InheritAttributes();

+    //
+    // All OS/2 ctrls use the small font
+    //
+    SetFont(*wxSMALL_FONT);
+
+    SetXComp(0);
+    SetYComp(0);
+    SetSize( rPos.x
+            ,rPos.y
+            ,rSize.x
+            ,rSize.y
+           );

     return TRUE;
 } // end of wxControl::OS2CreateControl
 
     return TRUE;
 } // end of wxControl::OS2CreateControl
 


@@ -171,16 +188,6 @@ wxSize wxControl::DoGetBestSize() const
 
 bool wxControl::ProcessCommand(wxCommandEvent& event)
 {
 
 bool wxControl::ProcessCommand(wxCommandEvent& event)
 {

-#if WXWIN_COMPATIBILITY
-    if ( m_callback )
-    {
-        (void)(*m_callback)(this, event);
-
-        return TRUE;
-    }
-    else
-#endif // WXWIN_COMPATIBILITY
-

     return GetEventHandler()->ProcessEvent(event);
 }
 
     return GetEventHandler()->ProcessEvent(event);
 }
 


@@ -224,17 +231,30 @@ void wxControl::OnEraseBackground(
     ::WinFillRect(hPS, &vRect, GetBackgroundColour().GetPixel());
 } // end of wxControl::OnEraseBackground
 
     ::WinFillRect(hPS, &vRect, GetBackgroundColour().GetPixel());
 } // end of wxControl::OnEraseBackground
 

-WXDWORD wxControl::GetExStyle(
-  WXDWORD&                          rStyle
+WXDWORD wxControl::OS2GetStyle(
+  long                              lStyle
+, WXDWORD*                          pdwExstyle

 ) const
 {
 ) const
 {

-    //
-    // Meaningless under OS/2, just return what was sent
-    //
-    WXDWORD                         exStyle = rStyle;
+    long                            dwStyle = wxWindow::OS2GetStyle( lStyle
+                                                                    ,pdwExstyle
+                                                                   );
+
+    if (AcceptsFocus())
+    {
+        dwStyle |= WS_TABSTOP;
+    }
+    return dwStyle;
+} // end of wxControl::OS2GetStyle
+
+void wxControl::SetLabel(
+  const wxString&                   rsLabel
+)
+{
+    wxString                        sLabel = ::wxPMTextToLabel(rsLabel);

 
 

-    return exStyle;
-} // end of wxControl::GetExStyle
+    ::WinSetWindowText(GetHwnd(), (PSZ)sLabel.c_str());
+} // end of wxControl::SetLabel

 
 // ---------------------------------------------------------------------------
 // global functions
 
 // ---------------------------------------------------------------------------
 // global functions


@@ -266,10 +286,10 @@ void wxFindMaxSize(
     if (nRight > pRect->xRight)
         pRect->xRight = nRight;
 
     if (nRight > pRect->xRight)
         pRect->xRight = nRight;
 

-    if (nTop < pRect->yTop)
+    if (nTop > pRect->yTop)

         pRect->yTop = nTop;
 
         pRect->yTop = nTop;
 

-    if (nBottom > pRect->yBottom)
+    if (nBottom < pRect->yBottom)

         pRect->yBottom = nBottom;
 } // end of wxFindMaxSize
 
         pRect->yBottom = nBottom;
 } // end of wxFindMaxSize