fixed a memory leak and an initialization problem

[wxWidgets.git] / src / mac / carbon / radiobut.cpp

diff --git a/src/mac/carbon/radiobut.cpp b/src/mac/carbon/radiobut.cpp
index aff004469bfd5ab440f824930cf0816763a80ecc..476cf9ef10b3ac7782252353742e29d4f2b908c4 100644 (file)
--- a/src/mac/carbon/radiobut.cpp
+++ b/src/mac/carbon/radiobut.cpp
@@ -13,12 +13,15 @@
 #pragma implementation "radiobut.h"
 #endif
 
 #pragma implementation "radiobut.h"
 #endif
 

-#include "wx/radiobut.h"
+#include "wx/defs.h"

 
 

+#include "wx/radiobut.h"

 
 

+#if !USE_SHARED_LIBRARY

 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)
 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)

+#endif

 
 

-#include <wx/mac/uma.h>
+#include "wx/mac/uma.h"

 
 bool wxRadioButton::Create(wxWindow *parent, wxWindowID id,
                   const wxString& label,
 
 bool wxRadioButton::Create(wxWindow *parent, wxWindowID id,
                   const wxString& label,


@@ -32,11 +35,13 @@ bool wxRadioButton::Create(wxWindow *parent, wxWindowID id,
        
        MacPreControlCreate( parent , id ,  label , pos , size ,style, validator , name , &bounds , title ) ;
 
        
        MacPreControlCreate( parent , id ,  label , pos , size ,style, validator , name , &bounds , title ) ;
 

-       m_macControl = UMANewControl( parent->GetMacRootWindow() , &bounds , title , true , 0 , 0 , 1, 
+       m_macControl = ::NewControl( parent->GetMacRootWindow() , &bounds , title , false , 0 , 0 , 1, 

                kControlRadioButtonProc , (long) this ) ;
        
        MacPostControlCreate() ;
 
                kControlRadioButtonProc , (long) this ) ;
        
        MacPostControlCreate() ;
 

+  m_cycle = this ;
+  

   if (HasFlag(wxRB_GROUP))
   {
          AddInCycle( NULL ) ;
   if (HasFlag(wxRB_GROUP))
   {
          AddInCycle( NULL ) ;


@@ -65,9 +70,10 @@ void wxRadioButton::SetValue(bool val)
 {
        int i;
        wxRadioButton *cycle;
 {
        int i;
        wxRadioButton *cycle;

-       
+         if ( GetControlValue( m_macControl ) == val )
+           return ;
+           

    ::SetControlValue( m_macControl , val ) ;
    ::SetControlValue( m_macControl , val ) ;

-   

    if (val) 
    {
                cycle=this->NextInCycle();
    if (val) 
    {
                cycle=this->NextInCycle();


@@ -93,10 +99,33 @@ void wxRadioButton::Command (wxCommandEvent & event)
 
 void wxRadioButton::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
 {
 
 void wxRadioButton::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
 {

-       SetValue(true) ;
-    wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, m_windowId );
-    event.SetEventObject(this);
-    ProcessCommand(event);
+    if ( GetValue() )
+      return ;
+      
+         wxRadioButton *cycle, *old = NULL ;
+    cycle=this->NextInCycle();
+    if (cycle!=NULL) {
+         while (cycle!=this) {
+           if ( cycle->GetValue() ) {
+             old = cycle ;
+                   cycle->SetValue(false);
+                 }
+                 cycle=cycle->NextInCycle();
+               }
+    }
+
+         SetValue(true) ;
+
+    if ( old ) {
+      wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, old->m_windowId );
+      event.SetEventObject(old);
+      event.SetInt( false );
+      old->ProcessCommand(event);
+    }
+    wxCommandEvent event2(wxEVT_COMMAND_RADIOBUTTON_SELECTED, m_windowId );
+    event2.SetEventObject(this);
+    event2.SetInt( true );
+    ProcessCommand(event2);

 }
 
 wxRadioButton *wxRadioButton::AddInCycle(wxRadioButton *cycle)
 }
 
 wxRadioButton *wxRadioButton::AddInCycle(wxRadioButton *cycle)