fixing overrelease and out-of-bounds write, fixes #13725

[wxWidgets.git] / include / wx / vector.h

diff --git a/include/wx/vector.h b/include/wx/vector.h
index 3af683621fb5c7020060a962b8fc66de7badf9f8..d558e774e603357e8a46623b21c2e7ff0f3318a1 100644 (file)
--- a/include/wx/vector.h
+++ b/include/wx/vector.h
@@ -14,7 +14,7 @@
 
 #include "wx/defs.h"
 
-#if wxUSE_STL
+#if wxUSE_STD_CONTAINERS
 
 #include <vector>
 #include <algorithm>
@@ -26,7 +26,7 @@ inline void wxVectorSort(wxVector<T>& v)
     std::sort(v.begin(), v.end());
 }
 
-#else // !wxUSE_STL
+#else // !wxUSE_STD_CONTAINERS
 
 #include "wx/utils.h"
 #include "wx/scopeguard.h"
@@ -118,7 +118,10 @@ private:
     // Note that we use typedef instead of privately deriving from this (which
     // would allowed us to omit "Ops::" prefixes below) to keep VC6 happy,
     // it can't compile code that derives from wxIf<...>::value.
-    typedef typename wxIf< wxIsMovable<T>::value,
+    //
+    // Note that bcc needs the extra parentheses for non-type template
+    // arguments to compile this expression.
+    typedef typename wxIf< (wxIsMovable<T>::value),
                            wxPrivate::wxVectorMemOpsMovable<T>,
                            wxPrivate::wxVectorMemOpsGeneric<T> >::value
             Ops;
@@ -202,6 +205,14 @@ public:
         clear();
     }
 
+    void assign(size_type p_size, const value_type& v)
+    {
+        clear();
+        reserve(p_size);
+        for ( size_t n = 0; n < p_size; n++ )
+            push_back(v);
+    }
+
     void swap(wxVector& v)
     {
         wxSwap(m_size, v.m_size);
@@ -448,22 +459,26 @@ inline typename wxVector<T>::size_type wxVector<T>::erase(size_type n)
 
 namespace wxPrivate
 {
-    // This function is a helper for the wxVectorSort function, and should
-    // not be used directly in user's code.
 
+// This is a helper for the wxVectorSort function, and should not be used
+// directly in user's code.
 template<typename T>
-int wxCMPFUNC_CONV wxVectorSort_compare(const void* pitem1, const void* pitem2, const void* )
+struct wxVectorComparator
 {
-    const T& item1 = *reinterpret_cast<const T*>(pitem1);
-    const T& item2 = *reinterpret_cast<const T*>(pitem2);
-
-    if (item1 < item2)
-        return -1;
-    else if (item2 < item1)
-        return 1;
-    else
-        return 0;
-}
+    static int
+    Compare(const void* pitem1, const void* pitem2, const void* )
+    {
+        const T& item1 = *reinterpret_cast<const T*>(pitem1);
+        const T& item2 = *reinterpret_cast<const T*>(pitem2);
+
+        if (item1 < item2)
+            return -1;
+        else if (item2 < item1)
+            return 1;
+        else
+            return 0;
+    }
+};
 
 }  // namespace wxPrivate
 
@@ -473,12 +488,12 @@ template<typename T>
 void wxVectorSort(wxVector<T>& v)
 {
     wxQsort(v.begin(), v.size(), sizeof(T),
-            wxPrivate::wxVectorSort_compare<T>, NULL);
+            wxPrivate::wxVectorComparator<T>::Compare, NULL);
 }
 
 
 
-#endif // wxUSE_STL/!wxUSE_STL
+#endif // wxUSE_STD_CONTAINERS/!wxUSE_STD_CONTAINERS
 
 #if WXWIN_COMPATIBILITY_2_8
     #define WX_DECLARE_VECTORBASE(obj, cls) typedef wxVector<obj> cls