fix PCH-less build after changing timer id type to WPARAM (closes #10901)

[wxWidgets.git] / include / wx / weakref.h

diff --git a/include/wx/weakref.h b/include/wx/weakref.h
index 74b590d6278daff5c4c07298d373030b677301f2..b8324d07ec7248eabe2464175ee67b73784526db 100644 (file)
--- a/include/wx/weakref.h
+++ b/include/wx/weakref.h
@@ -14,15 +14,17 @@
 #include "wx/tracker.h"
 
 
-// Some compilers (VC6, Borland, otehrs?) have problem with template specialization.
+// Some compilers (VC6, Borland, g++ < 3.3) have problem with template specialization.
 // However, this is only used for optimization purposes (a smaller wxWeakRef pointer)
-// (and the corner case of wxWeakRef<wxObject>). So for those compilers, we can fall 
-// back to the non-optimal case, where we use a the same type of weak ref (static one) 
+// (and the corner case of wxWeakRef<wxObject>). So for those compilers, we can fall
+// back to the non-optimal case, where we use a the same type of weak ref (static one)
 // in all cases. See defs.h for various setting these defines depending on compiler.
 
-#if !defined(HAVE_PARTIAL_SPECIALIZATION) || !defined(HAVE_TEMPLATE_OVERLOAD_RESOLUTION)
-    #define USE_ONLY_STATIC_WEAKREF 
-#endif 
+#if !defined(HAVE_PARTIAL_SPECIALIZATION) || \
+    !defined(HAVE_TEMPLATE_OVERLOAD_RESOLUTION) || \
+    (defined(__GNUC__) && !wxCHECK_GCC_VERSION(3, 3))
+    #define USE_ONLY_STATIC_WEAKREF
+#endif
 
 
 #ifndef USE_ONLY_STATIC_WEAKREF
@@ -59,6 +61,13 @@ public:
         }
     }
 
+    virtual void OnObjectDestroy()
+    {
+        // Tracked object itself removes us from list of trackers
+        wxASSERT(m_pobj != NULL);
+        m_pobj = NULL;
+    }
+
 protected:
     void Assign(T* pobj)
     {
@@ -82,13 +91,6 @@ protected:
         Assign( wr.m_pobj );
     }
 
-    virtual void OnObjectDestroy()
-    {
-        // Tracked object itself removes us from list of trackers
-        wxASSERT( m_pobj!=NULL );
-        m_pobj = NULL;
-    }
-
     T *m_pobj;
 };
 
@@ -122,6 +124,14 @@ struct wxWeakRefImpl<T, false> : public wxTrackerNode
         }
     }
 
+    virtual void OnObjectDestroy()
+    {
+        // Tracked object itself removes us from list of trackers
+        wxASSERT(m_pobj != NULL);
+        m_pobj = NULL;
+        m_ptbase = NULL;
+    }
+
 protected:
     wxWeakRefImpl() : m_pobj(NULL), m_ptbase(NULL) { }
 
@@ -177,14 +187,6 @@ protected:
         }
     }
 
-    virtual void OnObjectDestroy()
-    {
-        // Tracked object itself removes us from list of trackers
-        wxASSERT( m_pobj!=NULL );
-        m_pobj = NULL;
-        m_ptbase = NULL;
-    }
-
     T *m_pobj;
     wxTrackable *m_ptbase;
 };
@@ -200,7 +202,7 @@ class wxWeakRef : public
 #ifdef USE_ONLY_STATIC_WEAKREF
                   wxWeakRefStatic<T>
 #else
-                  wxWeakRefImpl<T, wxIsStaticTrackable<T>::value>
+                  wxWeakRefImpl<T, wxIsStaticTrackable<T>::value != 0>
 #endif
 {
 public:
@@ -215,13 +217,13 @@ public:
         Assign(pobj);
     }
 
-    // We need this copy ctor, since otherwise a default compiler (binary) copy 
+    // We need this copy ctor, since otherwise a default compiler (binary) copy
     // happens (if embedded as an object member).
     wxWeakRef(const wxWeakRef<T>& wr)
     {
         Assign(wr.get());
     }
-    
+
     template <class TDerived>
     wxWeakRef<T>& operator=(TDerived* pobj)
     {
@@ -265,18 +267,18 @@ public:
     {
         Assign(wr.get());
     }
-    
+
     virtual ~wxWeakRefDynamic() { Release(); }
 
     // Smart pointer functions
     T& operator*() const    { wxASSERT(m_pobj); return *m_pobj; }
     T* operator->() const   { wxASSERT(m_pobj); return m_pobj; }
-    
+
     T* get() const          { return m_pobj; }
     operator T* () const    { return m_pobj; }
 
     T* operator = (T* pobj) { Assign(pobj); return m_pobj; }
-    
+
     // Assign from another weak ref, point to same object
     T* operator = (const wxWeakRef<T> &wr) { Assign( wr.get() ); return m_pobj; }
 
@@ -293,6 +295,13 @@ public:
         }
     }
 
+    virtual void OnObjectDestroy()
+    {
+        wxASSERT_MSG(m_pobj, "tracked object should have removed us itself");
+
+        m_pobj = NULL;
+    }
+
 protected:
     void Assign(T *pobj)
     {
@@ -320,13 +329,6 @@ protected:
         }
     }
 
-    virtual void OnObjectDestroy()
-    {
-        wxASSERT_MSG( m_pobj, "tracked object should have removed us itself" );
-
-        m_pobj = NULL;
-    }
-
     T *m_pobj;
 };