Don't create GtkScrolledWindow if neither wxHSCROLL

[wxWidgets.git] / src / gtk / timer.cpp

diff --git a/src/gtk/timer.cpp b/src/gtk/timer.cpp
index 4e36a67f1447dc978ce61c33a361ef179d54811b..7bb0317952ef23068addc4b1700cae8a5b20b0e0 100644 (file)
--- a/src/gtk/timer.cpp
+++ b/src/gtk/timer.cpp
@@ -1,68 +1,85 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        timer.cpp
-// Purpose:
+// Name:        gtk/timer.cpp
+// Purpose:     wxTimer implementation
 // Author:      Robert Roebling
-// Created:     01/02/97
-// Id:
-// Copyright:   (c) 1998 Robert Roebling, Julian Smart and Markus Holzem
-// Licence:    wxWindows licence
+// Id:          $Id$
+// Copyright:   (c) 1998 Robert Roebling
+// Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
 
-#ifdef __GNUG__
-#pragma implementation "timer.h"
-#endif
+#if wxUSE_TIMER
 
 #include "wx/timer.h"
 
-//-----------------------------------------------------------------------------
+#include <gtk/gtk.h>
+
+// ----------------------------------------------------------------------------
 // wxTimer
-//-----------------------------------------------------------------------------
+// ----------------------------------------------------------------------------
 
-IMPLEMENT_ABSTRACT_CLASS(wxTimer,wxObject)
+IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxEvtHandler)
 
-gint timeout_callback( gpointer data )
+extern "C" {
+static gboolean timeout_callback(gpointer data)
 {
-  wxTimer *timer = (wxTimer*)data;
-  timer->Notify();
+    wxTimer *timer = (wxTimer*)data;
+
+    // Don't change the order of anything in this callback!
+
+    if (timer->IsOneShot())
+    {
+        // This sets m_tag to -1
+        timer->Stop();
+    }
+
+    // When getting called from GDK's timer handler we
+    // are no longer within GDK's grab on the GUI
+    // thread so we must lock it here ourselves.
+    gdk_threads_enter();
 
-  if ( timer->OneShot() )
-    timer->Stop();
+    timer->Notify();
 
-  return TRUE;
+    // Release lock again.
+    gdk_threads_leave();
+
+    return !timer->IsOneShot();
+}
 }
 
-wxTimer::wxTimer()
+void wxTimer::Init()
 {
-  m_tag = -1;
-  m_time = 1000;
-  m_oneShot = FALSE;
+    m_sourceId = 0;
+    m_milli = 1000;
 }
 
 wxTimer::~wxTimer()
 {
-  Stop();
+    Stop();
 }
 
 bool wxTimer::Start( int millisecs, bool oneShot )
 {
-  if ( millisecs != -1 )
-    m_time = millisecs;
+    (void)wxTimerBase::Start(millisecs, oneShot);
 
-  m_oneShot = oneShot;
+    if (m_sourceId != 0)
+        g_source_remove(m_sourceId);
 
-  m_tag = gtk_timeout_add( millisecs, timeout_callback, this );
+    m_sourceId = g_timeout_add(m_milli, timeout_callback, this);
 
-  return TRUE;
+    return true;
 }
 
 void wxTimer::Stop()
 {
-  if ( m_tag != -1 )
-  {
-    gtk_timeout_remove( m_tag );
-
-    m_tag = -1;
-  }
+    if (m_sourceId != 0)
+    {
+        g_source_remove(m_sourceId);
+        m_sourceId = 0;
+    }
 }
 
+#endif // wxUSE_TIMER
+