fixed crash introduced in v1.41

[wxWidgets.git] / src / mac / carbon / choice.cpp

diff --git a/src/mac/carbon/choice.cpp b/src/mac/carbon/choice.cpp
index 6c8444fc8af4cd7851530de623ecbd8ab92601ef..09edb0927431dff64015e7650e4ebc7f83089a54 100644 (file)
--- a/src/mac/carbon/choice.cpp
+++ b/src/mac/carbon/choice.cpp
@@ -1,171 +1,353 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        choice.cpp
+// Name:        src/mac/carbon/choice.cpp

 // Purpose:     wxChoice
 // Purpose:     wxChoice

-// Author:      AUTHOR
+// Author:      Stefan Csomor

 // Modified by:
 // Modified by:

-// Created:     ??/??/98
+// Created:     1998-01-01

 // RCS-ID:      $Id$
 // RCS-ID:      $Id$

-// Copyright:   (c) AUTHOR
-// Licence:    wxWindows licence
+// Copyright:   (c) Stefan Csomor
+// Licence:       wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "choice.h"
-#endif
+#include "wx/wxprec.h"
+
+#if wxUSE_CHOICE

 
 

-// For compilers that support precompilation, includes "wx.h".

 #include "wx/choice.h"
 #include "wx/menu.h"
 #include "wx/mac/uma.h"
 
 #include "wx/choice.h"
 #include "wx/menu.h"
 #include "wx/mac/uma.h"
 

-#if !USE_SHARED_LIBRARY
+extern MenuHandle NewUniqueMenu() ;
+

 IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)
 IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)

-#endif

 
 

-short nextMenuId = 100 ; // wxMenu takes the lower ids

 
 wxChoice::~wxChoice()
 {
 
 wxChoice::~wxChoice()
 {

-       // DeleteMenu( m_macPopUpMenuId ) ;
-       DisposeMenu( m_macPopUpMenuHandle ) ;
+    if ( HasClientObjectData() )
+    {
+        size_t i, max = GetCount();
+
+        for ( i = 0; i < max; ++i )
+            delete GetClientObject( i );
+    }
+
+    // DeleteMenu( m_macPopUpMenuId ) ;
+    // DisposeMenu( m_macPopUpMenuHandle ) ;
+}
+
+bool wxChoice::Create(wxWindow *parent,
+    wxWindowID id,
+    const wxPoint& pos,
+    const wxSize& size,
+    const wxArrayString& choices,
+    long style,
+    const wxValidator& validator,
+    const wxString& name )
+{
+    wxCArrayString chs( choices );
+
+    return Create(
+        parent, id, pos, size, chs.GetCount(), chs.GetStrings(),
+        style, validator, name );

 }
 
 }
 

-bool wxChoice::Create(wxWindow *parent, wxWindowID id,
-           const wxPoint& pos,
-           const wxSize& size,
-                  int n, const wxString choices[],
-                  long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool wxChoice::Create(wxWindow *parent,
+    wxWindowID id,
+    const wxPoint& pos,
+    const wxSize& size,
+    int n,
+    const wxString choices[],
+    long style,
+    const wxValidator& validator,
+    const wxString& name )

 {
 {

+    m_macIsUserPane = false;

 
 

-               Rect bounds ;
-               Str255 title ;
-       
-               MacPreControlCreate( parent , id ,  "" , pos , size ,style, validator , name , &bounds , title ) ;
+    if ( !wxChoiceBase::Create( parent, id, pos, size, style, validator, name ) )
+        return false;

 
 

-               m_macPopUpMenuHandle =  NewMenu( 1 , "\pPopUp Menu" ) ;
-               m_macControl = UMANewControl( parent->GetMacRootWindow() , &bounds , title , true , 0 , -12345 , 0 , 
-               kControlPopupButtonProc + kControlPopupFixedWidthVariant , (long) this ) ; 
-       
-               m_macPopUpMenuHandle =  NewMenu( 1 , "\pPopUp Menu" ) ;
-               SetControlData( m_macControl , kControlNoPart , kControlPopupButtonMenuHandleTag , sizeof( MenuHandle ) , (char*) &m_macPopUpMenuHandle) ;
-               for ( int i = 0 ; i < n ; i++ )
-               {
-                       Str255 label;
-                       wxMenuItem::MacBuildMenuString( label , NULL , NULL , choices[i] ,false);
-                       AppendMenu( m_macPopUpMenuHandle , label ) ;
-                       m_strings.Add( choices[i] ) ;
-               }
-               SetControlMinimum( m_macControl , 0 ) ;
-               SetControlMaximum( m_macControl , Number()) ;
-               if ( n > 0 )
-                       SetControlValue( m_macControl , 1 ) ;
+    Rect bounds = wxMacGetBoundsForControl( this , pos , size );

 
 

-               MacPostControlCreate() ;
+    m_peer = new wxMacControl( this ) ;
+    OSStatus err = CreatePopupButtonControl(
+        MAC_WXHWND(parent->MacGetTopLevelWindowRef()) , &bounds , CFSTR("") ,
+        -12345 , false /* no variable width */ , 0 , 0 , 0 , m_peer->GetControlRefAddr() );
+    verify_noerr( err );

 
 

-       return TRUE;
+    m_macPopUpMenuHandle = NewUniqueMenu() ;
+    m_peer->SetData<MenuHandle>( kControlNoPart , kControlPopupButtonMenuHandleTag , (MenuHandle) m_macPopUpMenuHandle ) ;
+    m_peer->SetValueAndRange( n > 0 ? 1 : 0 , 0 , 0 );
+    MacPostControlCreate( pos, size );
+
+#if !wxUSE_STL
+    if ( style & wxCB_SORT )
+        // autosort
+        m_strings = wxArrayString( 1 );
+#endif
+
+    for ( int i = 0; i < n; i++ )
+    {
+        Append( choices[i] );
+    }
+
+    // Set the first item as being selected
+    if (n > 0)
+        SetSelection( 0 );
+
+    // Needed because it is a wxControlWithItems
+    SetBestSize( size );
+
+    return true;

 }
 
 }
 

-void wxChoice::Append(const wxString& item)
+// ----------------------------------------------------------------------------
+// adding/deleting items to/from the list
+// ----------------------------------------------------------------------------
+int wxChoice::DoAppend( const wxString& item )

 {
 {

-       Str255 label;
-       wxMenuItem::MacBuildMenuString( label , NULL , NULL , item ,false);
-       AppendMenu( m_macPopUpMenuHandle , label ) ;
-       m_strings.Add( item ) ;
-       SetControlMaximum( m_macControl , Number()) ;
+#if wxUSE_STL
+    wxArrayString::iterator insertPoint;
+    size_t index;
+
+    if (GetWindowStyle() & wxCB_SORT)
+    {
+        insertPoint = std::lower_bound( m_strings.begin(), m_strings.end(), item );
+        index = insertPoint - m_strings.begin();
+    }
+    else
+    {
+        insertPoint = m_strings.end();
+        index = m_strings.size();
+    }
+
+    m_strings.insert( insertPoint, item );
+#else
+    size_t index = m_strings.Add( item );
+#endif
+
+    m_datas.Insert( NULL , index );
+    UMAInsertMenuItem( MAC_WXHMENU( m_macPopUpMenuHandle ), item, m_font.GetEncoding(), index );
+    DoSetItemClientData( index, NULL );
+    m_peer->SetMaximum( GetCount() );
+
+    return index;

 }
 
 }
 

-void wxChoice::Append(const wxString &item, void *client_data)
+int wxChoice::DoInsert( const wxString& item, int pos )

 {
 {

+    wxCHECK_MSG( !(GetWindowStyle() & wxCB_SORT), -1, wxT("wxChoice::DoInsert: can't insert into sorted list") );
+    wxCHECK_MSG( (pos >= 0) && (pos <= GetCount()), -1, wxT("wxChoice::DoInsert: invalid index") );
+
+    if (pos == GetCount())
+        return DoAppend( item );
+
+    UMAInsertMenuItem( MAC_WXHMENU( m_macPopUpMenuHandle ), item, m_font.GetEncoding(), pos );
+    m_strings.Insert( item, pos );
+    m_datas.Insert( NULL, pos );
+    DoSetItemClientData( pos, NULL );
+    m_peer->SetMaximum( GetCount() );
+
+    return pos;

 }
 
 }
 

-void *wxChoice::GetClientData(int index) const
+void wxChoice::Delete( int n )

 {
 {

-   return NULL;
+    wxCHECK_RET( n < GetCount(), wxT("wxChoice::Delete: invalid index") );
+
+    if ( HasClientObjectData() )
+        delete GetClientObject( n );
+
+    ::DeleteMenuItem( MAC_WXHMENU(m_macPopUpMenuHandle) , n + 1 ) ;
+    m_strings.RemoveAt( n ) ;
+    m_datas.RemoveAt( n ) ;
+    m_peer->SetMaximum( GetCount() ) ;

 }
 
 }
 

-void wxChoice::Delete(int n)
+void wxChoice::Clear()

 {
 {

-    ::DeleteMenuItem( m_macPopUpMenuHandle , n + 1) ;
-    m_strings.Remove( n ) ;
-       SetControlMaximum( m_macControl , Number()) ;
+    FreeData();
+    for ( int i = 0 ; i < GetCount() ; i++ )
+    {
+        ::DeleteMenuItem( MAC_WXHMENU(m_macPopUpMenuHandle) , 1 ) ;
+    }
+
+    m_strings.Empty() ;
+    m_datas.Empty() ;
+    m_peer->SetMaximum( 0 ) ;

 }
 
 }
 

-void wxChoice::Clear()
+void wxChoice::FreeData()

 {
 {

-    for ( int i = 0 ; i < Number() ; i++ )
+    if ( HasClientObjectData() )

     {
     {

-       ::DeleteMenuItem( m_macPopUpMenuHandle , 1 ) ;
-       }
-    m_strings.Clear() ;
-       SetControlMaximum( m_macControl , Number()) ;
+        size_t count = GetCount();
+        for ( size_t n = 0; n < count; n++ )
+        {
+            delete GetClientObject( n );
+        }
+    }

 }
 
 }
 

+// ----------------------------------------------------------------------------
+// selection
+// ----------------------------------------------------------------------------

 int wxChoice::GetSelection() const
 {
 int wxChoice::GetSelection() const
 {

-    return GetControlValue( m_macControl ) -1 ;
+    return m_peer->GetValue() - 1 ;

 }
 
 }
 

-void wxChoice::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
+void wxChoice::SetSelection( int n )

 {
 {

-    wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, m_windowId );
-       event.SetInt(GetSelection());
-    event.SetEventObject(this);
-    event.SetString(GetStringSelection());
-    ProcessCommand(event);
+    m_peer->SetValue( n + 1 ) ;

 }
 
 }
 

+// ----------------------------------------------------------------------------
+// string list functions
+// ----------------------------------------------------------------------------

 
 

-void wxChoice::SetSelection(int n)
+int wxChoice::GetCount() const

 {
 {

-    SetControlValue( m_macControl , n + 1 ) ;
+    return m_strings.GetCount() ;

 }
 
 }
 

-int wxChoice::FindString(const wxString& s) const
+int wxChoice::FindString( const wxString& s, bool bCase ) const

 {
 {

-    for( int i = 0 ; i < Number() ; i++ )
-    {
-       if ( GetString( i ) == s )
-               return i ; 
-    }
-    return -1;
+    return m_strings.Index( s , bCase ) ;

 }
 
 }
 

-wxString wxChoice::GetString(int n) const
+void wxChoice::SetString( int n, const wxString& s )

 {
 {

-       return m_strings[n] ;
+    wxCHECK_RET( n >= 0 && (size_t)n < m_strings.GetCount(),
+                    wxT("wxChoice::SetString(): invalid index") );
+
+    m_strings[n] = s ;
+
+    // apple menu pos is 1-based
+    UMASetMenuItemText( MAC_WXHMENU(m_macPopUpMenuHandle) , n + 1 , s , wxFont::GetDefaultEncoding() ) ;

 }
 
 }
 

-void wxChoice::SetSize(int x, int y, int width, int height, int sizeFlags)
+wxString wxChoice::GetString( int n ) const

 {
 {

-  wxControl::SetSize( x,y,width,height,sizeFlags ) ;
+    wxCHECK_MSG( n >= 0 && (size_t)n < m_strings.GetCount(), wxEmptyString,
+                    wxT("wxChoice::GetString(): invalid index") );
+
+    return m_strings[n] ;

 }
 
 }
 

-wxString wxChoice::GetStringSelection () const
+// ----------------------------------------------------------------------------
+// client data
+// ----------------------------------------------------------------------------
+void wxChoice::DoSetItemClientData( int n, void* clientData )

 {
 {

-    int sel = GetSelection ();
-    if (sel > -1)
-        return wxString(this->GetString (sel));
-    else
-        return wxString("");
+    wxCHECK_RET( n >= 0 && (size_t)n < m_datas.GetCount(),
+                 wxT("wxChoice::DoSetItemClientData: invalid index") );
+
+    m_datas[n] = (char*)clientData ;

 }
 
 }
 

-bool wxChoice::SetStringSelection (const wxString& s)
+void * wxChoice::DoGetItemClientData( int n ) const

 {
 {

-    int sel = FindString (s);
-    if (sel > -1)
-        {
-            SetSelection (sel);
-            return TRUE;
-        }
-    else
-        return FALSE;
+    wxCHECK_MSG( n >= 0 && (size_t)n < m_datas.GetCount(), NULL,
+                 wxT("wxChoice::DoGetClientData: invalid index") );
+
+    return (void *)m_datas[n];
+}
+
+void wxChoice::DoSetItemClientObject( int n, wxClientData* clientData )
+{
+    DoSetItemClientData( n, clientData ) ;

 }
 
 }
 

-void wxChoice::Command(wxCommandEvent & event)
+wxClientData* wxChoice::DoGetItemClientObject( int n ) const

 {
 {

-    SetSelection (event.GetInt());
-    ProcessCommand (event);
+    return (wxClientData*)DoGetItemClientData( n ) ;
+}
+
+wxInt32 wxChoice::MacControlHit( WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENTREF WXUNUSED(event) )
+{
+    wxCommandEvent event( wxEVT_COMMAND_CHOICE_SELECTED, m_windowId );
+
+    // actually n should be made sure by the os to be a valid selection, but ...
+    int n = GetSelection();
+    if ( n > -1 )
+    {
+        event.SetInt( n );
+        event.SetString( GetStringSelection() );
+        event.SetEventObject( this );
+
+        if ( HasClientObjectData() )
+            event.SetClientObject( GetClientObject( n ) );
+        else if ( HasClientUntypedData() )
+            event.SetClientData( GetClientData( n ) );
+
+        ProcessCommand( event );
+    }
+
+    return noErr ;
+}
+
+wxSize wxChoice::DoGetBestSize() const
+{
+    int lbWidth = GetCount() > 0 ? 20 : 100;  // some defaults
+    int lbHeight = 20;
+    int wLine;
+
+#if TARGET_CARBON
+    long metric ;
+
+    GetThemeMetric( kThemeMetricPopupButtonHeight , &metric );
+    lbHeight = metric ;
+#endif
+
+    {
+        wxMacPortStateHelper st( UMAGetWindowPort( (WindowRef) MacGetTopLevelWindowRef() ) ) ;
+        if ( m_font.Ok() )
+        {
+            ::TextFont( m_font.MacGetFontNum() ) ;
+            ::TextSize( m_font.MacGetFontSize() ) ;
+            ::TextFace( m_font.MacGetFontStyle() ) ;
+        }
+        else
+        {
+            ::TextFont( kFontIDMonaco ) ;
+            ::TextSize( 9 ) ;
+            ::TextFace( 0 ) ;
+        }
+
+        // Find the widest line
+        for(int i = 0; i < GetCount(); i++)
+        {
+            wxString str( GetString( i ) );
+
+#if wxUSE_UNICODE
+            Point bounds = { 0, 0 } ;
+            SInt16 baseline ;
+
+            ::GetThemeTextDimensions( wxMacCFStringHolder( str , m_font.GetEncoding() ) ,
+                kThemeCurrentPortFont,
+                kThemeStateActive,
+                false,
+                &bounds,
+                &baseline );
+
+            wLine = bounds.h ;
+#else
+            wLine = ::TextWidth( str.c_str() , 0 , str.Length() ) ;
+#endif
+
+            lbWidth = wxMax( lbWidth, wLine ) ;
+        }
+
+        // Add room for the popup arrow
+        lbWidth += 2 * lbHeight ;
+
+        // And just a bit more
+        int cx = ::TextWidth( "X" , 0 , 1 ) ;
+        lbWidth += cx ;
+    }
+
+    return wxSize( lbWidth, lbHeight );

 }
 
 }
 

+#endif // wxUSE_CHOICE