#include <gtk/gtk.h>
#include "wx/gtk/private.h"
+#ifdef __UNIX__
#include <unistd.h> // chdir
+#endif
#include "wx/filename.h" // wxFilename
#include "wx/tokenzr.h" // wxStringTokenizer
#include "wx/filefn.h" // ::wxGetCwd
+#include "wx/testing.h"
//-----------------------------------------------------------------------------
// "clicked" for OK-button
wxGtkString filename(gtk_file_chooser_get_filename(GTK_FILE_CHOOSER(widget)));
// gtk version numbers must be identical with the one in ctor (that calls set_do_overwrite_confirmation)
+#ifndef __WXGTK3__
#if GTK_CHECK_VERSION(2,7,3)
if (gtk_check_version(2, 7, 3) != NULL)
#endif
msg.Printf(
_("File '%s' already exists, do you really want to overwrite it?"),
- wxString(filename, *wxConvFileName));
+ wxString::FromUTF8(filename));
wxMessageDialog dlg(dialog, msg, _("Confirm"),
wxYES_NO | wxICON_QUESTION);
}
}
}
+#endif
if (style & wxFD_FILE_MUST_EXIST)
{
} // extern "C"
-//-----------------------------------------------------------------------------
-// "size_request" from m_extraControl
-//-----------------------------------------------------------------------------
-
-extern "C" {
-static void extra_widget_size_request(GtkWidget*, GtkRequisition* req, wxWindow* win)
+void wxFileDialog::AddChildGTK(wxWindowGTK* child)
{
// allow dialog to be resized smaller horizontally
- req->width = win->GetMinWidth();
-}
-}
+ gtk_widget_set_size_request(
+ child->m_widget, child->GetMinWidth(), child->m_height);
-void wxFileDialog::AddChildGTK(wxWindowGTK* child)
-{
- g_signal_connect_after(child->m_widget, "size_request",
- G_CALLBACK(extra_widget_size_request), child);
gtk_file_chooser_set_extra_widget(
GTK_FILE_CHOOSER(m_widget), child->m_widget);
}
const wxString& name)
: wxFileDialogBase()
{
- parent = GetParentForModalDialog(parent);
+ Create(parent, message, defaultDir, defaultFileName, wildCard, style, pos, sz, name);
+}
+
+bool wxFileDialog::Create(wxWindow *parent, const wxString& message,
+ const wxString& defaultDir,
+ const wxString& defaultFileName,
+ const wxString& wildCard,
+ long style, const wxPoint& pos,
+ const wxSize& sz,
+ const wxString& name)
+{
+ parent = GetParentForModalDialog(parent, style);
if (!wxFileDialogBase::Create(parent, message, defaultDir, defaultFileName,
wildCard, style, pos, sz, name))
{
- return;
+ return false;
}
if (!PreCreation(parent, pos, wxDefaultSize) ||
wxDefaultValidator, wxT("filedialog")))
{
wxFAIL_MSG( wxT("wxFileDialog creation failed") );
- return;
+ return false;
}
GtkFileChooserAction gtk_action;
// local-only property could be set to false to allow non-local files to be
// loaded. In that case get/set_uri(s) should be used instead of
// get/set_filename(s) everywhere and the GtkFileChooserDialog should
- // probably also be created with a backend, e.g "gnome-vfs", "default", ...
+ // probably also be created with a backend, e.g. "gnome-vfs", "default", ...
// (gtk_file_chooser_dialog_new_with_backend). Currently local-only is kept
// as the default - true:
// gtk_file_chooser_set_local_only(GTK_FILE_CHOOSER(m_widget), true);
g_signal_connect (m_widget, "response",
G_CALLBACK (gtk_filedialog_response_callback), this);
+
+ // deal with extensions/filters
SetWildcard(wildCard);
+ wxString defaultFileNameWithExt = defaultFileName;
+ if ( !wildCard.empty() && !defaultFileName.empty() &&
+ !wxFileName(defaultFileName).HasExt() )
+ {
+ // append the default extension to the initial file name: GTK won't do
+ // it for us by default (unlike e.g. MSW)
+ const wxString defaultExt = m_fc.GetCurrentWildCard().AfterFirst('.');
+ if ( defaultExt.find_first_of("?*") == wxString::npos )
+ defaultFileNameWithExt += "." + defaultExt;
+ }
+
+
// if defaultDir is specified it should contain the directory and
// defaultFileName should contain the default name of the file, however if
// directory is not given, defaultFileName contains both
wxFileName fn;
if ( defaultDir.empty() )
- fn.Assign(defaultFileName);
- else if ( !defaultFileName.empty() )
- fn.Assign(defaultDir, defaultFileName);
+ fn.Assign(defaultFileNameWithExt);
+ else if ( !defaultFileNameWithExt.empty() )
+ fn.Assign(defaultDir, defaultFileNameWithExt);
else
fn.AssignDir(defaultDir);
const wxString dir = fn.GetPath();
if ( !dir.empty() )
{
- gtk_file_chooser_set_current_folder(file_chooser, dir.fn_str());
+ gtk_file_chooser_set_current_folder(file_chooser, wxGTK_CONV_FN(dir));
}
const wxString fname = fn.GetFullName();
{
if ( !fname.empty() )
{
- gtk_file_chooser_set_current_name(file_chooser, fname.fn_str());
+ gtk_file_chooser_set_current_name(file_chooser, wxGTK_CONV_FN(fname));
}
#if GTK_CHECK_VERSION(2,7,3)
- if ((style & wxFD_OVERWRITE_PROMPT) && !gtk_check_version(2,7,3))
+ if ((style & wxFD_OVERWRITE_PROMPT)
+#ifndef __WXGTK3__
+ && gtk_check_version(2,7,3) == NULL
+#endif
+ )
+ {
gtk_file_chooser_set_do_overwrite_confirmation(file_chooser, true);
+ }
#endif
}
else // wxFD_OPEN
if ( !fname.empty() )
{
gtk_file_chooser_set_filename(file_chooser,
- fn.GetFullPath().fn_str());
+ wxGTK_CONV_FN(fn.GetFullPath()));
}
}
G_CALLBACK(gtk_filedialog_update_preview_callback),
previewImage);
}
+
+ return true;
}
wxFileDialog::~wxFileDialog()
int wxFileDialog::ShowModal()
{
+ WX_TESTING_SHOW_MODAL_HOOK();
+
CreateExtraControl();
return wxDialog::ShowModal();
wxString wxFileDialog::GetPath() const
{
- wxFileName fn = m_fc.GetPath();
-
- if (HasFdFlag(wxFD_SAVE))
- {
- // add extension
- if (!fn.HasExt())
- {
- wxFileName wildcard( "/dummy", m_fc.GetCurrentWildCard() );
- wxString ext = wildcard.GetExt();
- if (!ext.empty() && (ext.Find('?') == wxNOT_FOUND) && (ext.Find('*') == wxNOT_FOUND))
- fn.SetExt( ext );
- }
- }
-
- return fn.GetFullPath();
+ return m_fc.GetPath();
}
void wxFileDialog::GetFilenames(wxArrayString& files) const
void wxFileDialog::SetPath(const wxString& path)
{
- m_fc.SetPath( path );
+ wxFileDialogBase::SetPath(path);
+
+ // Don't do anything if no path is specified, in particular don't set the
+ // path to m_dir below as this would result in opening the dialog in the
+ // parent directory of this one instead of m_dir itself.
+ if ( path.empty() )
+ return;
+
+ // we need an absolute path for GTK native chooser so ensure that we have
+ // it: use the initial directory if it was set or just CWD otherwise (this
+ // is the default behaviour if m_dir is empty)
+ wxFileName fn(path);
+ fn.MakeAbsolute(m_dir);
+ m_fc.SetPath(fn.GetFullPath());
}
void wxFileDialog::SetDirectory(const wxString& dir)
{
- m_fc.SetDirectory( dir );
+ wxFileDialogBase::SetDirectory(dir);
+
+ m_fc.SetDirectory(dir);
}
wxString wxFileDialog::GetDirectory() const
{
- return m_fc.GetDirectory();
+ wxString currentDir( m_fc.GetDirectory() );
+ if (currentDir.empty())
+ {
+ // m_fc.GetDirectory() will return empty until the dialog has been shown
+ // in which case use any previously provided value
+ currentDir = m_dir;
+ }
+ return currentDir;
}
void wxFileDialog::SetFilename(const wxString& name)
{
+ wxFileDialogBase::SetFilename(name);
+
if (HasFdFlag(wxFD_SAVE))
+ {
gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(m_widget), wxGTK_CONV(name));
+ }
+
else
- SetPath(wxFileName(GetDirectory(), name).GetFullPath());
+ {
+ wxString path( GetDirectory() );
+ if (path.empty())
+ {
+ // SetPath() fires an assert if fed other than filepaths
+ return;
+ }
+ SetPath(wxFileName(path, name).GetFullPath());
+ }
}
wxString wxFileDialog::GetFilename() const
{
- return m_fc.GetFilename();
+ wxString currentFilename( m_fc.GetFilename() );
+ if (currentFilename.empty())
+ {
+ // m_fc.GetFilename() will return empty until the dialog has been shown
+ // in which case use any previously provided value
+ currentFilename = m_fileName;
+ }
+ return currentFilename;
}
void wxFileDialog::SetWildcard(const wxString& wildCard)
{
- m_fc.SetWildcard( wildCard );
+ wxFileDialogBase::SetWildcard(wildCard);
+ m_fc.SetWildcard( GetWildcard() );
}
void wxFileDialog::SetFilterIndex(int filterIndex)
{
-
m_fc.SetFilterIndex( filterIndex);
}
projects / wxWidgets.git / blobdiff