check whether the string is non-empty before accessing its first element

[wxWidgets.git] / src / unix / fontutil.cpp

diff --git a/src/unix/fontutil.cpp b/src/unix/fontutil.cpp
index c3cc7702e5210201296cbfa2ea5ac39f3ee0546e..8ec7b7892d57ad690d4af308f4f8ae38fac00e69 100644 (file)
--- a/src/unix/fontutil.cpp
+++ b/src/unix/fontutil.cpp
@@ -44,10 +44,17 @@
 #include "pango/pango.h"
 
 #ifdef __WXGTK20__
 #include "pango/pango.h"
 
 #ifdef __WXGTK20__

-#include "wx/gtk/private.h"
-extern GtkWidget *wxGetRootWindow();
+    #include "wx/gtk/private.h"
+    extern GtkWidget *wxGetRootWindow();
+
+    #define wxPANGO_CONV wxGTK_CONV_SYS
+    #define wxPANGO_CONV_BACK wxGTK_CONV_BACK_SYS

 #else
 #else

-#include "wx/x11/private.h"
+    #include "wx/x11/private.h"
+    #include "wx/gtk/private/string.h"
+
+    #define wxPANGO_CONV(s) (wxConvUTF8.cWX2MB((s)))
+    #define wxPANGO_CONV_BACK(s) (wxConvUTF8.cMB2WX((s)))

 #endif
 
 // ----------------------------------------------------------------------------
 #endif
 
 // ----------------------------------------------------------------------------


@@ -131,9 +138,7 @@ bool wxNativeFontInfo::GetUnderlined() const
 
 wxString wxNativeFontInfo::GetFaceName() const
 {
 
 wxString wxNativeFontInfo::GetFaceName() const
 {

-    wxString tmp = wxGTK_CONV_BACK( pango_font_description_get_family( description ) );
-
-    return tmp;
+    return wxPANGO_CONV_BACK(pango_font_description_get_family(description));

 }
 
 wxFontFamily wxNativeFontInfo::GetFamily() const
 }
 
 wxFontFamily wxNativeFontInfo::GetFamily() const


@@ -263,7 +268,7 @@ void wxNativeFontInfo::SetUnderlined(bool WXUNUSED(underlined))
 
 bool wxNativeFontInfo::SetFaceName(const wxString& facename)
 {
 
 bool wxNativeFontInfo::SetFaceName(const wxString& facename)
 {

-    pango_font_description_set_family(description, wxGTK_CONV_SYS(facename));
+    pango_font_description_set_family(description, wxPANGO_CONV(facename));

     return true;
 }
 
     return true;
 }
 


@@ -309,7 +314,7 @@ bool wxNativeFontInfo::FromString(const wxString& s)
         }
     }
 
         }
     }
 

-    description = pango_font_description_from_string( wxGTK_CONV_SYS( str ) );
+    description = pango_font_description_from_string(wxPANGO_CONV(str));

 
     // ensure a valid facename is selected
     if (!wxFontEnumerator::IsValidFacename(GetFaceName()))
 
     // ensure a valid facename is selected
     if (!wxFontEnumerator::IsValidFacename(GetFaceName()))


@@ -322,7 +327,7 @@ wxString wxNativeFontInfo::ToString() const
 {
     wxGtkString str(pango_font_description_to_string( description ));
 
 {
     wxGtkString str(pango_font_description_to_string( description ));
 

-    return wxGTK_CONV_BACK(str);
+    return wxPANGO_CONV_BACK(str);

 }
 
 bool wxNativeFontInfo::FromUserString(const wxString& s)
 }
 
 bool wxNativeFontInfo::FromUserString(const wxString& s)


@@ -335,36 +340,6 @@ wxString wxNativeFontInfo::ToUserString() const
     return ToString();
 }
 
     return ToString();
 }
 

-// ----------------------------------------------------------------------------
-// wxNativeEncodingInfo
-// ----------------------------------------------------------------------------
-
-bool wxNativeEncodingInfo::FromString(const wxString& WXUNUSED(s))
-{
-    return false;
-}
-
-wxString wxNativeEncodingInfo::ToString() const
-{
-    return wxEmptyString;
-}
-
-bool wxTestFontEncoding(const wxNativeEncodingInfo& WXUNUSED(info))
-{
-    return true;
-}
-
-bool wxGetNativeFontEncoding(wxFontEncoding encoding,
-                             wxNativeEncodingInfo *info)
-{
-    // all encodings are available in GTK+ 2 because we translate text in any
-    // encoding to UTF-8 internally anyhow
-    info->facename.clear();
-    info->encoding = encoding;
-
-    return true;
-}
-

 #else // GTK+ 1.x
 
 #ifdef __X__
 #else // GTK+ 1.x
 
 #ifdef __X__


@@ -667,7 +642,7 @@ wxFontStyle wxNativeFontInfo::GetStyle() const
         return wxFONTSTYLE_NORMAL;
     }
 
         return wxFONTSTYLE_NORMAL;
     }
 

-    switch ( s[0] )
+    switch ( s[0].GetValue() )

     {
         default:
             // again, unknown but consider normal by default
     {
         default:
             // again, unknown but consider normal by default