]> git.saurik.com Git - wxWidgets.git/blame - src/msw/choice.cpp
Don't skip after writing tab or we could get another one in some circumstances
[wxWidgets.git] / src / msw / choice.cpp
CommitLineData
2bda0e17
KB
1/////////////////////////////////////////////////////////////////////////////
2// Name: choice.cpp
3// Purpose: wxChoice
4// Author: Julian Smart
8d99be5f 5// Modified by: Vadim Zeitlin to derive from wxChoiceBase
2bda0e17
KB
6// Created: 04/01/98
7// RCS-ID: $Id$
6c9a19aa 8// Copyright: (c) Julian Smart
65571936 9// Licence: wxWindows licence
2bda0e17
KB
10/////////////////////////////////////////////////////////////////////////////
11
8d99be5f
VZ
12// ============================================================================
13// declarations
14// ============================================================================
15
16// ----------------------------------------------------------------------------
17// headers
18// ----------------------------------------------------------------------------
19
14f355c2 20#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
8d99be5f 21 #pragma implementation "choice.h"
2bda0e17
KB
22#endif
23
24// For compilers that support precompilation, includes "wx.h".
25#include "wx/wxprec.h"
26
27#ifdef __BORLANDC__
8d99be5f 28 #pragma hdrstop
2bda0e17
KB
29#endif
30
3180bc0e 31#if wxUSE_CHOICE && !(defined(__SMARTPHONE__) && defined(__WXWINCE__))
1e6feb95 32
2bda0e17 33#ifndef WX_PRECOMP
8d99be5f
VZ
34 #include "wx/choice.h"
35 #include "wx/utils.h"
36 #include "wx/log.h"
f6bcfd97 37 #include "wx/brush.h"
c7401637 38 #include "wx/settings.h"
2bda0e17
KB
39#endif
40
41#include "wx/msw/private.h"
42
6a89f9ee 43#if wxUSE_EXTENDED_RTTI
bc9fb572
JS
44WX_DEFINE_FLAGS( wxChoiceStyle )
45
3ff066a4 46wxBEGIN_FLAGS( wxChoiceStyle )
bc9fb572
JS
47 // new style border flags, we put them first to
48 // use them for streaming out
3ff066a4
SC
49 wxFLAGS_MEMBER(wxBORDER_SIMPLE)
50 wxFLAGS_MEMBER(wxBORDER_SUNKEN)
51 wxFLAGS_MEMBER(wxBORDER_DOUBLE)
52 wxFLAGS_MEMBER(wxBORDER_RAISED)
53 wxFLAGS_MEMBER(wxBORDER_STATIC)
54 wxFLAGS_MEMBER(wxBORDER_NONE)
3dfb79a6 55
bc9fb572 56 // old style border flags
3ff066a4
SC
57 wxFLAGS_MEMBER(wxSIMPLE_BORDER)
58 wxFLAGS_MEMBER(wxSUNKEN_BORDER)
59 wxFLAGS_MEMBER(wxDOUBLE_BORDER)
60 wxFLAGS_MEMBER(wxRAISED_BORDER)
61 wxFLAGS_MEMBER(wxSTATIC_BORDER)
cb0afb26 62 wxFLAGS_MEMBER(wxBORDER)
bc9fb572
JS
63
64 // standard window styles
3ff066a4
SC
65 wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
66 wxFLAGS_MEMBER(wxCLIP_CHILDREN)
67 wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
68 wxFLAGS_MEMBER(wxWANTS_CHARS)
cb0afb26 69 wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
3ff066a4
SC
70 wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
71 wxFLAGS_MEMBER(wxVSCROLL)
72 wxFLAGS_MEMBER(wxHSCROLL)
bc9fb572 73
3ff066a4 74wxEND_FLAGS( wxChoiceStyle )
bc9fb572
JS
75
76IMPLEMENT_DYNAMIC_CLASS_XTI(wxChoice, wxControl,"wx/choice.h")
6a89f9ee 77
3ff066a4 78wxBEGIN_PROPERTIES_TABLE(wxChoice)
3dfb79a6 79 wxEVENT_PROPERTY( Select , wxEVT_COMMAND_CHOICE_SELECTED , wxCommandEvent )
c5ca409b 80
af498247 81 wxPROPERTY( Font , wxFont , SetFont , GetFont , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
3ff066a4 82 wxPROPERTY_COLLECTION( Choices , wxArrayString , wxString , AppendString , GetStrings , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
3dfb79a6 83 wxPROPERTY( Selection ,int, SetSelection, GetSelection, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
af498247 84 wxPROPERTY_FLAGS( WindowStyle , wxChoiceStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
3ff066a4 85wxEND_PROPERTIES_TABLE()
6a89f9ee 86
3ff066a4
SC
87wxBEGIN_HANDLERS_TABLE(wxChoice)
88wxEND_HANDLERS_TABLE()
2bda0e17 89
3dfb79a6 90wxCONSTRUCTOR_4( wxChoice , wxWindow* , Parent , wxWindowID , Id , wxPoint , Position , wxSize , Size )
6a89f9ee
SC
91#else
92IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)
93#endif
066f1b7a 94/*
3dfb79a6
VZ
95 TODO PROPERTIES
96 selection (long)
97 content (list)
98 item
066f1b7a
SC
99*/
100
8d99be5f
VZ
101// ============================================================================
102// implementation
103// ============================================================================
104
105// ----------------------------------------------------------------------------
106// creation
107// ----------------------------------------------------------------------------
108
109bool wxChoice::Create(wxWindow *parent,
110 wxWindowID id,
111 const wxPoint& pos,
112 const wxSize& size,
113 int n, const wxString choices[],
114 long style,
115 const wxValidator& validator,
116 const wxString& name)
2bda0e17 117{
f6bcfd97 118 // Experience shows that wxChoice vs. wxComboBox distinction confuses
8d99be5f
VZ
119 // quite a few people - try to help them
120 wxASSERT_MSG( !(style & wxCB_DROPDOWN) &&
121 !(style & wxCB_READONLY) &&
122 !(style & wxCB_SIMPLE),
f6bcfd97
BP
123 _T("this style flag is ignored by wxChoice, you ")
124 _T("probably want to use a wxComboBox") );
2bda0e17 125
71e57cd6
VZ
126 return CreateAndInit(parent, id, pos, size, n, choices, style,
127 validator, name);
128}
129
cc61d2eb
VZ
130bool wxChoice::CreateAndInit(wxWindow *parent,
131 wxWindowID id,
71e57cd6 132 const wxPoint& pos,
3dfb79a6 133 const wxSize& size,
71e57cd6
VZ
134 int n, const wxString choices[],
135 long style,
136 const wxValidator& validator,
137 const wxString& name)
138{
139 // initialize wxControl
140 if ( !CreateControl(parent, id, pos, size, style, validator, name) )
02b7b6b0 141 return false;
2bda0e17 142
71e57cd6 143 // now create the real HWND
f31a4098 144 if ( !MSWCreateControl(wxT("COMBOBOX"), wxEmptyString, pos, size) )
02b7b6b0 145 return false;
71e57cd6
VZ
146
147
148 // choice/combobox normally has "white" (depends on colour scheme, of
149 // course) background rather than inheriting the parent's background
a756f210 150 SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));
c92d798f 151
cc61d2eb 152 // initialize the controls contents
8d99be5f
VZ
153 for ( int i = 0; i < n; i++ )
154 {
155 Append(choices[i]);
156 }
2bda0e17 157
cc61d2eb 158 // and now we may finally size the control properly (if needed)
3dfb79a6 159 SetBestSize(size);
cc61d2eb 160
02b7b6b0 161 return true;
2bda0e17
KB
162}
163
584ad2a3
MB
164bool wxChoice::Create(wxWindow *parent,
165 wxWindowID id,
166 const wxPoint& pos,
167 const wxSize& size,
168 const wxArrayString& choices,
169 long style,
170 const wxValidator& validator,
171 const wxString& name)
172{
173 wxCArrayString chs(choices);
174 return Create(parent, id, pos, size, chs.GetCount(), chs.GetStrings(),
175 style, validator, name);
176}
177
4b17d2e3
DS
178bool wxChoice::MSWShouldPreProcessMessage(WXMSG *pMsg)
179{
180 MSG *msg = (MSG *) pMsg;
181
dc302518
DS
182 // if the dropdown list is visible, don't preprocess certain keys
183 if ( msg->message == WM_KEYDOWN
184 && (msg->wParam == VK_ESCAPE || msg->wParam == VK_RETURN) )
4b17d2e3
DS
185 {
186 if (::SendMessage(GetHwndOf(this), CB_GETDROPPEDSTATE, 0, 0))
187 {
188 return false;
189 }
190 }
191
192 return wxControl::MSWShouldPreProcessMessage(pMsg);
193}
194
71e57cd6
VZ
195WXDWORD wxChoice::MSWGetStyle(long style, WXDWORD *exstyle) const
196{
197 // we never have an external border
198 WXDWORD msStyle = wxControl::MSWGetStyle
199 (
200 (style & ~wxBORDER_MASK) | wxBORDER_NONE, exstyle
201 );
202
203 // WS_CLIPSIBLINGS is useful with wxChoice and doesn't seem to result in
204 // any problems
205 msStyle |= WS_CLIPSIBLINGS;
206
207 // wxChoice-specific styles
208 msStyle |= CBS_DROPDOWNLIST | WS_HSCROLL | WS_VSCROLL;
209 if ( style & wxCB_SORT )
210 msStyle |= CBS_SORT;
211
212 return msStyle;
213}
214
8ee9d618
VZ
215wxChoice::~wxChoice()
216{
217 Free();
218}
219
8d99be5f
VZ
220// ----------------------------------------------------------------------------
221// adding/deleting items to/from the list
222// ----------------------------------------------------------------------------
2bda0e17 223
def6fb9b 224int wxChoice::DoAppend(const wxString& item)
8d99be5f 225{
c140b7e7 226 int n = (int)SendMessage(GetHwnd(), CB_ADDSTRING, 0, (LPARAM)item.c_str());
def6fb9b
VZ
227 if ( n == CB_ERR )
228 {
f6bcfd97 229 wxLogLastError(wxT("SendMessage(CB_ADDSTRING)"));
def6fb9b 230 }
71e57cd6
VZ
231 else // ok
232 {
233 // we need to refresh our size in order to have enough space for the
234 // newly added items
e0e3a32d
VZ
235 if ( !IsFrozen() )
236 UpdateVisibleHeight();
71e57cd6 237 }
def6fb9b 238
31582e4e 239 InvalidateBestSize();
def6fb9b 240 return n;
2bda0e17
KB
241}
242
243dbf1a
VZ
243int wxChoice::DoInsert(const wxString& item, int pos)
244{
245 wxCHECK_MSG(!(GetWindowStyle() & wxCB_SORT), -1, wxT("can't insert into sorted list"));
246 wxCHECK_MSG((pos>=0) && (pos<=GetCount()), -1, wxT("invalid index"));
247
c140b7e7 248 int n = (int)SendMessage(GetHwnd(), CB_INSERTSTRING, pos, (LPARAM)item.c_str());
243dbf1a
VZ
249 if ( n == CB_ERR )
250 {
251 wxLogLastError(wxT("SendMessage(CB_INSERTSTRING)"));
252 }
71e57cd6
VZ
253 else // ok
254 {
e0e3a32d
VZ
255 if ( !IsFrozen() )
256 UpdateVisibleHeight();
71e57cd6 257 }
243dbf1a 258
31582e4e 259 InvalidateBestSize();
243dbf1a
VZ
260 return n;
261}
262
debe6624 263void wxChoice::Delete(int n)
2bda0e17 264{
223d09f6 265 wxCHECK_RET( n < GetCount(), wxT("invalid item index in wxChoice::Delete") );
8d99be5f 266
6c8a980f
VZ
267 if ( HasClientObjectData() )
268 {
269 delete GetClientObject(n);
270 }
271
8d99be5f 272 SendMessage(GetHwnd(), CB_DELETESTRING, n, 0);
71e57cd6 273
e0e3a32d
VZ
274 if ( !IsFrozen() )
275 UpdateVisibleHeight();
31582e4e
RD
276
277 InvalidateBestSize();
2bda0e17
KB
278}
279
8d99be5f 280void wxChoice::Clear()
8ee9d618 281{
92d2389e 282 Free();
8ee9d618
VZ
283
284 SendMessage(GetHwnd(), CB_RESETCONTENT, 0, 0);
71e57cd6 285
e0e3a32d
VZ
286 if ( !IsFrozen() )
287 UpdateVisibleHeight();
31582e4e
RD
288
289 InvalidateBestSize();
8ee9d618
VZ
290}
291
292void wxChoice::Free()
2bda0e17 293{
6c8a980f
VZ
294 if ( HasClientObjectData() )
295 {
296 size_t count = GetCount();
297 for ( size_t n = 0; n < count; n++ )
298 {
299 delete GetClientObject(n);
300 }
301 }
2bda0e17
KB
302}
303
8d99be5f
VZ
304// ----------------------------------------------------------------------------
305// selection
306// ----------------------------------------------------------------------------
2bda0e17 307
8d99be5f 308int wxChoice::GetSelection() const
6ba93d23
VZ
309{
310 // if m_lastAcceptedSelection is set, it means that the dropdown is
311 // currently shown and that we want to use the last "permanent" selection
312 // instead of whatever is under the mouse pointer currently
313 //
314 // otherwise, get the selection from the control
315 return m_lastAcceptedSelection == wxID_NONE ? GetCurrentSelection()
316 : m_lastAcceptedSelection;
317}
318
319int wxChoice::GetCurrentSelection() const
2bda0e17 320{
8d99be5f 321 return (int)SendMessage(GetHwnd(), CB_GETCURSEL, 0, 0);
2bda0e17
KB
322}
323
debe6624 324void wxChoice::SetSelection(int n)
2bda0e17 325{
8d99be5f
VZ
326 SendMessage(GetHwnd(), CB_SETCURSEL, n, 0);
327}
328
329// ----------------------------------------------------------------------------
330// string list functions
331// ----------------------------------------------------------------------------
332
333int wxChoice::GetCount() const
334{
335 return (int)SendMessage(GetHwnd(), CB_GETCOUNT, 0, 0);
2bda0e17
KB
336}
337
338int wxChoice::FindString(const wxString& s) const
339{
340#if defined(__WATCOMC__) && defined(__WIN386__)
8d99be5f
VZ
341 // For some reason, Watcom in WIN386 mode crashes in the CB_FINDSTRINGEXACT message.
342 // wxChoice::Do it the long way instead.
343 int count = GetCount();
344 for ( int i = 0; i < count; i++ )
345 {
346 // as CB_FINDSTRINGEXACT is case insensitive, be case insensitive too
02b7b6b0 347 if ( GetString(i).IsSameAs(s, false) )
8d99be5f
VZ
348 return i;
349 }
350
351 return wxNOT_FOUND;
352#else // !Watcom
4cd1ed99
RN
353 //TODO: Evidently some MSW versions (all?) don't like empty strings
354 //passed to SendMessage, so we have to do it ourselves in that case
beedefb9 355 if ( s.empty() )
4cd1ed99
RN
356 {
357 int count = GetCount();
358 for ( int i = 0; i < count; i++ )
359 {
beedefb9 360 if ( GetString(i).empty() )
4cd1ed99
RN
361 return i;
362 }
363
364 return wxNOT_FOUND;
365 }
366 else
367 {
368 int pos = (int)SendMessage(GetHwnd(), CB_FINDSTRINGEXACT,
369 (WPARAM)-1, (LPARAM)s.c_str());
f31a4098 370
4cd1ed99
RN
371 return pos == LB_ERR ? wxNOT_FOUND : pos;
372 }
8d99be5f 373#endif // Watcom/!Watcom
2bda0e17
KB
374}
375
b4bfa452 376void wxChoice::SetString(int n, const wxString& s)
6c8a980f 377{
2b5f62a0
VZ
378 wxCHECK_RET( n >= 0 && n < GetCount(),
379 wxT("invalid item index in wxChoice::SetString") );
380
381 // we have to delete and add back the string as there is no way to change a
382 // string in place
383
384 // we need to preserve the client data
385 void *data;
386 if ( m_clientDataItemsType != wxClientData_None )
387 {
388 data = DoGetItemClientData(n);
389 }
390 else // no client data
391 {
392 data = NULL;
393 }
394
395 ::SendMessage(GetHwnd(), CB_DELETESTRING, n, 0);
396 ::SendMessage(GetHwnd(), CB_INSERTSTRING, n, (LPARAM)s.c_str() );
397
398 if ( data )
399 {
400 DoSetItemClientData(n, data);
401 }
402 //else: it's already NULL by default
31582e4e
RD
403
404 InvalidateBestSize();
6c8a980f
VZ
405}
406
debe6624 407wxString wxChoice::GetString(int n) const
2bda0e17 408{
478cabab
VZ
409 int len = (int)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
410
6c8a980f 411 wxString str;
478cabab
VZ
412 if ( len != CB_ERR && len > 0 )
413 {
414 if ( ::SendMessage
415 (
416 GetHwnd(),
417 CB_GETLBTEXT,
418 n,
419 (LPARAM)(wxChar *)wxStringBuffer(str, len)
420 ) == CB_ERR )
421 {
f6bcfd97 422 wxLogLastError(wxT("SendMessage(CB_GETLBTEXT)"));
21d72d17 423 }
4438caf4 424 }
2bda0e17 425
4438caf4
VZ
426 return str;
427}
2bda0e17 428
8d99be5f
VZ
429// ----------------------------------------------------------------------------
430// client data
431// ----------------------------------------------------------------------------
432
6c8a980f 433void wxChoice::DoSetItemClientData( int n, void* clientData )
8d99be5f 434{
2b5f62a0
VZ
435 if ( ::SendMessage(GetHwnd(), CB_SETITEMDATA,
436 n, (LPARAM)clientData) == CB_ERR )
8d99be5f 437 {
223d09f6 438 wxLogLastError(wxT("CB_SETITEMDATA"));
8d99be5f
VZ
439 }
440}
441
6c8a980f 442void* wxChoice::DoGetItemClientData( int n ) const
8d99be5f
VZ
443{
444 LPARAM rc = SendMessage(GetHwnd(), CB_GETITEMDATA, n, 0);
445 if ( rc == CB_ERR )
446 {
223d09f6 447 wxLogLastError(wxT("CB_GETITEMDATA"));
8d99be5f
VZ
448
449 // unfortunately, there is no way to return an error code to the user
8ee9d618 450 rc = (LPARAM) NULL;
8d99be5f
VZ
451 }
452
453 return (void *)rc;
454}
455
6c8a980f 456void wxChoice::DoSetItemClientObject( int n, wxClientData* clientData )
8d99be5f 457{
6c8a980f 458 DoSetItemClientData(n, clientData);
8d99be5f
VZ
459}
460
6c8a980f 461wxClientData* wxChoice::DoGetItemClientObject( int n ) const
8d99be5f 462{
6c8a980f 463 return (wxClientData *)DoGetItemClientData(n);
8d99be5f
VZ
464}
465
466// ----------------------------------------------------------------------------
467// wxMSW specific helpers
468// ----------------------------------------------------------------------------
469
71e57cd6
VZ
470void wxChoice::UpdateVisibleHeight()
471{
e6968367 472 // be careful to not change the width here
02b7b6b0 473 DoSetSize(wxDefaultCoord, wxDefaultCoord, wxDefaultCoord, GetSize().y, wxSIZE_USE_EXISTING);
71e57cd6
VZ
474}
475
18c50997
VZ
476void wxChoice::DoMoveWindow(int x, int y, int width, int height)
477{
478 // here is why this is necessary: if the width is negative, the combobox
479 // window proc makes the window of the size width*height instead of
480 // interpreting height in the usual manner (meaning the height of the drop
481 // down list - usually the height specified in the call to MoveWindow()
482 // will not change the height of combo box per se)
483 //
484 // this behaviour is not documented anywhere, but this is just how it is
485 // here (NT 4.4) and, anyhow, the check shouldn't hurt - however without
486 // the check, constraints/sizers using combos may break the height
487 // constraint will have not at all the same value as expected
488 if ( width < 0 )
489 return;
490
491 wxControl::DoMoveWindow(x, y, width, height);
492}
493
d99957b6
VZ
494void wxChoice::DoGetSize(int *w, int *h) const
495{
94a77ff7
VZ
496 // this is weird: sometimes, the height returned by Windows is clearly the
497 // total height of the control including the drop down list -- but only
498 // sometimes, and normally it isn't... I have no idea about what to do with
499 // this
02b7b6b0 500 wxControl::DoGetSize(w, h);
d99957b6
VZ
501}
502
4438caf4 503void wxChoice::DoSetSize(int x, int y,
d99957b6 504 int width, int height,
4438caf4
VZ
505 int sizeFlags)
506{
d99957b6 507 int heightOrig = height;
a8e65eee 508
d99957b6
VZ
509 // the height which we must pass to Windows should be the total height of
510 // the control including the drop down list while the height given to us
511 // is, of course, just the height of the permanently visible part of it
02b7b6b0 512 if ( height != wxDefaultCoord )
d99957b6
VZ
513 {
514 // don't make the drop down list too tall, arbitrarily limit it to 40
515 // items max and also don't leave it empty
516 size_t nItems = GetCount();
517 if ( !nItems )
518 nItems = 9;
cb828946
RD
519 else if ( nItems > 24 )
520 nItems = 24;
d99957b6
VZ
521
522 // add space for the drop down list
523 const int hItem = SendMessage(GetHwnd(), CB_GETITEMHEIGHT, 0, 0);
524 height += hItem*(nItems + 1);
525 }
d6959d6f
DS
526 else
527 {
528 // We cannot pass wxDefaultCoord as height to wxControl. wxControl uses
f31a4098
WS
529 // wxGetWindowRect() to determine the current height of the combobox,
530 // and then again sets the combobox's height to that value. Unfortunately,
531 // wxGetWindowRect doesn't include the dropdown list's height (at least
532 // on Win2K), so this would result in a combobox with dropdown height of
d6959d6f
DS
533 // 1 pixel. We have to determine the default height ourselves and call
534 // wxControl with that value instead.
535 int w, h;
536 RECT r;
537 DoGetSize(&w, &h);
538 if (::SendMessage(GetHwnd(), CB_GETDROPPEDCONTROLRECT, 0, (LPARAM) &r) != 0)
539 {
f31a4098 540 height = h + r.bottom - r.top;
d6959d6f
DS
541 }
542 }
d99957b6
VZ
543
544 wxControl::DoSetSize(x, y, width, height, sizeFlags);
545
ef036883
JS
546 // I'm commenting this out since the code appears to make choices
547 // and comboxes too high when they have associated sizers. I'm sure this
548 // is not the end of the story, which is why I'm leaving it #if'ed out for
549 // now. JACS.
550#if 0
d99957b6
VZ
551 // if the height specified for the visible part of the control is
552 // different from the current one, we need to change it separately
553 // as it is not affected by normal WM_SETSIZE
02b7b6b0 554 if ( height != wxDefaultCoord )
d99957b6 555 {
94a77ff7
VZ
556 const int delta = heightOrig - GetSize().y;
557 if ( delta )
d99957b6 558 {
94a77ff7
VZ
559 int h = ::SendMessage(GetHwnd(), CB_GETITEMHEIGHT, (WPARAM)-1, 0);
560 SendMessage(GetHwnd(), CB_SETITEMHEIGHT, (WPARAM)-1, h + delta);
d99957b6
VZ
561 }
562 }
e69ba9cb
WS
563#else
564 wxUnusedVar(heightOrig);
ef036883 565#endif
4438caf4 566}
2bda0e17 567
882a8f40 568wxSize wxChoice::DoGetBestSize() const
4438caf4
VZ
569{
570 // find the widest string
4438caf4 571 int wChoice = 0;
d99957b6
VZ
572 const size_t nItems = GetCount();
573 for ( size_t i = 0; i < nItems; i++ )
2bda0e17 574 {
d99957b6
VZ
575 int wLine;
576 GetTextExtent(GetString(i), &wLine, NULL);
4438caf4
VZ
577 if ( wLine > wChoice )
578 wChoice = wLine;
2bda0e17 579 }
fd3f686c 580
4438caf4
VZ
581 // give it some reasonable default value if there are no strings in the
582 // list
583 if ( wChoice == 0 )
584 wChoice = 100;
2bda0e17 585
d99957b6
VZ
586 // the combobox should be slightly larger than the widest string
587 wChoice += 5*GetCharWidth();
2bda0e17 588
1d13cc5d
RD
589 wxSize best(wChoice, EDIT_HEIGHT_FROM_CHAR_HEIGHT(GetCharHeight()));
590 CacheBestSize(best);
591 return best;
2bda0e17
KB
592}
593
c140b7e7 594WXLRESULT wxChoice::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
2bda0e17 595{
f499e614 596 switch ( nMsg )
2bda0e17 597 {
f499e614
VZ
598 case WM_LBUTTONUP:
599 {
600 int x = (int)LOWORD(lParam);
601 int y = (int)HIWORD(lParam);
602
603 // Ok, this is truly weird, but if a panel with a wxChoice
604 // loses the focus, then you get a *fake* WM_LBUTTONUP message
605 // with x = 65535 and y = 65535. Filter out this nonsense.
606 //
607 // VZ: I'd like to know how to reproduce this please...
608 if ( x == 65535 && y == 65535 )
609 return 0;
610 }
611 break;
612
613 // we have to handle both: one for the normal case and the other
614 // for readonly
615 case WM_CTLCOLOREDIT:
616 case WM_CTLCOLORLISTBOX:
617 case WM_CTLCOLORSTATIC:
618 {
f499e614
VZ
619 WXHDC hdc;
620 WXHWND hwnd;
9f368d0d 621 UnpackCtlColor(wParam, lParam, &hdc, &hwnd);
f499e614 622
2bae4332 623 WXHBRUSH hbr = MSWControlColor((WXHDC)hdc, hwnd);
48fa6bd3
VZ
624 if ( hbr )
625 return (WXLRESULT)hbr;
626 //else: fall through to default window proc
f499e614 627 }
2bda0e17
KB
628 }
629
8d99be5f 630 return wxWindow::MSWWindowProc(nMsg, wParam, lParam);
2bda0e17
KB
631}
632
8d99be5f 633bool wxChoice::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
2bda0e17 634{
6ba93d23 635 switch ( param )
2bda0e17 636 {
6ba93d23
VZ
637 case CBN_DROPDOWN:
638 // we don't want to track selection using CB_GETCURSEL while the
639 // dropdown is opened
640 m_lastAcceptedSelection = GetCurrentSelection();
641 break;
2bda0e17 642
6ba93d23
VZ
643 case CBN_CLOSEUP:
644 // it should be safe to use CB_GETCURSEL again
645 m_lastAcceptedSelection = wxID_NONE;
646 break;
647
648 case CBN_SELCHANGE:
649 {
650 const int n = GetSelection();
651
652 wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, m_windowId);
653 event.SetInt(n);
654 event.SetEventObject(this);
655
656 if ( n > -1 )
657 {
658 event.SetString(GetStringSelection());
659 if ( HasClientObjectData() )
660 event.SetClientObject( GetClientObject(n) );
661 else if ( HasClientUntypedData() )
662 event.SetClientData( GetClientData(n) );
663 }
664
665 ProcessCommand(event);
666 }
667 return true;
8c1c5302 668 }
2bda0e17 669
6ba93d23 670 return false;
8d99be5f 671}
2bda0e17 672
2bae4332 673WXHBRUSH wxChoice::MSWControlColor(WXHDC hDC, WXHWND hWnd)
f6bcfd97 674{
48fa6bd3
VZ
675 if ( !IsEnabled() )
676 return MSWControlColorDisabled(hDC);
f6bcfd97 677
2bae4332 678 return wxChoiceBase::MSWControlColor(hDC, hWnd);
f6bcfd97
BP
679}
680
3180bc0e 681#endif // wxUSE_CHOICE && !(__SMARTPHONE__ && __WXWINCE__)
48fa6bd3 682