]> git.saurik.com Git - wxWidgets.git/blame - src/msw/combobox.cpp
Clear is also expected to clear the text
[wxWidgets.git] / src / msw / combobox.cpp
CommitLineData
2bda0e17 1/////////////////////////////////////////////////////////////////////////////
8e25c198 2// Name: src/msw/combobox.cpp
2bda0e17
KB
3// Purpose: wxComboBox class
4// Author: Julian Smart
5// Modified by:
6// Created: 01/02/97
7// RCS-ID: $Id$
6c9a19aa 8// Copyright: (c) Julian Smart
65571936 9// Licence: wxWindows licence
2bda0e17
KB
10/////////////////////////////////////////////////////////////////////////////
11
f6bcfd97
BP
12// ============================================================================
13// declarations
14// ============================================================================
15
16// ----------------------------------------------------------------------------
17// headers
18// ----------------------------------------------------------------------------
19
2bda0e17
KB
20// For compilers that support precompilation, includes "wx.h".
21#include "wx/wxprec.h"
22
23#ifdef __BORLANDC__
fddfd9e1 24 #pragma hdrstop
2bda0e17
KB
25#endif
26
af79c52d
VZ
27#if wxUSE_COMBOBOX
28
670f9935
WS
29#include "wx/combobox.h"
30
2bda0e17 31#ifndef WX_PRECOMP
57bd4c60 32 #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
fddfd9e1
VZ
33 #include "wx/settings.h"
34 #include "wx/log.h"
ce7fe42e 35 // for wxEVT_TEXT_ENTER
2b5f62a0 36 #include "wx/textctrl.h"
670f9935 37 #include "wx/app.h"
c64755ed 38 #include "wx/brush.h"
2bda0e17
KB
39#endif
40
2bda0e17 41#include "wx/clipbrd.h"
428f8b06 42#include "wx/wupdlock.h"
2bda0e17
KB
43#include "wx/msw/private.h"
44
63f7d502
VZ
45#if wxUSE_UXTHEME
46 #include "wx/msw/uxtheme.h"
47#endif
48
f6bcfd97 49#if wxUSE_TOOLTIPS
f6bcfd97
BP
50 #include "wx/tooltip.h"
51#endif // wxUSE_TOOLTIPS
52
53// ----------------------------------------------------------------------------
54// wxWin macros
55// ----------------------------------------------------------------------------
56
150e31d2
JS
57BEGIN_EVENT_TABLE(wxComboBox, wxControl)
58 EVT_MENU(wxID_CUT, wxComboBox::OnCut)
59 EVT_MENU(wxID_COPY, wxComboBox::OnCopy)
60 EVT_MENU(wxID_PASTE, wxComboBox::OnPaste)
61 EVT_MENU(wxID_UNDO, wxComboBox::OnUndo)
62 EVT_MENU(wxID_REDO, wxComboBox::OnRedo)
63 EVT_MENU(wxID_CLEAR, wxComboBox::OnDelete)
64 EVT_MENU(wxID_SELECTALL, wxComboBox::OnSelectAll)
65
66 EVT_UPDATE_UI(wxID_CUT, wxComboBox::OnUpdateCut)
67 EVT_UPDATE_UI(wxID_COPY, wxComboBox::OnUpdateCopy)
68 EVT_UPDATE_UI(wxID_PASTE, wxComboBox::OnUpdatePaste)
69 EVT_UPDATE_UI(wxID_UNDO, wxComboBox::OnUpdateUndo)
70 EVT_UPDATE_UI(wxID_REDO, wxComboBox::OnUpdateRedo)
71 EVT_UPDATE_UI(wxID_CLEAR, wxComboBox::OnUpdateDelete)
72 EVT_UPDATE_UI(wxID_SELECTALL, wxComboBox::OnUpdateSelectAll)
73END_EVENT_TABLE()
74
f6bcfd97
BP
75// ----------------------------------------------------------------------------
76// function prototypes
77// ----------------------------------------------------------------------------
78
79LRESULT APIENTRY _EXPORT wxComboEditWndProc(HWND hWnd,
80 UINT message,
81 WPARAM wParam,
82 LPARAM lParam);
83
84// ---------------------------------------------------------------------------
85// global vars
86// ---------------------------------------------------------------------------
87
88// the pointer to standard radio button wnd proc
975b6bcf 89static WNDPROC gs_wndprocEdit = (WNDPROC)NULL;
f6bcfd97
BP
90
91// ============================================================================
92// implementation
93// ============================================================================
94
75aaa4c5
VZ
95namespace
96{
97
98// Check if the given message should be forwarded from the edit control which
99// is part of the combobox to wxComboBox itself. All messages generating the
100// events that the code using wxComboBox could be interested in must be
101// forwarded.
102bool ShouldForwardFromEditToCombo(UINT message)
103{
104 switch ( message )
105 {
106 case WM_KEYUP:
107 case WM_KEYDOWN:
108 case WM_CHAR:
109 case WM_SYSCHAR:
110 case WM_SYSKEYDOWN:
111 case WM_SYSKEYUP:
112 case WM_SETFOCUS:
113 case WM_KILLFOCUS:
114 case WM_CUT:
115 case WM_COPY:
116 case WM_PASTE:
117 return true;
118 }
119
120 return false;
121}
122
123} // anonymous namespace
124
f6bcfd97
BP
125// ----------------------------------------------------------------------------
126// wnd proc for subclassed edit control
127// ----------------------------------------------------------------------------
128
129LRESULT APIENTRY _EXPORT wxComboEditWndProc(HWND hWnd,
130 UINT message,
131 WPARAM wParam,
132 LPARAM lParam)
133{
134 HWND hwndCombo = ::GetParent(hWnd);
135 wxWindow *win = wxFindWinFromHandle((WXHWND)hwndCombo);
136
75aaa4c5 137 if ( ShouldForwardFromEditToCombo(message) )
f6bcfd97 138 {
75aaa4c5
VZ
139 wxComboBox *combo = wxDynamicCast(win, wxComboBox);
140 if ( !combo )
141 {
142 // we can get WM_KILLFOCUS while our parent is already half
143 // destroyed and hence doesn't look like a combobx any
144 // longer, check for it to avoid bogus assert failures
145 if ( !win->IsBeingDeleted() )
f6bcfd97 146 {
75aaa4c5 147 wxFAIL_MSG( wxT("should have combo as parent") );
f6bcfd97 148 }
75aaa4c5
VZ
149 }
150 else if ( combo->MSWProcessEditMsg(message, wParam, lParam) )
151 {
152 // handled by parent
153 return 0;
154 }
155 }
156 else if ( message == WM_GETDLGCODE )
157 {
158 wxCHECK_MSG( win, 0, wxT("should have a parent") );
f6bcfd97 159
75aaa4c5
VZ
160 if ( win->GetWindowStyle() & wxTE_PROCESS_ENTER )
161 {
162 // need to return a custom dlg code or we'll never get it
163 return DLGC_WANTMESSAGE;
164 }
f6bcfd97
BP
165 }
166
167 return ::CallWindowProc(CASTWNDPROC gs_wndprocEdit, hWnd, message, wParam, lParam);
168}
169
f6bcfd97 170// ----------------------------------------------------------------------------
3a7d5f7c 171// wxComboBox callbacks
f6bcfd97
BP
172// ----------------------------------------------------------------------------
173
c140b7e7 174WXLRESULT wxComboBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
3a7d5f7c 175{
5301d1f7
VZ
176 // TODO: handle WM_CTLCOLOR messages from our EDIT control to be able to
177 // set its colour correctly (to be the same as our own one)
682214d5 178
3a7d5f7c
VZ
179 switch ( nMsg )
180 {
682214d5 181 case WM_SIZE:
3bce55ac
JS
182 // wxStaticBox can generate this message, when modifying the control's style.
183 // This causes the content of the combobox to be selected, for some reason.
184 case WM_STYLECHANGED:
5301d1f7
VZ
185 {
186 // combobox selection sometimes spontaneously changes when its
187 // size changes, restore it to the old value if necessary
e9717bd5
VZ
188 if ( !GetEditHWNDIfAvailable() )
189 break;
190
5301d1f7
VZ
191 long fromOld, toOld;
192 GetSelection(&fromOld, &toOld);
428f8b06
VZ
193
194 // if an editable combobox has a not empty text not from the
195 // list, it tries to autocomplete it from the list when it is
196 // resized, but we don't want this to happen as it doesn't seem
197 // to make any sense, so we forcefully restore the old text
198 wxString textOld;
199 if ( !HasFlag(wxCB_READONLY) && GetCurrentSelection() == -1 )
200 textOld = GetValue();
201
202 // eliminate flickering during following hacks
203 wxWindowUpdateLocker lock(this);
204
5301d1f7 205 WXLRESULT result = wxChoice::MSWWindowProc(nMsg, wParam, lParam);
682214d5 206
428f8b06
VZ
207 if ( !textOld.empty() && GetValue() != textOld )
208 SetLabel(textOld);
209
5301d1f7
VZ
210 long fromNew, toNew;
211 GetSelection(&fromNew, &toNew);
682214d5 212
5301d1f7
VZ
213 if ( fromOld != fromNew || toOld != toNew )
214 {
215 SetSelection(fromOld, toOld);
216 }
682214d5 217
5301d1f7
VZ
218 return result;
219 }
3a7d5f7c
VZ
220 }
221
5301d1f7 222 return wxChoice::MSWWindowProc(nMsg, wParam, lParam);
3a7d5f7c
VZ
223}
224
f6bcfd97
BP
225bool wxComboBox::MSWProcessEditMsg(WXUINT msg, WXWPARAM wParam, WXLPARAM lParam)
226{
227 switch ( msg )
228 {
229 case WM_CHAR:
2b5f62a0
VZ
230 // for compatibility with wxTextCtrl, generate a special message
231 // when Enter is pressed
232 if ( wParam == VK_RETURN )
233 {
a2634d81
RR
234 if (SendMessage(GetHwnd(), CB_GETDROPPEDSTATE, 0, 0))
235 return false;
f4322df6 236
ce7fe42e 237 wxCommandEvent event(wxEVT_TEXT_ENTER, m_windowId);
593ac33e
VZ
238
239 const int sel = GetSelection();
240 event.SetInt(sel);
2b5f62a0 241 event.SetString(GetValue());
593ac33e
VZ
242 InitCommandEventWithItems(event, sel);
243
ffb1629f
VZ
244 if ( ProcessCommand(event) )
245 {
246 // don't let the event through to the native control
247 // because it doesn't need it and may generate an annoying
248 // beep if it gets it
249 return true;
250 }
2b5f62a0 251 }
75aaa4c5 252 // fall through, WM_CHAR is one of the message we should forward.
2b5f62a0 253
75aaa4c5
VZ
254 default:
255 if ( ShouldForwardFromEditToCombo(msg) )
256 {
257 // For all the messages forward from the edit control the
258 // result is not used.
259 WXLRESULT result;
260 return MSWHandleMessage(&result, msg, wParam, lParam);
261 }
f6bcfd97
BP
262 }
263
02b7b6b0 264 return false;
f6bcfd97
BP
265}
266
6ba93d23 267bool wxComboBox::MSWCommand(WXUINT param, WXWORD id)
2bda0e17 268{
fddfd9e1 269 int sel = -1;
7d90194c
VZ
270 wxString value;
271
cd0b1709 272 switch ( param )
8c1c5302 273 {
ae3b1487
VZ
274 case CBN_DROPDOWN:
275 // remember the last selection, just as wxChoice does
276 m_lastAcceptedSelection = GetCurrentSelection();
8933fbc6 277 {
ce7fe42e 278 wxCommandEvent event(wxEVT_COMBOBOX_DROPDOWN, GetId());
8933fbc6
VZ
279 event.SetEventObject(this);
280 ProcessCommand(event);
281 }
282 break;
65676a28 283
8933fbc6 284 case CBN_CLOSEUP:
65676a28
VZ
285 // Do the same thing as in wxChoice but using different event type.
286 if ( m_pendingSelection != wxID_NONE )
287 {
ce7fe42e 288 SendSelectionChangedEvent(wxEVT_COMBOBOX);
65676a28
VZ
289 m_pendingSelection = wxID_NONE;
290 }
8933fbc6 291 {
ce7fe42e 292 wxCommandEvent event(wxEVT_COMBOBOX_CLOSEUP, GetId());
8933fbc6
VZ
293 event.SetEventObject(this);
294 ProcessCommand(event);
295 }
ae3b1487 296 break;
65676a28 297
78a87a5d 298 case CBN_SELENDOK:
8e25c198 299#ifndef __SMARTPHONE__
7d90194c
VZ
300 // we need to reset this to prevent the selection from being undone
301 // by wxChoice, see wxChoice::MSWCommand() and comments there
302 m_lastAcceptedSelection = wxID_NONE;
8e25c198 303#endif
13bcc348 304
7d90194c
VZ
305 // set these variables so that they could be also fixed in
306 // CBN_EDITCHANGE below
307 sel = GetSelection();
f5a45ee2 308 value = GetStringSelection();
d0b6344d
VZ
309
310 // this string is going to become the new combobox value soon but
311 // we need it to be done right now, otherwise the event handler
312 // could get a wrong value when it calls our GetValue()
017dc06b 313 ::SetWindowText(GetHwnd(), value.t_str());
d0b6344d 314
ce7fe42e 315 SendSelectionChangedEvent(wxEVT_COMBOBOX);
fddfd9e1 316
7bc74071 317 // fall through: for compatibility with wxGTK, also send the text
fddfd9e1
VZ
318 // update event when the selection changes (this also seems more
319 // logical as the text does change)
29006414 320
cd0b1709 321 case CBN_EDITCHANGE:
b7bfef38 322 if ( m_allowTextEvents )
cd0b1709 323 {
ce7fe42e 324 wxCommandEvent event(wxEVT_TEXT, GetId());
3adc70bf 325
7d90194c 326 // if sel != -1, value was already initialized above
7ba166dd 327 if ( sel == -1 )
3adc70bf 328 {
7d90194c 329 value = wxGetWindowText(GetHwnd());
3adc70bf
VZ
330 }
331
7d90194c 332 event.SetString(value);
593ac33e
VZ
333 InitCommandEventWithItems(event, sel);
334
0ef2ebba 335 ProcessCommand(event);
cd0b1709
VZ
336 }
337 break;
6ba93d23
VZ
338
339 default:
340 return wxChoice::MSWCommand(param, id);
cd0b1709 341 }
29006414 342
7d90194c 343 // skip wxChoice version as it would generate its own events for
ae3b1487 344 // CBN_SELENDOK and also interfere with our handling of CBN_DROPDOWN
8cc5e8cf 345 return true;
2bda0e17
KB
346}
347
90ac8b50
RR
348bool wxComboBox::MSWShouldPreProcessMessage(WXMSG *pMsg)
349{
350 // prevent command accelerators from stealing editing
351 // hotkeys when we have the focus
352 if (wxIsCtrlDown())
353 {
354 WPARAM vkey = pMsg->wParam;
6b54668b 355
90ac8b50
RR
356 switch (vkey)
357 {
358 case 'C':
359 case 'V':
360 case 'X':
361 case VK_INSERT:
362 case VK_DELETE:
363 case VK_HOME:
364 case VK_END:
365 return false;
366 }
367 }
6b54668b 368
90ac8b50
RR
369 return wxChoice::MSWShouldPreProcessMessage(pMsg);
370}
371
e9717bd5
VZ
372WXHWND wxComboBox::GetEditHWNDIfAvailable() const
373{
1b6010d8
VZ
374 // FIXME-VC6: Only VC6 needs this guard, see WINVER definition in
375 // include/wx/msw/wrapwin.h
376#if defined(WINVER) && WINVER >= 0x0500
df74e2d2
VZ
377 WinStruct<COMBOBOXINFO> info;
378 if ( MSWGetComboBoxInfo(&info) )
e558f953 379 return info.hwndItem;
1b6010d8 380#endif // WINVER >= 0x0500
e558f953
JS
381
382 if (HasFlag(wxCB_SIMPLE))
383 {
384 POINT pt;
385 pt.x = pt.y = 4;
386 return (WXHWND) ::ChildWindowFromPoint(GetHwnd(), pt);
387 }
fe56156f 388
1690c2ce
JS
389 // notice that a slightly safer alternative could be to use FindWindowEx()
390 // but it's not available under WinCE so just take the first child for now
391 // to keep one version of the code for all platforms and fix it later if
392 // problems are discovered
393
74052fe8
VZ
394 // we assume that the only child of the combobox is the edit window
395 return (WXHWND)::GetWindow(GetHwnd(), GW_CHILD);
e9717bd5
VZ
396}
397
f6bcfd97
BP
398WXHWND wxComboBox::GetEditHWND() const
399{
400 // this function should not be called for wxCB_READONLY controls, it is
e9717bd5 401 // the callers responsibility to check this
fa2f57be 402 wxASSERT_MSG( !HasFlag(wxCB_READONLY),
9a83f860 403 wxT("read-only combobox doesn't have any edit control") );
f6bcfd97 404
e9717bd5 405 WXHWND hWndEdit = GetEditHWNDIfAvailable();
9a83f860 406 wxASSERT_MSG( hWndEdit, wxT("combobox without edit control?") );
f6bcfd97 407
e9717bd5 408 return hWndEdit;
f6bcfd97
BP
409}
410
63f7d502
VZ
411wxWindow *wxComboBox::GetEditableWindow()
412{
413 wxASSERT_MSG( !HasFlag(wxCB_READONLY),
9a83f860 414 wxT("read-only combobox doesn't have any edit control") );
63f7d502
VZ
415
416 return this;
417}
418
71e57cd6
VZ
419// ----------------------------------------------------------------------------
420// wxComboBox creation
421// ----------------------------------------------------------------------------
422
debe6624 423bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
c085e333
VZ
424 const wxString& value,
425 const wxPoint& pos,
426 const wxSize& size,
427 int n, const wxString choices[],
428 long style,
429 const wxValidator& validator,
430 const wxString& name)
2bda0e17 431{
bdf5c30d
VZ
432 // pretend that wxComboBox is hidden while it is positioned and resized and
433 // show it only right before leaving this method because otherwise there is
434 // some noticeable flicker while the control rearranges itself
02b7b6b0 435 m_isShown = false;
bdf5c30d 436
71e57cd6
VZ
437 if ( !CreateAndInit(parent, id, pos, size, n, choices, style,
438 validator, name) )
02b7b6b0 439 return false;
f6bcfd97 440
6341d824
VZ
441 // we shouldn't call SetValue() for an empty string because this would
442 // (correctly) result in an assert with a read only combobox and is useless
443 // for the other ones anyhow
444 if ( !value.empty() )
b9b8a2b5 445 SetValue(value);
db34b147 446
f6bcfd97
BP
447 // a (not read only) combobox is, in fact, 2 controls: the combobox itself
448 // and an edit control inside it and if we want to catch events from this
449 // edit control, we must subclass it as well
450 if ( !(style & wxCB_READONLY) )
451 {
94972183 452 gs_wndprocEdit = wxSetWindowProc((HWND)GetEditHWND(), wxComboEditWndProc);
f6bcfd97 453 }
2bda0e17 454
bdf5c30d 455 // and finally, show the control
02b7b6b0 456 Show(true);
bdf5c30d 457
02b7b6b0 458 return true;
2bda0e17
KB
459}
460
584ad2a3
MB
461bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
462 const wxString& value,
463 const wxPoint& pos,
464 const wxSize& size,
465 const wxArrayString& choices,
466 long style,
467 const wxValidator& validator,
468 const wxString& name)
469{
470 wxCArrayString chs(choices);
471 return Create(parent, id, value, pos, size, chs.GetCount(),
472 chs.GetStrings(), style, validator, name);
473}
474
71e57cd6
VZ
475WXDWORD wxComboBox::MSWGetStyle(long style, WXDWORD *exstyle) const
476{
477 // we never have an external border
478 WXDWORD msStyle = wxChoice::MSWGetStyle
479 (
480 (style & ~wxBORDER_MASK) | wxBORDER_NONE, exstyle
481 );
482
1dfd425a
VZ
483 // usually WS_TABSTOP is added by wxControl::MSWGetStyle() but as we're
484 // created hidden (see Create() above), it is not done for us but we still
485 // want to have this style
486 msStyle |= WS_TABSTOP;
487
71e57cd6
VZ
488 // remove the style always added by wxChoice
489 msStyle &= ~CBS_DROPDOWNLIST;
490
491 if ( style & wxCB_READONLY )
492 msStyle |= CBS_DROPDOWNLIST;
493#ifndef __WXWINCE__
494 else if ( style & wxCB_SIMPLE )
495 msStyle |= CBS_SIMPLE; // A list (shown always) and edit control
496#endif
497 else
498 msStyle |= CBS_DROPDOWN;
499
500 // there is no reason to not always use CBS_AUTOHSCROLL, so do use it
501 msStyle |= CBS_AUTOHSCROLL;
502
503 // NB: we used to also add CBS_NOINTEGRALHEIGHT here but why?
504
505 return msStyle;
506}
507
508// ----------------------------------------------------------------------------
509// wxComboBox text control-like methods
510// ----------------------------------------------------------------------------
511
e9717bd5
VZ
512wxString wxComboBox::GetValue() const
513{
514 return HasFlag(wxCB_READONLY) ? GetStringSelection()
515 : wxTextEntry::GetValue();
516}
517
2bda0e17
KB
518void wxComboBox::SetValue(const wxString& value)
519{
2b5f62a0
VZ
520 if ( HasFlag(wxCB_READONLY) )
521 SetStringSelection(value);
b38f3ff3 522 else
fa2f57be 523 wxTextEntry::SetValue(value);
150e31d2
JS
524}
525
e6a84162
VZ
526void wxComboBox::Clear()
527{
528 wxChoice::Clear();
529 if ( !HasFlag(wxCB_READONLY) )
530 wxTextEntry::Clear();
531}
532
5ddb3b8c
VZ
533bool wxComboBox::ContainsHWND(WXHWND hWnd) const
534{
535 return hWnd == GetEditHWNDIfAvailable();
536}
537
e9717bd5
VZ
538void wxComboBox::GetSelection(long *from, long *to) const
539{
540 if ( !HasFlag(wxCB_READONLY) )
541 {
542 wxTextEntry::GetSelection(from, to);
543 }
544 else // text selection doesn't make sense for read only comboboxes
545 {
546 if ( from )
547 *from = -1;
548 if ( to )
549 *to = -1;
550 }
551}
552
150e31d2
JS
553bool wxComboBox::IsEditable() const
554{
fa2f57be 555 return !HasFlag(wxCB_READONLY) && wxTextEntry::IsEditable();
3f5ca6b1
RN
556}
557
150e31d2
JS
558// ----------------------------------------------------------------------------
559// standard event handling
560// ----------------------------------------------------------------------------
561
562void wxComboBox::OnCut(wxCommandEvent& WXUNUSED(event))
563{
564 Cut();
565}
566
567void wxComboBox::OnCopy(wxCommandEvent& WXUNUSED(event))
568{
569 Copy();
570}
571
572void wxComboBox::OnPaste(wxCommandEvent& WXUNUSED(event))
573{
574 Paste();
575}
576
577void wxComboBox::OnUndo(wxCommandEvent& WXUNUSED(event))
578{
579 Undo();
580}
581
582void wxComboBox::OnRedo(wxCommandEvent& WXUNUSED(event))
583{
584 Redo();
585}
586
587void wxComboBox::OnDelete(wxCommandEvent& WXUNUSED(event))
588{
5a25f858 589 RemoveSelection();
150e31d2
JS
590}
591
592void wxComboBox::OnSelectAll(wxCommandEvent& WXUNUSED(event))
593{
e976429d 594 SelectAll();
150e31d2
JS
595}
596
597void wxComboBox::OnUpdateCut(wxUpdateUIEvent& event)
598{
599 event.Enable( CanCut() );
600}
601
602void wxComboBox::OnUpdateCopy(wxUpdateUIEvent& event)
603{
604 event.Enable( CanCopy() );
605}
606
607void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)
608{
609 event.Enable( CanPaste() );
610}
611
612void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)
613{
c0e15042 614 event.Enable( IsEditable() && CanUndo() );
150e31d2
JS
615}
616
617void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)
618{
c0e15042 619 event.Enable( IsEditable() && CanRedo() );
150e31d2
JS
620}
621
622void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)
623{
6b54668b 624 event.Enable(IsEditable() && HasSelection());
150e31d2
JS
625}
626
627void wxComboBox::OnUpdateSelectAll(wxUpdateUIEvent& event)
628{
e976429d 629 event.Enable(IsEditable() && !wxTextEntry::IsEmpty());
150e31d2
JS
630}
631
d6b9cc87
VZ
632#if wxUSE_TOOLTIPS
633
634void wxComboBox::DoSetToolTip(wxToolTip *tip)
635{
636 wxChoice::DoSetToolTip(tip);
637
638 if ( tip && !HasFlag(wxCB_READONLY) )
f7dd07f6 639 tip->AddOtherWindow(GetEditHWND());
d6b9cc87
VZ
640}
641
642#endif // wxUSE_TOOLTIPS
643
63f7d502
VZ
644#if wxUSE_UXTHEME
645
646bool wxComboBox::SetHint(const wxString& hintOrig)
647{
648 wxString hint(hintOrig);
649 if ( wxUxThemeEngine::GetIfActive() )
650 {
651 // under XP (but not Vista) there is a bug in cue banners
652 // implementation for combobox edit control: the first character is
653 // partially chopped off, so prepend a space to make it fully visible
654 hint.insert(0, " ");
655 }
656
657 return wxTextEntry::SetHint(hint);
658}
659
660#endif // wxUSE_UXTHEME
661
aa24f946
VZ
662wxSize wxComboBox::DoGetSizeFromTextSize(int xlen, int ylen) const
663{
664 wxSize tsize( wxChoice::DoGetSizeFromTextSize(xlen, ylen) );
665
666 if ( !HasFlag(wxCB_READONLY) )
667 {
668 // Add the margins we have previously set
669 wxPoint marg( GetMargins() );
670 marg.x = wxMax(0, marg.x);
671 marg.y = wxMax(0, marg.y);
672 tsize.IncBy( marg );
673 }
674
675 return tsize;
676}
677
71e57cd6 678#endif // wxUSE_COMBOBOX