]> git.saurik.com Git - wxWidgets.git/blame - src/msw/choice.cpp
Resets scroll position on load
[wxWidgets.git] / src / msw / choice.cpp
CommitLineData
2bda0e17 1/////////////////////////////////////////////////////////////////////////////
11e62fe6 2// Name: src/msw/choice.cpp
2bda0e17
KB
3// Purpose: wxChoice
4// Author: Julian Smart
8d99be5f 5// Modified by: Vadim Zeitlin to derive from wxChoiceBase
2bda0e17
KB
6// Created: 04/01/98
7// RCS-ID: $Id$
6c9a19aa 8// Copyright: (c) Julian Smart
65571936 9// Licence: wxWindows licence
2bda0e17
KB
10/////////////////////////////////////////////////////////////////////////////
11
8d99be5f
VZ
12// ============================================================================
13// declarations
14// ============================================================================
15
16// ----------------------------------------------------------------------------
17// headers
18// ----------------------------------------------------------------------------
19
2bda0e17
KB
20// For compilers that support precompilation, includes "wx.h".
21#include "wx/wxprec.h"
22
23#ifdef __BORLANDC__
8d99be5f 24 #pragma hdrstop
2bda0e17
KB
25#endif
26
3180bc0e 27#if wxUSE_CHOICE && !(defined(__SMARTPHONE__) && defined(__WXWINCE__))
1e6feb95 28
2bda0e17 29#ifndef WX_PRECOMP
8d99be5f
VZ
30 #include "wx/choice.h"
31 #include "wx/utils.h"
32 #include "wx/log.h"
f6bcfd97 33 #include "wx/brush.h"
c7401637 34 #include "wx/settings.h"
2bda0e17
KB
35#endif
36
37#include "wx/msw/private.h"
38
6a89f9ee 39#if wxUSE_EXTENDED_RTTI
bc9fb572
JS
40WX_DEFINE_FLAGS( wxChoiceStyle )
41
3ff066a4 42wxBEGIN_FLAGS( wxChoiceStyle )
bc9fb572
JS
43 // new style border flags, we put them first to
44 // use them for streaming out
3ff066a4
SC
45 wxFLAGS_MEMBER(wxBORDER_SIMPLE)
46 wxFLAGS_MEMBER(wxBORDER_SUNKEN)
47 wxFLAGS_MEMBER(wxBORDER_DOUBLE)
48 wxFLAGS_MEMBER(wxBORDER_RAISED)
49 wxFLAGS_MEMBER(wxBORDER_STATIC)
50 wxFLAGS_MEMBER(wxBORDER_NONE)
3dfb79a6 51
bc9fb572 52 // old style border flags
3ff066a4
SC
53 wxFLAGS_MEMBER(wxSIMPLE_BORDER)
54 wxFLAGS_MEMBER(wxSUNKEN_BORDER)
55 wxFLAGS_MEMBER(wxDOUBLE_BORDER)
56 wxFLAGS_MEMBER(wxRAISED_BORDER)
57 wxFLAGS_MEMBER(wxSTATIC_BORDER)
cb0afb26 58 wxFLAGS_MEMBER(wxBORDER)
bc9fb572
JS
59
60 // standard window styles
3ff066a4
SC
61 wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
62 wxFLAGS_MEMBER(wxCLIP_CHILDREN)
63 wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
64 wxFLAGS_MEMBER(wxWANTS_CHARS)
cb0afb26 65 wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
3ff066a4
SC
66 wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
67 wxFLAGS_MEMBER(wxVSCROLL)
68 wxFLAGS_MEMBER(wxHSCROLL)
bc9fb572 69
3ff066a4 70wxEND_FLAGS( wxChoiceStyle )
bc9fb572
JS
71
72IMPLEMENT_DYNAMIC_CLASS_XTI(wxChoice, wxControl,"wx/choice.h")
6a89f9ee 73
3ff066a4 74wxBEGIN_PROPERTIES_TABLE(wxChoice)
3dfb79a6 75 wxEVENT_PROPERTY( Select , wxEVT_COMMAND_CHOICE_SELECTED , wxCommandEvent )
c5ca409b 76
af498247 77 wxPROPERTY( Font , wxFont , SetFont , GetFont , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
3ff066a4 78 wxPROPERTY_COLLECTION( Choices , wxArrayString , wxString , AppendString , GetStrings , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
3dfb79a6 79 wxPROPERTY( Selection ,int, SetSelection, GetSelection, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
af498247 80 wxPROPERTY_FLAGS( WindowStyle , wxChoiceStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
3ff066a4 81wxEND_PROPERTIES_TABLE()
6a89f9ee 82
3ff066a4
SC
83wxBEGIN_HANDLERS_TABLE(wxChoice)
84wxEND_HANDLERS_TABLE()
2bda0e17 85
3dfb79a6 86wxCONSTRUCTOR_4( wxChoice , wxWindow* , Parent , wxWindowID , Id , wxPoint , Position , wxSize , Size )
6a89f9ee
SC
87#else
88IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)
89#endif
066f1b7a 90/*
3dfb79a6
VZ
91 TODO PROPERTIES
92 selection (long)
93 content (list)
94 item
066f1b7a
SC
95*/
96
8d99be5f
VZ
97// ============================================================================
98// implementation
99// ============================================================================
100
101// ----------------------------------------------------------------------------
102// creation
103// ----------------------------------------------------------------------------
104
105bool wxChoice::Create(wxWindow *parent,
106 wxWindowID id,
107 const wxPoint& pos,
108 const wxSize& size,
109 int n, const wxString choices[],
110 long style,
111 const wxValidator& validator,
112 const wxString& name)
2bda0e17 113{
f6bcfd97 114 // Experience shows that wxChoice vs. wxComboBox distinction confuses
8d99be5f
VZ
115 // quite a few people - try to help them
116 wxASSERT_MSG( !(style & wxCB_DROPDOWN) &&
117 !(style & wxCB_READONLY) &&
118 !(style & wxCB_SIMPLE),
f6bcfd97
BP
119 _T("this style flag is ignored by wxChoice, you ")
120 _T("probably want to use a wxComboBox") );
2bda0e17 121
71e57cd6
VZ
122 return CreateAndInit(parent, id, pos, size, n, choices, style,
123 validator, name);
124}
125
cc61d2eb
VZ
126bool wxChoice::CreateAndInit(wxWindow *parent,
127 wxWindowID id,
71e57cd6 128 const wxPoint& pos,
3dfb79a6 129 const wxSize& size,
71e57cd6
VZ
130 int n, const wxString choices[],
131 long style,
132 const wxValidator& validator,
133 const wxString& name)
134{
135 // initialize wxControl
136 if ( !CreateControl(parent, id, pos, size, style, validator, name) )
02b7b6b0 137 return false;
2bda0e17 138
71e57cd6 139 // now create the real HWND
f31a4098 140 if ( !MSWCreateControl(wxT("COMBOBOX"), wxEmptyString, pos, size) )
02b7b6b0 141 return false;
71e57cd6
VZ
142
143
144 // choice/combobox normally has "white" (depends on colour scheme, of
145 // course) background rather than inheriting the parent's background
a756f210 146 SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));
c92d798f 147
cc61d2eb 148 // initialize the controls contents
8d99be5f
VZ
149 for ( int i = 0; i < n; i++ )
150 {
151 Append(choices[i]);
152 }
2bda0e17 153
cc61d2eb 154 // and now we may finally size the control properly (if needed)
3dfb79a6 155 SetBestSize(size);
cc61d2eb 156
02b7b6b0 157 return true;
2bda0e17
KB
158}
159
584ad2a3
MB
160bool wxChoice::Create(wxWindow *parent,
161 wxWindowID id,
162 const wxPoint& pos,
163 const wxSize& size,
164 const wxArrayString& choices,
165 long style,
166 const wxValidator& validator,
167 const wxString& name)
168{
169 wxCArrayString chs(choices);
170 return Create(parent, id, pos, size, chs.GetCount(), chs.GetStrings(),
171 style, validator, name);
172}
173
4b17d2e3
DS
174bool wxChoice::MSWShouldPreProcessMessage(WXMSG *pMsg)
175{
176 MSG *msg = (MSG *) pMsg;
177
dc302518
DS
178 // if the dropdown list is visible, don't preprocess certain keys
179 if ( msg->message == WM_KEYDOWN
180 && (msg->wParam == VK_ESCAPE || msg->wParam == VK_RETURN) )
4b17d2e3
DS
181 {
182 if (::SendMessage(GetHwndOf(this), CB_GETDROPPEDSTATE, 0, 0))
183 {
184 return false;
185 }
186 }
187
188 return wxControl::MSWShouldPreProcessMessage(pMsg);
189}
190
71e57cd6
VZ
191WXDWORD wxChoice::MSWGetStyle(long style, WXDWORD *exstyle) const
192{
193 // we never have an external border
194 WXDWORD msStyle = wxControl::MSWGetStyle
195 (
196 (style & ~wxBORDER_MASK) | wxBORDER_NONE, exstyle
197 );
198
199 // WS_CLIPSIBLINGS is useful with wxChoice and doesn't seem to result in
200 // any problems
201 msStyle |= WS_CLIPSIBLINGS;
202
203 // wxChoice-specific styles
204 msStyle |= CBS_DROPDOWNLIST | WS_HSCROLL | WS_VSCROLL;
205 if ( style & wxCB_SORT )
206 msStyle |= CBS_SORT;
207
208 return msStyle;
209}
210
8ee9d618
VZ
211wxChoice::~wxChoice()
212{
213 Free();
214}
215
8d99be5f
VZ
216// ----------------------------------------------------------------------------
217// adding/deleting items to/from the list
218// ----------------------------------------------------------------------------
2bda0e17 219
def6fb9b 220int wxChoice::DoAppend(const wxString& item)
8d99be5f 221{
c140b7e7 222 int n = (int)SendMessage(GetHwnd(), CB_ADDSTRING, 0, (LPARAM)item.c_str());
def6fb9b
VZ
223 if ( n == CB_ERR )
224 {
f6bcfd97 225 wxLogLastError(wxT("SendMessage(CB_ADDSTRING)"));
def6fb9b 226 }
71e57cd6
VZ
227 else // ok
228 {
229 // we need to refresh our size in order to have enough space for the
230 // newly added items
e0e3a32d
VZ
231 if ( !IsFrozen() )
232 UpdateVisibleHeight();
71e57cd6 233 }
def6fb9b 234
31582e4e 235 InvalidateBestSize();
def6fb9b 236 return n;
2bda0e17
KB
237}
238
243dbf1a
VZ
239int wxChoice::DoInsert(const wxString& item, int pos)
240{
241 wxCHECK_MSG(!(GetWindowStyle() & wxCB_SORT), -1, wxT("can't insert into sorted list"));
242 wxCHECK_MSG((pos>=0) && (pos<=GetCount()), -1, wxT("invalid index"));
243
c140b7e7 244 int n = (int)SendMessage(GetHwnd(), CB_INSERTSTRING, pos, (LPARAM)item.c_str());
243dbf1a
VZ
245 if ( n == CB_ERR )
246 {
247 wxLogLastError(wxT("SendMessage(CB_INSERTSTRING)"));
248 }
71e57cd6
VZ
249 else // ok
250 {
e0e3a32d
VZ
251 if ( !IsFrozen() )
252 UpdateVisibleHeight();
71e57cd6 253 }
243dbf1a 254
31582e4e 255 InvalidateBestSize();
243dbf1a
VZ
256 return n;
257}
258
debe6624 259void wxChoice::Delete(int n)
2bda0e17 260{
223d09f6 261 wxCHECK_RET( n < GetCount(), wxT("invalid item index in wxChoice::Delete") );
8d99be5f 262
6c8a980f
VZ
263 if ( HasClientObjectData() )
264 {
265 delete GetClientObject(n);
266 }
267
8d99be5f 268 SendMessage(GetHwnd(), CB_DELETESTRING, n, 0);
71e57cd6 269
e0e3a32d
VZ
270 if ( !IsFrozen() )
271 UpdateVisibleHeight();
31582e4e
RD
272
273 InvalidateBestSize();
2bda0e17
KB
274}
275
8d99be5f 276void wxChoice::Clear()
8ee9d618 277{
92d2389e 278 Free();
8ee9d618
VZ
279
280 SendMessage(GetHwnd(), CB_RESETCONTENT, 0, 0);
71e57cd6 281
e0e3a32d
VZ
282 if ( !IsFrozen() )
283 UpdateVisibleHeight();
31582e4e
RD
284
285 InvalidateBestSize();
8ee9d618
VZ
286}
287
288void wxChoice::Free()
2bda0e17 289{
6c8a980f
VZ
290 if ( HasClientObjectData() )
291 {
292 size_t count = GetCount();
293 for ( size_t n = 0; n < count; n++ )
294 {
295 delete GetClientObject(n);
296 }
297 }
2bda0e17
KB
298}
299
8d99be5f
VZ
300// ----------------------------------------------------------------------------
301// selection
302// ----------------------------------------------------------------------------
2bda0e17 303
8d99be5f 304int wxChoice::GetSelection() const
6ba93d23
VZ
305{
306 // if m_lastAcceptedSelection is set, it means that the dropdown is
307 // currently shown and that we want to use the last "permanent" selection
308 // instead of whatever is under the mouse pointer currently
309 //
310 // otherwise, get the selection from the control
311 return m_lastAcceptedSelection == wxID_NONE ? GetCurrentSelection()
312 : m_lastAcceptedSelection;
313}
314
315int wxChoice::GetCurrentSelection() const
2bda0e17 316{
8d99be5f 317 return (int)SendMessage(GetHwnd(), CB_GETCURSEL, 0, 0);
2bda0e17
KB
318}
319
debe6624 320void wxChoice::SetSelection(int n)
2bda0e17 321{
8d99be5f
VZ
322 SendMessage(GetHwnd(), CB_SETCURSEL, n, 0);
323}
324
325// ----------------------------------------------------------------------------
326// string list functions
327// ----------------------------------------------------------------------------
328
329int wxChoice::GetCount() const
330{
331 return (int)SendMessage(GetHwnd(), CB_GETCOUNT, 0, 0);
2bda0e17
KB
332}
333
11e62fe6 334int wxChoice::FindString(const wxString& s, bool bCase) const
2bda0e17
KB
335{
336#if defined(__WATCOMC__) && defined(__WIN386__)
8d99be5f
VZ
337 // For some reason, Watcom in WIN386 mode crashes in the CB_FINDSTRINGEXACT message.
338 // wxChoice::Do it the long way instead.
339 int count = GetCount();
340 for ( int i = 0; i < count; i++ )
341 {
342 // as CB_FINDSTRINGEXACT is case insensitive, be case insensitive too
11e62fe6 343 if ( GetString(i).IsSameAs(s, bCase) )
8d99be5f
VZ
344 return i;
345 }
346
347 return wxNOT_FOUND;
348#else // !Watcom
4cd1ed99
RN
349 //TODO: Evidently some MSW versions (all?) don't like empty strings
350 //passed to SendMessage, so we have to do it ourselves in that case
beedefb9 351 if ( s.empty() )
4cd1ed99 352 {
11e62fe6
WS
353 int count = GetCount();
354 for ( int i = 0; i < count; i++ )
355 {
356 if ( GetString(i).empty() )
357 return i;
358 }
359
360 return wxNOT_FOUND;
361 }
362 else if (bCase)
363 {
364 // back to base class search for not native search type
365 return wxItemContainerImmutable::FindString( s, bCase );
4cd1ed99
RN
366 }
367 else
368 {
11e62fe6
WS
369 int pos = (int)SendMessage(GetHwnd(), CB_FINDSTRINGEXACT,
370 (WPARAM)-1, (LPARAM)s.c_str());
f31a4098 371
11e62fe6 372 return pos == LB_ERR ? wxNOT_FOUND : pos;
4cd1ed99 373 }
8d99be5f 374#endif // Watcom/!Watcom
2bda0e17
KB
375}
376
b4bfa452 377void wxChoice::SetString(int n, const wxString& s)
6c8a980f 378{
2b5f62a0
VZ
379 wxCHECK_RET( n >= 0 && n < GetCount(),
380 wxT("invalid item index in wxChoice::SetString") );
381
382 // we have to delete and add back the string as there is no way to change a
383 // string in place
384
385 // we need to preserve the client data
386 void *data;
387 if ( m_clientDataItemsType != wxClientData_None )
388 {
389 data = DoGetItemClientData(n);
390 }
391 else // no client data
392 {
393 data = NULL;
394 }
395
396 ::SendMessage(GetHwnd(), CB_DELETESTRING, n, 0);
397 ::SendMessage(GetHwnd(), CB_INSERTSTRING, n, (LPARAM)s.c_str() );
398
399 if ( data )
400 {
401 DoSetItemClientData(n, data);
402 }
403 //else: it's already NULL by default
31582e4e
RD
404
405 InvalidateBestSize();
6c8a980f
VZ
406}
407
debe6624 408wxString wxChoice::GetString(int n) const
2bda0e17 409{
478cabab
VZ
410 int len = (int)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
411
6c8a980f 412 wxString str;
478cabab
VZ
413 if ( len != CB_ERR && len > 0 )
414 {
415 if ( ::SendMessage
416 (
417 GetHwnd(),
418 CB_GETLBTEXT,
419 n,
420 (LPARAM)(wxChar *)wxStringBuffer(str, len)
421 ) == CB_ERR )
422 {
f6bcfd97 423 wxLogLastError(wxT("SendMessage(CB_GETLBTEXT)"));
21d72d17 424 }
4438caf4 425 }
2bda0e17 426
4438caf4
VZ
427 return str;
428}
2bda0e17 429
8d99be5f
VZ
430// ----------------------------------------------------------------------------
431// client data
432// ----------------------------------------------------------------------------
433
6c8a980f 434void wxChoice::DoSetItemClientData( int n, void* clientData )
8d99be5f 435{
2b5f62a0
VZ
436 if ( ::SendMessage(GetHwnd(), CB_SETITEMDATA,
437 n, (LPARAM)clientData) == CB_ERR )
8d99be5f 438 {
223d09f6 439 wxLogLastError(wxT("CB_SETITEMDATA"));
8d99be5f
VZ
440 }
441}
442
6c8a980f 443void* wxChoice::DoGetItemClientData( int n ) const
8d99be5f
VZ
444{
445 LPARAM rc = SendMessage(GetHwnd(), CB_GETITEMDATA, n, 0);
446 if ( rc == CB_ERR )
447 {
223d09f6 448 wxLogLastError(wxT("CB_GETITEMDATA"));
8d99be5f
VZ
449
450 // unfortunately, there is no way to return an error code to the user
8ee9d618 451 rc = (LPARAM) NULL;
8d99be5f
VZ
452 }
453
454 return (void *)rc;
455}
456
6c8a980f 457void wxChoice::DoSetItemClientObject( int n, wxClientData* clientData )
8d99be5f 458{
6c8a980f 459 DoSetItemClientData(n, clientData);
8d99be5f
VZ
460}
461
6c8a980f 462wxClientData* wxChoice::DoGetItemClientObject( int n ) const
8d99be5f 463{
6c8a980f 464 return (wxClientData *)DoGetItemClientData(n);
8d99be5f
VZ
465}
466
467// ----------------------------------------------------------------------------
468// wxMSW specific helpers
469// ----------------------------------------------------------------------------
470
71e57cd6
VZ
471void wxChoice::UpdateVisibleHeight()
472{
e6968367 473 // be careful to not change the width here
02b7b6b0 474 DoSetSize(wxDefaultCoord, wxDefaultCoord, wxDefaultCoord, GetSize().y, wxSIZE_USE_EXISTING);
71e57cd6
VZ
475}
476
18c50997
VZ
477void wxChoice::DoMoveWindow(int x, int y, int width, int height)
478{
479 // here is why this is necessary: if the width is negative, the combobox
480 // window proc makes the window of the size width*height instead of
481 // interpreting height in the usual manner (meaning the height of the drop
482 // down list - usually the height specified in the call to MoveWindow()
483 // will not change the height of combo box per se)
484 //
485 // this behaviour is not documented anywhere, but this is just how it is
486 // here (NT 4.4) and, anyhow, the check shouldn't hurt - however without
487 // the check, constraints/sizers using combos may break the height
488 // constraint will have not at all the same value as expected
489 if ( width < 0 )
490 return;
491
492 wxControl::DoMoveWindow(x, y, width, height);
493}
494
d99957b6
VZ
495void wxChoice::DoGetSize(int *w, int *h) const
496{
94a77ff7
VZ
497 // this is weird: sometimes, the height returned by Windows is clearly the
498 // total height of the control including the drop down list -- but only
499 // sometimes, and normally it isn't... I have no idea about what to do with
500 // this
02b7b6b0 501 wxControl::DoGetSize(w, h);
d99957b6
VZ
502}
503
4438caf4 504void wxChoice::DoSetSize(int x, int y,
d99957b6 505 int width, int height,
4438caf4
VZ
506 int sizeFlags)
507{
d99957b6 508 int heightOrig = height;
a8e65eee 509
d99957b6
VZ
510 // the height which we must pass to Windows should be the total height of
511 // the control including the drop down list while the height given to us
512 // is, of course, just the height of the permanently visible part of it
02b7b6b0 513 if ( height != wxDefaultCoord )
d99957b6
VZ
514 {
515 // don't make the drop down list too tall, arbitrarily limit it to 40
516 // items max and also don't leave it empty
517 size_t nItems = GetCount();
518 if ( !nItems )
519 nItems = 9;
cb828946
RD
520 else if ( nItems > 24 )
521 nItems = 24;
d99957b6
VZ
522
523 // add space for the drop down list
524 const int hItem = SendMessage(GetHwnd(), CB_GETITEMHEIGHT, 0, 0);
525 height += hItem*(nItems + 1);
526 }
d6959d6f
DS
527 else
528 {
529 // We cannot pass wxDefaultCoord as height to wxControl. wxControl uses
f31a4098
WS
530 // wxGetWindowRect() to determine the current height of the combobox,
531 // and then again sets the combobox's height to that value. Unfortunately,
532 // wxGetWindowRect doesn't include the dropdown list's height (at least
533 // on Win2K), so this would result in a combobox with dropdown height of
d6959d6f
DS
534 // 1 pixel. We have to determine the default height ourselves and call
535 // wxControl with that value instead.
536 int w, h;
537 RECT r;
538 DoGetSize(&w, &h);
539 if (::SendMessage(GetHwnd(), CB_GETDROPPEDCONTROLRECT, 0, (LPARAM) &r) != 0)
540 {
f31a4098 541 height = h + r.bottom - r.top;
d6959d6f
DS
542 }
543 }
d99957b6
VZ
544
545 wxControl::DoSetSize(x, y, width, height, sizeFlags);
546
ef036883
JS
547 // I'm commenting this out since the code appears to make choices
548 // and comboxes too high when they have associated sizers. I'm sure this
549 // is not the end of the story, which is why I'm leaving it #if'ed out for
550 // now. JACS.
551#if 0
d99957b6
VZ
552 // if the height specified for the visible part of the control is
553 // different from the current one, we need to change it separately
554 // as it is not affected by normal WM_SETSIZE
02b7b6b0 555 if ( height != wxDefaultCoord )
d99957b6 556 {
94a77ff7
VZ
557 const int delta = heightOrig - GetSize().y;
558 if ( delta )
d99957b6 559 {
94a77ff7
VZ
560 int h = ::SendMessage(GetHwnd(), CB_GETITEMHEIGHT, (WPARAM)-1, 0);
561 SendMessage(GetHwnd(), CB_SETITEMHEIGHT, (WPARAM)-1, h + delta);
d99957b6
VZ
562 }
563 }
e69ba9cb
WS
564#else
565 wxUnusedVar(heightOrig);
ef036883 566#endif
4438caf4 567}
2bda0e17 568
882a8f40 569wxSize wxChoice::DoGetBestSize() const
4438caf4
VZ
570{
571 // find the widest string
4438caf4 572 int wChoice = 0;
d99957b6
VZ
573 const size_t nItems = GetCount();
574 for ( size_t i = 0; i < nItems; i++ )
2bda0e17 575 {
d99957b6
VZ
576 int wLine;
577 GetTextExtent(GetString(i), &wLine, NULL);
4438caf4
VZ
578 if ( wLine > wChoice )
579 wChoice = wLine;
2bda0e17 580 }
fd3f686c 581
4438caf4
VZ
582 // give it some reasonable default value if there are no strings in the
583 // list
584 if ( wChoice == 0 )
585 wChoice = 100;
2bda0e17 586
d99957b6
VZ
587 // the combobox should be slightly larger than the widest string
588 wChoice += 5*GetCharWidth();
2bda0e17 589
1d13cc5d
RD
590 wxSize best(wChoice, EDIT_HEIGHT_FROM_CHAR_HEIGHT(GetCharHeight()));
591 CacheBestSize(best);
592 return best;
2bda0e17
KB
593}
594
c140b7e7 595WXLRESULT wxChoice::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
2bda0e17 596{
f499e614 597 switch ( nMsg )
2bda0e17 598 {
f499e614
VZ
599 case WM_LBUTTONUP:
600 {
601 int x = (int)LOWORD(lParam);
602 int y = (int)HIWORD(lParam);
603
604 // Ok, this is truly weird, but if a panel with a wxChoice
605 // loses the focus, then you get a *fake* WM_LBUTTONUP message
606 // with x = 65535 and y = 65535. Filter out this nonsense.
607 //
608 // VZ: I'd like to know how to reproduce this please...
609 if ( x == 65535 && y == 65535 )
610 return 0;
611 }
612 break;
613
614 // we have to handle both: one for the normal case and the other
615 // for readonly
616 case WM_CTLCOLOREDIT:
617 case WM_CTLCOLORLISTBOX:
618 case WM_CTLCOLORSTATIC:
619 {
f499e614
VZ
620 WXHDC hdc;
621 WXHWND hwnd;
9f368d0d 622 UnpackCtlColor(wParam, lParam, &hdc, &hwnd);
f499e614 623
2bae4332 624 WXHBRUSH hbr = MSWControlColor((WXHDC)hdc, hwnd);
48fa6bd3
VZ
625 if ( hbr )
626 return (WXLRESULT)hbr;
627 //else: fall through to default window proc
f499e614 628 }
2bda0e17
KB
629 }
630
8d99be5f 631 return wxWindow::MSWWindowProc(nMsg, wParam, lParam);
2bda0e17
KB
632}
633
8d99be5f 634bool wxChoice::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
2bda0e17 635{
6ba93d23 636 switch ( param )
2bda0e17 637 {
6ba93d23
VZ
638 case CBN_DROPDOWN:
639 // we don't want to track selection using CB_GETCURSEL while the
640 // dropdown is opened
641 m_lastAcceptedSelection = GetCurrentSelection();
642 break;
2bda0e17 643
6ba93d23
VZ
644 case CBN_CLOSEUP:
645 // it should be safe to use CB_GETCURSEL again
646 m_lastAcceptedSelection = wxID_NONE;
647 break;
648
649 case CBN_SELCHANGE:
650 {
651 const int n = GetSelection();
652
653 wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, m_windowId);
654 event.SetInt(n);
655 event.SetEventObject(this);
656
657 if ( n > -1 )
658 {
659 event.SetString(GetStringSelection());
660 if ( HasClientObjectData() )
661 event.SetClientObject( GetClientObject(n) );
662 else if ( HasClientUntypedData() )
663 event.SetClientData( GetClientData(n) );
664 }
665
666 ProcessCommand(event);
667 }
668 return true;
8c1c5302 669 }
2bda0e17 670
6ba93d23 671 return false;
8d99be5f 672}
2bda0e17 673
2bae4332 674WXHBRUSH wxChoice::MSWControlColor(WXHDC hDC, WXHWND hWnd)
f6bcfd97 675{
48fa6bd3
VZ
676 if ( !IsEnabled() )
677 return MSWControlColorDisabled(hDC);
f6bcfd97 678
2bae4332 679 return wxChoiceBase::MSWControlColor(hDC, hWnd);
f6bcfd97
BP
680}
681
3180bc0e 682#endif // wxUSE_CHOICE && !(__SMARTPHONE__ && __WXWINCE__)