faster INCR doing far less allocation in common cases

diff --git a/src/t_string.c b/src/t_string.c
index 39ee506d5e9586851ad8bf603859ca2c0b2d15b7..cc6526fbe8b152327d84a0ce3dea902a49ed2b10 100644 (file)
--- a/src/t_string.c
+++ b/src/t_string.c
@@ -144,8 +144,23 @@ void incrDecrCommand(redisClient *c, long long incr) {
 
     o = lookupKeyWrite(c->db,c->argv[1]);
     if (o != NULL && checkType(c,o,REDIS_STRING)) return;
-    if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return;
 
+    /* Fast path if the object is integer encoded and is not shared. */
+    if (o && o->refcount == 1 && o->encoding == REDIS_ENCODING_INT) {
+        long long newval = ((long)o->ptr) + incr;
+
+        if (newval >= LONG_MIN && newval <= LONG_MAX) {
+            o->ptr = (void*) (long) newval;
+            touchWatchedKey(c->db,c->argv[1]);
+            server.dirty++;
+            addReplyLongLong(c,newval);
+            return;
+        }
+        /* ... else take the usual safe path */
+    }
+
+    /* Otherwise we create a new object and replace the old one. */
+    if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return;
     value += incr;
     o = createStringObjectFromLongLong(value);
     dbReplace(c->db,c->argv[1],o);