LTRIM now returns +OK against non existing keys. More tests in test-redis.tcl

diff --git a/redis.c b/redis.c
index 52443129aa53ff1b82c21a31f3217ee8bd65d643..dde1630d4a12538f712601dce01a8807afd130e8 100644 (file)
--- a/redis.c
+++ b/redis.c
@@ -3631,7 +3631,7 @@ static void ltrimCommand(redisClient *c) {
     
     o = lookupKeyWrite(c->db,c->argv[1]);
     if (o == NULL) {
     
     o = lookupKeyWrite(c->db,c->argv[1]);
     if (o == NULL) {

-        addReply(c,shared.nokeyerr);
+        addReply(c,shared.ok);

     } else {
         if (o->type != REDIS_LIST) {
             addReply(c,shared.wrongtypeerr);
     } else {
         if (o->type != REDIS_LIST) {
             addReply(c,shared.wrongtypeerr);

diff --git a/test-redis.tcl b/test-redis.tcl
index d7b4213596afe2bf587475444e789a7767c9a9d4..3983ee3bfa70566b27be876e07af22aa2dae119d 100644 (file)
--- a/test-redis.tcl
+++ b/test-redis.tcl
@@ -126,7 +126,19 @@ proc createComplexDataset {r ops} {
     for {set j 0} {$j < $ops} {incr j} {
         set k [randomKey]
         set v [randomValue]
     for {set j 0} {$j < $ops} {incr j} {
         set k [randomKey]
         set v [randomValue]

-        set d [expr {rand()}]
+        randpath {
+            set d [expr {rand()}]
+        } {
+            set d [expr {rand()}]
+        } {
+            set d [expr {rand()}]
+        } {
+            set d [expr {rand()}]
+        } {
+            set d [expr {rand()}]
+        } {
+            randpath {set d +inf} {set d -inf}
+        }

         set t [$r type $k]
 
         if {$t eq {none}} {
         set t [$r type $k]
 
         if {$t eq {none}} {


@@ -308,6 +320,11 @@ proc main {server port} {
         $r incrby novar 17179869184
     } {34359738368}
 
         $r incrby novar 17179869184
     } {34359738368}
 

+    test {INCR against key with spaces (no integer encoded)} {
+        $r set novar "    11    "
+        $r incr novar
+    } {12}
+

     test {DECRBY over 32bit value with over 32bit increment, negative res} {
         $r set novar 17179869184
         $r decrby novar 17179869185
     test {DECRBY over 32bit value with over 32bit increment, negative res} {
         $r set novar 17179869184
         $r decrby novar 17179869185


@@ -370,7 +387,8 @@ proc main {server port} {
         append res [$r lindex mylist 0]
         append res [$r lindex mylist 1]
         append res [$r lindex mylist 2]
         append res [$r lindex mylist 0]
         append res [$r lindex mylist 1]
         append res [$r lindex mylist 2]

-    } {3bac}
+        list $res [$r lindex mylist 100]
+    } {3bac {}}

 
     test {DEL a list} {
         $r del mylist
 
     test {DEL a list} {
         $r del mylist


@@ -423,11 +441,19 @@ proc main {server port} {
         format $err
     } {ERR*}
 
         format $err
     } {ERR*}
 

+    test {LLEN against non existing key} {
+        $r llen not-a-key
+    } {0}
+

     test {LINDEX against non-list value error} {
         catch {$r lindex mylist 0} err
         format $err
     } {ERR*}
 
     test {LINDEX against non-list value error} {
         catch {$r lindex mylist 0} err
         format $err
     } {ERR*}
 

+    test {LINDEX against non existing key} {
+        $r lindex not-a-key 10
+    } {}
+

     test {LPUSH against non-list value error} {
         catch {$r lpush mylist 0} err
         format $err
     test {LPUSH against non-list value error} {
         catch {$r lpush mylist 0} err
         format $err