allow running the test suite against an external Redis instance, without auto spawning

diff --git a/tests/support/server.tcl b/tests/support/server.tcl
index 0c9f48ce9cd30caec2db51b325133836f94cde9f..eb5fe621450d6825629e263dfbc87848b8e3cccb 100644 (file)
--- a/tests/support/server.tcl
+++ b/tests/support/server.tcl
@@ -25,6 +25,9 @@ proc check_valgrind_errors stderr {
 }
 
 proc kill_server config {
 }
 
 proc kill_server config {

+    # nothing to kill when running against external server
+    if {$::external} return
+

     # nevermind if its already dead
     if {![is_alive $config]} { return }
     set pid [dict get $config pid]
     # nevermind if its already dead
     if {![is_alive $config]} { return }
     set pid [dict get $config pid]


@@ -93,6 +96,24 @@ proc tags {tags code} {
 }
 
 proc start_server {options {code undefined}} {
 }
 
 proc start_server {options {code undefined}} {

+    # If we are runnign against an external server, we just push the
+    # host/port pair in the stack the first time
+    if {$::external} {
+        if {[llength $::servers] == 0} {
+            set srv {}
+            dict set srv "host" $::host
+            dict set srv "port" $::port
+            set client [redis $::host $::port]
+            dict set srv "client" $client
+            $client select 9
+
+            # append the server to the stack
+            lappend ::servers $srv
+        }
+        uplevel 1 $code
+        return
+    }
+

     # setup defaults
     set baseconfig "default.conf"
     set overrides {}
     # setup defaults
     set baseconfig "default.conf"
     set overrides {}

diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl
index 5aa2424807222fa497d1e1e81aa46121a3c28425..da6520a361dcf34837453606e356b68a0a840cd9 100644 (file)
--- a/tests/test_helper.tcl
+++ b/tests/test_helper.tcl
@@ -15,6 +15,7 @@ set ::traceleaks 0
 set ::valgrind 0
 set ::denytags {}
 set ::allowtags {}
 set ::valgrind 0
 set ::denytags {}
 set ::allowtags {}

+set ::external 0; # If "1" this means, we are running against external instance

 
 proc execute_tests name {
     source "tests/$name.tcl"
 
 proc execute_tests name {
     source "tests/$name.tcl"


@@ -106,6 +107,13 @@ for {set j 0} {$j < [llength $argv]} {incr j} {
             }
         }
         incr j
             }
         }
         incr j

+    } elseif {$opt eq {--host}} {
+        set ::external 1
+        set ::host $arg
+        incr j
+    } elseif {$opt eq {--port}} {
+        set ::port $arg
+        incr j

     } else {
         puts "Wrong argument: $opt"
         exit 1
     } else {
         puts "Wrong argument: $opt"
         exit 1